59772 2011-04-28 19:47:14 -0700 [Qt] Don't build TestNetscapePlugin if ENABLE_NETSCAPE_PLUGIN_API=0 2011-04-29 16:38:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kamaji webkit-unassigned commit-queue jturcotte kling laszlo.gombos ossy yael oldest_to_newest 395046 0 kamaji 2011-04-28 19:47:14 -0700 TestNetscapePlugin depends on Netscape Plugin support -- so if it is disabled via ENABLE_NETSCAPE_PLUGIN_API=0, we should not try to build this tool. 395047 1 91622 kamaji 2011-04-28 19:49:06 -0700 Created attachment 91622 Patch 395213 2 91622 ossy 2011-04-29 04:49:12 -0700 Comment on attachment 91622 Patch r- now, because DEFINES is emtpy here. Please add an "include(../Source/WebCore/features.pri)" line after CONFIG to make checking ENABLE_NETSCAPE_PLUGIN_API work. 395231 3 kamaji 2011-04-29 05:43:35 -0700 (In reply to comment #2) > (From update of attachment 91622 [details]) > r- now, because DEFINES is emtpy here. > > Please add an "include(../Source/WebCore/features.pri)" line > after CONFIG to make checking ENABLE_NETSCAPE_PLUGIN_API work. Oh duh! This worked for me during testing because I had ENABLE_NETSCAPE_PLUGIN_API defined on the command line. 395452 4 91721 kamaji 2011-04-29 13:06:03 -0700 Created attachment 91721 Patch 395457 5 91721 ossy 2011-04-29 13:15:58 -0700 Comment on attachment 91721 Patch Thanks, r=me 395616 6 91721 commit-queue 2011-04-29 16:38:32 -0700 Comment on attachment 91721 Patch Clearing flags on attachment: 91721 Committed r85370: <http://trac.webkit.org/changeset/85370> 395617 7 commit-queue 2011-04-29 16:38:37 -0700 All reviewed patches have been landed. Closing bug. 91622 2011-04-28 19:49:06 -0700 2011-04-29 13:05:55 -0700 Patch bug-59772-20110428225000.patch text/plain 1137 kamaji U3VidmVyc2lvbiBSZXZpc2lvbjogODUyNjMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhYmZmOTZhODExMGU1ZDkwZWIwNTViZGMxOTcwNGNhODE3 NmU2YmZiLi4zMzQyNmI2ZTJhZTVkZmRiZGFjOTI4MWY4NjUyMjM4YmI0MTMxZGI1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDQtMjggIEtlaXRoIEt5eml2YXQgIDxrZWl0aC5reXppdmF0QG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERv bid0IGJ1aWxkIFRlc3ROZXRzY2FwZVBsdWdpbiBpZiBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQ ST0wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTc3 MgorCisgICAgICAgICogVG9vbHMucHJvOgorCiAyMDExLTA0LTI4ICBTYW0gV2VpbmlnICA8c2Ft QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KZGlmZiAtLWdp dCBhL1Rvb2xzL1Rvb2xzLnBybyBiL1Rvb2xzL1Rvb2xzLnBybwppbmRleCA3NmNkMTA4MDExMDE2 Yzc1MDA2NzY5ZjA4ODNkZTRhY2EzNWNiMjc1Li44M2RiN2Y0MzViZTU5MmE5YzI1MWIyNTk5OWQx NWNkNTgzYjZmMWU2IDEwMDY0NAotLS0gYS9Ub29scy9Ub29scy5wcm8KKysrIGIvVG9vbHMvVG9v bHMucHJvCkBAIC0xMSw2ICsxMSw2IEBAIHdlYmtpdDIgewogICAgICFzeW1iaWFuOmV4aXN0cygk JFBXRC9XZWJLaXRUZXN0UnVubmVyL1dlYktpdFRlc3RSdW5uZXIucHJvKTogU1VCRElSUyArPSBX ZWJLaXRUZXN0UnVubmVyL1dlYktpdFRlc3RSdW5uZXIucHJvCiB9CiAKLSF3aW4zMjohc3ltYmlh biB7Cishd2luMzI6IXN5bWJpYW46Y29udGFpbnMoREVGSU5FUywgRU5BQkxFX05FVFNDQVBFX1BM VUdJTl9BUEk9MSkgewogICAgIGV4aXN0cygkJFBXRC9EdW1wUmVuZGVyVHJlZS9xdC9UZXN0TmV0 c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLnBybyk6IFNVQkRJUlMgKz0gRHVtcFJlbmRl clRyZWUvcXQvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5wcm8KIH0K 91721 2011-04-29 13:06:03 -0700 2011-04-29 16:38:32 -0700 Patch bug-59772-20110429160658.patch text/plain 1526 kamaji U3VidmVyc2lvbiBSZXZpc2lvbjogODUyNjMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhYmZmOTZhODExMGU1ZDkwZWIwNTViZGMxOTcwNGNhODE3 NmU2YmZiLi4zMzQyNmI2ZTJhZTVkZmRiZGFjOTI4MWY4NjUyMjM4YmI0MTMxZGI1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDQtMjggIEtlaXRoIEt5eml2YXQgIDxrZWl0aC5reXppdmF0QG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERv bid0IGJ1aWxkIFRlc3ROZXRzY2FwZVBsdWdpbiBpZiBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQ ST0wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTc3 MgorCisgICAgICAgICogVG9vbHMucHJvOgorCiAyMDExLTA0LTI4ICBTYW0gV2VpbmlnICA8c2Ft QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KZGlmZiAtLWdp dCBhL1Rvb2xzL1Rvb2xzLnBybyBiL1Rvb2xzL1Rvb2xzLnBybwppbmRleCA3NmNkMTA4MDExMDE2 Yzc1MDA2NzY5ZjA4ODNkZTRhY2EzNWNiMjc1Li4wYzMzZmFlMDg5YzMxMDMzYTdkOTc4MzFjNDlj MmM3MWViMzAxNmYwIDEwMDY0NAotLS0gYS9Ub29scy9Ub29scy5wcm8KKysrIGIvVG9vbHMvVG9v bHMucHJvCkBAIC0yLDYgKzIsOCBAQAogVEVNUExBVEUgPSBzdWJkaXJzCiBDT05GSUcgKz0gb3Jk ZXJlZAogCitpbmNsdWRlKCQkUFdELy4uL1NvdXJjZS9XZWJDb3JlL2ZlYXR1cmVzLnByaSkKKwog ZXhpc3RzKCQkUFdEL1F0VGVzdEJyb3dzZXIvUXRUZXN0QnJvd3Nlci5wcm8pOiBTVUJESVJTICs9 IFF0VGVzdEJyb3dzZXIvUXRUZXN0QnJvd3Nlci5wcm8KIGV4aXN0cygkJFBXRC9EdW1wUmVuZGVy VHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5wcm8pOiBTVUJESVJTICs9IER1bXBSZW5kZXJUcmVlL3F0 L0R1bXBSZW5kZXJUcmVlLnBybwogZXhpc3RzKCQkUFdEL0R1bXBSZW5kZXJUcmVlL3F0L0ltYWdl RGlmZi5wcm8pOiBTVUJESVJTICs9IER1bXBSZW5kZXJUcmVlL3F0L0ltYWdlRGlmZi5wcm8KQEAg LTExLDYgKzEzLDYgQEAgd2Via2l0MiB7CiAgICAgIXN5bWJpYW46ZXhpc3RzKCQkUFdEL1dlYktp dFRlc3RSdW5uZXIvV2ViS2l0VGVzdFJ1bm5lci5wcm8pOiBTVUJESVJTICs9IFdlYktpdFRlc3RS dW5uZXIvV2ViS2l0VGVzdFJ1bm5lci5wcm8KIH0KIAotIXdpbjMyOiFzeW1iaWFuIHsKKyF3aW4z Mjohc3ltYmlhbjpjb250YWlucyhERUZJTkVTLCBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQST0x KSB7CiAgICAgZXhpc3RzKCQkUFdEL0R1bXBSZW5kZXJUcmVlL3F0L1Rlc3ROZXRzY2FwZVBsdWdp bi9UZXN0TmV0c2NhcGVQbHVnaW4ucHJvKTogU1VCRElSUyArPSBEdW1wUmVuZGVyVHJlZS9xdC9U ZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLnBybwogfQo=