59767 2011-04-28 18:37:07 -0700 AX: Remote accessibility should build on snow leopard 2011-04-29 16:18:10 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach bdakin commit-queue oldest_to_newest 395005 0 cfleizach 2011-04-28 18:37:07 -0700 The WKSI headers now allow Remote accessibility code in WK2 to build on SL. The SL checks need to be removed 395006 1 91613 cfleizach 2011-04-28 18:38:01 -0700 Created attachment 91613 patch to check building 395418 2 bdakin 2011-04-29 12:09:38 -0700 Hey Chris, is this patch really looking for a review? Or did you only mark it for review so the EWS bots build it? 395432 3 cfleizach 2011-04-29 12:17:48 -0700 i assumed i needed review. maybe not. i also wanted to check the bots 395436 4 91613 cfleizach 2011-04-29 12:20:45 -0700 Comment on attachment 91613 patch to check building thanks beth! 395604 5 91613 commit-queue 2011-04-29 16:18:06 -0700 Comment on attachment 91613 patch to check building Clearing flags on attachment: 91613 Committed r85366: <http://trac.webkit.org/changeset/85366> 395605 6 commit-queue 2011-04-29 16:18:10 -0700 All reviewed patches have been landed. Closing bug. 91613 2011-04-28 18:38:01 -0700 2011-04-29 16:18:06 -0700 patch to check building patch.txt text/plain 5446 cfleizach SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1MjgzKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDQtMjggIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBWDogUmVtb3RlIGFjY2Vzc2liaWxpdHkgc2hvdWxkIGJ1 aWxkIG9uIHNub3cgbGVvcGFyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTk3NjcKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5t bToKKyAgICAgICAgKC1bV0tWaWV3IF91cGRhdGVSZW1vdGVBY2Nlc3NpYmlsaXR5UmVnaXN0cmF0 aW9uOl0pOgorICAgICAgICAoLVtXS1ZpZXcgdmlld0RpZE1vdmVUb1dpbmRvd10pOgorICAgICAg ICAoLVtXS1ZpZXcgX3NldEFjY2Vzc2liaWxpdHlXZWJQcm9jZXNzVG9rZW46XSk6CisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tOgorICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlOjpwbGF0Zm9ybUluaXRpYWxpemUpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdl OjpyZWdpc3RlclVJUHJvY2Vzc0FjY2Vzc2liaWxpdHlUb2tlbnMpOgorICAgICAgICAqIFdlYlBy b2Nlc3MvbWFjL1dlYlByb2Nlc3NNYWluTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9j ZXNzTWFpbik6CisKIDIwMTEtMDQtMjggIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL21hYy9XZWJQcm9jZXNzTWFpbk1hYy5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL21hYy9XZWJQcm9jZXNzTWFpbk1hYy5tbQkocmV2aXNpb24g ODUxMzEpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL21hYy9XZWJQcm9jZXNzTWFpbk1h Yy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTAyLDkgKzEwMiw3IEBACiAgICAgLy8gRklYTUU6IFJl bW92ZSB3aGVuIDxyZGFyOi8vcHJvYmxlbS84OTI5NDI2PiBpcyBmaXhlZC4KICAgICBbW05TQXBw bGljYXRpb24gc2hhcmVkQXBwbGljYXRpb25dIF9pbnN0YWxsQXV0b3JlbGVhc2VQb29sc09uQ3Vy cmVudFRocmVhZElmTmVjZXNzYXJ5XTsKIAotI2lmICFkZWZpbmVkKEJVSUxESU5HX09OX1NOT1df TEVPUEFSRCkKICAgICBXS0FYUmVnaXN0ZXJSZW1vdGVBcHAoKTsKLSNlbmRpZgogICAgIAogICAg IFJ1bkxvb3A6OnJ1bigpOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL1dlYlBhZ2VNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tCShyZXZpc2lvbiA4NTEzMSkKKysrIFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQkod29ya2luZyBj b3B5KQpAQCAtNjMsNyArNjMsNiBAQAogewogICAgIG1fcGFnZS0+YWRkU2NoZWR1bGVQYWlyKFNj aGVkdWxlUGFpcjo6Y3JlYXRlKFtOU1J1bkxvb3AgY3VycmVudFJ1bkxvb3BdLCBrQ0ZSdW5Mb29w Q29tbW9uTW9kZXMpKTsKIAotI2lmICFkZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCkK ICAgICBBY2Nlc3NpYmlsaXR5V2ViUGFnZU9iamVjdCogbW9ja0FjY2Vzc2liaWxpdHlFbGVtZW50 ID0gW1tbQWNjZXNzaWJpbGl0eVdlYlBhZ2VPYmplY3QgYWxsb2NdIGluaXRdIGF1dG9yZWxlYXNl XTsKIAogICAgIC8vIEdldCB0aGUgcGlkIGZvciB0aGUgc3RhcnRpbmcgcHJvY2Vzcy4KQEAgLTc2 LDcgKzc1LDYgQEAKICAgICBDb3JlSVBDOjpEYXRhUmVmZXJlbmNlIGRhdGFUb2tlbiA9IENvcmVJ UEM6OkRhdGFSZWZlcmVuY2UocmVpbnRlcnByZXRfY2FzdDxjb25zdCB1aW50OF90Kj4oW3JlbW90 ZVRva2VuIGJ5dGVzXSksIFtyZW1vdGVUb2tlbiBsZW5ndGhdKTsKICAgICBzZW5kKE1lc3NhZ2Vz OjpXZWJQYWdlUHJveHk6OlJlZ2lzdGVyV2ViUHJvY2Vzc0FjY2Vzc2liaWxpdHlUb2tlbihkYXRh VG9rZW4pKTsKICAgICBtX21vY2tBY2Nlc3NpYmlsaXR5RWxlbWVudCA9IG1vY2tBY2Nlc3NpYmls aXR5RWxlbWVudDsKLSNlbmRpZgogfQogCiB2b2lkIFdlYlBhZ2U6OnBsYXRmb3JtUHJlZmVyZW5j ZXNEaWRDaGFuZ2UoY29uc3QgV2ViUHJlZmVyZW5jZXNTdG9yZSYpCkBAIC01ODMsNyArNTgxLDYg QEAKIAogdm9pZCBXZWJQYWdlOjpyZWdpc3RlclVJUHJvY2Vzc0FjY2Vzc2liaWxpdHlUb2tlbnMo Y29uc3QgQ29yZUlQQzo6RGF0YVJlZmVyZW5jZSYgZWxlbWVudFRva2VuLCBjb25zdCBDb3JlSVBD OjpEYXRhUmVmZXJlbmNlJiB3aW5kb3dUb2tlbikKIHsKLSNpZiAhZGVmaW5lZChCVUlMRElOR19P Tl9TTk9XX0xFT1BBUkQpCiAgICAgTlNEYXRhKiBlbGVtZW50VG9rZW5EYXRhID0gW05TRGF0YSBk YXRhV2l0aEJ5dGVzOmVsZW1lbnRUb2tlbi5kYXRhKCkgbGVuZ3RoOmVsZW1lbnRUb2tlbi5zaXpl KCldOwogICAgIE5TRGF0YSogd2luZG93VG9rZW5EYXRhID0gW05TRGF0YSBkYXRhV2l0aEJ5dGVz OndpbmRvd1Rva2VuLmRhdGEoKSBsZW5ndGg6d2luZG93VG9rZW4uc2l6ZSgpXTsKICAgICBpZCBy ZW1vdGVFbGVtZW50ID0gV0tBWFJlbW90ZUVsZW1lbnRGb3JUb2tlbihlbGVtZW50VG9rZW5EYXRh KTsKQEAgLTU5MSw3ICs1ODgsNiBAQAogICAgIFdLQVhTZXRXaW5kb3dGb3JSZW1vdGVFbGVtZW50 KHJlbW90ZVdpbmRvdywgcmVtb3RlRWxlbWVudCk7CiAgICAgCiAgICAgW2FjY2Vzc2liaWxpdHlS ZW1vdGVPYmplY3QoKSBzZXRSZW1vdGVQYXJlbnQ6cmVtb3RlRWxlbWVudF07Ci0jZW5kaWYKIH0K IAogdm9pZCBXZWJQYWdlOjp3cml0ZVNlbGVjdGlvblRvUGFzdGVib2FyZChjb25zdCBTdHJpbmcm IHBhc3RlYm9hcmROYW1lLCBjb25zdCBWZWN0b3I8U3RyaW5nPiYgcGFzdGVib2FyZFR5cGVzLCBi b29sJiByZXN1bHQpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1Zp ZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tW aWV3Lm1tCShyZXZpc2lvbiA4NTEzMSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv bWFjL1dLVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTkzLDcgKzE5Myw2IEBACiAKIC0gKHZv aWQpX3VwZGF0ZVJlbW90ZUFjY2Vzc2liaWxpdHlSZWdpc3RyYXRpb246KEJPT0wpcmVnaXN0ZXJQ cm9jZXNzCiB7Ci0jaWYgIWRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQogICAgIC8v IFdoZW4gdGhlIHRyZWUgaXMgY29ubmVjdGVkL2Rpc2Nvbm5lY3RlZCwgdGhlIHJlbW90ZSBhY2Nl c3NpYmlsaXR5IHJlZ2lzdHJhdGlvbgogICAgIC8vIG5lZWRzIHRvIGJlIHVwZGF0ZWQgd2l0aCB0 aGUgcGlkIG9mIHRoZSByZW1vdGUgcHJvY2Vzcy4gSWYgdGhlIHByb2Nlc3MgaXMgZ29pbmcKICAg ICAvLyBhd2F5LCB0aGF0IGluZm9ybWF0aW9uIGlzIG5vdCBwcmVzZW50IGluIFdlYlByb2Nlc3MK QEAgLTIwNiw3ICsyMDUsNiBAQAogICAgIH0KICAgICBpZiAocGlkKQogICAgICAgICBXS0FYUmVn aXN0ZXJSZW1vdGVQcm9jZXNzKHJlZ2lzdGVyUHJvY2VzcywgcGlkKTsgCi0jZW5kaWYKIH0KIAog LSAoaWQpaW5pdFdpdGhGcmFtZTooTlNSZWN0KWZyYW1lIGNvbnRleHRSZWY6KFdLQ29udGV4dFJl Ziljb250ZXh0UmVmIHBhZ2VHcm91cFJlZjooV0tQYWdlR3JvdXBSZWYpcGFnZUdyb3VwUmVmCkBA IC0xNzE2LDEzICsxNzE0LDExIEBACiAgICAgICAgIFtzZWxmIF91cGRhdGVXaW5kb3dBbmRWaWV3 RnJhbWVzXTsKICAgICAgICAgCiAgICAgICAgIC8vIEluaXRpYWxpemUgcmVtb3RlIGFjY2Vzc2li aWxpdHkgd2hlbiB0aGUgd2luZG93IGNvbm5lY3Rpb24gaGFzIGJlZW4gZXN0YWJsaXNoZWQuCi0j aWYgIWRlZmluZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQogICAgICAgICBOU0RhdGEgKnJl bW90ZUVsZW1lbnRUb2tlbiA9IFdLQVhSZW1vdGVUb2tlbkZvckVsZW1lbnQoc2VsZik7CiAgICAg ICAgIE5TRGF0YSAqcmVtb3RlV2luZG93VG9rZW4gPSBXS0FYUmVtb3RlVG9rZW5Gb3JFbGVtZW50 KFtzZWxmIGFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTpOU0FjY2Vzc2liaWxpdHlXaW5kb3dB dHRyaWJ1dGVdKTsKICAgICAgICAgQ29yZUlQQzo6RGF0YVJlZmVyZW5jZSBlbGVtZW50VG9rZW4g PSBDb3JlSVBDOjpEYXRhUmVmZXJlbmNlKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+ KFtyZW1vdGVFbGVtZW50VG9rZW4gYnl0ZXNdKSwgW3JlbW90ZUVsZW1lbnRUb2tlbiBsZW5ndGhd KTsKICAgICAgICAgQ29yZUlQQzo6RGF0YVJlZmVyZW5jZSB3aW5kb3dUb2tlbiA9IENvcmVJUEM6 OkRhdGFSZWZlcmVuY2UocmVpbnRlcnByZXRfY2FzdDxjb25zdCB1aW50OF90Kj4oW3JlbW90ZVdp bmRvd1Rva2VuIGJ5dGVzXSksIFtyZW1vdGVXaW5kb3dUb2tlbiBsZW5ndGhdKTsKICAgICAgICAg X2RhdGEtPl9wYWdlLT5yZWdpc3RlclVJUHJvY2Vzc0FjY2Vzc2liaWxpdHlUb2tlbnMoZWxlbWVu dFRva2VuLCB3aW5kb3dUb2tlbik7Ci0jZW5kaWYgICAgCiAgICAgICAgICAgICAKICAgICB9IGVs c2UgewogICAgICAgICBfZGF0YS0+X3BhZ2UtPnZpZXdTdGF0ZURpZENoYW5nZShXZWJQYWdlUHJv eHk6OlZpZXdJc1Zpc2libGUpOwpAQCAtMjIxNiwxMCArMjIxMiw4IEBACiAKIC0gKHZvaWQpX3Nl dEFjY2Vzc2liaWxpdHlXZWJQcm9jZXNzVG9rZW46KE5TRGF0YSAqKWRhdGEKIHsKLSNpZiAhZGVm aW5lZChCVUlMRElOR19PTl9TTk9XX0xFT1BBUkQpCiAgICAgX2RhdGEtPl9yZW1vdGVBY2Nlc3Np YmlsaXR5Q2hpbGQgPSBXS0FYUmVtb3RlRWxlbWVudEZvclRva2VuKGRhdGEpOwogICAgIFtzZWxm IF91cGRhdGVSZW1vdGVBY2Nlc3NpYmlsaXR5UmVnaXN0cmF0aW9uOllFU107Ci0jZW5kaWYKIH0K IAogLSAodm9pZClfc2V0Q29tcGxleFRleHRJbnB1dEVuYWJsZWQ6KEJPT0wpY29tcGxleFRleHRJ bnB1dEVuYWJsZWQgcGx1Z2luQ29tcGxleFRleHRJbnB1dElkZW50aWZpZXI6KHVpbnQ2NF90KXBs dWdpbkNvbXBsZXhUZXh0SW5wdXRJZGVudGlmaWVyCg==