59760 2011-04-28 16:32:33 -0700 Right-clicking on a Flash movie in an iframe shows the browser context menu 2011-04-28 16:44:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 394896 0 andersca 2011-04-28 16:32:33 -0700 Right-clicking on a Flash movie in an iframe shows the browser context menu 394897 1 91587 andersca 2011-04-28 16:37:23 -0700 Created attachment 91587 Patch 394904 2 91587 darin 2011-04-28 16:40:02 -0700 Comment on attachment 91587 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91587&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:956 > + return handleContextMenuEvent(platformMouseEvent, page); Is it really OK to ignore the result of “handled” entirely here? Not || it in? Is it correct to return false if the mouse press event was handled, but not the context menu event? 394906 3 91587 andersca 2011-04-28 16:41:39 -0700 Comment on attachment 91587 Patch I think so; the semantics are still the same as they were before my change. 394912 4 andersca 2011-04-28 16:44:32 -0700 Committed r85259: <http://trac.webkit.org/changeset/85259> 91587 2011-04-28 16:37:23 -0700 2011-04-28 16:41:39 -0700 Patch bug-59760-20110428163722.patch text/plain 2665 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1MjU2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQtMjggIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSaWdodC1jbGlja2luZyBvbiBhIEZsYXNoIG1vdmllIGlu IGFuIGlmcmFtZSBzaG93cyB0aGUgYnJvd3NlciBjb250ZXh0IG1lbnUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5NzYwCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS85MzQwNTQxPgorCisgICAgICAgIE1vdmUgY29udGV4dCBtZW51IGV2ZW50IGhhbmRs aW5nIG91dCBpbnRvIGEgc2VwYXJhdGUgZnVuY3Rpb24uIE1ha2Ugc3VyZSB0byBjYWxsCisgICAg ICAgIEV2ZW50SGFuZGxlcjo6c2VuZENvbnRleHRNZW51RXZlbnQgb24gdGhlIGV2ZW50IGhhbmRs ZXIgYmVsb25naW5nIHRvIHRoZSBmcmFtZSBvZiB0aGUKKyAgICAgICAgbm9kZSB0aGF0IHdhcyBj bGlja2VkLCBhbmQgbm90IHRoZSBtYWluIGZyYW1lLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpoYW5kbGVDb250ZXh0TWVudUV2 ZW50KToKKyAgICAgICAgKFdlYktpdDo6aGFuZGxlTW91c2VFdmVudCk6CisKIDIwMTEtMDQtMjgg IEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBF cmljIFNlaWRlbC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViUGFnZS5jcHAJKHJldmlzaW9uIDg1MjMxKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MjEsNiArOTIxLDIyIEBA IHN0YXRpYyBib29sIGlzQ29udGV4dENsaWNrKGNvbnN0IFBsYXRmb3IKICAgICByZXR1cm4gZmFs c2U7CiB9CiAKK3N0YXRpYyBib29sIGhhbmRsZUNvbnRleHRNZW51RXZlbnQoY29uc3QgUGxhdGZv cm1Nb3VzZUV2ZW50JiBwbGF0Zm9ybU1vdXNlRXZlbnQsIFBhZ2UqIHBhZ2UpCit7CisgICAgSW50 UG9pbnQgcG9pbnQgPSBwYWdlLT5tYWluRnJhbWUoKS0+dmlldygpLT53aW5kb3dUb0NvbnRlbnRz KHBsYXRmb3JtTW91c2VFdmVudC5wb3MoKSk7CisgICAgSGl0VGVzdFJlc3VsdCByZXN1bHQgPSBw YWdlLT5tYWluRnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCktPmhpdFRlc3RSZXN1bHRBdFBvaW50KHBv aW50LCBmYWxzZSk7CisKKyAgICBGcmFtZSogZnJhbWUgPSBwYWdlLT5tYWluRnJhbWUoKTsKKyAg ICBpZiAocmVzdWx0LmlubmVyTm9uU2hhcmVkTm9kZSgpKQorICAgICAgICBmcmFtZSA9IHJlc3Vs dC5pbm5lck5vblNoYXJlZE5vZGUoKS0+ZG9jdW1lbnQoKS0+ZnJhbWUoKTsKKyAgICAKKyAgICBi b29sIGhhbmRsZWQgPSBmcmFtZS0+ZXZlbnRIYW5kbGVyKCktPnNlbmRDb250ZXh0TWVudUV2ZW50 KHBsYXRmb3JtTW91c2VFdmVudCk7CisgICAgaWYgKGhhbmRsZWQpCisgICAgICAgIHBhZ2UtPmNo cm9tZSgpLT5zaG93Q29udGV4dE1lbnUoKTsKKworICAgIHJldHVybiBoYW5kbGVkOworfQorCiBz dGF0aWMgYm9vbCBoYW5kbGVNb3VzZUV2ZW50KGNvbnN0IFdlYk1vdXNlRXZlbnQmIG1vdXNlRXZl bnQsIFBhZ2UqIHBhZ2UpCiB7CiAgICAgRnJhbWUqIGZyYW1lID0gcGFnZS0+bWFpbkZyYW1lKCk7 CkBAIC05MzYsMTIgKzk1Miw4IEBAIHN0YXRpYyBib29sIGhhbmRsZU1vdXNlRXZlbnQoY29uc3Qg V2ViTW8KICAgICAgICAgICAgICAgICBwYWdlLT5jb250ZXh0TWVudUNvbnRyb2xsZXIoKS0+Y2xl YXJDb250ZXh0TWVudSgpOwogICAgICAgICAgICAgCiAgICAgICAgICAgICBib29sIGhhbmRsZWQg PSBmcmFtZS0+ZXZlbnRIYW5kbGVyKCktPmhhbmRsZU1vdXNlUHJlc3NFdmVudChwbGF0Zm9ybU1v dXNlRXZlbnQpOwotICAgICAgICAgICAgCi0gICAgICAgICAgICBpZiAoaXNDb250ZXh0Q2xpY2so cGxhdGZvcm1Nb3VzZUV2ZW50KSkgewotICAgICAgICAgICAgICAgIGhhbmRsZWQgPSBmcmFtZS0+ ZXZlbnRIYW5kbGVyKCktPnNlbmRDb250ZXh0TWVudUV2ZW50KHBsYXRmb3JtTW91c2VFdmVudCk7 Ci0gICAgICAgICAgICAgICAgaWYgKGhhbmRsZWQpCi0gICAgICAgICAgICAgICAgICAgIHBhZ2Ut PmNocm9tZSgpLT5zaG93Q29udGV4dE1lbnUoKTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAg IGlmIChpc0NvbnRleHRDbGljayhwbGF0Zm9ybU1vdXNlRXZlbnQpKQorICAgICAgICAgICAgICAg IHJldHVybiBoYW5kbGVDb250ZXh0TWVudUV2ZW50KHBsYXRmb3JtTW91c2VFdmVudCwgcGFnZSk7 CiAKICAgICAgICAgICAgIHJldHVybiBoYW5kbGVkOwogICAgICAgICB9Cg==