59759 2011-04-28 16:20:25 -0700 Overflow:scroll regions with overlay scrollbars show full thumb instead of just a track when there is nothing to scroll to 2011-04-28 17:20:20 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX InRadar P2 Normal --- 1 bdakin bdakin bdakin oldest_to_newest 394884 0 bdakin 2011-04-28 16:20:25 -0700 Overflow:scroll regions with overlay scrollbars show full thumb instead of just a track when there is nothing to scroll to. <rdar://problem/9282066> Patch forthcoming. 394890 1 91586 bdakin 2011-04-28 16:27:19 -0700 Created attachment 91586 Patch 394894 2 91586 darin 2011-04-28 16:31:31 -0700 Comment on attachment 91586 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91586&action=review > Source/WebCore/platform/mac/ScrollbarThemeMac.mm:472 > + float proportion = visibleSize != totalSize ? (visibleSize - overhang) / totalSize : 0; I kind of wish you used "<" here instead of "!=". 394965 3 91586 bdakin 2011-04-28 17:18:31 -0700 Comment on attachment 91586 Patch Actually! I want to fix this a different way. I'm going to roll this out. 394968 4 bdakin 2011-04-28 17:20:20 -0700 Rolled out with revision 85269. 91586 2011-04-28 16:27:19 -0700 2011-04-28 17:18:30 -0700 Patch for-review-os.txt text/plain 4203 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1MjU1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMjggIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 OTc1OQorICAgICAgICBPdmVyZmxvdzpzY3JvbGwgcmVnaW9ucyB3aXRoIG92ZXJsYXkgc2Nyb2xs YmFycyBzaG93IGZ1bGwgdGh1bWIgaW5zdGVhZCBvZiBqdXN0IGEgCisgICAgICAgIHRyYWNrIHdo ZW4gdGhlcmUgaXMgbm90aGluZyB0byBzY3JvbGwgdG8KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzkyODIwNjY+CisKKyAgICAgICAgU2Nyb2xsYmFyOjp0b3RhbFNpemUoKSBhbmQgU2Nyb2xsYmFy Ojp2aXNpYmxlU2l6ZSgpIGFyZSB0aGUgc2FtZSB3aGVuIHRoZXJlIGlzIAorICAgICAgICBub3Ro aW5nIHRvIHNjcm9sbCB0by4gSnVzdCBkaXZpZGluZyB0aGVtIHRvIGdldCBhIGtub2IgcHJvcG9y dGlvbiB5aWVsZHMgMSwgd2hpY2ggCisgICAgICAgIGlzIG5vdCByaWdodC4gU2V0IHRoZSBwcm9w b3J0aW9uIHRvIDAgaW4gdGhpcyBjYXNlIGluc3RlYWQuCisgICAgICAgICogcGxhdGZvcm0vbWFj L1Njcm9sbGJhclRoZW1lTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVN YWM6OnBhaW50KToKKwogMjAxMS0wNC0yOCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg1MjMzIGFu ZCByODUyMzUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhl bWVNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9s bGJhclRoZW1lTWFjLm1tCShyZXZpc2lvbiA4NTE0NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtNDQ1LDYgKzQ0 NSw5IEBAIHN0YXRpYyBpbmxpbmUgd2tTY3JvbGxlcktub2JTdHlsZSB0b1Njcm8KIAogYm9vbCBT Y3JvbGxiYXJUaGVtZU1hYzo6cGFpbnQoU2Nyb2xsYmFyKiBzY3JvbGxiYXIsIEdyYXBoaWNzQ29u dGV4dCogY29udGV4dCwgY29uc3QgSW50UmVjdCYgZGFtYWdlUmVjdCkKIHsKKyAgICBpbnQgdmlz aWJsZVNpemUgPSBzY3JvbGxiYXItPnZpc2libGVTaXplKCk7CisgICAgaW50IHRvdGFsU2l6ZSA9 IHNjcm9sbGJhci0+dG90YWxTaXplKCk7CisKICNpZiBVU0UoV0tfU0NST0xMQkFSX1BBSU5URVIp CiAgICAgZmxvYXQgdmFsdWUgPSAwOwogICAgIGZsb2F0IG92ZXJoYW5nID0gMDsKQEAgLTQ1Mywx MCArNDU2LDEwIEBAIGJvb2wgU2Nyb2xsYmFyVGhlbWVNYWM6OnBhaW50KFNjcm9sbGJhcioKICAg ICAgICAgLy8gU2Nyb2xsZWQgcGFzdCB0aGUgdG9wLgogICAgICAgICB2YWx1ZSA9IDA7CiAgICAg ICAgIG92ZXJoYW5nID0gLXNjcm9sbGJhci0+Y3VycmVudFBvcygpOwotICAgIH0gZWxzZSBpZiAo c2Nyb2xsYmFyLT52aXNpYmxlU2l6ZSgpICsgc2Nyb2xsYmFyLT5jdXJyZW50UG9zKCkgPiBzY3Jv bGxiYXItPnRvdGFsU2l6ZSgpKSB7CisgICAgfSBlbHNlIGlmICh2aXNpYmxlU2l6ZSArIHNjcm9s bGJhci0+Y3VycmVudFBvcygpID4gdG90YWxTaXplKSB7CiAgICAgICAgIC8vIFNjcm9sbGVkIHBh c3QgdGhlIGJvdHRvbS4KICAgICAgICAgdmFsdWUgPSAxOwotICAgICAgICBvdmVyaGFuZyA9IHNj cm9sbGJhci0+Y3VycmVudFBvcygpICsgc2Nyb2xsYmFyLT52aXNpYmxlU2l6ZSgpIC0gc2Nyb2xs YmFyLT50b3RhbFNpemUoKTsKKyAgICAgICAgb3ZlcmhhbmcgPSBzY3JvbGxiYXItPmN1cnJlbnRQ b3MoKSArIHZpc2libGVTaXplIC0gdG90YWxTaXplOwogICAgIH0gZWxzZSB7CiAgICAgICAgIC8v IFdpdGhpbiB0aGUgYm91bmRzIG9mIHRoZSBzY3JvbGxhYmxlIGFyZWEuCiAgICAgICAgIGludCBt YXhpbXVtID0gc2Nyb2xsYmFyLT5tYXhpbXVtKCk7CkBAIC00NjUsNiArNDY4LDggQEAgYm9vbCBT Y3JvbGxiYXJUaGVtZU1hYzo6cGFpbnQoU2Nyb2xsYmFyKgogICAgICAgICBlbHNlCiAgICAgICAg ICAgICB2YWx1ZSA9IDA7CiAgICAgfQorCisgICAgZmxvYXQgcHJvcG9ydGlvbiA9IHZpc2libGVT aXplICE9IHRvdGFsU2l6ZSA/ICh2aXNpYmxlU2l6ZSAtIG92ZXJoYW5nKSAvIHRvdGFsU2l6ZSA6 IDA7CiAgICAgCiAgICAgU2Nyb2xsQW5pbWF0b3JNYWMqIHNjcm9sbEFuaW1hdG9yID0gc3RhdGlj X2Nhc3Q8U2Nyb2xsQW5pbWF0b3JNYWMqPihzY3JvbGxiYXItPnNjcm9sbGFibGVBcmVhKCktPnNj cm9sbEFuaW1hdG9yKCkpOwogICAgIHNjcm9sbEFuaW1hdG9yLT5zZXRJc0RyYXdpbmdJbnRvTGF5 ZXIoY29udGV4dC0+aXNDQUxheWVyQ29udGV4dCgpKTsKQEAgLTQ4MCw3ICs0ODUsNyBAQCBib29s IFNjcm9sbGJhclRoZW1lTWFjOjpwYWludChTY3JvbGxiYXIqCiAgICAgd2tTY3JvbGxiYXJQYWlu dGVyUGFpbnQoc2Nyb2xsYmFyTWFwKCktPmdldChzY3JvbGxiYXIpLmdldCgpLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHNjcm9sbGJhci0+ZW5hYmxlZCgpLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHZhbHVlLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdGF0aWNf Y2FzdDxDR0Zsb2F0PihzY3JvbGxiYXItPnZpc2libGVTaXplKCkpIC0gb3ZlcmhhbmcpIC8gc2Ny b2xsYmFyLT50b3RhbFNpemUoKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcm9wb3J0 aW9uLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNjcm9sbGJhci0+ZnJhbWVSZWN0KCkp OwogCiAgICAgc2Nyb2xsQW5pbWF0b3ItPnNldElzRHJhd2luZ0ludG9MYXllcihmYWxzZSk7CkBA IC00OTYsOSArNTAxLDkgQEAgYm9vbCBTY3JvbGxiYXJUaGVtZU1hYzo6cGFpbnQoU2Nyb2xsYmFy KgogICAgIGZsb2F0IHBvc2l0aW9uID0gMC4wZjsKICAgICBpZiAoc2Nyb2xsYmFyLT5jdXJyZW50 UG9zKCkgPCAwKSB7CiAgICAgICAgIC8vIFNjcm9sbGVkIHBhc3QgdGhlIHRvcC4KLSAgICAgICAg bWF4aW11bSA9IChzY3JvbGxiYXItPnRvdGFsU2l6ZSgpIC0gc2Nyb2xsYmFyLT5jdXJyZW50UG9z KCkpIC0gc2Nyb2xsYmFyLT52aXNpYmxlU2l6ZSgpOworICAgICAgICBtYXhpbXVtID0gKHRvdGFs U2l6ZSAtIHNjcm9sbGJhci0+Y3VycmVudFBvcygpKSAtIHZpc2libGVTaXplOwogICAgICAgICBw b3NpdGlvbiA9IDA7Ci0gICAgfSBlbHNlIGlmIChzY3JvbGxiYXItPnZpc2libGVTaXplKCkgKyBz Y3JvbGxiYXItPmN1cnJlbnRQb3MoKSA+IHNjcm9sbGJhci0+dG90YWxTaXplKCkpIHsKKyAgICB9 IGVsc2UgaWYgKHZpc2libGVTaXplICsgc2Nyb2xsYmFyLT5jdXJyZW50UG9zKCkgPiB0b3RhbFNp emUpIHsKICAgICAgICAgLy8gU2Nyb2xsZWQgcGFzdCB0aGUgYm90dG9tLgogICAgICAgICBtYXhp bXVtID0gc2Nyb2xsYmFyLT5jdXJyZW50UG9zKCk7CiAgICAgICAgIHBvc2l0aW9uID0gbWF4aW11 bTsKQEAgLTUxMiw3ICs1MTcsNyBAQCBib29sIFNjcm9sbGJhclRoZW1lTWFjOjpwYWludChTY3Jv bGxiYXIqCiAgICAgdHJhY2tJbmZvLm1heCA9IHN0YXRpY19jYXN0PGludD4obWF4aW11bSk7CiAg ICAgdHJhY2tJbmZvLnZhbHVlID0gc3RhdGljX2Nhc3Q8aW50Pihwb3NpdGlvbik7CiAKLSAgICB0 cmFja0luZm8udHJhY2tJbmZvLnNjcm9sbGJhci52aWV3c2l6ZSA9IHNjcm9sbGJhci0+dmlzaWJs ZVNpemUoKTsKKyAgICB0cmFja0luZm8udHJhY2tJbmZvLnNjcm9sbGJhci52aWV3c2l6ZSA9IHZp c2libGVTaXplOwogICAgIHRyYWNrSW5mby5hdHRyaWJ1dGVzID0gMDsKICAgICBpZiAoc2Nyb2xs YmFyLT5vcmllbnRhdGlvbigpID09IEhvcml6b250YWxTY3JvbGxiYXIpCiAgICAgICAgIHRyYWNr SW5mby5hdHRyaWJ1dGVzIHw9IGtUaGVtZVRyYWNrSG9yaXpvbnRhbDsK