59757 2011-04-28 16:18:04 -0700 REGRESSION(r85101): it'd be better to rollout the patch and do another one with another property name. Current one will bring us to a problem at first run after upgrade because it's type was changed from int to string. (Requested by loislo on #webkit). 2011-04-28 17:06:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 59630 1 webkit.review.bot webkit.review.bot bweinstein loislo oldest_to_newest 394879 0 webkit.review.bot 2011-04-28 16:18:04 -0700 http://trac.webkit.org/changeset/85101 broke the build: it'd be better to rollout the patch and do another one with another property name. Current one will bring us to a problem at first run after upgrade because it's type was changed from int to string. (Requested by loislo on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 394881 1 91583 webkit.review.bot 2011-04-28 16:18:25 -0700 Created attachment 91583 ROLLOUT of r85101 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 394943 2 91583 loislo 2011-04-28 17:06:32 -0700 Comment on attachment 91583 ROLLOUT of r85101 Clearing flags on attachment: 91583 Committed r85266: <http://trac.webkit.org/changeset/85266> 394944 3 loislo 2011-04-28 17:06:35 -0700 All reviewed patches have been landed. Closing bug. 91583 2011-04-28 16:18:25 -0700 2011-04-28 17:06:32 -0700 ROLLOUT of r85101 bug-59757-20110428231452.patch text/plain 2440 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogODUyNTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkZDIzOTEzOTlmZWI1YmUy MDgyZGYxNTk3MWI5MDRlOWM1ZTQ1YzA2Li4wOTZiMTcwYjNhMWIwODc3YTRmZWIwZGY5ZjVhYzQ4 MzEwYTA2YzMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTEtMDQtMjggIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCisgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHI4NTEwMS4KKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9j aGFuZ2VzZXQvODUxMDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU5NzU3CisKKyAgICAgICAgIGl0J2QgYmUgYmV0dGVyIHRvIHJvbGxvdXQgdGhlIHBh dGNoIGFuZCBkbyBhbm90aGVyIG9uZSB3aXRoCisgICAgICAgIGFub3RoZXIgcHJvcGVydHkgbmFt ZS4gQ3VycmVudCBvbmUgd2lsbCBicmluZyB1cyB0byBhIHByb2JsZW0KKyAgICAgICAgYXQgZmly c3QgcnVuIGFmdGVyIHVwZ3JhZGUgYmVjYXVzZSBpdCdzIHR5cGUgd2FzIGNoYW5nZWQgZnJvbQor ICAgICAgICBpbnQgdG8gc3RyaW5nLiAoUmVxdWVzdGVkIGJ5IGxvaXNsbyBvbiAjd2Via2l0KS4K KworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUuX2RlYnVnZ2VyV2FzRW5hYmxl ZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZS5fc2V0UGF1 c2VPbkV4Y2VwdGlvbnMuY2FsbGJhY2spOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdHNQ YW5lbC5wcm90b3R5cGUuX3NldFBhdXNlT25FeGNlcHRpb25zKToKKworMjAxMS0wNC0yOCAgU2hl cmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CisKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjg1MjMzIGFuZCByODUyMzUuCiAgICAgICAgIGh0dHA6Ly90cmFj LndlYmtpdC5vcmcvY2hhbmdlc2V0Lzg1MjMzCiAgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5v cmcvY2hhbmdlc2V0Lzg1MjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvU2NyaXB0c1BhbmVsLmpzCmluZGV4IGZjYzliZWQzMzFmNzBkYTZmYTdlM2M1MDZhNjE3 ZWRjMGRjYjIzOTQuLmIwZGE2Mzk5ZmY3NWVkYzc4OGJkOGI4NDM5YTMzNmI3Y2JkZGUxMmUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVs LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVs LmpzCkBAIC00NDYsNyArNDQ2LDcgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5 cGUgPSB7CiAKICAgICBfZGVidWdnZXJXYXNFbmFibGVkOiBmdW5jdGlvbigpCiAgICAgewotICAg ICAgICB0aGlzLl9zZXRQYXVzZU9uRXhjZXB0aW9ucyhXZWJJbnNwZWN0b3Iuc2V0dGluZ3MucGF1 c2VPbkV4Y2VwdGlvblN0YXRlKTsKKyAgICAgICAgdGhpcy5fc2V0UGF1c2VPbkV4Y2VwdGlvbnMo V2ViSW5zcGVjdG9yLnNldHRpbmdzLnBhdXNlT25FeGNlcHRpb25TdGF0ZVN0cmluZyk7CiAKICAg ICAgICAgaWYgKHRoaXMuX2RlYnVnZ2VyRW5hYmxlZCkKICAgICAgICAgICAgIHJldHVybjsKQEAg LTcxNSw3ICs3MTUsNyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZSA9IHsK ICAgICAgICAgICAgICAgICB0aGlzLl9wYXVzZU9uRXhjZXB0aW9uQnV0dG9uLnRpdGxlID0gV2Vi SW5zcGVjdG9yLlVJU3RyaW5nKCJQYXVzZSBvbiB1bmNhdWdodCBleGNlcHRpb25zLlxuQ2xpY2sg dG8gTm90IHBhdXNlIG9uIGV4Y2VwdGlvbnMuIik7CiAKICAgICAgICAgICAgIHRoaXMuX3BhdXNl T25FeGNlcHRpb25CdXR0b24uc3RhdGUgPSBwYXVzZU9uRXhjZXB0aW9uc1N0YXRlOwotICAgICAg ICAgICAgV2ViSW5zcGVjdG9yLnNldHRpbmdzLnBhdXNlT25FeGNlcHRpb25TdGF0ZSA9IHBhdXNl T25FeGNlcHRpb25zU3RhdGU7CisgICAgICAgICAgICBXZWJJbnNwZWN0b3Iuc2V0dGluZ3MucGF1 c2VPbkV4Y2VwdGlvblN0YXRlU3RyaW5nID0gcGF1c2VPbkV4Y2VwdGlvbnNTdGF0ZTsKICAgICAg ICAgfQogICAgICAgICBEZWJ1Z2dlckFnZW50LnNldFBhdXNlT25FeGNlcHRpb25zKHBhdXNlT25F eGNlcHRpb25zU3RhdGUsIGNhbGxiYWNrLmJpbmQodGhpcykpOwogICAgIH0sCg==