59750 2011-04-28 15:36:42 -0700 fast/harness/results.html failing in some configurations 2011-04-28 16:47:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 59711 1 kbr ojan dpranke eric kbr tony oldest_to_newest 394828 0 kbr 2011-04-28 15:36:42 -0700 fast/harness/results.html is failing in some configurations, at least Chromium Win. Please see: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Vista/builds/2315 Adding a downstream suppression for the moment. 394855 1 91575 ojan 2011-04-28 15:58:39 -0700 Created attachment 91575 Patch 394899 2 91575 darin 2011-04-28 16:38:24 -0700 Comment on attachment 91575 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91575&action=review > LayoutTests/fast/harness/resources/results-test.js:318 > + // Use a regexp to match windows and unix-style paths. Never heard of windows and unix, maybe you mean Windows and Unix? ;-) > LayoutTests/fast/harness/resources/results-test.js:319 > + var expectedRegExp = new RegExp('file.*' + results.layout_tests_dir + '/fullscreen/full-screen-api.html'); Does this need a ^ and a $, or does the exec function only match the entire URL? 394911 3 ojan 2011-04-28 16:43:12 -0700 (In reply to comment #2) > (From update of attachment 91575 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91575&action=review > > > LayoutTests/fast/harness/resources/results-test.js:318 > > + // Use a regexp to match windows and unix-style paths. > > Never heard of windows and unix, maybe you mean Windows and Unix? ;-) lol. Will fix. > > LayoutTests/fast/harness/resources/results-test.js:319 > > + var expectedRegExp = new RegExp('file.*' + results.layout_tests_dir + '/fullscreen/full-screen-api.html'); > > Does this need a ^ and a $, or does the exec function only match the entire URL? Oh good point. It does need them. 394915 4 ojan 2011-04-28 16:47:02 -0700 Committed r85260: <http://trac.webkit.org/changeset/85260> 91575 2011-04-28 15:58:39 -0700 2011-04-28 16:38:24 -0700 Patch bug-59750-20110428155838.patch text/plain 1669 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogODUyNTAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxMzZiZjY3YTg3ODE1MDM4ZDUwZjBj OGM3ZTdjZDAwNjBhNTlhMjljLi5hZjJjZjI5Mjk4MjVhOGFlYTljNTA5OWI0NmVkNTc5YjIzNWYz NDM5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQtMjggIE9qYW4gVmFmYWkgIDxvamFu QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBmYXN0L2hhcm5lc3MvcmVzdWx0cy5odG1sIGZhaWxpbmcgaW4gc29tZSBjb25maWd1 cmF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTk3NTAKKworICAgICAgICAqIGZhc3QvaGFybmVzcy9yZXNvdXJjZXMvcmVzdWx0cy10ZXN0Lmpz OgorCiAyMDExLTA0LTI4ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9oYXJuZXNzL3Jlc291cmNlcy9yZXN1bHRzLXRlc3QuanMgYi9MYXlvdXRUZXN0cy9mYXN0 L2hhcm5lc3MvcmVzb3VyY2VzL3Jlc3VsdHMtdGVzdC5qcwppbmRleCBhMjdiOWE2MjRkZmNkYmE4 ZjRiYjM3YWQyODhhZGQ3YTdlYTljOTg3Li41YTk3ZWZiNDdiNjEwNmJiNTM2NDIzNjM4MzAxZDZj NDBjZWViMzcwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzb3VyY2Vz L3Jlc3VsdHMtdGVzdC5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvcmVzb3VyY2Vz L3Jlc3VsdHMtdGVzdC5qcwpAQCAtMzE1LDggKzMxNSw5IEBAIGZ1bmN0aW9uIHJ1blRlc3RzKCkK ICAgICByZXN1bHRzID0gbW9ja1Jlc3VsdHMoKTsKICAgICByZXN1bHRzLnRlc3RzWydmdWxsc2Ny ZWVuL2Z1bGwtc2NyZWVuLWFwaS5odG1sJ10gPSBtb2NrRXhwZWN0YXRpb24oJ1RFWFQnLCAnSU1B R0UrVEVYVCcpOwogICAgIHJ1blRlc3QocmVzdWx0cywgZnVuY3Rpb24oKSB7Ci0gICAgICAgIHZh ciBleHBlY3RlZEhyZWYgPSAnZmlsZTovLycgKyByZXN1bHRzLmxheW91dF90ZXN0c19kaXIgKyAn L2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4tYXBpLmh0bWwnOwotICAgICAgICBhc3NlcnRUcnVlKGRv Y3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ3Rib2R5IHRkOmZpcnN0LWNoaWxkIGEnKS5ocmVmID09IGV4 cGVjdGVkSHJlZik7CisgICAgICAgIC8vIFVzZSBhIHJlZ2V4cCB0byBtYXRjaCB3aW5kb3dzIGFu ZCB1bml4LXN0eWxlIHBhdGhzLgorICAgICAgICB2YXIgZXhwZWN0ZWRSZWdFeHAgPSBuZXcgUmVn RXhwKCdmaWxlLionICsgcmVzdWx0cy5sYXlvdXRfdGVzdHNfZGlyICsgJy9mdWxsc2NyZWVuL2Z1 bGwtc2NyZWVuLWFwaS5odG1sJyk7CisgICAgICAgIGFzc2VydFRydWUoZXhwZWN0ZWRSZWdFeHAu ZXhlYyhkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCd0Ym9keSB0ZDpmaXJzdC1jaGlsZCBhJykuaHJl ZikpOwogICAgIH0pOwogICAgIAogICAgIHZhciBvbGRTaG91bGRVc2VUcmFjTGlua3MgPSBzaG91 bGRVc2VUcmFjTGlua3M7Cg==