59747 2011-04-28 15:17:47 -0700 Web Inspector: REGRESSION(85051): Develop Menu items are wrong when inspector is frontmost window 2011-04-28 15:53:13 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 bweinstein bweinstein abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 394802 0 bweinstein 2011-04-28 15:17:47 -0700 http://trac.webkit.org/changeset/85051 broke Safari's Develop Menu when the Inspector was frontmost. The removed code in WebInspectorClient.cpp was used. 394815 1 91566 bweinstein 2011-04-28 15:25:45 -0700 Created attachment 91566 [PATCH] Revert part of r85051 394826 2 bweinstein 2011-04-28 15:34:17 -0700 Landed in r85250. 394845 3 webkit.review.bot 2011-04-28 15:53:13 -0700 http://trac.webkit.org/changeset/85250 might have broken WinCE Release (Build) 91566 2011-04-28 15:25:45 -0700 2011-04-28 15:27:01 -0700 [PATCH] Revert part of r85051 revert_85051.patch text/plain 3334 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1MjQ3KQorKysgU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQtMjgg IEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJ T04oODUwNTEpOiBEZXZlbG9wIE1lbnUgaXRlbXMgYXJlIHdyb25nIHdoZW4gaW5zcGVjdG9yIGlz IGZyb250bW9zdCB3aW5kb3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU5NzQ3CisKKyAgICAgICAgUmVzdG9yZSBmdW5jdGlvbnMgdGhhdCB3ZXJlIHJl bW92ZWQgaW4gcjg1MDUxLiBUaGV5IHdlcmUgbmVlZGVkIHdoZW4gdGhlIGluc3BlY3RvciBpcyB0 aGUgZnJvbnRtb3N0IHdpbmRvdy4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1dlYkluc3Bl Y3RvckNsaWVudC5tbToKKyAgICAgICAgKC1bV2ViSW5zcGVjdG9yV2luZG93Q29udHJvbGxlciBz aG93V2ViSW5zcGVjdG9yOl0pOgorICAgICAgICAoLVtXZWJJbnNwZWN0b3JXaW5kb3dDb250cm9s bGVyIHNob3dFcnJvckNvbnNvbGU6XSk6CisgICAgICAgICgtW1dlYkluc3BlY3RvcldpbmRvd0Nv bnRyb2xsZXIgdG9nZ2xlRGVidWdnaW5nSmF2YVNjcmlwdDpdKToKKyAgICAgICAgKC1bV2ViSW5z cGVjdG9yV2luZG93Q29udHJvbGxlciB0b2dnbGVQcm9maWxpbmdKYXZhU2NyaXB0Ol0pOgorICAg ICAgICAoLVtXZWJJbnNwZWN0b3JXaW5kb3dDb250cm9sbGVyIHZhbGlkYXRlVXNlckludGVyZmFj ZUl0ZW06XSk6CisKIDIwMTEtMDQtMjggIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNv bT4KIAogICAgICAgICBGb2xsb3ctdXAgZml4OiA8aHR0cDovL3dlYmtpdC5vcmcvYi81OTcyNz4g LVtXZWJQREZWaWV3IG1lbnVGb3JFdmVudDpdIGxlYWtzIE5TTWVudUl0ZW0gb2JqZWN0cwpJbmRl eDogU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3Bl Y3RvckNsaWVudC5tbQkocmV2aXNpb24gODUyNDUpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJD b3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQubW0JKHdvcmtpbmcgY29weSkKQEAgLTQ3Miw0 ICs0NzIsNDkgQEAgLSAoTlNVSW50ZWdlcil3ZWJWaWV3OihXZWJWaWV3ICopc2VuZGVyIAogICAg IHJldHVybiBXZWJEcmFnRGVzdGluYXRpb25BY3Rpb25Ob25lOwogfQogCisvLyBNQVJLOiAtCisv LyBUaGVzZSBtZXRob2RzIGNhbiBiZSB1c2VkIGJ5IFVJIGVsZW1lbnRzIHN1Y2ggYXMgbWVudSBp dGVtcyBhbmQgdG9vbGJhciBidXR0b25zIHdoZW4gdGhlIGluc3BlY3RvciBpcyB0aGUga2V5IHdp bmRvdy4KKworLy8gVGhpcyBtZXRob2QgaXMgcmVhbGx5IG9ubHkgaW1wbGVtZW50ZWQgdG8ga2Vl cCBhbnkgVUkgZWxlbWVudHMgZW5hYmxlZC4KKy0gKHZvaWQpc2hvd1dlYkluc3BlY3RvcjooaWQp c2VuZGVyCit7CisgICAgW1tfaW5zcGVjdGVkV2ViVmlldyBpbnNwZWN0b3JdIHNob3c6c2VuZGVy XTsKK30KKworLSAodm9pZClzaG93RXJyb3JDb25zb2xlOihpZClzZW5kZXIKK3sKKyAgICBbW19p bnNwZWN0ZWRXZWJWaWV3IGluc3BlY3Rvcl0gc2hvd0NvbnNvbGU6c2VuZGVyXTsKK30KKworLSAo dm9pZCl0b2dnbGVEZWJ1Z2dpbmdKYXZhU2NyaXB0OihpZClzZW5kZXIKK3sKKyAgICBbW19pbnNw ZWN0ZWRXZWJWaWV3IGluc3BlY3Rvcl0gdG9nZ2xlRGVidWdnaW5nSmF2YVNjcmlwdDpzZW5kZXJd OworfQorCistICh2b2lkKXRvZ2dsZVByb2ZpbGluZ0phdmFTY3JpcHQ6KGlkKXNlbmRlcgorewor ICAgIFtbX2luc3BlY3RlZFdlYlZpZXcgaW5zcGVjdG9yXSB0b2dnbGVQcm9maWxpbmdKYXZhU2Ny aXB0OnNlbmRlcl07Cit9CisKKy0gKEJPT0wpdmFsaWRhdGVVc2VySW50ZXJmYWNlSXRlbTooaWQg PE5TVmFsaWRhdGVkVXNlckludGVyZmFjZUl0ZW0+KWl0ZW0KK3sKKyAgICBCT09MIGlzTWVudUl0 ZW0gPSBbKGlkKWl0ZW0gaXNLaW5kT2ZDbGFzczpbTlNNZW51SXRlbSBjbGFzc11dOworICAgIGlm IChbaXRlbSBhY3Rpb25dID09IEBzZWxlY3Rvcih0b2dnbGVEZWJ1Z2dpbmdKYXZhU2NyaXB0Oikg JiYgaXNNZW51SXRlbSkgeworICAgICAgICBOU01lbnVJdGVtICptZW51SXRlbSA9IChOU01lbnVJ dGVtICopaXRlbTsKKyAgICAgICAgaWYgKFtbX2luc3BlY3RlZFdlYlZpZXcgaW5zcGVjdG9yXSBp c0RlYnVnZ2luZ0phdmFTY3JpcHRdKQorICAgICAgICAgICAgW21lbnVJdGVtIHNldFRpdGxlOlVJ X1NUUklOR19JTlRFUk5BTCgiU3RvcCBEZWJ1Z2dpbmcgSmF2YVNjcmlwdCIsICJ0aXRsZSBmb3Ig U3RvcCBEZWJ1Z2dpbmcgSmF2YVNjcmlwdCBtZW51IGl0ZW0iKV07CisgICAgICAgIGVsc2UKKyAg ICAgICAgICAgIFttZW51SXRlbSBzZXRUaXRsZTpVSV9TVFJJTkdfSU5URVJOQUwoIlN0YXJ0IERl YnVnZ2luZyBKYXZhU2NyaXB0IiwgInRpdGxlIGZvciBTdGFydCBEZWJ1Z2dpbmcgSmF2YVNjcmlw dCBtZW51IGl0ZW0iKV07CisgICAgfSBlbHNlIGlmIChbaXRlbSBhY3Rpb25dID09IEBzZWxlY3Rv cih0b2dnbGVQcm9maWxpbmdKYXZhU2NyaXB0OikgJiYgaXNNZW51SXRlbSkgeworICAgICAgICBO U01lbnVJdGVtICptZW51SXRlbSA9IChOU01lbnVJdGVtICopaXRlbTsKKyAgICAgICAgaWYgKFtb X2luc3BlY3RlZFdlYlZpZXcgaW5zcGVjdG9yXSBpc1Byb2ZpbGluZ0phdmFTY3JpcHRdKQorICAg ICAgICAgICAgW21lbnVJdGVtIHNldFRpdGxlOlVJX1NUUklOR19JTlRFUk5BTCgiU3RvcCBQcm9m aWxpbmcgSmF2YVNjcmlwdCIsICJ0aXRsZSBmb3IgU3RvcCBQcm9maWxpbmcgSmF2YVNjcmlwdCBt ZW51IGl0ZW0iKV07CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIFttZW51SXRlbSBzZXRUaXRs ZTpVSV9TVFJJTkdfSU5URVJOQUwoIlN0YXJ0IFByb2ZpbGluZyBKYXZhU2NyaXB0IiwgInRpdGxl IGZvciBTdGFydCBQcm9maWxpbmcgSmF2YVNjcmlwdCBtZW51IGl0ZW0iKV07CisgICAgfQorCisg ICAgcmV0dXJuIFlFUzsKK30KKworCiBAZW5kCg==