59743 2011-04-28 15:06:26 -0700 DumpRenderTree should have an install target for the Perl support module 2011-06-18 19:15:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.6 RESOLVED FIXED P2 Normal --- 1 slewis webkit-unassigned darin mrowe slewis webkit.review.bot oldest_to_newest 394791 0 slewis 2011-04-28 15:06:26 -0700 This breaks automated tests of mac production builds 394792 1 91564 slewis 2011-04-28 15:07:24 -0700 Created attachment 91564 patch 394793 2 webkit.review.bot 2011-04-28 15:08:58 -0700 Attachment 91564 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/m..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 394813 3 91564 mrowe 2011-04-28 15:25:06 -0700 Comment on attachment 91564 patch View in context: https://bugs.webkit.org/attachment.cgi?id=91564&action=review Marking as r- as the destination path is not correct. > Tools/ChangeLog:6 > + Add an install target for production builds. You can put this on a single line. > Tools/ChangeLog:8 > + * DumpRenderTree/mac/PerlSupport/Makefile: You’re missing a blank line after this. > Tools/DumpRenderTree/mac/PerlSupport/Makefile:78 > +INSTALL_PATH=/System/Library/Frameworks I don’t like the name INSTALL_PATH for this since INSTALL_PATH in Xcode configuration settings means something different. It wouldn’t hurt to use SYSTEM_LIBRARY_DIR in place of the hard-coded /System/Library here either. And if you’re going to pull the base of the destination directory out in to an environment variable, I’d suggest pulling all of it rather than just a subset from the middle. > Tools/DumpRenderTree/mac/PerlSupport/Makefile:82 > + cp $(PERL_MODULE) $(NEXT_ROOT)/$(INSTALL_PATH)/$(WEBKIT_FRAMEWORK_RESOURCES_PATH)/DumpRenderTreeSupport.pm This isn’t right. Files need to be installed below DSTROOT. 395128 4 91642 slewis 2011-04-28 22:58:12 -0700 Created attachment 91642 new install location 423298 5 slewis 2011-06-18 19:15:52 -0700 committed http://trac.webkit.org/projects/webkit/changeset/85308 91564 2011-04-28 15:07:24 -0700 2011-04-28 22:58:12 -0700 patch drt.patch text/plain 1256 slewis SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg1MjM4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTEgQEAKKzIwMTEtMDQtMjggIFN0ZXBoYW5pZSBMZXdpcyAgPHNsZXdpc0BhcHBsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzkwNDA0MTM+CisgICAgICAgIEFkZCBhbiBpbnN0YWxsIHRhcmdldCBmb3IgcHJv ZHVjdGlvbiBidWlsZHMuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvUGVybFN1cHBv cnQvTWFrZWZpbGU6CiAyMDExLTA0LTI4ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJU cmVlL21hYy9QZXJsU3VwcG9ydC9NYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVu ZGVyVHJlZS9tYWMvUGVybFN1cHBvcnQvTWFrZWZpbGUJKHJldmlzaW9uIDg1MjM4KQorKysgVG9v bHMvRHVtcFJlbmRlclRyZWUvbWFjL1BlcmxTdXBwb3J0L01ha2VmaWxlCSh3b3JraW5nIGNvcHkp CkBAIC03MSw0ICs3MSwxOCBAQCAkKERZTElCKTogRHVtcFJlbmRlclRyZWVTdXBwb3J0LmMgJChX UkFQCiBjbGVhbjoKIAlybSAtZiAkKFdSQVBQRVIpICQoUEVSTF9NT0RVTEUpICQoRFlMSUIpCiAK LWluc3RhbGxoZHJzIGluc3RhbGxzcmMgaW5zdGFsbDoKK2luc3RhbGxoZHJzIGluc3RhbGxzcmM6 CisKK2lmZXEgIiQoQ09ORklHVVJBVElPTikiICJQcm9kdWN0aW9uIgorCitJTlNUQUxMX1BBVEg9 L1N5c3RlbS9MaWJyYXJ5L0ZyYW1ld29ya3MKKworaW5zdGFsbDogYWxsCisJY3AgJChEWUxJQikg JChORVhUX1JPT1QpLyQoSU5TVEFMTF9QQVRIKS8kKFdFQktJVF9GUkFNRVdPUktfUkVTT1VSQ0VT X1BBVEgpL0R1bXBSZW5kZXJUcmVlU3VwcG9ydC5keWxpYgorCWNwICQoUEVSTF9NT0RVTEUpICQo TkVYVF9ST09UKS8kKElOU1RBTExfUEFUSCkvJChXRUJLSVRfRlJBTUVXT1JLX1JFU09VUkNFU19Q QVRIKS9EdW1wUmVuZGVyVHJlZVN1cHBvcnQucG0KKworZWxzZQorCitpbnN0YWxsOgorCitlbmRp Zgo= 91642 2011-04-28 22:58:12 -0700 2011-04-29 00:03:55 -0700 new install location DRT.patch text/plain 1306 slewis SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg1MjI1KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTEtMDQtMjggIFN0ZXBoYW5pZSBMZXdpcyAgPHNsZXdpc0BhcHBsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cDov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk3NDMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzkwNDA0MTM+IEFkZCBhbiBpbnN0YWxsIHRhcmdldCBmb3IgcHJvZHVjdGlvbiBidWls ZHMuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvUGVybFN1cHBvcnQvTWFrZWZpbGU6 CisKIDIwMTEtMDQtMjggIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL21h Yy9QZXJsU3VwcG9ydC9NYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJl ZS9tYWMvUGVybFN1cHBvcnQvTWFrZWZpbGUJKHJldmlzaW9uIDg0NzgzKQorKysgVG9vbHMvRHVt cFJlbmRlclRyZWUvbWFjL1BlcmxTdXBwb3J0L01ha2VmaWxlCSh3b3JraW5nIGNvcHkpCkBAIC03 MSw0ICs3MSwxOSBAQCAkKERZTElCKTogRHVtcFJlbmRlclRyZWVTdXBwb3J0LmMgJChXUkFQCiBj bGVhbjoKIAlybSAtZiAkKFdSQVBQRVIpICQoUEVSTF9NT0RVTEUpICQoRFlMSUIpCiAKLWluc3Rh bGxoZHJzIGluc3RhbGxzcmMgaW5zdGFsbDoKK2luc3RhbGxoZHJzIGluc3RhbGxzcmM6CisKK2lm ZXEgIiQoQ09ORklHVVJBVElPTikiICJQcm9kdWN0aW9uIgorCitJTlNUQUxMX0xPQ0FUSU9OPSQo RFNUUk9PVCkvJChTWVNURU1fTElCUkFSWV9ESVIpL0ZyYW1ld29ya3MvJChXRUJLSVRfRlJBTUVX T1JLX1JFU09VUkNFU19QQVRIKQorCitpbnN0YWxsOiBhbGwKKwlta2RpciAtcCAkKElOU1RBTExf TE9DQVRJT04pCisJY3AgJChEWUxJQikgJChJTlNUQUxMX0xPQ0FUSU9OKS9EdW1wUmVuZGVyVHJl ZVN1cHBvcnQuZHlsaWIKKwljcCAkKFBFUkxfTU9EVUxFKSAkKElOU1RBTExfTE9DQVRJT04pL0R1 bXBSZW5kZXJUcmVlU3VwcG9ydC5wbQorCitlbHNlCisKK2luc3RhbGw6CisKK2VuZGlmCg==