59727 2011-04-28 12:31:05 -0700 -[WebPDFView menuForEvent:] leaks NSMenuItem objects 2011-04-28 14:40:25 -0700 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 3711 1 ddkilzer ddkilzer darin sullivan webkit.review.bot oldest_to_newest 394659 0 91537 ddkilzer 2011-04-28 12:31:05 -0700 Created attachment 91537 Patch Reviewed by NOBODY (OOPS!). * WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): Call -autorelease after copying each NSMenuItem. Regressed in r9566. --- 2 files changed, 11 insertions(+), 1 deletions(-) 394660 1 webkit.review.bot 2011-04-28 12:34:06 -0700 Attachment 91537 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 394668 2 ddkilzer 2011-04-28 12:45:37 -0700 (In reply to comment #0) > Regressed in r9566. <http://trac.webkit.org/changeset/9566> 394672 3 ddkilzer 2011-04-28 12:46:37 -0700 (In reply to comment #2) > (In reply to comment #0) > > Regressed in r9566. > <http://trac.webkit.org/changeset/9566> Bug 3711! 394677 4 91537 darin 2011-04-28 12:48:24 -0700 Comment on attachment 91537 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91537&action=review > Source/WebKit/mac/WebView/WebPDFView.mm:395 > + [menu addItem:[[menuItem copy] autorelease]]; It’s normally better to use release than autorelease. We could do that by adding a local variable. 394698 5 ddkilzer 2011-04-28 13:17:05 -0700 Committed r85230: <http://trac.webkit.org/changeset/85230> 394764 6 ddkilzer 2011-04-28 14:40:25 -0700 (In reply to comment #4) > (From update of attachment 91537 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91537&action=review > > > Source/WebKit/mac/WebView/WebPDFView.mm:395 > > + [menu addItem:[[menuItem copy] autorelease]]; > > It’s normally better to use release than autorelease. We could do that by adding a local variable. Committed r85237: <http://trac.webkit.org/changeset/85237> 91537 2011-04-28 12:31:05 -0700 2011-04-28 12:48:24 -0700 Patch 20110428123104.patch text/plain 1402 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogODUxOTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFj L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwppbmRleCBlNzM5MjUzZTU5 OGYzODIzNGY5NTJjYjJkNzBjZGU4ZTI5NDhjNjgwLi43Y2U4MDA3MzEyYzhmODNmMzZkNDJlZDFm ODJiN2MwYTBiYzY5M2M1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEt MDQtMjggIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICA8aHR0 cDovL3dlYmtpdC5vcmcvYi8wMDAwMD4gLVtXZWJQREZWaWV3IG1lbnVGb3JFdmVudDpdIGxlYWtz IE5TTWVudUl0ZW0gb2JqZWN0cworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogV2ViVmlldy9XZWJQREZWaWV3Lm1tOgorICAgICAgICAoLVtXZWJQREZW aWV3IG1lbnVGb3JFdmVudDpdKTogQ2FsbCAtYXV0b3JlbGVhc2UgYWZ0ZXIgY29weWluZworICAg ICAgICBlYWNoIE5TTWVudUl0ZW0uICBSZWdyZXNzZWQgaW4gcjk1NjYuCisKIDIwMTEtMDQtMjcg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBGb2xsb3ct dXAgTGVvcGFyZCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJW aWV3L1dlYlBERlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlBERlZpZXcu bW0KaW5kZXggMDM3ZmU1ZGY4NDg4MjkyOTI1Y2FjMWQ2NTU1ZDFmNDcyYzUxMTNkOC4uOGFjMDAx Njg1YmY1NDYzM2M1ZDEzNTFiMmFlZjM1OTdiYzEwYjI1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9tYWMvV2ViVmlldy9XZWJQREZWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL1dl YlZpZXcvV2ViUERGVmlldy5tbQpAQCAtMzkyLDcgKzM5Miw3IEBAIC0gKE5TTWVudSAqKW1lbnVG b3JFdmVudDooTlNFdmVudCAqKXRoZUV2ZW50CiAgICAgICAgIHdoaWxlICgobWVudUl0ZW0gPSBb ZSBuZXh0T2JqZWN0XSkgIT0gbmlsKSB7CiAgICAgICAgICAgICAvLyBjb3B5IG1lbnVJdGVtIHNp bmNlIGEgZ2l2ZW4gbWVudUl0ZW0gY2FuIGJlIGluIG9ubHkgb25lIG1lbnUgYXQgYSB0aW1lLCBh bmQgd2UgZG9uJ3QKICAgICAgICAgICAgIC8vIHdhbnQgdG8gbWVzcyB3aXRoIHRoZSBtZW51IHJl dHVybmVkIGZyb20gUERGS2l0LgotICAgICAgICAgICAgW21lbnUgYWRkSXRlbTpbbWVudUl0ZW0g Y29weV1dOworICAgICAgICAgICAgW21lbnUgYWRkSXRlbTpbW21lbnVJdGVtIGNvcHldIGF1dG9y ZWxlYXNlXV07CiAgICAgICAgIH0KICAgICB9CiAgICAgCg==