59705 2011-04-28 09:19:28 -0700 WTF::postTimer() leaks a CFRunLoopTimerRef every time it's called 2011-04-28 17:07:57 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other OS X 10.5 RESOLVED INVALID InRadar P2 Normal --- 35943 1 ddkilzer ddkilzer darin dimich webkit.review.bot oldest_to_newest 394469 0 91502 ddkilzer 2011-04-28 09:19:28 -0700 Created attachment 91502 Patch Reviewed by NOBODY (OOPS!). * wtf/mac/MainThreadMac.mm: (WTF::postTimer): Use RetainPtr to plug the leak. --- 2 files changed, 12 insertions(+), 1 deletions(-) 394471 1 91502 simon.fraser 2011-04-28 09:20:53 -0700 Comment on attachment 91502 Patch Good catch! 394472 2 webkit.review.bot 2011-04-28 09:21:53 -0700 Attachment 91502 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 394473 3 ddkilzer 2011-04-28 09:22:25 -0700 This regressed in r55816 for Bug 35943. <http://trac.webkit.org/changeset/55816> 394487 4 ddkilzer 2011-04-28 09:40:38 -0700 Committed r85195: <http://trac.webkit.org/changeset/85195> 394924 5 ddkilzer 2011-04-28 16:54:53 -0700 This needs to be rolled out. It causes crashes on Lion. 394927 6 ddkilzer 2011-04-28 16:56:02 -0700 <rdar://problem/9355811> 394935 7 91502 darin 2011-04-28 17:00:07 -0700 Comment on attachment 91502 Patch I don’t think this fix is correct. The timerFired function releases the timer when it fires, so as far as I can tell there is no leak here. 394946 8 ddkilzer 2011-04-28 17:07:57 -0700 (In reply to comment #7) > (From update of attachment 91502 [details]) > I don’t think this fix is correct. The timerFired function releases the timer when it fires, so as far as I can tell there is no leak here. Ahh...that's kind of strange, but it works. Rolled out in r85265. <http://trac.webkit.org/changeset/85265> Closing as RESOLVED/INVALID. 91502 2011-04-28 09:19:28 -0700 2011-04-28 17:00:07 -0700 Patch 20110428091926.patch text/plain 1644 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogODQ5MzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDhh Nzk1NGMzNGZkM2FiMmU3OTc4YzlhYTQ0ZmQ3NmRhYWZiZGY4NDguLmE2YTVlNmJhYmQ1MzExOTM2 MzZkM2I4YmI3NmZhOWI2Zjg0MmY4MDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDExLTA0LTI4ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+ CisKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMDAwMDA+IFdURjo6cG9zdFRpbWVyKCkg bGVha3MgYSBDRlJ1bkxvb3BUaW1lclJlZiBldmVyeSB0aW1lIGl0J3MgY2FsbGVkCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvbWFjL01haW5U aHJlYWRNYWMubW06CisgICAgICAgIChXVEY6OnBvc3RUaW1lcik6IFVzZSBSZXRhaW5QdHIgdG8g cGx1ZyB0aGUgbGVhay4KKwogMjAxMS0wNC0yNiAgR2Fib3IgTG9raSAgPGxva2lAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL21hYy9NYWluVGhyZWFkTWFjLm1tIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3d0Zi9tYWMvTWFpblRocmVhZE1hYy5tbQppbmRleCAxNzM2M2JjOTJl OWQwYWEyYTY5MTZkMTQ1MTMwNGUwODBkNzYxYjExLi42YzdkN2M1ZTMxODI3OGI0MWRiOTdlZTQw ZjIyMDNjMjY1MTlhODBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL21h Yy9NYWluVGhyZWFkTWFjLm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvbWFjL01h aW5UaHJlYWRNYWMubW0KQEAgLTMzLDYgKzMzLDcgQEAKICNpbXBvcnQgPEZvdW5kYXRpb24vTlNU aHJlYWQuaD4KICNpbXBvcnQgPHN0ZGlvLmg+CiAjaW1wb3J0IDx3dGYvQXNzZXJ0aW9ucy5oPgor I2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogI2ltcG9ydCA8d3RmL1RocmVhZGluZy5oPgogCiBA aW50ZXJmYWNlIFdURk1haW5UaHJlYWRDYWxsZXIgOiBOU09iamVjdCB7CkBAIC05OSw3ICsxMDAs OCBAQCBzdGF0aWMgdm9pZCBwb3N0VGltZXIoKQogICAgICAgICByZXR1cm47CiAKICAgICBpc1Rp bWVyUG9zdGVkID0gdHJ1ZTsKLSAgICBDRlJ1bkxvb3BBZGRUaW1lcihDRlJ1bkxvb3BHZXRDdXJy ZW50KCksIENGUnVuTG9vcFRpbWVyQ3JlYXRlKDAsIDAsIDAsIDAsIDAsIHRpbWVyRmlyZWQsIDAp LCBrQ0ZSdW5Mb29wQ29tbW9uTW9kZXMpOworICAgIFJldGFpblB0cjxDRlJ1bkxvb3BUaW1lclJl Zj4gcnVuTG9vcFRpbWVyKEFkb3B0Q0YsIENGUnVuTG9vcFRpbWVyQ3JlYXRlKDAsIDAsIDAsIDAs IDAsIHRpbWVyRmlyZWQsIDApKTsKKyAgICBDRlJ1bkxvb3BBZGRUaW1lcihDRlJ1bkxvb3BHZXRD dXJyZW50KCksIHJ1bkxvb3BUaW1lci5nZXQoKSwga0NGUnVuTG9vcENvbW1vbk1vZGVzKTsKIH0K IAogdm9pZCBzY2hlZHVsZURpc3BhdGNoRnVuY3Rpb25zT25NYWluVGhyZWFkKCkK