59704 2011-04-28 09:02:37 -0700 Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER 2011-04-28 11:24:52 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 394457 0 yael 2011-04-28 09:02:37 -0700 Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER . It is not being used. A patch is coming soon. 394462 1 91500 yael 2011-04-28 09:06:34 -0700 Created attachment 91500 Patch. 394474 2 91500 kling 2011-04-28 09:23:37 -0700 Comment on attachment 91500 Patch. rs=me 394535 3 91500 commit-queue 2011-04-28 10:40:21 -0700 Comment on attachment 91500 Patch. Clearing flags on attachment: 91500 Committed r85206: <http://trac.webkit.org/changeset/85206> 394536 4 commit-queue 2011-04-28 10:40:27 -0700 All reviewed patches have been landed. Closing bug. 394576 5 webkit.review.bot 2011-04-28 11:24:52 -0700 http://trac.webkit.org/changeset/85206 might have broken SnowLeopard Intel Release (Tests) 91500 2011-04-28 09:06:34 -0700 2011-04-28 10:40:21 -0700 Patch. 57904.patch text/plain 5636 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1MTg3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMjggIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBmbGFnIEVOQUJMRV9TWU1CSUFOX0RJQUxPR19Q Uk9WSURFUgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTk3MDQKKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgY29kZSBjbGVhbnVwLgorCisgICAg ICAgICogV2ViQ29yZS5wcmk6CisKIDIwMTEtMDQtMjggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1h bkBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9XZWJDb3JlLnByaQkocmV2aXNpb24gODUxNzkpCisrKyBTb3VyY2UvV2ViQ29yZS9XZWJD b3JlLnByaQkod29ya2luZyBjb3B5KQpAQCAtMjc2LDE0ICsyNzYsNiBAQCBjb250YWlucyhERUZJ TkVTLCBFTkFCTEVfV0VCR0w9MSl8Y29udGFpCiAgICAgUVQgKj0gb3BlbmdsCiB9CiAKLWNvbnRh aW5zKERFRklORVMsIEVOQUJMRV9TWU1CSUFOX0RJQUxPR19QUk9WSURFUlMpIHsKLSAgICAjIHRo aXMgZmVhdHVyZSByZXF1aXJlcyB0aGUgUzYwIHBsYXRmb3JtIHByaXZhdGUgQnJvd3NlckRpYWxv Z3NQcm92aWRlci5oIGhlYWRlciBmaWxlCi0gICAgIyBhbmQgaXMgdGhlcmVmb3JlIG5vdCBlbmFi bGVkIGJ5IGRlZmF1bHQgYnV0IG9ubHkgbWVhbnQgZm9yIHBsYXRmb3JtIGJ1aWxkcy4KLSAgICBz eW1iaWFuIHsKLSAgICAgICAgTElCUyArPSAtbGJyb3dzZXJkaWFsb2dzcHJvdmlkZXIKLSAgICB9 Ci19Ci0KICFDT05GSUcod2Via2l0LWRlYnVnKTpDT05GSUcoUVRESVJfYnVpbGQpIHsKICAgICAj IFJlbW92ZSB0aGUgZm9sbG93aW5nIDIgbGluZXMgaWYgeW91IHdhbnQgZGVidWcgaW5mb3JtYXRp b24gaW4gV2ViQ29yZQogICAgIENPTkZJRyAtPSBzZXBhcmF0ZV9kZWJ1Z19pbmZvCkluZGV4OiBT b3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZwkocmV2aXNpb24gODUxODcpCisrKyBTb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTA0LTI4ICBZYWVsIEFoYXJv biAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgZmxhZyBFTkFCTEVfU1lNQklBTl9ESUFMT0dfUFJP VklERVIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5 NzA0CisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9RdEZhbGxiYWNrV2ViUG9wdXAuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UXRGYWxsYmFja1dlYlBvcHVwOjpzaG93KToKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9RdEZhbGxiYWNrV2ViUG9wdXAuaDoKKwogMjAxMS0wNC0yNyAgWWkgU2hl biAgPHlpLjQuc2hlbkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBS b2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBTb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0 L1F0RmFsbGJhY2tXZWJQb3B1cC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9xdC9X ZWJDb3JlU3VwcG9ydC9RdEZhbGxiYWNrV2ViUG9wdXAuY3BwCShyZXZpc2lvbiA4NTE3OSkKKysr IFNvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUXRGYWxsYmFja1dlYlBvcHVwLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzUsMTIgKzM1LDYgQEAKICNpbmNsdWRlIDxRTW91c2VFdmVudD4K ICNpbmNsdWRlIDxRU3RhbmRhcmRJdGVtTW9kZWw+CiAKLSNpZiBFTkFCTEUoU1lNQklBTl9ESUFM T0dfUFJPVklERVJTKQotI2luY2x1ZGUgPEJyQ3RsRGlhbG9nc1Byb3ZpZGVyLmg+Ci0jaW5jbHVk ZSA8QnJvd3NlckRpYWxvZ3NQcm92aWRlci5oPiAvLyBTNjAgcGxhdGZvcm0gcHJpdmF0ZSBoZWFk ZXIgZmlsZQotI2luY2x1ZGUgPGUzMmJhc2UuaD4KLSNlbmRpZgotCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKIFF0RmFsbGJhY2tXZWJQb3B1cENvbWJvOjpRdEZhbGxiYWNrV2ViUG9wdXBDb21ibyhR dEZhbGxiYWNrV2ViUG9wdXAmIG93bmVyUG9wdXApCkBAIC0xMTMsMTAgKzEwNyw2IEBAIHZvaWQg UXRGYWxsYmFja1dlYlBvcHVwOjpzaG93KGNvbnN0IFFXZWIKICAgICBpZiAoIXBhZ2VDbGllbnQo KSkKICAgICAgICAgcmV0dXJuOwogCi0jaWYgRU5BQkxFKFNZTUJJQU5fRElBTE9HX1BST1ZJREVS UykKLSAgICBUUkFQX0lHTk9SRShzaG93UzYwQnJvd3NlckRpYWxvZygpKTsKLSNlbHNlCi0KICAg ICBkZXN0cm95UG9wdXAoKTsKICAgICBtX2NvbWJvID0gbmV3IFF0RmFsbGJhY2tXZWJQb3B1cENv bWJvKCp0aGlzKTsKICAgICBjb25uZWN0KG1fY29tYm8sIFNJR05BTChhY3RpdmF0ZWQoaW50KSks CkBAIC0xNTAsNjIgKzE0MCw4IEBAIHZvaWQgUXRGYWxsYmFja1dlYlBvcHVwOjpzaG93KGNvbnN0 IFFXZWIKICAgICBRTW91c2VFdmVudCBldmVudChRRXZlbnQ6Ok1vdXNlQnV0dG9uUHJlc3MsIFFD dXJzb3I6OnBvcygpLCBRdDo6TGVmdEJ1dHRvbiwKICAgICAgICAgICAgICAgICAgICAgICBRdDo6 TGVmdEJ1dHRvbiwgUXQ6Ok5vTW9kaWZpZXIpOwogICAgIFFDb3JlQXBwbGljYXRpb246OnNlbmRF dmVudChtX2NvbWJvLCAmZXZlbnQpOwotI2VuZGlmCiB9CiAKLSNpZiBFTkFCTEUoU1lNQklBTl9E SUFMT0dfUFJPVklERVJTKQotCi1zdGF0aWMgdm9pZCBSZXNldEFuZERlc3Ryb3koVEFueSogYVB0 cikKLXsKLSAgICBSUG9pbnRlckFycmF5PEhCdWZDPiogaXRlbXMgPSByZWludGVycHJldF9jYXN0 PFJQb2ludGVyQXJyYXk8SEJ1ZkM+KiA+KGFQdHIpOwotICAgIGl0ZW1zLT5SZXNldEFuZERlc3Ry b3koKTsKLX0KLQotdm9pZCBRdEZhbGxiYWNrV2ViUG9wdXA6OnNob3dTNjBCcm93c2VyRGlhbG9n KCkKLXsKLSAgICBzdGF0aWMgTUJyQ3RsRGlhbG9nc1Byb3ZpZGVyKiBkaWFsb2dzID0gQ0Jyb3dz ZXJEaWFsb2dzUHJvdmlkZXI6Ok5ld0woMCk7Ci0gICAgaWYgKCFkaWFsb2dzKQotICAgICAgICBy ZXR1cm47Ci0KLSAgICBpbnQgc2l6ZSA9IGl0ZW1Db3VudCgpOwotICAgIENBcnJheUZpeDxUQnJD dGxTZWxlY3RPcHRpb25EYXRhPiogb3B0aW9ucyA9IG5ldyBDQXJyYXlGaXhGbGF0PFRCckN0bFNl bGVjdE9wdGlvbkRhdGE+KHFNYXgoMSwgc2l6ZSkpOwotICAgIFJQb2ludGVyQXJyYXk8SEJ1ZkM+ IGl0ZW1zKHFNYXgoMSwgc2l6ZSkpOwotICAgIENsZWFudXBTdGFjazo6UHVzaEwoVENsZWFudXBJ dGVtKCZSZXNldEFuZERlc3Ryb3ksICZpdGVtcykpOwotCi0gICAgZm9yIChpbnQgaSA9IDA7IGkg PCBzaXplOyBpKyspIHsKLSAgICAgICAgaWYgKGl0ZW1UeXBlKGkpID09IFNlcGFyYXRvcikgewot ICAgICAgICAgICAgVEJyQ3RsU2VsZWN0T3B0aW9uRGF0YSBkYXRhKF9MKCItLS0tLS0tLS0tIiks IGZhbHNlLCBmYWxzZSwgZmFsc2UpOwotICAgICAgICAgICAgb3B0aW9ucy0+QXBwZW5kTChkYXRh KTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIEhCdWZDMTYqIGl0ZW1TdHIgPSBIQnVm QzE2OjpOZXdMKGl0ZW1UZXh0KGkpLmxlbmd0aCgpKTsKLSAgICAgICAgICAgIGl0ZW1TdHItPkRl cygpLkNvcHkoKGNvbnN0IFRVaW50MTYqKWl0ZW1UZXh0KGkpLnV0ZjE2KCksIGl0ZW1UZXh0KGkp Lmxlbmd0aCgpKTsKLSAgICAgICAgICAgIENsZWFudXBTdGFjazo6UHVzaEwoaXRlbVN0cik7Ci0g ICAgICAgICAgICBUQnJDdGxTZWxlY3RPcHRpb25EYXRhIGRhdGEoKml0ZW1TdHIsIGkgPT0gY3Vy cmVudEluZGV4KCksIGZhbHNlLCBpdGVtSXNFbmFibGVkKGkpKTsKLSAgICAgICAgICAgIG9wdGlv bnMtPkFwcGVuZEwoZGF0YSk7Ci0gICAgICAgICAgICBpdGVtcy5BcHBlbmRMKGl0ZW1TdHIpOwot ICAgICAgICAgICAgQ2xlYW51cFN0YWNrOjpQb3AoKTsKLSAgICAgICAgfQotICAgIH0KLQotICAg IGRpYWxvZ3MtPkRpYWxvZ1NlbGVjdE9wdGlvbkwoS051bGxEZXNDKCksIChUQnJDdGxTZWxlY3RP cHRpb25UeXBlKShFU2VsZWN0VHlwZVNpbmdsZSB8IEVTZWxlY3RUeXBlV2l0aEZpbmRQYW5lKSwg Km9wdGlvbnMpOwotCi0gICAgQ2xlYW51cFN0YWNrOjpQb3BBbmREZXN0cm95KCZpdGVtcyk7Ci0K LSAgICBpbnQgbmV3SW5kZXg7Ci0gICAgZm9yIChuZXdJbmRleCA9IDA7IG5ld0luZGV4IDwgb3B0 aW9ucy0+Q291bnQoKSAmJiAhb3B0aW9ucy0+QXQobmV3SW5kZXgpLklzU2VsZWN0ZWQoKTsgbmV3 SW5kZXgrKykge30KLSAgICBpZiAobmV3SW5kZXggPT0gb3B0aW9ucy0+Q291bnQoKSkKLSAgICAg ICAgbmV3SW5kZXggPSBjdXJyZW50SW5kZXgoKTsKLSAgICAKLSAgICBtX3BvcHVwVmlzaWJsZSA9 IGZhbHNlOwotICAgIHBvcHVwRGlkSGlkZSgpOwotCi0gICAgaWYgKGN1cnJlbnRJbmRleCgpICE9 IG5ld0luZGV4ICYmIG5ld0luZGV4ID49IDApCi0gICAgICAgIHZhbHVlQ2hhbmdlZChuZXdJbmRl eCk7Ci0KLSAgICBkZWxldGUgb3B0aW9uczsKLX0KLSNlbmRpZgotCiB2b2lkIFF0RmFsbGJhY2tX ZWJQb3B1cDo6aGlkZSgpCiB7CiAgICAgLy8gRGVzdHJveWluZyB0aGUgUUNvbWJvQm94IGhlcmUg Y2F1c2UgcHJvYmxlbXMgaWYgdGhlIHBvcHVwIGlzIGluIHRoZQpJbmRleDogU291cmNlL1dlYktp dC9xdC9XZWJDb3JlU3VwcG9ydC9RdEZhbGxiYWNrV2ViUG9wdXAuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L1F0RmFsbGJhY2tXZWJQb3B1cC5oCShyZXZp c2lvbiA4NTE3OSkKKysrIFNvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvUXRGYWxsYmFj a1dlYlBvcHVwLmgJKHdvcmtpbmcgY29weSkKQEAgLTY5LDkgKzY5LDYgQEAgcHJpdmF0ZToKICAg ICBRV2ViUGFnZUNsaWVudCogcGFnZUNsaWVudCgpIGNvbnN0OwogCiAgICAgdm9pZCBwb3B1bGF0 ZShjb25zdCBRV2ViU2VsZWN0RGF0YSYpOwotI2lmIEVOQUJMRShTWU1CSUFOX0RJQUxPR19QUk9W SURFUlMpCi0gICAgdm9pZCBzaG93UzYwQnJvd3NlckRpYWxvZygpOwotI2VuZGlmCiB9OwogCiBj bGFzcyBRdEZhbGxiYWNrV2ViUG9wdXBDb21ibyA6IHB1YmxpYyBRQ29tYm9Cb3ggewo=