59676 2011-04-28 00:52:21 -0700 [GTK] PlatformWebView should be the view widget 2011-04-28 09:33:20 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned eric mrobinson xan.lopez oldest_to_newest 394296 0 cgarcia 2011-04-28 00:52:21 -0700 PlatformWebView is currently the page client, it should be the view widget. 394299 1 91449 cgarcia 2011-04-28 00:57:51 -0700 Created attachment 91449 Patch 394480 2 cgarcia 2011-04-28 09:32:55 -0700 Committed r85193: <http://trac.webkit.org/changeset/85193> 91449 2011-04-28 00:57:51 -0700 2011-04-28 09:33:20 -0700 Patch wk2-platform-webview.diff text/plain 6499 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0N2Q4NTBhLi5mMmYyZTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTEtMDQtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IFBsYXRmb3JtV2ViVmlldyBzaG91bGQgYmUgdGhlIHZpZXcgd2lkZ2V0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTY3NgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwOgorICAgICAgICAod2Via2l0V2Vi Vmlld0Jhc2VHZXRQYWdlKTogUmV0dXJuIHRoZSBwYWdlIG9mIHRoZSB2aWV3LgorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmg6CisgICAgICAgICogVUlQcm9j ZXNzL0NodW5rZWRVcGRhdGVEcmF3aW5nQXJlYVByb3h5Lmg6IE1hcCBQbGF0Zm9ybVdlYlZpZXcK KyAgICAgICAgdG8gV2ViS2l0V2ViVmlld0Jhc2UgaW5zdGVhZCBvZiB0aGUgcGFnZSBjbGllbnQu CisgICAgICAgICogVUlQcm9jZXNzL2d0ay9DaHVua2VkVXBkYXRlRHJhd2luZ0FyZWFQcm94eUd0 ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNodW5rZWRVcGRhdGVEcmF3aW5nQXJlYVByb3h5Ojpw YWdlKTogVXNlIHRoZSB2aWV3IHdpZGdldAorICAgICAgICBkaXJlY3RseS4KKyAgICAgICAgKFdl YktpdDo6Q2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJveHk6OmVuc3VyZUJhY2tpbmdTdG9yZSk6 IERpdHRvLgorICAgICAgICAoV2ViS2l0OjpDaHVua2VkVXBkYXRlRHJhd2luZ0FyZWFQcm94eTo6 ZHJhd1VwZGF0ZUNodW5rSW50b0JhY2tpbmdTdG9yZSk6IERpdHRvLgorICAgICAgICAqIFVJUHJv Y2Vzcy9ndGsvV2ViVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXc6OmNyZWF0ZURy YXdpbmdBcmVhUHJveHkpOiBQYXNzIHRoZSB2aWV3IHdpZGdldCB0bworICAgICAgICB0aGUgRHJh d2luZ0FyZWFQcm94eSBjb25zdHJ1Y3RvciBpbnN0ZWFkIG9mIHRoZSBwYWdlIGNsaWVudC4KKyAg ICAgICAgKiBVSVByb2Nlc3MvZ3RrL1dlYlZpZXcuaDogUmVtb3ZlIGdldFdlYlZpZXdXaW5kb3co KSB3aGljaCBpcyBubworICAgICAgICBsb25nZXIgbmVlZGVkLgorCiAyMDExLTA0LTI3ICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jl bi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YlZpZXdCYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YlZpZXdCYXNlLmNwcAppbmRleCA0NWRlMzA1Li43YmRiOTI2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBAIC0z NzUsMyArMzc1LDggQEAgR3RrSU1Db250ZXh0KiB3ZWJraXRXZWJWaWV3QmFzZUdldElNQ29udGV4 dChXZWJLaXRXZWJWaWV3QmFzZSogd2Via2l0V2ViVmlld0Jhc2UKIHsKICAgICByZXR1cm4gd2Vi a2l0V2ViVmlld0Jhc2UtPnByaXYtPmltQ29udGV4dDsKIH0KKworV2ViUGFnZVByb3h5KiB3ZWJr aXRXZWJWaWV3QmFzZUdldFBhZ2UoV2ViS2l0V2ViVmlld0Jhc2UqIHdlYmtpdFdlYlZpZXdCYXNl KQoreworICAgIHJldHVybiB3ZWJraXRXZWJWaWV3QmFzZS0+cHJpdi0+d2ViVmlld0luc3RhbmNl LT5wYWdlKCk7Cit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRXZWJWaWV3QmFzZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViVmlld0Jhc2UuaAppbmRleCBmNDQ4NzcyLi42ZmE4NWVhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmgKQEAg LTY1LDYgKzY1LDggQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVNldFdlYlZpZXdJbnN0YW5jZShX ZWJLaXRXZWJWaWV3QmFzZSosIFdlYlZpZXcqKTsKIAogR3RrSU1Db250ZXh0KiB3ZWJraXRXZWJW aWV3QmFzZUdldElNQ29udGV4dChXZWJLaXRXZWJWaWV3QmFzZSopOwogCitXZWJQYWdlUHJveHkq IHdlYmtpdFdlYlZpZXdCYXNlR2V0UGFnZShXZWJLaXRXZWJWaWV3QmFzZSopOworCiBHX0VORF9E RUNMUwogCiAjZW5kaWYgLy8gV2ViS2l0V2ViVmlld0Jhc2VfaApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0NodW5rZWRVcGRhdGVEcmF3aW5nQXJlYVByb3h5LmggYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJveHkuaAppbmRl eCA5NGU0NDFmLi44MjlkYWMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv Q2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJveHkuaApAQCAtNDEsNiArNDEsNyBAQCBP QkpDX0NMQVNTIFdLVmlldzsKIGNsYXNzIFFHcmFwaGljc1dLVmlldzsKICNlbGlmIFBMQVRGT1JN KEdUSykKIHR5cGVkZWYgc3RydWN0IF9jYWlyb19zdXJmYWNlIGNhaXJvX3N1cmZhY2VfdDsKK3R5 cGVkZWYgc3RydWN0IF9XZWJLaXRXZWJWaWV3QmFzZSBXZWJLaXRXZWJWaWV3QmFzZTsKICNlbmRp ZgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKQEAgLTU2LDggKzU3LDcgQEAgdHlwZWRlZiBXZWJWaWV3 IFBsYXRmb3JtV2ViVmlldzsKICNlbGlmIFBMQVRGT1JNKFFUKQogdHlwZWRlZiBRR3JhcGhpY3NX S1ZpZXcgUGxhdGZvcm1XZWJWaWV3OwogI2VsaWYgUExBVEZPUk0oR1RLKQotY2xhc3MgV2ViVmll dzsKLXR5cGVkZWYgV2ViVmlldyBQbGF0Zm9ybVdlYlZpZXc7Cit0eXBlZGVmIFdlYktpdFdlYlZp ZXdCYXNlIFBsYXRmb3JtV2ViVmlldzsKICNlbmRpZgogCiBjbGFzcyBDaHVua2VkVXBkYXRlRHJh d2luZ0FyZWFQcm94eSA6IHB1YmxpYyBEcmF3aW5nQXJlYVByb3h5IHsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJveHlH dGsuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9DaHVua2VkVXBkYXRlRHJhd2lu Z0FyZWFQcm94eUd0ay5jcHAKaW5kZXggODlhOWVmNy4uMTRhYzkxMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9DaHVua2VkVXBkYXRlRHJhd2luZ0FyZWFQcm94eUd0 ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9DaHVua2VkVXBkYXRlRHJh d2luZ0FyZWFQcm94eUd0ay5jcHAKQEAgLTMwLDYgKzMwLDcgQEAKIAogI2luY2x1ZGUgIlJlZlB0 ckNhaXJvLmgiCiAjaW5jbHVkZSAiVXBkYXRlQ2h1bmsuaCIKKyNpbmNsdWRlICJXZWJLaXRXZWJW aWV3QmFzZS5oIgogI2luY2x1ZGUgIldlYlByb2Nlc3NQcm94eS5oIgogI2luY2x1ZGUgIldlYlZp ZXcuaCIKICNpbmNsdWRlIDxXZWJDb3JlL0d0a1ZlcnNpb25pbmcuaD4KQEAgLTQxLDcgKzQyLDcg QEAgbmFtZXNwYWNlIFdlYktpdCB7CiAKIFdlYlBhZ2VQcm94eSogQ2h1bmtlZFVwZGF0ZURyYXdp bmdBcmVhUHJveHk6OnBhZ2UoKQogewotICAgIHJldHVybiBtX3dlYlZpZXctPnBhZ2UoKTsKKyAg ICByZXR1cm4gd2Via2l0V2ViVmlld0Jhc2VHZXRQYWdlKG1fd2ViVmlldyk7CiB9CiAKIHZvaWQg Q2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJveHk6OmVuc3VyZUJhY2tpbmdTdG9yZSgpCkBAIC00 OSw3ICs1MCw3IEBAIHZvaWQgQ2h1bmtlZFVwZGF0ZURyYXdpbmdBcmVhUHJveHk6OmVuc3VyZUJh Y2tpbmdTdG9yZSgpCiAgICAgaWYgKG1fYmFja2luZ1N0b3JlSW1hZ2UpCiAgICAgICAgIHJldHVy bjsKIAotICAgIG1fYmFja2luZ1N0b3JlSW1hZ2UgPSBnZGtfd2luZG93X2NyZWF0ZV9zaW1pbGFy X3N1cmZhY2UoZ3RrX3dpZGdldF9nZXRfd2luZG93KG1fd2ViVmlldy0+d2luZG93KCkpLAorICAg IG1fYmFja2luZ1N0b3JlSW1hZ2UgPSBnZGtfd2luZG93X2NyZWF0ZV9zaW1pbGFyX3N1cmZhY2Uo Z3RrX3dpZGdldF9nZXRfd2luZG93KEdUS19XSURHRVQobV93ZWJWaWV3KSksCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBDQUlST19D T05URU5UX0NPTE9SX0FMUEhBLCBzaXplKCkud2lkdGgoKSwgc2l6ZSgpLmhlaWdodCgpKTsKIH0K IApAQCAtODcsNyArODgsNyBAQCB2b2lkIENodW5rZWRVcGRhdGVEcmF3aW5nQXJlYVByb3h5Ojpk cmF3VXBkYXRlQ2h1bmtJbnRvQmFja2luZ1N0b3JlKFVwZGF0ZUNodW5rKgogICAgIGNhaXJvX3Nl dF9zb3VyY2Vfc3VyZmFjZShjci5nZXQoKSwgcGl4bWFwLmdldCgpLCB1cGRhdGVDaHVua1JlY3Qu eCgpLCB1cGRhdGVDaHVua1JlY3QueSgpKTsKICAgICBjYWlyb19wYWludChjci5nZXQoKSk7CiAK LSAgICBndGtfd2lkZ2V0X3F1ZXVlX2RyYXdfYXJlYShtX3dlYlZpZXctPndpbmRvdygpLCB1cGRh dGVDaHVua1JlY3QueCgpLCB1cGRhdGVDaHVua1JlY3QueSgpLAorICAgIGd0a193aWRnZXRfcXVl dWVfZHJhd19hcmVhKEdUS19XSURHRVQobV93ZWJWaWV3KSwgdXBkYXRlQ2h1bmtSZWN0LngoKSwg dXBkYXRlQ2h1bmtSZWN0LnkoKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1cGRh dGVDaHVua1JlY3Qud2lkdGgoKSwgdXBkYXRlQ2h1bmtSZWN0LmhlaWdodCgpKTsKIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJWaWV3LmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViVmlldy5jcHAKaW5kZXggNzQ5OGI1MS4uODI0YTEx OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJWaWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlZpZXcuY3BwCkBAIC0yNjcsMTEg KzI2Nyw2IEBAIFdlYlZpZXc6On5XZWJWaWV3KCkKIHsKIH0KIAotR2RrV2luZG93KiBXZWJWaWV3 OjpnZXRXZWJWaWV3V2luZG93KCkKLXsKLSAgICByZXR1cm4gZ3RrX3dpZGdldF9nZXRfd2luZG93 KG1fdmlld1dpZGdldCk7Ci19Ci0KIHZvaWQgV2ViVmlldzo6cGFpbnQoR3RrV2lkZ2V0KiB3aWRn ZXQsIEdka1JlY3RhbmdsZSByZWN0LCBjYWlyb190KiBjcikKIHsKICAgICBtX3BhZ2UtPmRyYXdp bmdBcmVhKCktPnBhaW50KEludFJlY3QocmVjdCksIGNyKTsKQEAgLTM1Niw3ICszNTEsNyBAQCB2 b2lkIFdlYlZpZXc6OmNsb3NlKCkKIC8vIFBhZ2VDbGllbnQncyBwdXJlIHZpcnR1YWwgZnVuY3Rp b25zCiBQYXNzT3duUHRyPERyYXdpbmdBcmVhUHJveHk+IFdlYlZpZXc6OmNyZWF0ZURyYXdpbmdB cmVhUHJveHkoKQogewotICAgIHJldHVybiBDaHVua2VkVXBkYXRlRHJhd2luZ0FyZWFQcm94eTo6 Y3JlYXRlKHRoaXMsIG1fcGFnZS5nZXQoKSk7CisgICAgcmV0dXJuIENodW5rZWRVcGRhdGVEcmF3 aW5nQXJlYVByb3h5OjpjcmVhdGUoV0VCS0lUX1dFQl9WSUVXX0JBU0UobV92aWV3V2lkZ2V0KSwg bV9wYWdlLmdldCgpKTsKIH0KIAogdm9pZCBXZWJWaWV3OjpzZXRWaWV3TmVlZHNEaXNwbGF5KGNv bnN0IFdlYkNvcmU6OkludFJlY3QmKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2d0ay9XZWJWaWV3LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlZpZXcu aAppbmRleCA2Y2VmMTRjLi42Njg3ZDkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvZ3RrL1dlYlZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dl YlZpZXcuaApAQCAtMzIsOCArMzIsNiBAQAogI2luY2x1ZGUgIldlYlBhZ2VQcm94eS5oIgogI2lu Y2x1ZGUgIldpbmRvd3NLZXlib2FyZENvZGVzLmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9JbnRTaXpl Lmg+Ci0jaW5jbHVkZSA8Z2RrL2dkay5oPgotI2luY2x1ZGUgPGdsaWIuaD4KICNpbmNsdWRlIDxn dGsvZ3RrLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVm Q291bnRlZC5oPgpAQCAtNzAsOCArNjgsNiBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIFdlYlZp ZXcoV2ViQ29udGV4dCosIFdlYlBhZ2VHcm91cCopOwogCi0gICAgR2RrV2luZG93KiBnZXRXZWJW aWV3V2luZG93KCk7Ci0KICAgICBib29sIGlzQWN0aXZlKCk7CiAgICAgdm9pZCBjbG9zZSgpOwog Cg==