59666 2011-04-27 18:24:16 -0700 Enable strict OwnPtrs for Chromium 2011-04-28 00:10:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 59664 59428 1 abarth abarth dglazkov jamesr levin webkit.review.bot oldest_to_newest 394052 0 abarth 2011-04-27 18:24:16 -0700 Enable strict OwnPtrs for Chromium 394053 1 91397 abarth 2011-04-27 18:24:31 -0700 Created attachment 91397 Patch 394055 2 abarth 2011-04-27 18:25:03 -0700 Should build cleanly on Mac, but jamesr says it doesn't build cleanly on Linux. 394057 3 91397 levin 2011-04-27 18:26:19 -0700 Comment on attachment 91397 Patch Pending clean build of course. 394059 4 jamesr 2011-04-27 18:27:06 -0700 https://bugs.webkit.org/show_bug.cgi?id=59664 is needed for chromium linux. I haven't tried chromium win, but I'm sure there are issues there as well. 394089 5 webkit.review.bot 2011-04-27 18:48:05 -0700 Attachment 91397 did not build on chromium: Build output: http://queues.webkit.org/results/8518180 394096 6 abarth 2011-04-27 18:55:22 -0700 I don't have a chromium-win build. I'll probably land this late at night and fire-fight the bot, unless someone would like to volunteer to weed out these issues on windows. 394121 7 levin 2011-04-27 19:28:13 -0700 Figuring out how to do a try job with both depots was harder than I thought it would be but here you go: http://build.chromium.org/p/tryserver.chromium/builders/win/builds/28759 http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/23951 http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/24454 394124 8 jamesr 2011-04-27 19:39:26 -0700 Tryjobs all failed to apply the patch. Try specifying -r to git/gcl try. 394129 9 levin 2011-04-27 19:47:23 -0700 (In reply to comment #8) > Tryjobs all failed to apply the patch. Try specifying -r to git/gcl try. I'm not sure if that would help because I think that specifies chromium's revision and the problem is webkit's revision (maybe if I ran it from the subdir and then I wouldn't have to update DEPS?) Anyway, I modified the patch so that it won't conflict with the other patch that is on the webkit side (http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/23959/steps/update/logs/patch) and I think this will work now: http://build.chromium.org/p/tryserver.chromium/builders/win/builds/28765 http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/23959 http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/24460 394235 10 abarth 2011-04-27 23:04:28 -0700 Those try results don't really make sense. It's reporting errors in functions that have #define LOOSE_OWN_PTR at the top. 394243 11 levin 2011-04-27 23:15:41 -0700 (In reply to comment #10) > Those try results don't really make sense. It's reporting errors in functions that have #define LOOSE_OWN_PTR at the top. oh that has to do with how I finally got the patch to apply: http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/23959/steps/update/logs/patch The reason I had to do this was a bit involved. (I was patching before your first change to OwnPtr.h but rolling to after it -- I didn't think of this issue or I could have handled it differently.) 394255 12 abarth 2011-04-27 23:21:20 -0700 In any case, the windows results are helpful. :) 394260 13 abarth 2011-04-27 23:31:34 -0700 Ok. I've fixed the error that the Windows try bot uncovered. The Mac trybot also uncovered an error that I don't see in my upstream Chromium build. Perhaps the feature is only enabled downstream? In any case, I fixed it as well. I'm going to try landing this patch with my fingers crossed. I expect disaster. 394262 14 91397 abarth 2011-04-27 23:35:48 -0700 Comment on attachment 91397 Patch Clearing flags on attachment: 91397 Committed r85167: <http://trac.webkit.org/changeset/85167> 394263 15 abarth 2011-04-27 23:35:52 -0700 All reviewed patches have been landed. Closing bug. 394275 16 abarth 2011-04-28 00:10:08 -0700 Looks like it built cleanly on chromium-win. Thanks Mr. Levin! 91397 2011-04-27 18:24:31 -0700 2011-04-27 23:35:48 -0700 Patch bug-59666-20110427182430.patch text/plain 971 abarth SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODUxMzMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDQtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgc3RyaWN0IE93blB0 cnMgZm9yIENocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01OTY2NgorCisgICAgICAgICogd3RmL093blB0ci5oOgorCiAyMDExLTA0LTI3ICBP bGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2Vv ZmZyZXkgR2FyZW4uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL093blB0ci5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvT3duUHRyLmgJKHJldmlzaW9u IDg1MTEyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Pd25QdHIuaAkod29ya2luZyBj b3B5KQpAQCAtMjksNyArMjksNyBAQAogI2luY2x1ZGUgPG1lbW9yeT4KIAogLy8gUmVtb3ZlIHRo aXMgb25jZSB3ZSBtYWtlIGFsbCBXZWJLaXQgY29kZSBjb21wYXRpYmxlIHdpdGggc3RyaWN0ZXIg cnVsZXMgYWJvdXQgT3duUHRyLgotI2lmICFQTEFURk9STShNQUMpCisjaWYgIVBMQVRGT1JNKE1B QykgJiYgIVBMQVRGT1JNKENIUk9NSVVNKQogI2RlZmluZSBMT09TRV9PV05fUFRSCiAjZW5kaWYK IAo=