59665 2011-04-27 18:23:36 -0700 check-webkit-style should flags spacing errors for braces on the same line. 2019-05-18 12:06:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 levin levin ap ashgeeky1 eric hamaji mohitsharma83996 oldest_to_newest 394050 0 levin 2011-04-27 18:23:36 -0700 check-webkit-style should flags spacing errors for braces on the same line. 394054 1 91398 levin 2011-04-27 18:24:50 -0700 Created attachment 91398 Patch 394092 2 91398 levin 2011-04-27 18:52:16 -0700 Comment on attachment 91398 Patch Actually I'll just land this by hand. 394095 3 levin 2011-04-27 18:55:14 -0700 Committed as http://trac.webkit.org/changeset/85138 91398 2011-04-27 18:24:50 -0700 2011-04-27 18:52:16 -0700 Patch bug-59665-20110427182449.patch text/plain 3767 levin U3VidmVyc2lvbiBSZXZpc2lvbjogODUxMzIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmNmY4NmY5NWY0YTNjNzRmNGYyOTQwMTI4ZWFiMWQ0MmU1 OWFjZjkzLi5iNjBiZjBiY2Y2MTJjY2UyYTc4MDU1NmJmZGY1MmJhYTAzNjA2NjczIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDQtMjcgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1z dHlsZSBzaG91bGQgZmxhZ3Mgc3BhY2luZyBlcnJvcnMgZm9yIGJyYWNlcyBvbiB0aGUgc2FtZSBs aW5lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk2 NjUKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OiBB ZGRlZCB0aGUgY2hlY2suCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHBfdW5pdHRlc3QucHk6IEFkZGVkIHNvbWUgdGVzdHMgZm9yIHRoZSBjaGVjaworICAgICAg ICAgIGFuZCBmaXhlZCBzb21lIHRlc3QgY2FzZXMgdG8gbm90IHRyaWdnZXIgdGhpcyBlcnJvciBz aW5jZSBpdCBpc24ndCB3aGF0IHRoZXkgYXJlIHZlcmlmeWluZy4KKwogMjAxMS0wNC0yNyAgT2ph biBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHJlbW92ZSBhc3NlcnRpb24g bm93IHRoYXQgcGxhdGZvcm0vbWFjLXRpZ2VyIG5vIGxvbmdlciBleGlzdHMKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggMGEwZGI1NDBkY2E1Zjc4 N2Q5ODk0ZjhiMDgwMTgzMzEzODVmODQ5Ny4uMDUyNDA3Zjg5ODYzNGZlN2E3NjFmMTZkZTk3NDE0 MWQwYzQyZWIxOCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHAucHkKQEAgLTE4NzgsNiArMTg3OCwxMiBAQCBkZWYgY2hlY2tfc3BhY2luZyhmaWxlX2V4dGVu c2lvbiwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcik6CiAgICAgICAgIGVycm9yKGxp bmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9icmFjZXMnLCA1LAogICAgICAgICAgICAgICAnRXh0cmEg c3BhY2UgYmVmb3JlIFsnKQogCisgICAgIyBUaGVyZSBzaG91bGQgYWx3YXlzIGJlIGEgc2luZ2xl IHNwYWNlIGluIGJldHdlZW4gYnJhY2VzIG9uIHRoZSBzYW1lIGxpbmUuCisgICAgaWYgc2VhcmNo KHInXHtcfScsIGxpbmUpOgorICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3doaXRlc3BhY2Uv YnJhY2VzJywgNSwgJ01pc3Npbmcgc3BhY2UgaW5zaWRlIHsgfS4nKQorICAgIGlmIHNlYXJjaChy J1x7XHNccytcfScsIGxpbmUpOgorICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3doaXRlc3Bh Y2UvYnJhY2VzJywgNSwgJ1RvbyBtYW55IHNwYWNlcyBpbnNpZGUgeyB9LicpCisKICAgICAjIFlv dSBzaG91bGRuJ3QgaGF2ZSBhIHNwYWNlIGJlZm9yZSBhIHNlbWljb2xvbiBhdCB0aGUgZW5kIG9m IHRoZSBsaW5lLgogICAgICMgVGhlcmUncyBhIHNwZWNpYWwgY2FzZSBmb3IgImZvciIgc2luY2Ug dGhlIHN0eWxlIGd1aWRlIGFsbG93cyBzcGFjZSBiZWZvcmUKICAgICAjIHRoZSBzZW1pY29sb24g dGhlcmUuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwX3VuaXR0ZXN0LnB5CmluZGV4IGE5OGQwZGQzNzkwYjk3OWIyMzU1ZTgzZGM1MzdiZTY4NTk3 OWRhNmQuLmViZDZkMzI0ZjMzZTE1ZjdkNjBjZjYzYjRjYTNiZDhkNTA1OGI2Y2YgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0 LnB5CkBAIC03ODksNyArNzg5LDcgQEAgY2xhc3MgQ3BwU3R5bGVUZXN0KENwcFN0eWxlVGVzdEJh c2UpOgogICAgICAgICAgICAgJ2ludCBhID0gaW50KCk7IC8vIENvbnN0cnVjdG9yLCBvLmsuJywK ICAgICAgICAgICAgICcnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KAotICAgICAgICAgICAg J1g6OlgoKSA6IGEoaW50KCkpIHt9IC8vIGRlZmF1bHQgQ29uc3RydWN0b3IsIG8uay4nLAorICAg ICAgICAgICAgJ1g6OlgoKSA6IGEoaW50KCkpIHsgfSAvLyBkZWZhdWx0IENvbnN0cnVjdG9yLCBv LmsuJywKICAgICAgICAgICAgICcnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KAogICAgICAg ICAgICAgJ29wZXJhdG9yIGJvb2woKTsgLy8gQ29udmVyc2lvbiBvcGVyYXRvciwgby5rLicsCkBA IC0xNjAxLDYgKzE2MDEsMTEgQEAgY2xhc3MgQ3BwU3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2Up OgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdmb3IgeycsICcnKQogICAgICAgICBzZWxmLmFz c2VydF9saW50KCdFWFBFQ1RfREVCVUdfREVBVEgoeycsICcnKQogCisgICAgZGVmIHRlc3Rfc3Bh Y2luZ19iZXR3ZWVuX2JyYWNlcyhzZWxmKToKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnICAg IHsgfScsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCcgICAge30nLCAnTWlzc2luZyBz cGFjZSBpbnNpZGUgeyB9LiAgW3doaXRlc3BhY2UvYnJhY2VzXSBbNV0nKQorICAgICAgICBzZWxm LmFzc2VydF9saW50KCcgICAgeyAgIH0nLCAnVG9vIG1hbnkgc3BhY2VzIGluc2lkZSB7IH0uICBb d2hpdGVzcGFjZS9icmFjZXNdIFs1XScpCisKICAgICBkZWYgdGVzdF9zcGFjaW5nX2Fyb3VuZF9l bHNlKHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd9ZWxzZSB7JywgJ01pc3Npbmcg c3BhY2UgYmVmb3JlIGVsc2UnCiAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgW3doaXRlc3Bh Y2UvYnJhY2VzXSBbNV0nKQpAQCAtMTc0OSw3ICsxNzU0LDcgQEAgY2xhc3MgQ3BwU3R5bGVUZXN0 KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdzdHJpbmcgRW1w dHlTdHJpbmcoKSB7IHJldHVybiAiIjsgfScsICcnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50 KCdzdHJpbmcgRW1wdHlTdHJpbmcgKCkgeyByZXR1cm4gIiI7IH0nLCAnJykKICAgICAgICAgc2Vs Zi5hc3NlcnRfbGludCgnc3RyaW5nIFZlcnlMb25nTmFtZUZ1bmN0aW9uU29tZXRpbWVzRW5kc1dp dGgoXG4nCi0gICAgICAgICAgICAgICAgICAgICAgICAgJyAgICBWZXJ5TG9uZ05hbWVUeXBlIHZl cnlMb25nTmFtZVZhcmlhYmxlKSB7fScsICcnKQorICAgICAgICAgICAgICAgICAgICAgICAgICcg ICAgVmVyeUxvbmdOYW1lVHlwZSB2ZXJ5TG9uZ05hbWVWYXJpYWJsZSkgeyB9JywgJycpCiAgICAg ICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3RlbXBsYXRlPD5cbicKICAgICAgICAgICAgICAgICAgICAg ICAgICAnc3RyaW5nIEZ1bmN0aW9uVGVtcGxhdGVTcGVjaWFsaXphdGlvbjxTb21lVHlwZT4oXG4n CiAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgIGludCB4KSB7IHJldHVybiAiIjsgfScs ICcnKQo=