59664 2011-04-27 18:22:13 -0700 Fix OwnPtr strict issues in chromium linux build 2011-04-27 18:42:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 59666 1 jamesr jamesr abarth eric kbr oldest_to_newest 394047 0 jamesr 2011-04-27 18:22:13 -0700 Fix OwnPtr strict issues in chromium linux build 394049 1 91395 jamesr 2011-04-27 18:22:42 -0700 Created attachment 91395 Patch 394060 2 91395 abarth 2011-04-27 18:27:37 -0700 Comment on attachment 91395 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91395&action=review > Source/WebKit/chromium/src/WebImageDecoder.cpp:115 > - OwnPtr<NativeImageSkia>image(frameBuffer->asNewNativeImage()); > + OwnPtr<NativeImageSkia> image(adoptPtr(frameBuffer->asNewNativeImage())); We usually prefer the = form of the constructor. 394082 3 jamesr 2011-04-27 18:42:31 -0700 Committed r85135: <http://trac.webkit.org/changeset/85135> 91395 2011-04-27 18:22:42 -0700 2011-04-27 18:27:37 -0700 Patch bug-59664-20110427182241.patch text/plain 5758 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogODUxMjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNTkxNzNlOTYwMzc2NDQ1 MTZlY2E5YzczZTYxMjY4N2JiODQwZjMwLi43ZTVmZjUxODlkZDk4MTEyZTUzNTVmNzhmYWRjNjkx M2Q5OGE0N2VhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMjcgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggT3duUHRyIHN0cmljdCBpc3N1ZXMgaW4gY2hy b21pdW0gbGludXggYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU5NjY0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9D b21wbGV4VGV4dENvbnRyb2xsZXJMaW51eC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wbGV4 VGV4dENvbnRyb2xsZXI6OmdldE5vcm1hbGl6ZWRUZXh0UnVuKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJ bWFnZUJ1ZmZlcjo6SW1hZ2VCdWZmZXIpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3Nr aWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybUNv bnRleHRTa2lhOjpQbGF0Zm9ybUNvbnRleHRTa2lhKToKKwogMjAxMS0wNC0yNyAgR2VvZmZyZXkg R2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWlu aWcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9Db21wbGV4VGV4dENvbnRyb2xsZXJMaW51eC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9Db21wbGV4VGV4dENvbnRyb2xsZXJMaW51eC5jcHAKaW5kZXgg MjJlYjhjY2YxYWNjOWQ0NGI1NzMwMzc2MWE4NWI2MTcwY2YzOWI0Yi4uYTJmZmI3NDcwMDRjZGZk YTI1NmIwZGZhNGIwN2VkN2RlZjMwYWVmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ29tcGxleFRleHRDb250cm9sbGVyTGludXguY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0NvbXBsZXhUZXh0 Q29udHJvbGxlckxpbnV4LmNwcApAQCAtMzk0LDcgKzM5NCw3IEBAIGNvbnN0IFRleHRSdW4mIENv bXBsZXhUZXh0Q29udHJvbGxlcjo6Z2V0Tm9ybWFsaXplZFRleHRSdW4oY29uc3QgVGV4dFJ1biYg b3JpZ2luCiAKICAgICBub3JtYWxpemVTcGFjZXNBbmRNaXJyb3JDaGFycyhzb3VyY2VUZXh0LCBv cmlnaW5hbFJ1bi5ydGwoKSwgbm9ybWFsaXplZEJ1ZmZlci5nZXQoKSwgbm9ybWFsaXplZEJ1ZmZl ckxlbmd0aCk7CiAKLSAgICBub3JtYWxpemVkUnVuLnNldChuZXcgVGV4dFJ1bihvcmlnaW5hbFJ1 bikpOworICAgIG5vcm1hbGl6ZWRSdW4gPSBhZG9wdFB0cihuZXcgVGV4dFJ1bihvcmlnaW5hbFJ1 bikpOwogICAgIG5vcm1hbGl6ZWRSdW4tPnNldFRleHQobm9ybWFsaXplZEJ1ZmZlci5nZXQoKSwg bm9ybWFsaXplZEJ1ZmZlckxlbmd0aCk7CiAgICAgcmV0dXJuICpub3JtYWxpemVkUnVuOwogfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1 ZmZlclNraWEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFn ZUJ1ZmZlclNraWEuY3BwCmluZGV4IGZhYjA0YzI3MTFiM2ZhMzc3Y2ZiZDIwNmI3NjhiNWJkMzA3 NTQyOTguLjY5YTkzNjY0NDMzM2Q5NGI4YjhmY2I3MzM4MmNmNTdiN2VjMGM5MDYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lh LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVm ZmVyU2tpYS5jcHAKQEAgLTc0LDcgKzc0LDcgQEAgSW1hZ2VCdWZmZXI6OkltYWdlQnVmZmVyKGNv bnN0IEludFNpemUmIHNpemUsIENvbG9yU3BhY2UsIFJlbmRlcmluZ01vZGUsIGJvb2wmIHMKIAog ICAgIG1fZGF0YS5tX2NhbnZhcyA9IGNhbnZhczsKICAgICBtX2RhdGEubV9wbGF0Zm9ybUNvbnRl eHQuc2V0Q2FudmFzKG1fZGF0YS5tX2NhbnZhcy5nZXQoKSk7Ci0gICAgbV9jb250ZXh0LnNldChu ZXcgR3JhcGhpY3NDb250ZXh0KCZtX2RhdGEubV9wbGF0Zm9ybUNvbnRleHQpKTsKKyAgICBtX2Nv bnRleHQgPSBhZG9wdFB0cihuZXcgR3JhcGhpY3NDb250ZXh0KCZtX2RhdGEubV9wbGF0Zm9ybUNv bnRleHQpKTsKICAgICBtX2NvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpLT5zZXREcmF3aW5nVG9J bWFnZUJ1ZmZlcih0cnVlKTsKIAogICAgIC8vIE1ha2UgdGhlIGJhY2tncm91bmQgdHJhbnNwYXJl bnQuIEl0IHdvdWxkIGJlIG5pY2UgaWYgdGhpcyB3YXNuJ3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEu Y3BwCmluZGV4IGZkNjIxMDkxMzFhNTRlMTUxNTdhYWRlODA2OGRiNjY0NzAyMjkyNTcuLjZiMDYw ZjlkZTg2MmMyOGM1NzNiZThkY2RiNzQwNTNkZTYwMDcwZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRT a2lhLmNwcApAQCAtMjE1LDkgKzIxNSw2IEBAIFBsYXRmb3JtQ29udGV4dFNraWE6OlBsYXRmb3Jt Q29udGV4dFNraWEoU2tDYW52YXMqIGNhbnZhcykKICAgICAsIG1fcHJpbnRpbmcoZmFsc2UpCiAg ICAgLCBtX2RyYXdpbmdUb0ltYWdlQnVmZmVyKGZhbHNlKQogICAgICwgbV9hY2NlbGVyYXRpb25N b2RlKE5vQWNjZWxlcmF0aW9uKQotI2lmIEVOQUJMRShBQ0NFTEVSQVRFRF8yRF9DQU5WQVMpCi0g ICAgLCBtX2dwdUNhbnZhcygwKQotI2VuZGlmCiAgICAgLCBtX2JhY2tpbmdTdG9yZVN0YXRlKE5v bmUpCiB7CiAgICAgbV9zdGF0ZVN0YWNrLmFwcGVuZChTdGF0ZSgpKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cKaW5kZXggZjY2YWY4MjAxZWZhNmJiZTY5Y2RkY2Q2Nzc3YTY2MDAyNjUxOTJmYi4u ZjliZDE3NGJlNjQ1MDRmOGJiMjM5NDEwNDgyNjk1Y2E5NmQyNjE0NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wNC0yNyAgSmFtZXMgUm9iaW5zb24g IDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCBPd25QdHIgc3RyaWN0IGlzc3VlcyBpbiBjaHJvbWl1bSBsaW51 eCBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTk2NjQKKworICAgICAgICAqIHNyYy9XZWJJbWFnZURlY29kZXIuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJJbWFnZURlY29kZXI6OmdldEZyYW1lQXRJbmRleCk6CisgICAgICAgICogc3JjL1dl YkltYWdlU2tpYS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkltYWdlOjpmcm9tRGF0YSk6CisK IDIwMTEtMDQtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkltYWdlRGVjb2Rlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJJbWFnZURlY29kZXIuY3BwCmluZGV4IDg3Y2Y4ZTNlZjg1YmFlZTY5ZmI0MzI1NWMyMGUzYTEx ZDFiYTNjNzIuLmNmOWJlODgwNDI4NjIzNzQ4MjlhMDdmZmU2ZDA0ZDE0ZjU0MGE3MmIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkltYWdlRGVjb2Rlci5jcHAKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW1hZ2VEZWNvZGVyLmNwcApAQCAtNDAs OSArNDAsMTEgQEAKIAogI2lmIFdFQktJVF9VU0lOR19TS0lBCiAjaW5jbHVkZSA8d3RmL093blB0 ci5oPgotI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CisjaW5jbHVkZSA8d3RmL1Bhc3NPd25Q dHIuaD4KICNlbmRpZgogCisjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KKwogdXNpbmcgbmFt ZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewpAQCAtMTEwLDcgKzExMiw3IEBA IFdlYkltYWdlIFdlYkltYWdlRGVjb2Rlcjo6Z2V0RnJhbWVBdEluZGV4KGludCBpbmRleCA9IDAp IGNvbnN0CiAgICAgaWYgKCFmcmFtZUJ1ZmZlcikKICAgICAgICAgcmV0dXJuIFdlYkltYWdlKCk7 CiAjaWYgV0VCS0lUX1VTSU5HX1NLSUEKLSAgICBPd25QdHI8TmF0aXZlSW1hZ2VTa2lhPmltYWdl KGZyYW1lQnVmZmVyLT5hc05ld05hdGl2ZUltYWdlKCkpOworICAgIE93blB0cjxOYXRpdmVJbWFn ZVNraWE+IGltYWdlKGFkb3B0UHRyKGZyYW1lQnVmZmVyLT5hc05ld05hdGl2ZUltYWdlKCkpKTsK ICAgICByZXR1cm4gV2ViSW1hZ2UoKmltYWdlKTsKICNlbGlmIFdFQktJVF9VU0lOR19DRwogICAg IC8vIEZJWE1FOiBJbXBsZW1lbnQgQ0cgc2lkZSBvZiB0aGlzLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW1hZ2VTa2lhLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkltYWdlU2tpYS5jcHAKaW5kZXggMDY4NGI1OGJlMWY2ZjQ3OWNiM2Y4Yzgw MzQzZmQ1YTRmNTlmMTUzYi4uMDI2YmNkZWVkNWNiYmM1ODJhNmFiZDU1NzVlNGE4MDVmNzJiN2Ni NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW1hZ2VTa2lhLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbWFnZVNraWEuY3BwCkBAIC00 MCw2ICs0MCw3IEBACiAjaW5jbHVkZSAiV2ViU2l6ZS5oIgogCiAjaW5jbHVkZSA8d3RmL093blB0 ci5oPgorI2luY2x1ZGUgPHd0Zi9QYXNzT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQ dHIuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CkBAIC03Niw4ICs3Nyw4IEBAIFdlYklt YWdlIFdlYkltYWdlOjpmcm9tRGF0YShjb25zdCBXZWJEYXRhJiBkYXRhLCBjb25zdCBXZWJTaXpl JiBkZXNpcmVkU2l6ZSkKICAgICAgICAgfQogICAgIH0KIAotICAgIE93blB0cjxOYXRpdmVJbWFn ZVNraWE+IGZyYW1lKHNvdXJjZS5jcmVhdGVGcmFtZUF0SW5kZXgoaW5kZXgpKTsKLSAgICBpZiAo IWZyYW1lLmdldCgpKQorICAgIE93blB0cjxOYXRpdmVJbWFnZVNraWE+IGZyYW1lID0gYWRvcHRQ dHIoc291cmNlLmNyZWF0ZUZyYW1lQXRJbmRleChpbmRleCkpOworICAgIGlmICghZnJhbWUpCiAg ICAgICAgIHJldHVybiBXZWJJbWFnZSgpOwogCiAgICAgcmV0dXJuIFdlYkltYWdlKCpmcmFtZSk7 Cg==