59663 2011-04-27 18:13:47 -0700 check-webkit-style error for spaces after periods in a comment has a bad error message and warns about end of line spaces. 2011-04-27 18:49:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 levin levin abarth eric hamaji oldest_to_newest 394044 0 levin 2011-04-27 18:13:47 -0700 check-webkit-style error for spaces after periods in a comment has a bad error message and warns about end of line spaces. 394045 1 91393 levin 2011-04-27 18:14:59 -0700 Created attachment 91393 Patch 394076 2 91393 abarth 2011-04-27 18:38:42 -0700 Comment on attachment 91393 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91393&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:1761 > - 'Should only a single space after a punctuation in a comment.') > + 'Should only have a single space after a punctuation in a comment.') Should only have => Should have only 394090 3 levin 2011-04-27 18:49:33 -0700 Committed as http://trac.webkit.org/changeset/85137. 91393 2011-04-27 18:14:59 -0700 2011-04-27 18:38:42 -0700 Patch bug-59663-20110427181458.patch text/plain 4723 levin U3VidmVyc2lvbiBSZXZpc2lvbjogODQ5MjQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNWIwOTc3MjE2ODU2NmE0NmMxNWM1OWM5ZjIzYzZlZDQw MjhiODE3Li5lYTdmY2FkMDI2MDEwZmZhOWE1OWM4NjI5Mjk3NGVlNzU2OWQzYzFhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDQtMjcgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1z dHlsZSBlcnJvciBmb3Igc3BhY2VzIGFmdGVyIHBlcmlvZHMgaW4gYSBjb21tZW50IGhhcyBhIGJh ZCBlcnJvcgorICAgICAgICBtZXNzYWdlIGFuZCB3YXJucyBhYm91dCBlbmQgb2YgbGluZSBzcGFj ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTY2 MworCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6IEZp eCBib3RoIGlzc3Vlcy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcF91bml0dGVzdC5weTogQWRkZWQgdGVzdHMgZm9yIHNwYWNlcyBhdCB0aGUgZW5kIG9mIGxp bmUKKyAgICAgICAgYW5kIGNoYW5nZWQgdGhlIGVycm9yIG1lc3NhZ2VzLgorCiAyMDExLTA0LTI2 ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIERSVC93aW4g bG9nIGxvYWRpbmcgZXJyb3JzIHRoZSBzYW1lIHdheSBEUlQvbWFjIGRvZXMKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggMGEwZGI1NDBkY2E1Zjc4 N2Q5ODk0ZjhiMDgwMTgzMzEzODVmODQ5Ny4uZDI1MTA2NDg0YTlkOGY2MDllOTE1MWM2NGFmNDJj MDkxNzZlYTlmMCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHAucHkKQEAgLTE3NTYsOSArMTc1Niw5IEBAIGRlZiBjaGVja19zcGFjaW5nKGZpbGVfZXh0ZW5z aW9uLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKToKICAgICAgICAgICAgICAgICAg ICAgICAgICAgJ1Nob3VsZCBoYXZlIGEgc3BhY2UgYmV0d2VlbiAvLyBhbmQgY29tbWVudCcpCiAK ICAgICAgICAgICAgICMgVGhlcmUgc2hvdWxkIG9ubHkgYmUgb25lIHNwYWNlIGFmdGVyIHB1bmN0 dWF0aW9uIGluIGEgY29tbWVudC4KLSAgICAgICAgICAgIGlmIHNlYXJjaCgnWy4hPyw7Ol1cc1xz JywgbGluZVtjb21tZW50X3Bvc2l0aW9uOl0pOgorICAgICAgICAgICAgaWYgc2VhcmNoKHInWy4h Pyw7Ol1cc1xzK1x3JywgbGluZVtjb21tZW50X3Bvc2l0aW9uOl0pOgogICAgICAgICAgICAgICAg IGVycm9yKGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9jb21tZW50cycsIDUsCi0gICAgICAgICAg ICAgICAgICAgICAgJ1Nob3VsZCBvbmx5IGEgc2luZ2xlIHNwYWNlIGFmdGVyIGEgcHVuY3R1YXRp b24gaW4gYSBjb21tZW50LicpCisgICAgICAgICAgICAgICAgICAgICAgJ1Nob3VsZCBvbmx5IGhh dmUgYSBzaW5nbGUgc3BhY2UgYWZ0ZXIgYSBwdW5jdHVhdGlvbiBpbiBhIGNvbW1lbnQuJykKIAog ICAgIGxpbmUgPSBjbGVhbl9saW5lcy5lbGlkZWRbbGluZV9udW1iZXJdICAjIGdldCByaWQgb2Yg Y29tbWVudHMgYW5kIHN0cmluZ3MKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQppbmRleCBhOThkMGRkMzc5MGI5NzliMjM1 NWU4M2RjNTM3YmU2ODU5NzlkYTZkLi5lNmJmNTYwNTM2YjJkYmQxYjBhNTIzMzRjYjFjMGRmZWIx ZmY2NzVlIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcF91bml0dGVzdC5weQpAQCAtMTgwOSwyMCArMTgwOSwyMiBAQCBjbGFzcyBDcHBTdHls ZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgZGVmIHRlc3Rfb25lX3NwYWNlc19hZnRlcl9w dW5jdHVhdGlvbl9pbl9jb21tZW50cyhzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgn aW50IGE7IC8vIFRoaXMgaXMgYSBzZW50ZW5jZS4nLAogICAgICAgICAgICAgICAgICAgICAgICAg ICcnKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCdpbnQgYTsgLy8gVGhpcyBpcyBhIHNlbnRl bmNlLiAgJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAnTGluZSBlbmRzIGluIHdoaXRlc3Bh Y2UuICBDb25zaWRlciBkZWxldGluZyB0aGVzZSBleHRyYSBzcGFjZXMuICBbd2hpdGVzcGFjZS9l bmRfb2ZfbGluZV0gWzRdJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnaW50IGE7IC8vIFRo aXMgaXMgYSBzZW50ZW5jZS4gVGhpcyBpcyBhIGFub3RoZXIgc2VudGVuY2UuJywKICAgICAgICAg ICAgICAgICAgICAgICAgICAnJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnaW50IGE7IC8v IFRoaXMgaXMgYSBzZW50ZW5jZS4gIFRoaXMgaXMgYSBhbm90aGVyIHNlbnRlbmNlLicsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgJ1Nob3VsZCBvbmx5IGEgc2luZ2xlIHNwYWNlIGFmdGVyIGEg cHVuY3R1YXRpb24gaW4gYSBjb21tZW50LiAgW3doaXRlc3BhY2UvY29tbWVudHNdIFs1XScpCisg ICAgICAgICAgICAgICAgICAgICAgICAgJ1Nob3VsZCBvbmx5IGhhdmUgYSBzaW5nbGUgc3BhY2Ug YWZ0ZXIgYSBwdW5jdHVhdGlvbiBpbiBhIGNvbW1lbnQuICBbd2hpdGVzcGFjZS9jb21tZW50c10g WzVdJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnaW50IGE7IC8vIFRoaXMgaXMgYSBzZW50 ZW5jZSEgIFRoaXMgaXMgYSBhbm90aGVyIHNlbnRlbmNlLicsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgJ1Nob3VsZCBvbmx5IGEgc2luZ2xlIHNwYWNlIGFmdGVyIGEgcHVuY3R1YXRpb24gaW4g YSBjb21tZW50LiAgW3doaXRlc3BhY2UvY29tbWVudHNdIFs1XScpCisgICAgICAgICAgICAgICAg ICAgICAgICAgJ1Nob3VsZCBvbmx5IGhhdmUgYSBzaW5nbGUgc3BhY2UgYWZ0ZXIgYSBwdW5jdHVh dGlvbiBpbiBhIGNvbW1lbnQuICBbd2hpdGVzcGFjZS9jb21tZW50c10gWzVdJykKICAgICAgICAg c2VsZi5hc3NlcnRfbGludCgnaW50IGE7IC8vIFdoeSBkaWQgSSB3cml0ZSB0aGlzPyAgVGhpcyBp cyBhIGFub3RoZXIgc2VudGVuY2UuJywKLSAgICAgICAgICAgICAgICAgICAgICAgICAnU2hvdWxk IG9ubHkgYSBzaW5nbGUgc3BhY2UgYWZ0ZXIgYSBwdW5jdHVhdGlvbiBpbiBhIGNvbW1lbnQuICBb d2hpdGVzcGFjZS9jb21tZW50c10gWzVdJykKKyAgICAgICAgICAgICAgICAgICAgICAgICAnU2hv dWxkIG9ubHkgaGF2ZSBhIHNpbmdsZSBzcGFjZSBhZnRlciBhIHB1bmN0dWF0aW9uIGluIGEgY29t bWVudC4gIFt3aGl0ZXNwYWNlL2NvbW1lbnRzXSBbNV0nKQogICAgICAgICBzZWxmLmFzc2VydF9s aW50KCdpbnQgYTsgLy8gRWxlbWVudGFyeSwgIG15IGRlYXIuJywKLSAgICAgICAgICAgICAgICAg ICAgICAgICAnU2hvdWxkIG9ubHkgYSBzaW5nbGUgc3BhY2UgYWZ0ZXIgYSBwdW5jdHVhdGlvbiBp biBhIGNvbW1lbnQuICBbd2hpdGVzcGFjZS9jb21tZW50c10gWzVdJykKKyAgICAgICAgICAgICAg ICAgICAgICAgICAnU2hvdWxkIG9ubHkgaGF2ZSBhIHNpbmdsZSBzcGFjZSBhZnRlciBhIHB1bmN0 dWF0aW9uIGluIGEgY29tbWVudC4gIFt3aGl0ZXNwYWNlL2NvbW1lbnRzXSBbNV0nKQogICAgICAg ICBzZWxmLmFzc2VydF9saW50KCdpbnQgYTsgLy8gVGhlIGZvbGxvd2luZyBzaG91bGQgYmUgY2xl YXI6ICBJcyBpdD8nLAotICAgICAgICAgICAgICAgICAgICAgICAgICdTaG91bGQgb25seSBhIHNp bmdsZSBzcGFjZSBhZnRlciBhIHB1bmN0dWF0aW9uIGluIGEgY29tbWVudC4gIFt3aGl0ZXNwYWNl L2NvbW1lbnRzXSBbNV0nKQorICAgICAgICAgICAgICAgICAgICAgICAgICdTaG91bGQgb25seSBo YXZlIGEgc2luZ2xlIHNwYWNlIGFmdGVyIGEgcHVuY3R1YXRpb24gaW4gYSBjb21tZW50LiAgW3do aXRlc3BhY2UvY29tbWVudHNdIFs1XScpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2ludCBh OyAvLyBMb29rIGF0IHRoZSBmb2xsb3cgc2VtaWNvbG9uOyAgSSBob3BlIHRoaXMgZ2l2ZXMgYW4g ZXJyb3IuJywKLSAgICAgICAgICAgICAgICAgICAgICAgICAnU2hvdWxkIG9ubHkgYSBzaW5nbGUg c3BhY2UgYWZ0ZXIgYSBwdW5jdHVhdGlvbiBpbiBhIGNvbW1lbnQuICBbd2hpdGVzcGFjZS9jb21t ZW50c10gWzVdJykKKyAgICAgICAgICAgICAgICAgICAgICAgICAnU2hvdWxkIG9ubHkgaGF2ZSBh IHNpbmdsZSBzcGFjZSBhZnRlciBhIHB1bmN0dWF0aW9uIGluIGEgY29tbWVudC4gIFt3aGl0ZXNw YWNlL2NvbW1lbnRzXSBbNV0nKQogCiAgICAgZGVmIHRlc3Rfc3BhY2VfYWZ0ZXJfY29tbWVudF9t YXJrZXIoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJy8vJywgJycpCg==