59650 2011-04-27 16:22:10 -0700 Every RenderLayer registers itself as a scrollableArea 2011-06-18 11:54:03 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser bdakin darin simon.fraser oldest_to_newest 393941 0 simon.fraser 2011-04-27 16:22:10 -0700 It seems wrong that every RenderLayer registers itself with Page's scrollableArea list, since 80% of RenderLayers are not created for scrolling. 398432 1 simon.fraser 2011-05-04 17:20:34 -0700 I need to fix this to fix another bug. 399080 2 92480 simon.fraser 2011-05-05 15:04:28 -0700 Created attachment 92480 Patch 399086 3 92480 bdakin 2011-05-05 15:06:08 -0700 Comment on attachment 92480 Patch Yay! 92480 2011-05-05 15:04:28 -0700 2011-05-05 15:06:07 -0700 Patch bug-59650-20110505150427.patch text/plain 4738 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogODU4NTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmZWIzMjMzNDQ0ZGQ1ZDM2 YTkxN2MwZGVhNWZmMWRlZjVhMTA2MzgxLi5kNGRhOGIxMDJkYmI3ZWJjMGViNDIyMzNmMTc4MTRi ZDc1NjczNTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDUtMDUgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXZlcnkgUmVuZGVyTGF5ZXIgcmVnaXN0ZXJzIGl0 c2VsZiBhcyBhIFNjcm9sbGFibGVBcmVhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01OTY1MAorCisgICAgICAgIFJhdGhlciB0aGFuIHJlZ2lzdGVyaW5n IGV2ZXJ5IFJlbmRlckxheWVyIGFzIGEgU2Nyb2xsYWJsZUFyZWEKKyAgICAgICAgb24gbGF5ZXIg Y3JlYXRpb24sIG9ubHkgcmVnaXN0ZXIgUmVuZGVyTGF5ZXJzIHdoaWNoIGFyZSBvdmVyZmxvdy0K KyAgICAgICAgc2Nyb2xsYWJsZS4gVXNlIHRoZSBtX3Njcm9sbGFibGVBcmVhUGFnZSBwb2ludGVy IHRvIGtlZXAgdHJhY2sKKyAgICAgICAgb2Ygd2hldGhlciB3ZSd2ZSByZWdpc3RlcmVkIHRvIGF2 b2lkIGV4Y2VzcyB3b3JrLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpSZW5kZXJMYXllcik6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJMYXllcjo6c2Nyb2xsc092ZXJmbG93KToKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckxheWVyOjpzdHlsZUNoYW5nZWQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJM YXllci5oOgorCiAyMDExLTA1LTA1ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCA4MjNhZDBkZmU0NjZkYjFjNjU2NGM2 MDI1YWZmOWI2NDU4ZTY5YWE5Li4yMmFkMWI1NWYyOTM2OTllM2FkYjFhNTVjYjFlY2U1MGM2ZWMz MjE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTE4Miw2 ICsxODIsNyBAQCBSZW5kZXJMYXllcjo6UmVuZGVyTGF5ZXIoUmVuZGVyQm94TW9kZWxPYmplY3Qq IHJlbmRlcmVyKQogICAgICwgbV9yZWZsZWN0aW9uKDApCiAgICAgLCBtX3Njcm9sbENvcm5lcigw KQogICAgICwgbV9yZXNpemVyKDApCisgICAgLCBtX3Njcm9sbGFibGVBcmVhUGFnZSgwKQogewog ICAgIFNjcm9sbGFibGVBcmVhOjpzZXRDb25zdHJhaW5zU2Nyb2xsaW5nVG9Db250ZW50RWRnZShm YWxzZSk7CiAKQEAgLTE4OSwxMyArMTkwLDYgQEAgUmVuZGVyTGF5ZXI6OlJlbmRlckxheWVyKFJl bmRlckJveE1vZGVsT2JqZWN0KiByZW5kZXJlcikKICAgICAgICAgbV92aXNpYmxlQ29udGVudFN0 YXR1c0RpcnR5ID0gZmFsc2U7CiAgICAgICAgIG1faGFzVmlzaWJsZUNvbnRlbnQgPSByZW5kZXJl ci0+c3R5bGUoKS0+dmlzaWJpbGl0eSgpID09IFZJU0lCTEU7CiAgICAgfQotCi0gICAgaWYgKEZy YW1lKiBmcmFtZSA9IHJlbmRlcmVyLT5mcmFtZSgpKSB7Ci0gICAgICAgIGlmIChQYWdlKiBwYWdl ID0gZnJhbWUtPnBhZ2UoKSkgewotICAgICAgICAgICAgbV9wYWdlID0gcGFnZTsKLSAgICAgICAg ICAgIG1fcGFnZS0+YWRkU2Nyb2xsYWJsZUFyZWEodGhpcyk7Ci0gICAgICAgIH0KLSAgICB9CiB9 CiAKIFJlbmRlckxheWVyOjp+UmVuZGVyTGF5ZXIoKQpAQCAtMjA1LDggKzE5OSw4IEBAIFJlbmRl ckxheWVyOjp+UmVuZGVyTGF5ZXIoKQogICAgICAgICAgICAgZnJhbWUtPmV2ZW50SGFuZGxlcigp LT5yZXNpemVMYXllckRlc3Ryb3llZCgpOwogICAgIH0KIAotICAgIGlmIChtX3BhZ2UpCi0gICAg ICAgIG1fcGFnZS0+cmVtb3ZlU2Nyb2xsYWJsZUFyZWEodGhpcyk7CisgICAgaWYgKG1fc2Nyb2xs YWJsZUFyZWFQYWdlKQorICAgICAgICBtX3Njcm9sbGFibGVBcmVhUGFnZS0+cmVtb3ZlU2Nyb2xs YWJsZUFyZWEodGhpcyk7CiAKICAgICBkZXN0cm95U2Nyb2xsYmFyKEhvcml6b250YWxTY3JvbGxi YXIpOwogICAgIGRlc3Ryb3lTY3JvbGxiYXIoVmVydGljYWxTY3JvbGxiYXIpOwpAQCAtMTkwMyw2 ICsxODk3LDE0IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OmRlc3Ryb3lTY3JvbGxiYXIoU2Nyb2xsYmFy T3JpZW50YXRpb24gb3JpZW50YXRpb24pCiAgICAgfQogfQogCitib29sIFJlbmRlckxheWVyOjpz Y3JvbGxzT3ZlcmZsb3coKSBjb25zdAoreworICAgIGlmICghcmVuZGVyZXIoKS0+aXNCb3goKSkK KyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIAorICAgIHJldHVybiB0b1JlbmRlckJveChyZW5k ZXJlcigpKS0+c2Nyb2xsc092ZXJmbG93KCk7Cit9CisKIHZvaWQgUmVuZGVyTGF5ZXI6OnNldEhh c0hvcml6b250YWxTY3JvbGxiYXIoYm9vbCBoYXNTY3JvbGxiYXIpCiB7CiAgICAgaWYgKGhhc1Nj cm9sbGJhciA9PSAobV9oQmFyICE9IDApKQpAQCAtMzk5MCw2ICszOTkyLDIwIEBAIHZvaWQgUmVu ZGVyTGF5ZXI6OnN0eWxlQ2hhbmdlZChTdHlsZURpZmZlcmVuY2UgZGlmZiwgY29uc3QgUmVuZGVy U3R5bGUqIG9sZFN0eWxlCiAgICAgICAgIHVwZGF0ZVJlZmxlY3Rpb25TdHlsZSgpOwogICAgIH0K ICAgICAKKyAgICBpZiAoc2Nyb2xsc092ZXJmbG93KCkpIHsKKyAgICAgICAgaWYgKCFtX3Njcm9s bGFibGVBcmVhUGFnZSkgeworICAgICAgICAgICAgaWYgKEZyYW1lKiBmcmFtZSA9IHJlbmRlcmVy KCktPmZyYW1lKCkpIHsKKyAgICAgICAgICAgICAgICBpZiAoUGFnZSogcGFnZSA9IGZyYW1lLT5w YWdlKCkpIHsKKyAgICAgICAgICAgICAgICAgICAgbV9zY3JvbGxhYmxlQXJlYVBhZ2UgPSBwYWdl OworICAgICAgICAgICAgICAgICAgICBtX3Njcm9sbGFibGVBcmVhUGFnZS0+YWRkU2Nyb2xsYWJs ZUFyZWEodGhpcyk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorICAgICAgICB9 CisgICAgfSBlbHNlIGlmIChtX3Njcm9sbGFibGVBcmVhUGFnZSkgeworICAgICAgICBtX3Njcm9s bGFibGVBcmVhUGFnZS0+cmVtb3ZlU2Nyb2xsYWJsZUFyZWEodGhpcyk7CisgICAgICAgIG1fc2Ny b2xsYWJsZUFyZWFQYWdlID0gMDsKKyAgICB9CisgICAgCiAgICAgLy8gRklYTUU6IE5lZWQgdG8g ZGV0ZWN0IGEgc3dhcCBmcm9tIGN1c3RvbSB0byBuYXRpdmUgc2Nyb2xsYmFycyAoYW5kIHZpY2Ug dmVyc2EpLgogICAgIGlmIChtX2hCYXIpCiAgICAgICAgIG1faEJhci0+c3R5bGVDaGFuZ2VkKCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCmluZGV4IDgwMmFjODczN2MzMDg1 Y2VkNzhhMGE5OThlZGMwNzg4NmQ4YWViZmMuLjExMDI5ZWRmNDkwZGIwN2YxMjNjNjMwZGFkYjI0 MjcyZTk3NDA4ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCkBAIC0y NDYsNiArMjQ2LDcgQEAgcHVibGljOgogCiAgICAgSW50UmVjdCBnZXRSZWN0VG9FeHBvc2UoY29u c3QgSW50UmVjdCYgdmlzaWJsZVJlY3QsIGNvbnN0IEludFJlY3QmIGV4cG9zZVJlY3QsIGNvbnN0 IFNjcm9sbEFsaWdubWVudCYgYWxpZ25YLCBjb25zdCBTY3JvbGxBbGlnbm1lbnQmIGFsaWduWSk7 CiAKKyAgICBib29sIHNjcm9sbHNPdmVyZmxvdygpIGNvbnN0OwogICAgIHZvaWQgc2V0SGFzSG9y aXpvbnRhbFNjcm9sbGJhcihib29sKTsKICAgICB2b2lkIHNldEhhc1ZlcnRpY2FsU2Nyb2xsYmFy KGJvb2wpOwogCkBAIC01NDIsNyArNTQzLDcgQEAgcHJpdmF0ZToKICAgICAvLyBSZWN0YW5nbGUg ZW5jb21wYXNzaW5nIHRoZSBzY3JvbGwgY29ybmVyIGFuZCByZXNpemVyIHJlY3QuCiAgICAgSW50 UmVjdCBzY3JvbGxDb3JuZXJBbmRSZXNpemVyUmVjdCgpIGNvbnN0OwogCi0gICAgdmlydHVhbCB2 b2lkIGRpc2Nvbm5lY3RGcm9tUGFnZSgpIHsgbV9wYWdlID0gMDsgfQorICAgIHZpcnR1YWwgdm9p ZCBkaXNjb25uZWN0RnJvbVBhZ2UoKSB7IG1fc2Nyb2xsYWJsZUFyZWFQYWdlID0gMDsgfQogCiAg ICAgLy8gTk9URTogVGhpcyBzaG91bGQgb25seSBiZSBjYWxsZWQgYnkgdGhlIG92ZXJyaWRlbiBz ZXRTY3JvbGxPZmZzZXQgZnJvbSBTY3JvbGxhYmxlQXJlYS4KICAgICB2b2lkIHNjcm9sbFRvKGlu dCB4LCBpbnQgeSk7CkBAIC03MjMsNyArNzI0LDcgQEAgcHJpdmF0ZToKICAgICBPd25QdHI8UmVu ZGVyTGF5ZXJCYWNraW5nPiBtX2JhY2tpbmc7CiAjZW5kaWYKIAotICAgIFBhZ2UqIG1fcGFnZTsK KyAgICBQYWdlKiBtX3Njcm9sbGFibGVBcmVhUGFnZTsgLy8gUGFnZSBvbiB3aGljaCB0aGlzIGlz IHJlZ2lzdGVyZWQgYXMgYSBzY3JvbGxhYmxlIGFyZWEuCiB9OwogCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCg==