59646 2011-04-27 16:00:16 -0700 Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld 2011-04-27 17:19:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren sam oldest_to_newest 393915 0 ggaren 2011-04-27 16:00:16 -0700 Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld 393924 1 91368 ggaren 2011-04-27 16:05:41 -0700 Created attachment 91368 Patch 393931 2 91368 sam 2011-04-27 16:14:11 -0700 Comment on attachment 91368 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91368&action=review > Source/WebCore/bindings/js/JSDOMBinding.h:-221 > - HashMap<CSSValue*, void*>& cssValueRoots(); Can we remove the forward declaration of CSSValue here now? 393946 3 ggaren 2011-04-27 16:25:18 -0700 > Can we remove the forward declaration of CSSValue here now? As you wish! 394025 4 ggaren 2011-04-27 17:19:54 -0700 Committed r85127: <http://trac.webkit.org/changeset/85127> 91368 2011-04-27 16:05:41 -0700 2011-04-27 16:14:10 -0700 Patch bug-59646-20110427160540.patch text/plain 4659 ggaren SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1MTE1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDQtMjcgIEdlb2ZmcmV5 IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXhlZCBhIHNtYWxsIGxlYWsgcmVsYXRlZCB0byBDU1NWYWx1 ZXMgd2hlbiBkZWFsbG9jYXRpbmcgYSBET01XcmFwcGVyV29ybGQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5NjQ2CisKKyAgICAgICAgTWFkZSB0aGUg Y3NzVmFsdWVSb290cyBtYXAgcGVyLXdvcmxkLCBpbnN0ZWFkIG9mIGEgZ2xvYmFsLiBXaGVuIHdl IGRlYWxsb2NhdGUKKyAgICAgICAgYSB3b3JsZCwgd2UgbmVlZCB0byBjbGVhciBhbGwgZW50cmll cyBpbiB0aGUgbWFwIGZvciB0aGF0IHdvcmxkLCBzaW5jZQorICAgICAgICB0aGUgZmluYWxpemVy cyB0aGF0IHdvdWxkIG90aGVyd2lzZSBjbGVhciB0aG9zZSBlbnRyaWVzIGRvbid0IHJ1bi4gVGhl CisgICAgICAgIHNpbXBsZXN0IHdheSB0byBkbyB0aGlzIGlzIGp1c3QgdG8gbWFrZSB0aGUgd29y bGQgb3duIHRoZSBtYXAuCisgICAgICAgIAorICAgICAgICAqIGJpbmRpbmdzL2pzL0RPTVdyYXBw ZXJXb3JsZC5oOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQ1NTU3R5bGVEZWNsYXJhdGlvbkN1 c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0NTU1N0eWxlRGVjbGFyYXRpb246OmdldFBy b3BlcnR5Q1NTVmFsdWUpOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQ1NTVmFsdWVDdXN0b20u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNDU1NWYWx1ZU93bmVyOjppc1JlYWNoYWJsZUZyb21P cGFxdWVSb290cyk6CisgICAgICAgIChXZWJDb3JlOjpKU0NTU1ZhbHVlT3duZXI6OmZpbmFsaXpl KToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaDoKKwogMjAxMS0wNC0yNyAg TWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeC4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0RPTVdyYXBwZXJXb3JsZC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0RPTVdyYXBwZXJXb3JsZC5oCShyZXZpc2lv biA4NDkzNCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0RPTVdyYXBwZXJXb3JsZC5o CSh3b3JraW5nIGNvcHkpCkBAIC0yOSw2ICsyOSw3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAorY2xhc3MgQ1NTVmFsdWU7CiBjbGFzcyBKU0RPTVdyYXBwZXI7CiBjbGFzcyBTY3JpcHRDb250 cm9sbGVyOwogCkBAIC04MCw2ICs4MSw3IEBAIHB1YmxpYzoKICAgICAvLyBGSVhNRTogY2FuIHdl IG1ha2UgdGhpcyBwcml2YXRlPwogICAgIERPTU9iamVjdFdyYXBwZXJNYXAgbV93cmFwcGVyczsK ICAgICBKU1N0cmluZ0NhY2hlIG1fc3RyaW5nQ2FjaGU7CisgICAgSGFzaE1hcDxDU1NWYWx1ZSos IHZvaWQqPiBtX2Nzc1ZhbHVlUm9vdHM7CiAKICAgICBib29sIGlzTm9ybWFsKCkgY29uc3QgeyBy ZXR1cm4gbV9pc05vcm1hbDsgfQogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U0NTU1N0eWxlRGVjbGFyYXRpb25DdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTQ1NTU3R5bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHAJKHJldmlzaW9u IDg0OTMzKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDU1NTdHlsZURlY2xhcmF0 aW9uQ3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTkxLDcgKzE5MSw3IEBAIEpTVmFsdWUg SlNDU1NTdHlsZURlY2xhcmF0aW9uOjpnZXRQcm9wZXIKICAgICBpZiAoIWNzc1ZhbHVlKQogICAg ICAgICByZXR1cm4ganNOdWxsKCk7CiAKLSAgICBjc3NWYWx1ZVJvb3RzKCkuYWRkKGNzc1ZhbHVl LmdldCgpLCByb290KGltcGwoKSkpOyAvLyBCYWxhbmNlZCBieSBKU0NTU1ZhbHVlT3duZXI6OmZp bmFsaXplKCkuCisgICAgY3VycmVudFdvcmxkKGV4ZWMpLT5tX2Nzc1ZhbHVlUm9vdHMuYWRkKGNz c1ZhbHVlLmdldCgpLCByb290KGltcGwoKSkpOyAvLyBCYWxhbmNlZCBieSBKU0NTU1ZhbHVlT3du ZXI6OmZpbmFsaXplKCkuCiAgICAgcmV0dXJuIHRvSlMoZXhlYywgZ2xvYmFsT2JqZWN0KCksIFdU Rjo6Z2V0UHRyKGNzc1ZhbHVlKSk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTQ1NTVmFsdWVDdXN0b20uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTQ1NTVmFsdWVDdXN0b20uY3BwCShyZXZpc2lvbiA4NDkzMykKKysrIFNvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ1NTVmFsdWVDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00NSwxOSArNDUsMTMgQEAgdXNpbmcgbmFtZXNwYWNlIEpTQzsKIAogbmFtZXNwYWNlIFdl YkNvcmUgewogCi1IYXNoTWFwPENTU1ZhbHVlKiwgdm9pZCo+JiBjc3NWYWx1ZVJvb3RzKCkKLXsK LSAgICB0eXBlZGVmIEhhc2hNYXA8Q1NTVmFsdWUqLCB2b2lkKj4gTWFwVHlwZTsKLSAgICBERUZJ TkVfU1RBVElDX0xPQ0FMKE1hcFR5cGUsIGNzc1ZhbHVlUm9vdHMsICgpKTsKLSAgICByZXR1cm4g Y3NzVmFsdWVSb290czsKLX0KLQotYm9vbCBKU0NTU1ZhbHVlT3duZXI6OmlzUmVhY2hhYmxlRnJv bU9wYXF1ZVJvb3RzKEpTQzo6SGFuZGxlPEpTQzo6VW5rbm93bj4gaGFuZGxlLCB2b2lkKiwgTWFy a1N0YWNrJiBtYXJrU3RhY2spCitib29sIEpTQ1NTVmFsdWVPd25lcjo6aXNSZWFjaGFibGVGcm9t T3BhcXVlUm9vdHMoSlNDOjpIYW5kbGU8SlNDOjpVbmtub3duPiBoYW5kbGUsIHZvaWQqIGNvbnRl eHQsIE1hcmtTdGFjayYgbWFya1N0YWNrKQogewogICAgIEpTQ1NTVmFsdWUqIGpzQ1NTVmFsdWUg PSBzdGF0aWNfY2FzdDxKU0NTU1ZhbHVlKj4oaGFuZGxlLmdldCgpLmFzQ2VsbCgpKTsKICAgICBp ZiAoIWpzQ1NTVmFsdWUtPmhhc0N1c3RvbVByb3BlcnRpZXMoKSkKICAgICAgICAgcmV0dXJuIGZh bHNlOwotICAgIHZvaWQqIHJvb3QgPSBjc3NWYWx1ZVJvb3RzKCkuZ2V0KGpzQ1NTVmFsdWUtPmlt cGwoKSk7CisgICAgRE9NV3JhcHBlcldvcmxkKiB3b3JsZCA9IHN0YXRpY19jYXN0PERPTVdyYXBw ZXJXb3JsZCo+KGNvbnRleHQpOworICAgIHZvaWQqIHJvb3QgPSB3b3JsZC0+bV9jc3NWYWx1ZVJv b3RzLmdldChqc0NTU1ZhbHVlLT5pbXBsKCkpOwogICAgIGlmICghcm9vdCkKICAgICAgICAgcmV0 dXJuIGZhbHNlOwogICAgIHJldHVybiBtYXJrU3RhY2suY29udGFpbnNPcGFxdWVSb290KHJvb3Qp OwpAQCAtNjcsOCArNjEsOCBAQCB2b2lkIEpTQ1NTVmFsdWVPd25lcjo6ZmluYWxpemUoSlNDOjpI YW5kCiB7CiAgICAgSlNDU1NWYWx1ZSoganNDU1NWYWx1ZSA9IHN0YXRpY19jYXN0PEpTQ1NTVmFs dWUqPihoYW5kbGUuZ2V0KCkuYXNDZWxsKCkpOwogICAgIERPTVdyYXBwZXJXb3JsZCogd29ybGQg PSBzdGF0aWNfY2FzdDxET01XcmFwcGVyV29ybGQqPihjb250ZXh0KTsKKyAgICB3b3JsZC0+bV9j c3NWYWx1ZVJvb3RzLnJlbW92ZShqc0NTU1ZhbHVlLT5pbXBsKCkpOwogICAgIHVuY2FjaGVXcmFw cGVyKHdvcmxkLCBqc0NTU1ZhbHVlLT5pbXBsKCksIGpzQ1NTVmFsdWUpOwotICAgIGNzc1ZhbHVl Um9vdHMoKS5yZW1vdmUoanNDU1NWYWx1ZS0+aW1wbCgpKTsKIH0KIAogSlNWYWx1ZSB0b0pTKEV4 ZWNTdGF0ZSogZXhlYywgSlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgQ1NTVmFsdWUq IHZhbHVlKQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmgJ KHJldmlzaW9uIDg0OTM0KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5k aW5nLmgJKHdvcmtpbmcgY29weSkKQEAgLTIxOCw4ICsyMTgsNiBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAgICAgICAgIHJldHVybiBzdHlsZUJhc2U7CiAgICAgfQogCi0gICAgSGFzaE1hcDxDU1NW YWx1ZSosIHZvaWQqPiYgY3NzVmFsdWVSb290cygpOwotCiAgICAgY29uc3QgSlNDOjpIYXNoVGFi bGUqIGdldEhhc2hUYWJsZUZvckdsb2JhbERhdGEoSlNDOjpKU0dsb2JhbERhdGEmLCBjb25zdCBK U0M6Okhhc2hUYWJsZSogc3RhdGljVGFibGUpOwogCiAgICAgdm9pZCByZXBvcnRFeGNlcHRpb24o SlNDOjpFeGVjU3RhdGUqLCBKU0M6OkpTVmFsdWUgZXhjZXB0aW9uKTsK