59645 2011-04-27 15:58:53 -0700 Add ability to remove keys from weakmap API 2011-04-27 16:54:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver oliver abarth eric webkit.review.bot oldest_to_newest 393910 0 oliver 2011-04-27 15:58:53 -0700 Add ability to remove keys from weakmap API 393912 1 91366 oliver 2011-04-27 15:59:53 -0700 Created attachment 91366 Patch 393916 2 91366 ggaren 2011-04-27 16:01:55 -0700 Comment on attachment 91366 Patch r=me 393920 3 webkit.review.bot 2011-04-27 16:03:05 -0700 Attachment 91366 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSWeakObjectMapR..." exit_code: 1 Source/JavaScriptCore/API/JSWeakObjectMapRefPrivate.h:86: The parameter name "map" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 393925 4 oliver 2011-04-27 16:07:25 -0700 Committed r85117: <http://trac.webkit.org/changeset/85117> 394000 5 webkit.review.bot 2011-04-27 16:54:18 -0700 http://trac.webkit.org/changeset/85117 might have broken Qt Linux Release 91366 2011-04-27 15:59:53 -0700 2011-04-27 16:01:55 -0700 Patch bug-59645-20110427155952.patch text/plain 3041 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogODUxMDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9BUEkvSlNXZWFrT2JqZWN0TWFwUmVmUHJpdmF0ZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQVBJL0pTV2Vha09iamVjdE1hcFJlZlByaXZhdGUuY3BwCmluZGV4IDU0ZGZkYTY5NjY5 YmQzMjc5ZjllOTIxNzJkMGFlYjYwMTdiODVjNzMuLjEzOTAwY2Y4MzI3YjRmMDI2ZTIwM2Y0YTEy Y2I1ODQ2NGMyMDNhMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNX ZWFrT2JqZWN0TWFwUmVmUHJpdmF0ZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQ SS9KU1dlYWtPYmplY3RNYXBSZWZQcml2YXRlLmNwcApAQCAtNjgsNiArNjgsMTMgQEAgSlNPYmpl Y3RSZWYgSlNXZWFrT2JqZWN0TWFwR2V0KEpTQ29udGV4dFJlZiBjdHgsIEpTV2Vha09iamVjdE1h cFJlZiBtYXAsIHZvaWQqIGsKICAgICByZXR1cm4gdG9SZWYoc3RhdGljX2Nhc3Q8SlNPYmplY3Qq PihtYXAtPm1hcCgpLmdldChrZXkpKSk7CiB9CiAKK3ZvaWQgSlNXZWFrT2JqZWN0TWFwUmVtb3Zl KEpTQ29udGV4dFJlZiBjdHgsIEpTV2Vha09iamVjdE1hcFJlZiBtYXAsIHZvaWQqIGtleSkKK3sK KyAgICBFeGVjU3RhdGUqIGV4ZWMgPSB0b0pTKGN0eCk7CisgICAgQVBJRW50cnlTaGltIGVudHJ5 U2hpbShleGVjKTsKKyAgICBtYXAtPm1hcCgpLnRha2Uoa2V5KTsKK30KKwogLy8gV2UgbmVlZCB0 byBrZWVwIHRoaXMgZnVuY3Rpb24gaW4gdGhlIGJ1aWxkIHRvIGtlZXAgdGhlIG5pZ2h0bGllcyBy dW5uaW5nLgogSlNfRVhQT1JUIGJvb2wgSlNXZWFrT2JqZWN0TWFwQ2xlYXIoSlNDb250ZXh0UmVm LCBKU1dlYWtPYmplY3RNYXBSZWYsIHZvaWQqLCBKU09iamVjdFJlZik7CiBib29sIEpTV2Vha09i amVjdE1hcENsZWFyKEpTQ29udGV4dFJlZiwgSlNXZWFrT2JqZWN0TWFwUmVmLCB2b2lkKiwgSlNP YmplY3RSZWYpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTV2Vha09i amVjdE1hcFJlZlByaXZhdGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNXZWFrT2Jq ZWN0TWFwUmVmUHJpdmF0ZS5oCmluZGV4IDAxZTA2MTFhZDZiODBhZDMwY2Y3ZWEzODliMTRiOTFj ZTY4NjEwZmQuLjVhMDdjZjdjNDExODIzNzhjMTNlOTAyOGZiMjQ2MWVlNjdhMmM5ZTEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNXZWFrT2JqZWN0TWFwUmVmUHJpdmF0 ZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNXZWFrT2JqZWN0TWFwUmVmUHJp dmF0ZS5oCkBAIC03Niw2ICs3NiwxNSBAQCBKU19FWFBPUlQgdm9pZCBKU1dlYWtPYmplY3RNYXBT ZXQoSlNDb250ZXh0UmVmIGN0eCwgSlNXZWFrT2JqZWN0TWFwUmVmIG1hcCwgdm9pZAogICovCiBK U19FWFBPUlQgSlNPYmplY3RSZWYgSlNXZWFrT2JqZWN0TWFwR2V0KEpTQ29udGV4dFJlZiBjdHgs IEpTV2Vha09iamVjdE1hcFJlZiBtYXAsIHZvaWQqIGtleSk7CiAKKy8qIQorIEBmdW5jdGlvbgor IEBhYnN0cmFjdCBSZW1vdmVzIHRoZSBlbnRyeSBmb3IgdGhlIGdpdmVuIGtleSBpZiB0aGUga2V5 IGlzIHByZXNlbnQsIG90aGVyd2lzZSBpdCBoYXMgbm8gZWZmZWN0LgorIEBwYXJhbSBjdHggVGhl IGV4ZWN1dGlvbiBjb250ZXh0IHRvIHVzZS4KKyBAcGFyYW0gbWFwIFRoZSBtYXAgdG8gdXNlLgor IEBwYXJhbSBrZXkgVGhlIGtleSB0byByZW1vdmUuCisgKi8KK0pTX0VYUE9SVCB2b2lkIEpTV2Vh a09iamVjdE1hcFJlbW92ZShKU0NvbnRleHRSZWYgY3R4LCBKU1dlYWtPYmplY3RNYXBSZWYgbWFw LCB2b2lkKiBrZXkpOworCiAjaWZkZWYgX19jcGx1c3BsdXMKIH0KICNlbmRpZgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKaW5kZXggZGE0ZTE4NWUyZDhlNDdhOGYzMTZjNjE2MDZjNjNkNDMyOWM4M2Rm YS4uMjRkYzA3YWFjNDIyNDlmNGFhZDY4NmY4ODdlOWMzOGFmMGE1OGVlYiAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMjcgIE9saXZlciBIdW50ICA8 b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgYWJpbGl0eSB0byByZW1vdmUga2V5cyBmcm9tIHdlYWttYXAgQVBJCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTY0NQorCisg ICAgICAgIEFkZCBKU1dlYWtPYmplY3RNYXBSZW1vdmUgQVBJCisKKyAgICAgICAgKiBBUEkvSlNX ZWFrT2JqZWN0TWFwUmVmUHJpdmF0ZS5jcHA6CisgICAgICAgICogQVBJL0pTV2Vha09iamVjdE1h cFJlZlByaXZhdGUuaDoKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS5leHA6CisKIDIwMTEtMDQt MjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2Ny aXB0Q29yZS5leHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZXhwCmlu ZGV4IGYzM2EzOGMxMjljMjhhYWNjY2E2ZGU3YTM1YjM2ZGVkZDI4MTBmNGMuLmU5ZDdmNTQ0YTJj Mjc5NzUyYWI2MTE0MGI2Mjc3NTI0Y2E5ZjBmYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5leHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0ph dmFTY3JpcHRDb3JlLmV4cApAQCAtODcsNiArODcsNyBAQCBfSlNWYWx1ZVVucHJvdGVjdAogX0pT V2Vha09iamVjdE1hcENsZWFyCiBfSlNXZWFrT2JqZWN0TWFwQ3JlYXRlCiBfSlNXZWFrT2JqZWN0 TWFwR2V0CitfSlNXZWFrT2JqZWN0TWFwUmVtb3ZlCiBfSlNXZWFrT2JqZWN0TWFwU2V0CiBfV1RG TG9nCiBfV1RGTG9nVmVyYm9zZQo=