59634 2011-04-27 14:19:19 -0700 Port Mozilla's IndexedDB tests: event.target.result after add() and put() 2011-04-28 11:49:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 0 pilgrim webkit-unassigned commit-queue dgrogan fishd hans pilgrim tony oldest_to_newest 393816 0 pilgrim 2011-04-27 14:19:19 -0700 Original test: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/test_key_requirements.html?force=1 This is a port of a test from Mozilla's IndexedDB test suite. It checks the value of event.target.result after the asynchronous add() and put() methods. WebKit passes this test. 393818 1 91348 pilgrim 2011-04-27 14:21:17 -0700 Created attachment 91348 Patch 393903 2 91348 dgrogan 2011-04-27 15:46:35 -0700 Comment on attachment 91348 Patch r+ Mark, I'll let you set /cq?/ 394184 3 91348 commit-queue 2011-04-27 21:37:42 -0700 Comment on attachment 91348 Patch Clearing flags on attachment: 91348 Committed r85148: <http://trac.webkit.org/changeset/85148> 394185 4 commit-queue 2011-04-27 21:37:47 -0700 All reviewed patches have been landed. Closing bug. 394623 5 tony 2011-04-28 11:46:11 -0700 (In reply to comment #4) > All reviewed patches have been landed. Closing bug. This test is failing on the bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=storage%2Findexeddb%2Fmozilla%2Fkey-requirements.html&group=%40ToT%20-%20chromium.org Looks like the expected result is incorrect (the description is wrong). I'll land a fix. 394629 6 tony 2011-04-28 11:48:38 -0700 Fixed expected result in http://trac.webkit.org/changeset/85217. 394630 7 pilgrim 2011-04-28 11:49:17 -0700 Sorry about that. Thanks, Tony. 91348 2011-04-27 14:21:17 -0700 2011-04-27 21:37:42 -0700 Patch bug-59634-20110427172115.patch text/plain 4762 pilgrim SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg1MDkwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMjcgIE1hcmsgUGlsZ3JpbSAgPHBp bGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFBvcnQgTW96aWxsYSdzIEluZGV4ZWREQiB0ZXN0czogZXZlbnQudGFyZ2V0 LnJlc3VsdCBhZnRlciBhZGQoKSBhbmQgcHV0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU5NjM0CisKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRk Yi9tb3ppbGxhL2tleS1yZXF1aXJlbWVudHMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2tleS1yZXF1aXJlbWVudHMuaHRtbDogQWRkZWQu CisKIDIwMTEtMDQtMjcgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL3N0b3JhZ2Uv aW5kZXhlZGRiL21vemlsbGEva2V5LXJlcXVpcmVtZW50cy1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9rZXktcmVxdWlyZW1l bnRzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3N0b3JhZ2UvaW5k ZXhlZGRiL21vemlsbGEva2V5LXJlcXVpcmVtZW50cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMjYgQEAKK1Rlc3QgSW5kZXhlZERCJ3MgYmVoYXZpb3IgYWRkaW5nIGFuZCBy ZXRyaWV2aW5nIGtleXMKKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQ QVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK2luZGV4ZWRE QiA9IHdpbmRvdy5pbmRleGVkREIgfHwgd2luZG93LndlYmtpdEluZGV4ZWREQiB8fCB3aW5kb3cu bW96SW5kZXhlZERCOworUEFTUyBpbmRleGVkREIgPT0gbnVsbCBpcyBmYWxzZQoraW5kZXhlZERC Lm9wZW4obmFtZSwgZGVzY3JpcHRpb24pCitkYiA9IGV2ZW50LnRhcmdldC5yZXN1bHQKK3JlcXVl c3QgPSBkYi5zZXRWZXJzaW9uKCcxJykKK0RlbGV0ZWQgYWxsIG9iamVjdCBzdG9yZXMuCitvYmpl Y3RTdG9yZSA9IGRiLmNyZWF0ZU9iamVjdFN0b3JlKCdmb28nLCB7IGF1dG9JbmNyZW1lbnQ6IHRy dWUgfSk7CityZXF1ZXN0ID0gb2JqZWN0U3RvcmUuYWRkKHt9KTsKK2tleTEgPSBldmVudC50YXJn ZXQucmVzdWx0OworcmVxdWVzdCA9IG9iamVjdFN0b3JlLnB1dCh7fSwga2V5MSk7CitQQVNTIGV2 ZW50LnRhcmdldC5yZXN1bHQgaXMga2V5MQora2V5MiA9IDEwOworcmVxdWVzdCA9IG9iamVjdFN0 b3JlLnB1dCh7fSwga2V5Mik7CitQQVNTIGV2ZW50LnRhcmdldC5yZXN1bHQgaXMga2V5Mgora2V5 MiA9IDEwMDsKK3JlcXVlc3QgPSBvYmplY3RTdG9yZS5wdXQoe30sIGtleTIpOworUEFTUyBldmVu dC50YXJnZXQucmVzdWx0IGlzIGtleTIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK KworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9t b3ppbGxhL2tleS1yZXF1aXJlbWVudHMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9z dG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2tleS1yZXF1aXJlbWVudHMuaHRtbAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vemlsbGEva2V5LXJlcXVpcmVt ZW50cy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDkzIEBACis8IURPQ1RZUEUgaHRtbD4K KzwhLS0KKyAgb3JpZ2luYWwgdGVzdDogaHR0cDovL214ci5tb3ppbGxhLm9yZy9tb3ppbGxhMi4w L3NvdXJjZS9kb20vaW5kZXhlZERCL3Rlc3QvdGVzdF9rZXlfcmVxdWlyZW1lbnRzLmh0bWwKKyAg bGljZW5zZSBvZiBvcmlnaW5hbCB0ZXN0OgorICAgICIgQW55IGNvcHlyaWdodCBpcyBkZWRpY2F0 ZWQgdG8gdGhlIFB1YmxpYyBEb21haW4uCisgICAgICBodHRwOi8vY3JlYXRpdmVjb21tb25zLm9y Zy9wdWJsaWNkb21haW4vemVyby8xLjAvICIKKy0tPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJl bD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1z dHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9mYXN0L2pzL3Jlc291 cmNlcy9qcy10ZXN0LXBvc3QtZnVuY3Rpb24uanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4u L3Jlc291cmNlcy9zaGFyZWQuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0i ZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KKwor ZGVzY3JpcHRpb24oIlRlc3QgSW5kZXhlZERCJ3MgZXZlbnQudGFyZ2V0LnJlc3VsdCBhZnRlciBh ZGQoKSBhbmQgcHV0KCkiKTsKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworCitmdW5jdGlvbiB0ZXN0KCkK K3sKKyAgICBpbmRleGVkREIgPSBldmFsQW5kTG9nKCJpbmRleGVkREIgPSB3aW5kb3cuaW5kZXhl ZERCIHx8IHdpbmRvdy53ZWJraXRJbmRleGVkREIgfHwgd2luZG93Lm1vekluZGV4ZWREQjsiKTsK KyAgICBzaG91bGRCZUZhbHNlKCJpbmRleGVkREIgPT0gbnVsbCIpOworCisgICAgbmFtZSA9IHdp bmRvdy5sb2NhdGlvbi5wYXRobmFtZTsKKyAgICBkZXNjcmlwdGlvbiA9ICJNeSBUZXN0IERhdGFi YXNlIjsKKyAgICByZXF1ZXN0ID0gZXZhbEFuZExvZygiaW5kZXhlZERCLm9wZW4obmFtZSwgZGVz Y3JpcHRpb24pIik7CisgICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBvcGVuU3VjY2VzczsKKyAgICBy ZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKK30KKworZnVuY3Rpb24g b3BlblN1Y2Nlc3MoKQoreworICAgIGRiID0gZXZhbEFuZExvZygiZGIgPSBldmVudC50YXJnZXQu cmVzdWx0Iik7CisKKyAgICByZXF1ZXN0ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IGRiLnNldFZl cnNpb24oJzEnKSIpOworICAgIHJlcXVlc3Qub25zdWNjZXNzID0gY2xlYW5EYXRhYmFzZTsKKyAg ICByZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKK30KKworZnVuY3Rp b24gY2xlYW5EYXRhYmFzZSgpCit7CisgICAgZGVsZXRlQWxsT2JqZWN0U3RvcmVzKGRiKTsKKyAg ICBvYmplY3RTdG9yZSA9IGV2YWxBbmRMb2coIm9iamVjdFN0b3JlID0gZGIuY3JlYXRlT2JqZWN0 U3RvcmUoJ2ZvbycsIHsgYXV0b0luY3JlbWVudDogdHJ1ZSB9KTsiKTsKKyAgICByZXF1ZXN0ID0g ZXZhbEFuZExvZygicmVxdWVzdCA9IG9iamVjdFN0b3JlLmFkZCh7fSk7Iik7CisgICAgcmVxdWVz dC5vbnN1Y2Nlc3MgPSBwb3N0QWRkOworICAgIHJlcXVlc3Qub25lcnJvciA9IHVuZXhwZWN0ZWRF cnJvckNhbGxiYWNrOworfQorCitmdW5jdGlvbiBwb3N0QWRkKCkKK3sKKyAgICBrZXkxID0gZXZh bEFuZExvZygia2V5MSA9IGV2ZW50LnRhcmdldC5yZXN1bHQ7Iik7CisgICAgcmVxdWVzdCA9IGV2 YWxBbmRMb2coInJlcXVlc3QgPSBvYmplY3RTdG9yZS5wdXQoe30sIGtleTEpOyIpOworICAgIHJl cXVlc3Qub25zdWNjZXNzID0gcG9zdFB1dDE7CisgICAgcmVxdWVzdC5vbmVycm9yID0gdW5leHBl Y3RlZEVycm9yQ2FsbGJhY2s7Cit9CisKK2Z1bmN0aW9uIHBvc3RQdXQxKCkKK3sKKyAgICBzaG91 bGRCZSgiZXZlbnQudGFyZ2V0LnJlc3VsdCIsICJrZXkxIik7CisgICAga2V5MiA9IGV2YWxBbmRM b2coImtleTIgPSAxMDsiKTsKKyAgICByZXF1ZXN0ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IG9i amVjdFN0b3JlLnB1dCh7fSwga2V5Mik7Iik7CisgICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBwb3N0 UHV0MjsKKyAgICByZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKK30K KworZnVuY3Rpb24gcG9zdFB1dDIoKQoreworICAgIHNob3VsZEJlKCJldmVudC50YXJnZXQucmVz dWx0IiwgImtleTIiKTsKKyAgICBrZXkyID0gZXZhbEFuZExvZygia2V5MiA9IDEwMDsiKTsKKyAg ICByZXF1ZXN0ID0gZXZhbEFuZExvZygicmVxdWVzdCA9IG9iamVjdFN0b3JlLnB1dCh7fSwga2V5 Mik7Iik7CisgICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBwb3N0UHV0MzsKKyAgICByZXF1ZXN0Lm9u ZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKK30KKworZnVuY3Rpb24gcG9zdFB1dDMo KQoreworICAgIHNob3VsZEJlKCJldmVudC50YXJnZXQucmVzdWx0IiwgImtleTIiKTsKKyAgICBk b25lKCk7Cit9CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworCit0ZXN0KCk7CisK Kzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgorCg==