59628 2011-04-27 13:35:15 -0700 Make start parameter of Blob.slice optional 2011-05-24 11:58:39 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 jianli jianli ap dimich eric fishd kbr mjs oldest_to_newest 393758 0 jianli 2011-04-27 13:35:15 -0700 We need to make start parameter of Blob.slice optional, per the latest File API spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob 393773 1 91339 jianli 2011-04-27 13:54:00 -0700 Created attachment 91339 Proposed Patch 395983 2 eric 2011-05-01 12:05:35 -0700 There was a gigantic thread about this on webkit-dev. I'm surprised more of those players aren't cc'd here. 408410 3 eric 2011-05-23 15:50:28 -0700 Jian: Could you please CC the relevant people and get this resolved? it's been in the queue for almost a month. 408432 4 jianli 2011-05-23 16:04:29 -0700 Per the discussion, we decide to do no change to how code generator handles optional parameter since it is the right behavior as in ECMA-262. The spec author Arun also updated the File API spec to explicitly illustrate the case for optional end parameter. The only change in this patch to make start parameter as optional. It does not change any other existing behaviors. CC peoples that were in the discussion if they have more to day. 408442 5 91339 kbr 2011-05-23 16:09:36 -0700 Comment on attachment 91339 Proposed Patch Looks fine. 409072 6 jianli 2011-05-24 11:58:39 -0700 Committed as https://trac.webkit.org/changeset/87181. 91339 2011-04-27 13:54:00 -0700 2011-05-23 16:09:36 -0700 Proposed Patch 59628 text/plain 4156 jianli ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZmZiMTQwLi41MGQzYzY4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQt MjcgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ugc3RhcnQgcGFyYW1ldGVyIG9mIEJsb2Iu c2xpY2Ugb3B0aW9uYWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01OTYyOAorCisgICAgICAgICogZmFzdC9maWxlcy9ibG9iLXNsaWNlLXRlc3QtZXhw ZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZmlsZXMvYmxvYi1zbGljZS10ZXN0Lmh0bWw6CisK IDIwMTEtMDQtMTYgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvZmlsZXMvYmxvYi1zbGljZS10ZXN0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvZmlsZXMvYmxvYi1zbGljZS10ZXN0LWV4cGVjdGVkLnR4dAppbmRleCA4ZTIwZTFiLi4w ZjI3NGQzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2Jsb2Itc2xpY2UtdGVz dC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9ibG9iLXNsaWNlLXRl c3QtZXhwZWN0ZWQudHh0CkBAIC0yNCw0ICsyNCw1IEBAIFNsaWNpbmcgZnJvbSAyMTQ3NDgzNjQ3 OgogU2xpY2luZyBmcm9tIC0yMTQ3NDgzNjQ4OiAwMTIzNDU2Nzg5CiBTbGljaW5nIGZyb20gOTIy MzM3MjAzNjg1NDc3NTAwMDogCiBTbGljaW5nIGZyb20gLTkyMjMzNzIwMzY4NTQ3NzUwMDA6IDAx MjM0NTY3ODkKK1NsaWNpbmcgd2l0aG91dCBwYXJhbWV0ZXJzOiAwMTIzNDU2Nzg5CiAKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZmlsZXMvYmxvYi1zbGljZS10ZXN0Lmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L2ZpbGVzL2Jsb2Itc2xpY2UtdGVzdC5odG1sCmluZGV4IDBmZjE4YjYuLjU2 MDQ4ZGEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZmlsZXMvYmxvYi1zbGljZS10ZXN0 Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9ibG9iLXNsaWNlLXRlc3QuaHRtbApA QCAtMzEsNiArMzEsNyBAQCB2YXIgc2xpY2VQYXJhbXMgPSBbCiAgICAgWy0yMTQ3NDgzNjQ4XSwK ICAgICBbOTIyMzM3MjAzNjg1NDc3NTAwMF0sCiAgICAgWy05MjIzMzcyMDM2ODU0Nzc1MDAwXSwK KyAgICBbXSwKIF07CiAKIGZ1bmN0aW9uIGxvZyhtZXNzYWdlKQpAQCAtNDEsMTUgKzQyLDE5IEBA IGZ1bmN0aW9uIGxvZyhtZXNzYWdlKQogZnVuY3Rpb24gdGVzdFNsaWNpbmcoc3RhcnQsIGVuZCkK IHsKICAgICB2YXIgc3ViQmxvYjsKLSAgICB2YXIgbWVzc2FnZTsKICAgICB2YXIgcmVhZGVyID0g bmV3IEZpbGVSZWFkZXIoKTsKLSAgICBpZiAoZW5kID09IHVuZGVmaW5lZCkgeworICAgIHZhciBt ZXNzYWdlID0gIlNsaWNpbmcgIjsKKyAgICBpZiAoc3RhcnQgPT0gdW5kZWZpbmVkICYmIGVuZCA9 PSB1bmRlZmluZWQpIHsKKyAgICAgICAgbWVzc2FnZSArPSAid2l0aG91dCBwYXJhbWV0ZXJzIjsK KyAgICAgICAgc3ViQmxvYiA9IGJsb2Iud2Via2l0U2xpY2UoKTsKKyAgICB9IGVsc2UgaWYgKGVu ZCA9PSB1bmRlZmluZWQpIHsKKyAgICAgICAgbWVzc2FnZSArPSAiZnJvbSAiICsgc3RhcnQ7CiAg ICAgICAgIHN1YkJsb2IgPSBibG9iLndlYmtpdFNsaWNlKHN0YXJ0KTsKLSAgICAgICAgbWVzc2Fn ZSA9ICJTbGljaW5nIGZyb20gIiArIHN0YXJ0ICsgIjogIjsKICAgICB9IGVsc2UgeworICAgICAg ICBtZXNzYWdlICs9ICJmcm9tICIgKyBzdGFydCArICIgdG8gIiArIGVuZDsKICAgICAgICAgc3Vi QmxvYiA9IGJsb2Iud2Via2l0U2xpY2Uoc3RhcnQsIGVuZCk7Ci0gICAgICAgIG1lc3NhZ2UgPSAi U2xpY2luZyBmcm9tICIgKyBzdGFydCArICIgdG8gIiArIGVuZCArICI6ICI7CiAgICAgfQorICAg IG1lc3NhZ2UgKz0gIjogIjsKICAgICByZWFkZXIub25sb2FkID0gZnVuY3Rpb24oZXZlbnQpIHsK ICAgICAgICAgbG9nKG1lc3NhZ2UgKyBldmVudC50YXJnZXQucmVzdWx0KTsKICAgICAgICAgcnVu TmV4dFRlc3QoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4MTAwM2I1Li4xMmQ5OTVjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMjcgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ug c3RhcnQgcGFyYW1ldGVyIG9mIEJsb2Iuc2xpY2Ugb3B0aW9uYWwuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTYyOAorCisgICAgICAgIFRoZSBzdGFy dCBwYXJhbWV0ZXIgc2hvdWxkIGJlIG9wdGlvbmFsIHBlciB0aGUgbGF0ZXN0IEZJTEUgQVBJCisg ICAgICAgIHNwZWM6IGh0dHA6Ly9kZXYudzMub3JnLzIwMDYvd2ViYXBpL0ZpbGVBUEkvI2Rmbi1C bG9iLgorCisgICAgICAgICogZmlsZWFwaS9CbG9iLmg6CisgICAgICAgICogZmlsZWFwaS9CbG9i LmlkbDogTWFrZSBzdGFydCBwYXJhbWV0ZXIgb3B0aW9uYWwuCisKIDIwMTEtMDQtMjAgIERpbWl0 cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbnR0aSBLb2l2aXN0by4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvQmxv Yi5oIGIvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9CbG9iLmgKaW5kZXggNWNlZmM2NS4uYmNhOTM5 OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9CbG9iLmgKKysrIGIvU291cmNl L1dlYkNvcmUvZmlsZWFwaS9CbG9iLmgKQEAgLTYzLDcgKzYzLDcgQEAgcHVibGljOgogICAgIHZp cnR1YWwgYm9vbCBpc0ZpbGUoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogCiAjaWYgRU5BQkxF KEJMT0IpCi0gICAgUGFzc1JlZlB0cjxCbG9iPiB3ZWJraXRTbGljZShsb25nIGxvbmcgc3RhcnQs IGxvbmcgbG9uZyBlbmQgPSBzdGQ6Om51bWVyaWNfbGltaXRzPGxvbmcgbG9uZz46Om1heCgpLCBj b25zdCBTdHJpbmcmIGNvbnRlbnRUeXBlID0gU3RyaW5nKCkpIGNvbnN0OworICAgIFBhc3NSZWZQ dHI8QmxvYj4gd2Via2l0U2xpY2UobG9uZyBsb25nIHN0YXJ0ID0gMCwgbG9uZyBsb25nIGVuZCA9 IHN0ZDo6bnVtZXJpY19saW1pdHM8bG9uZyBsb25nPjo6bWF4KCksIGNvbnN0IFN0cmluZyYgY29u dGVudFR5cGUgPSBTdHJpbmcoKSkgY29uc3Q7CiAjZW5kaWYKIAogcHJvdGVjdGVkOgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9CbG9iLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2Zp bGVhcGkvQmxvYi5pZGwKaW5kZXggYzAzZDJkMy4uZTliNzk1OSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZmlsZWFwaS9CbG9iLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0Js b2IuaWRsCkBAIC0zOSw3ICszOSw3IEBAIG1vZHVsZSBodG1sIHsKIAogI2lmICFkZWZpbmVkKExB TkdVQUdFX09CSkVDVElWRV9DKQogI2lmIGRlZmluZWQoRU5BQkxFX0JMT0IpICYmIEVOQUJMRV9C TE9CCi0gICAgICAgIEJsb2Igd2Via2l0U2xpY2UoaW4gbG9uZyBsb25nIHN0YXJ0LCBpbiBbT3B0 aW9uYWxdIGxvbmcgbG9uZyBlbmQsIGluIFtPcHRpb25hbCwgQ29udmVydFVuZGVmaW5lZE9yTnVs bFRvTnVsbFN0cmluZ10gRE9NU3RyaW5nIGNvbnRlbnRUeXBlKTsKKyAgICAgICAgQmxvYiB3ZWJr aXRTbGljZShpbiBbT3B0aW9uYWxdIGxvbmcgbG9uZyBzdGFydCwgaW4gW09wdGlvbmFsXSBsb25n IGxvbmcgZW5kLCBpbiBbT3B0aW9uYWwsIENvbnZlcnRVbmRlZmluZWRPck51bGxUb051bGxTdHJp bmddIERPTVN0cmluZyBjb250ZW50VHlwZSk7CiAjZW5kaWYKICNlbmRpZgogICAgIH07Cg==