59593 2011-04-27 03:10:25 -0700 Web Inspector: provide a hotkey for script pause 2011-04-28 06:03:47 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 393469 0 yurys 2011-04-27 03:10:25 -0700 We have hotkeys for stepping and continue, it looks logical to have one for script pause. There is a user request for this: http://groups.google.com/a/chromium.org/group/chromium-discuss/browse_thread/thread/c5bde640f8281002/63410885d71aef6d 394300 1 apavlov 2011-04-28 00:59:25 -0700 F8 is the key, as it is bound to the Pause/Continue button click handler. If the same key for the two actions is deemed OK, we just need to update the shortcuts help page. 394363 2 91471 apavlov 2011-04-28 04:31:06 -0700 Created attachment 91471 [PATCH] Suggested fix This fixes the shortcuts help page for F8. 394364 3 webkit.review.bot 2011-04-28 04:34:00 -0700 Attachment 91471 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 394383 4 apavlov 2011-04-28 06:03:47 -0700 Committed r85179: <http://trac.webkit.org/changeset/85179> 91471 2011-04-28 04:31:06 -0700 2011-04-28 04:55:31 -0700 [PATCH] Suggested fix pausekey.patch text/plain 2082 apavlov Y29tbWl0IGRmNzhmZGU3YjdkNTNmMzJhZjFmOWZhZDY3ZTA3ZDA1MWViMzdhM2MKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBUaHUgQXByIDI4 IDE0OjU2OjI4IDIwMTEgKzA0MDAKCiAgICBGaXgKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzZmZmE4Zi4uYTYx ODQ2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTA0LTI4ICBBbGV4YW5kZXIg UGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogcHJvdmlkZSBhIGhvdGtleSBm b3Igc2NyaXB0IHBhdXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01OTU5MworCisJSW4gZmFjdCwgRjggd29ya3MgYXMgYSBob3RrZXksIGJ1dCB0aGlz IGZhY3Qgd2FzIG5vdCByZWZsZWN0ZWQKKwlpbiB0aGUgc2hvcnRjdXQgaGVscCBwb3B1cC4KKwor ICAgICAgICAqIEVuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczoKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5TY3JpcHRzUGFuZWwucHJvdG90eXBlLl9yZWdpc3RlclNob3J0Y3V0cyk6CisKIDIwMTEtMDQt MjYgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvRW5n bGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIGIvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5s cHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IGVmZDBmNDY3ZTUxNTk4OGJkNTJiNzA2YzBl M2FjYzA1OWMxZjkxMTkuLmIwMTAwZDQxMTllNTE5Y2FkN2NlMzdlNGI3MzEwZGYwYjM3Mjg3ZDUg MTAwNjQ0CkdJVCBiaW5hcnkgcGF0Y2gKZGVsdGEgNDIKdmNtZXllbEtJZ3A8XyUxbGpRVyFVd1Bo emFxX1J2dGtqQDY/Mn5UZCYpfGs5dUd0WHcwJW4jV0JUT2JlXgoKZGVsdGEgMTQKV2NtYUV+aXV1 Yio8XyUxbG4rcX5PV2RpXj1FKGJJSwoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKaW5kZXggOWRmYjYwYy4uYTc0MmZlNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMK KysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMK QEAgLTkwOSw3ICs5MDksNyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZSA9 IHsKICAgICAgICAgc2hvcnRjdXRzW3Nob3J0Y3V0MS5rZXldID0gaGFuZGxlcjsKICAgICAgICAg c2hvcnRjdXQyID0gV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQubWFrZURlc2NyaXB0b3Io V2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuS2V5cy5TbGFzaCwgcGxhdGZvcm1TcGVjaWZp Y01vZGlmaWVyKTsKICAgICAgICAgc2hvcnRjdXRzW3Nob3J0Y3V0Mi5rZXldID0gaGFuZGxlcjsK LSAgICAgICAgc2VjdGlvbi5hZGRBbHRlcm5hdGVLZXlzKFsgc2hvcnRjdXQxLm5hbWUsIHNob3J0 Y3V0Mi5uYW1lIF0sIFdlYkluc3BlY3Rvci5VSVN0cmluZygiQ29udGludWUiKSk7CisgICAgICAg IHNlY3Rpb24uYWRkQWx0ZXJuYXRlS2V5cyhbIHNob3J0Y3V0MS5uYW1lLCBzaG9ydGN1dDIubmFt ZSBdLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlBhdXNlL0NvbnRpbnVlIikpOwogCiAgICAgICAg IC8vIFN0ZXAgb3Zlci4KICAgICAgICAgaGFuZGxlciA9IHRoaXMuc3RlcE92ZXJCdXR0b24uY2xp Y2suYmluZCh0aGlzLnN0ZXBPdmVyQnV0dG9uKTsK