59585 2011-04-27 00:33:37 -0700 Webkit-gtk build failure, no type/member 'Page' in namespace 'WebCore' 2011-04-28 12:10:54 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 ojab webkit-unassigned mrobinson oldest_to_newest 393412 0 ojab 2011-04-27 00:33:37 -0700 Webkit trunk r85024 build fails with both clang & gcc-4.6.0, the error is: make[1]: Entering directory `/mnt/mnt/backup/sources/webkit' CXX Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_1_0_la-TextCheckerClientEnchant.lo In file included from Source/WebKit/gtk/WebCoreSupport/TextCheckerClientEnchant.cpp:29: ./Source/WebKit/gtk/webkit/webkitwebviewprivate.h:34:10: error: no type named 'Page' in namespace 'WebCore' WebCore::Page* core(WebKitWebView*); ~~~~~~~~~^ ./Source/WebKit/gtk/webkit/webkitwebviewprivate.h:35:29: error: no member named 'Page' in namespace 'WebCore' WebKitWebView* kit(WebCore::Page*); ~~~~~~~~~^ ./Source/WebKit/gtk/webkit/webkitwebviewprivate.h:35:34: error: expected expression WebKitWebView* kit(WebCore::Page*); ^ ./Source/WebKit/gtk/webkit/webkitwebviewprivate.h:54:14: error: no type named 'Page' in namespace 'WebCore' WebCore::Page* corePage; ~~~~~~~~~^ 4 errors generated. make[1]: *** [Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_1_0_la-TextCheckerClientEnchant.lo] Error 1 make[1]: Leaving directory `/mnt/mnt/backup/sources/webkit' make: *** [all] Error 2 393425 1 91250 ojab 2011-04-27 00:50:20 -0700 Created attachment 91250 #include "Page.h" fixes the issue. 393762 2 91250 mrobinson 2011-04-27 13:39:37 -0700 Comment on attachment 91250 #include "Page.h" fixes the issue. Would you be willing to include and fill out a ChangeLog with this patch. Please see the instructions at: http://www.webkit.org/coding/contributing.html 394330 3 91458 ojab 2011-04-28 03:15:38 -0700 Created attachment 91458 '#include "Page.h" ' in webkitwebviewprivate.h This time with Changelog & created with svn-create-patch. 394450 4 91458 mrobinson 2011-04-28 08:49:04 -0700 Comment on attachment 91458 '#include "Page.h" ' in webkitwebviewprivate.h View in context: https://bugs.webkit.org/attachment.cgi?id=91458&action=review > Source/WebKit/gtk/webkit/webkitwebviewprivate.h:29 > #include "GOwnPtr.h" The style guidelines say this must be in alphabetical order. Sorry I didn't mention it before. I'll land this and fix it. 394650 5 mrobinson 2011-04-28 12:10:33 -0700 Committed r85221: <http://trac.webkit.org/changeset/85221> 91250 2011-04-27 00:50:20 -0700 2011-04-28 03:15:38 -0700 #include "Page.h" fixes the issue. webcore-page.patch text/plain 442 ojab ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3cHJpdmF0 ZS5oIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXdwcml2YXRlLmgKaW5k ZXggYTM1NWE1My4uOTJiMjU2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdHdlYnZpZXdwcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYnZpZXdwcml2YXRlLmgKQEAgLTIzLDYgKzIzLDcgQEAKICNpZm5kZWYgd2Via2l0d2Vi dmlld3ByaXZhdGVfaAogI2RlZmluZSB3ZWJraXR3ZWJ2aWV3cHJpdmF0ZV9oCiAKKyNpbmNsdWRl ICJQYWdlLmgiCiAjaW5jbHVkZSAiRGF0YU9iamVjdEd0ay5oIgogI2luY2x1ZGUgIkZ1bGxzY3Jl ZW5WaWRlb0NvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJHT3duUHRyLmgiCg== 91458 2011-04-28 03:15:38 -0700 2011-04-28 12:10:54 -0700 '#include "Page.h" ' in webkitwebviewprivate.h 59585.patch text/plain 1013 ojab SW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1MTc1KQorKysgU291cmNlL1dlYktpdC9n dGsvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQtMjgg IG9qYWIgIDxvamFiQG9qYWIucnU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2Via2l0LWd0ayBidWlsZCBmYWlsdXJlLCBubyB0eXBlL21lbWJlciAn UGFnZScgaW4gbmFtZXNwYWNlICdXZWJDb3JlJworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk1ODUKKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2 aWV3cHJpdmF0ZS5oOgorCiAyMDExLTA0LTI3ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25A aWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFNv dXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3cHJpdmF0ZS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3cHJpdmF0ZS5oCShyZXZp c2lvbiA4NTE3NSkKKysrIFNvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3cHJp dmF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMyw2ICsyMyw3IEBACiAjaWZuZGVmIHdlYmtpdHdl YnZpZXdwcml2YXRlX2gKICNkZWZpbmUgd2Via2l0d2Vidmlld3ByaXZhdGVfaAogCisjaW5jbHVk ZSAiUGFnZS5oIgogI2luY2x1ZGUgIkRhdGFPYmplY3RHdGsuaCIKICNpbmNsdWRlICJGdWxsc2Ny ZWVuVmlkZW9Db250cm9sbGVyLmgiCiAjaW5jbHVkZSAiR093blB0ci5oIgo=