59569 2011-04-26 18:35:43 -0700 Should call done() from unexpectedErrorCallback so failing IndexedDB tests don't time out 2011-04-27 22:18:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 0 pilgrim webkit-unassigned commit-queue dgrogan fishd pilgrim tony oldest_to_newest 393247 0 pilgrim 2011-04-26 18:35:43 -0700 As discussed in bug 59465, especially https://bugs.webkit.org/show_bug.cgi?id=59465#c9 393250 1 pilgrim 2011-04-26 18:38:22 -0700 Presumably also from unexpectedSuccessCallback, unexpectedAbortCallback, unexpectedCompleteCallback, and unexpectedBlockedCallback. These are all in LayoutTests/storage/indexeddb/resources/shared.js 393256 2 pilgrim 2011-04-26 18:43:38 -0700 Preliminary test run with these changes (calling done() in all the unexpected callbacks) confirms that this does not affect existing tests... except one. LayoutTests/storage/indexeddb/exception-in-event-aborts.html shows a slight difference. Attaching diff for discussion. 393257 3 91207 pilgrim 2011-04-26 18:45:39 -0700 Created attachment 91207 diff of affected test 393293 4 91207 dgrogan 2011-04-26 20:07:50 -0700 Comment on attachment 91207 diff of affected test That test needs some fixing, but I'm not yet sure how much. I think request = evalAndLog("store.add({x: 'value4', y: 'zzz4'}, 'key4')"); request.onsuccess = unexpectedSuccessCallback; request.onerror = throwAndCatch; should probably be changed to request.onsuccess = function(){ testPassed("something") } request.onerror = unexpectedErrorCallback but I'm not yet positive that Jeremy made a mistake as opposed to me not understanding his cleverness. 393861 5 pilgrim 2011-04-27 15:06:14 -0700 I'm going ahead with this change as well as your proposed fix for exception-in-event-aborts.html. 393863 6 91356 pilgrim 2011-04-27 15:08:05 -0700 Created attachment 91356 Patch 393870 7 91356 dgrogan 2011-04-27 15:14:20 -0700 Comment on attachment 91356 Patch r+ Out of curiosity, and for my own sake, how are you updating the text expectation txt files? I copy them manually from layout-test-results but I'd imagine there's a better way. 393871 8 tony 2011-04-27 15:16:14 -0700 BTW, normally when uploading a patch, you should set cq? if you want me to also cq+ the patch. I've been adding cq+ since you guys don't have commit access right now, but cq? makes it more explicit that you want me to do this. 394080 9 pilgrim 2011-04-27 18:41:30 -0700 (In reply to comment #7) > Out of curiosity, and for my own sake, how are you updating the text expectation txt files? I copy them manually from layout-test-results but I'd imagine there's a better way. That's what I'm doing too, plus re-running them to make sure they pass and I didn't mess up the whitespace or anything. 394208 10 91356 commit-queue 2011-04-27 22:18:48 -0700 Comment on attachment 91356 Patch Clearing flags on attachment: 91356 Committed r85153: <http://trac.webkit.org/changeset/85153> 394209 11 commit-queue 2011-04-27 22:18:53 -0700 All reviewed patches have been landed. Closing bug. 91207 2011-04-26 18:45:39 -0700 2011-04-26 20:07:50 -0700 diff of affected test exception-in-event-aborts-diff.txt text/plain 486 pilgrim LS0tIC9ob21lL3BpbGdyaW0vd29yay9jaHJvbWl1bS9zcmMvd2Via2l0L0RlYnVnL2xheW91dC10 ZXN0LXJlc3VsdHMvc3RvcmFnZS9pbmRleGVkZGIvZXhjZXB0aW9uLWluLWV2ZW50LWFib3J0cy1l eHBlY3RlZC50eHQgCisrKyAvaG9tZS9waWxncmltL3dvcmsvY2hyb21pdW0vc3JjL3dlYmtpdC9E ZWJ1Zy9sYXlvdXQtdGVzdC1yZXN1bHRzL3N0b3JhZ2UvaW5kZXhlZGRiL2V4Y2VwdGlvbi1pbi1l dmVudC1hYm9ydHMtYWN0dWFsLnR4dCAKQEAgLTUyLDkgKzUyLDYgQEAKIHN0b3JlID0gdHJhbnMu b2JqZWN0U3RvcmUoJ3N0b3JlTmFtZScpCiBzdG9yZS5hZGQoe3g6ICd2YWx1ZTQnLCB5OiAnenp6 NCd9LCAna2V5NCcpCiBGQUlMIFN1Y2Nlc3MgZnVuY3Rpb24gY2FsbGVkIHVuZXhwZWN0ZWRseS4K LQotUEFTUyBUaGUgdHJhbnNhY3Rpb24gY29tcGxldGVkLgotCiBQQVNTIHN1Y2Nlc3NmdWxseVBh cnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUK 91356 2011-04-27 15:08:05 -0700 2011-04-27 22:18:47 -0700 Patch bug-59569-20110427180803.patch text/plain 3274 pilgrim SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg1MTAyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDQtMjcgIE1hcmsgUGlsZ3JpbSAgPHBp bGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFNob3VsZCBjYWxsIGRvbmUoKSBmcm9tIHVuZXhwZWN0ZWRFcnJvckNhbGxi YWNrIHNvIGZhaWxpbmcgSW5kZXhlZERCIHRlc3RzIGRvbid0IHRpbWUgb3V0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTU2OQorCisgICAgICAgICog c3RvcmFnZS9pbmRleGVkZGIvZXhjZXB0aW9uLWluLWV2ZW50LWFib3J0cy1leHBlY3RlZC50eHQ6 CisgICAgICAgICogc3RvcmFnZS9pbmRleGVkZGIvZXhjZXB0aW9uLWluLWV2ZW50LWFib3J0cy5o dG1sOgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9zaGFyZWQuanM6Cisg ICAgICAgICh1bmV4cGVjdGVkU3VjY2Vzc0NhbGxiYWNrKToKKyAgICAgICAgKHVuZXhwZWN0ZWRF cnJvckNhbGxiYWNrKToKKyAgICAgICAgKHVuZXhwZWN0ZWRBYm9ydENhbGxiYWNrKToKKyAgICAg ICAgKHVuZXhwZWN0ZWRDb21wbGV0ZUNhbGxiYWNrKToKKyAgICAgICAgKHVuZXhwZWN0ZWRCbG9j a2VkQ2FsbGJhY2spOgorCiAyMDExLTA0LTI3ICBWaWN0b3JpYSBLaXJzdCAgPHZya0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KSW5kZXg6IExheW91dFRlc3RzL3N0b3JhZ2Uv aW5kZXhlZGRiL2V4Y2VwdGlvbi1pbi1ldmVudC1hYm9ydHMtZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2V4Y2VwdGlvbi1pbi1ldmVudC1h Ym9ydHMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA4NTA3MSkKKysrIExheW91dFRlc3RzL3N0b3Jh Z2UvaW5kZXhlZGRiL2V4Y2VwdGlvbi1pbi1ldmVudC1hYm9ydHMtZXhwZWN0ZWQudHh0CSh3b3Jr aW5nIGNvcHkpCkBAIC01MSw3ICs1MSw3IEBAIHRyYW5zLm9uYWJvcnQgPSB1bmV4cGVjdGVkQWJv cnRDYWxsYmFjawogdHJhbnMub25jb21wbGV0ZSA9IHRyYW5zYWN0aW9uQ29tcGxldGVkMgogc3Rv cmUgPSB0cmFucy5vYmplY3RTdG9yZSgnc3RvcmVOYW1lJykKIHN0b3JlLmFkZCh7eDogJ3ZhbHVl NCcsIHk6ICd6eno0J30sICdrZXk0JykKLUZBSUwgU3VjY2VzcyBmdW5jdGlvbiBjYWxsZWQgdW5l eHBlY3RlZGx5LgorUEFTUyBrZXk0IGFkZGVkCiAKIFBBU1MgVGhlIHRyYW5zYWN0aW9uIGNvbXBs ZXRlZC4KIApJbmRleDogTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvZXhjZXB0aW9uLWlu LWV2ZW50LWFib3J0cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N0b3JhZ2UvaW5k ZXhlZGRiL2V4Y2VwdGlvbi1pbi1ldmVudC1hYm9ydHMuaHRtbAkocmV2aXNpb24gODUwNzEpCisr KyBMYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9leGNlcHRpb24taW4tZXZlbnQtYWJvcnRz Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTExMiw4ICsxMTIsOCBAQCBmdW5jdGlvbiB0cmFuc2Fj dGlvbkNvbXBsZXRlZDEoKQogICAgIGV2YWxBbmRMb2coInRyYW5zLm9uY29tcGxldGUgPSB0cmFu c2FjdGlvbkNvbXBsZXRlZDIiKTsKICAgICBzdG9yZSA9IGV2YWxBbmRMb2coInN0b3JlID0gdHJh bnMub2JqZWN0U3RvcmUoJ3N0b3JlTmFtZScpIik7CiAgICAgcmVxdWVzdCA9IGV2YWxBbmRMb2co InN0b3JlLmFkZCh7eDogJ3ZhbHVlNCcsIHk6ICd6eno0J30sICdrZXk0JykiKTsKLSAgICByZXF1 ZXN0Lm9uc3VjY2VzcyA9IHVuZXhwZWN0ZWRTdWNjZXNzQ2FsbGJhY2s7Ci0gICAgcmVxdWVzdC5v bmVycm9yID0gdGhyb3dBbmRDYXRjaDsKKyAgICByZXF1ZXN0Lm9uc3VjY2VzcyA9IGZ1bmN0aW9u KCkgeyB0ZXN0UGFzc2VkKCJrZXk0IGFkZGVkIik7IH0KKyAgICByZXF1ZXN0Lm9uZXJyb3IgPSB1 bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKIH0KIAogZnVuY3Rpb24gdHJhbnNhY3Rpb25Db21wbGV0 ZWQyKCkKSW5kZXg6IExheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9zaGFy ZWQuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3Vy Y2VzL3NoYXJlZC5qcwkocmV2aXNpb24gODUwNzEpCisrKyBMYXlvdXRUZXN0cy9zdG9yYWdlL2lu ZGV4ZWRkYi9yZXNvdXJjZXMvc2hhcmVkLmpzCSh3b3JraW5nIGNvcHkpCkBAIC04LDI2ICs4LDMx IEBAIGZ1bmN0aW9uIGRvbmUoKQogZnVuY3Rpb24gdW5leHBlY3RlZFN1Y2Nlc3NDYWxsYmFjaygp CiB7CiAgICAgdGVzdEZhaWxlZCgiU3VjY2VzcyBmdW5jdGlvbiBjYWxsZWQgdW5leHBlY3RlZGx5 LiIpOworICAgIGRvbmUoKTsKIH0KIAogZnVuY3Rpb24gdW5leHBlY3RlZEVycm9yQ2FsbGJhY2so KQogewogICAgIHRlc3RGYWlsZWQoIkVycm9yIGZ1bmN0aW9uIGNhbGxlZCB1bmV4cGVjdGVkbHk6 ICgiICsgZXZlbnQudGFyZ2V0LmVycm9yQ29kZSArICIpICIgKyBldmVudC50YXJnZXQud2Via2l0 RXJyb3JNZXNzYWdlKTsKKyAgICBkb25lKCk7CiB9CiAKIGZ1bmN0aW9uIHVuZXhwZWN0ZWRBYm9y dENhbGxiYWNrKCkKIHsKICAgICB0ZXN0RmFpbGVkKCJBYm9ydCBmdW5jdGlvbiBjYWxsZWQgdW5l eHBlY3RlZGx5ISIpOworICAgIGRvbmUoKTsKIH0KIAogZnVuY3Rpb24gdW5leHBlY3RlZENvbXBs ZXRlQ2FsbGJhY2soKQogewogICAgIHRlc3RGYWlsZWQoIm9uY29tcGxldGUgZnVuY3Rpb24gY2Fs bGVkIHVuZXhwZWN0ZWRseSEiKTsKKyAgICBkb25lKCk7CiB9CiAKIGZ1bmN0aW9uIHVuZXhwZWN0 ZWRCbG9ja2VkQ2FsbGJhY2soKQogewogICAgIHRlc3RGYWlsZWQoIm9uYmxvY2tlZCBjYWxsZWQg dW5leHBlY3RlZGx5Iik7CisgICAgZG9uZSgpOwogfQogCiBmdW5jdGlvbiBldmFsQW5kRXhwZWN0 RXhjZXB0aW9uKGNtZCwgZXhwZWN0ZWQpCg==