59567 2011-04-26 18:14:54 -0700 Add a few more missing options to new-run-webkit-tests 2011-04-27 16:54:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam sam abarth dpranke eric levin tony webkit.review.bot oldest_to_newest 393213 0 sam 2011-04-26 18:14:54 -0700 Add a few more missing options to new-run-webkit-tests 393218 1 91198 sam 2011-04-26 18:17:28 -0700 Created attachment 91198 Patch 393220 2 webkit.review.bot 2011-04-26 18:20:34 -0700 Attachment 91198 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:264: whitespace before ']' [pep8/E202] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 393725 3 levin 2011-04-27 12:50:16 -0700 Seems fine but adding a few more discerning eyes. 393728 4 dpranke 2011-04-27 13:02:23 -0700 looks fine to me. 393935 5 sam 2011-04-27 16:17:50 -0700 Committed r85119: <http://trac.webkit.org/changeset/85119> 394002 6 webkit.review.bot 2011-04-27 16:54:27 -0700 http://trac.webkit.org/changeset/85119 might have broken Qt Linux Release 91198 2011-04-26 18:17:28 -0700 2011-04-27 13:29:57 -0700 Patch bug-59567-20110426181727.patch text/plain 5374 sam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg0OTk1KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMDQtMjYgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBmZXcgbW9y ZSBtaXNzaW5nIG9wdGlvbnMgdG8gbmV3LXJ1bi13ZWJraXQtdGVzdHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5NTY3CisKKyAgICAgICAgQWRkIHN1 cHBvcnQgZm9yOgorICAgICAgICAgICAgLS10aHJlYWRlZAorICAgICAgICAgICAgLS1nYy1iZXR3 ZWVuLXRlc3RzCisgICAgICAgICAgICAtLWNvbXBsZXgtdGV4dAorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHk6CisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzX3VuaXR0ZXN0LnB5 OgorCiAyMDExLTA0LTI2ICBLZXZpbiBPbGxpdmllciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29t PgogCiAgICAgICAgIFJ1YmJlcnN0YW1wZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVz dHMucHkJKHJldmlzaW9uIDg0OTkwKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQkod29ya2luZyBjb3B5KQpAQCAtMSw2ICsxLDcgQEAK ICMhL3Vzci9iaW4vZW52IHB5dGhvbgogIyBDb3B5cmlnaHQgKEMpIDIwMTAgR29vZ2xlIEluYy4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KICMgQ29weXJpZ2h0IChDKSAyMDEwIEdhYm9yIFJhcGNzYW55 aSAocmdhYm9yQGluZi51LXN6ZWdlZC5odSksIFVuaXZlcnNpdHkgb2YgU3plZ2VkCisjIENvcHly aWdodCAoQykgMjAxMSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAjCiAjIFJlZGlz dHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0 aG91dAogIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9s bG93aW5nIGNvbmRpdGlvbnMgYXJlCkBAIC0yNTQsNiArMjU1LDE1IEBAIGRlZiBwYXJzZV9hcmdz KGFyZ3M9Tm9uZSk6CiAgICAgICAgICAgICBoZWxwPSJSdW4gZ3JhcGhpY3MgdGVzdHMgb24gcmVh bCBHUFUgaGFyZHdhcmUgdnMgc29mdHdhcmUiKSwKICAgICBdCiAKKyAgICB3ZWJraXRfb3B0aW9u cyA9IFsKKyAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tZ2MtYmV0d2Vlbi10ZXN0cyIs IGFjdGlvbj0ic3RvcmVfdHJ1ZSIsIGRlZmF1bHQ9RmFsc2UsCisgICAgICAgICAgICBoZWxwPSJG b3JjZSBnYXJiYWdlIGNvbGxlY3Rpb24gYmV0d2VlbiBlYWNoIHRlc3QiKSwKKyAgICAgICAgb3B0 cGFyc2UubWFrZV9vcHRpb24oIi0tY29tcGxleC10ZXh0IiwgYWN0aW9uPSJzdG9yZV90cnVlIiwg ZGVmYXVsdD1GYWxzZSwKKyAgICAgICAgICAgIGhlbHA9IlVzZSB0aGUgY29tcGxleCB0ZXh0IGNv ZGUgcGF0aCBmb3IgYWxsIHRleHQgKE1hYyBPUyBYIGFuZCBXaW5kb3dzIG9ubHkpIiksCisgICAg ICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXRocmVhZGVkIiwgYWN0aW9uPSJzdG9yZV90cnVl IiwgZGVmYXVsdD1GYWxzZSwKKyAgICAgICAgICAgIGhlbHA9IlJ1biBhIGNvbmN1cnJlbnQgSmF2 YVNjcmlwdCB0aGVhZCB3aXRoIGVhY2ggdGVzdCIpCisgICAgXQorCiAgICAgIyBNaXNzaW5nIE1h Yy1zcGVjaWZpYyBvbGQtcnVuLXdlYmtpdC10ZXN0cyBvcHRpb25zOgogICAgICMgRklYTUU6IE5l ZWQ6IC1nLCAtLWd1YXJkIGZvciBndWFyZCBtYWxsb2Mgc3VwcG9ydCBvbiBNYWMuCiAgICAgIyBG SVhNRTogTmVlZDogLWwgLS1sZWFrcyAgICBFbmFibGUgbGVha3MgY2hlY2tpbmcuCkBAIC00Mjcs OSArNDM3LDggQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25lKToKICAgICBdCiAKICAgICBvcHRp b25fbGlzdCA9IChjb25maWd1cmF0aW9uX29wdGlvbnMgKyBwcmludF9vcHRpb25zICsKLSAgICAg ICAgICAgICAgICAgICBjaHJvbWl1bV9vcHRpb25zICsgcmVzdWx0c19vcHRpb25zICsgdGVzdF9v cHRpb25zICsKLSAgICAgICAgICAgICAgICAgICBtaXNjX29wdGlvbnMgKyByZXN1bHRzX2pzb25f b3B0aW9ucyArCi0gICAgICAgICAgICAgICAgICAgb2xkX3J1bl93ZWJraXRfdGVzdHNfY29tcGF0 KQorICAgICAgICAgICAgICAgICAgIGNocm9taXVtX29wdGlvbnMgKyB3ZWJraXRfb3B0aW9ucyAr IHJlc3VsdHNfb3B0aW9ucyArIHRlc3Rfb3B0aW9ucyArCisgICAgICAgICAgICAgICAgICAgbWlz Y19vcHRpb25zICsgcmVzdWx0c19qc29uX29wdGlvbnMgKyBvbGRfcnVuX3dlYmtpdF90ZXN0c19j b21wYXQpCiAgICAgb3B0aW9uX3BhcnNlciA9IG9wdHBhcnNlLk9wdGlvblBhcnNlcihvcHRpb25f bGlzdD1vcHRpb25fbGlzdCkKIAogICAgIHJldHVybiBvcHRpb25fcGFyc2VyLnBhcnNlX2FyZ3Mo YXJncykKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJr aXRfdGVzdHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c191bml0dGVzdC5weQkocmV2aXNpb24gODQ5 OTApCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rl c3RzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xLDYgKzEsNyBAQAogIyEvdXNyL2Jp bi9weXRob24KICMgQ29weXJpZ2h0IChDKSAyMDEwIEdvb2dsZSBJbmMuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAjIENvcHlyaWdodCAoQykgMjAxMCBHYWJvciBSYXBjc2FueWkgKHJnYWJvckBpbmYu dS1zemVnZWQuaHUpLCBVbml2ZXJzaXR5IG9mIFN6ZWdlZAorIyBDb3B5cmlnaHQgKEMpIDIwMTEg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogIwogIyBSZWRpc3RyaWJ1dGlvbiBhbmQg dXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICMgbW9kaWZp Y2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRp b25zIGFyZQpAQCAtMjk1LDYgKzI5NiwxNSBAQCBjbGFzcyBNYWluVGVzdCh1bml0dGVzdC5UZXN0 Q2FzZSk6CiAgICAgICAgICMgRklYTUU6IHZlcmlmeSBvcmRlciB3YXMgc2h1ZmZsZWQKICAgICAg ICAgc2VsZi5hc3NlcnRUcnVlKHBhc3NpbmdfcnVuKFsnLS1yYW5kb21pemUtb3JkZXInXSkpCiAK KyAgICBkZWYgdGVzdF9nY19iZXR3ZWVuX3Rlc3RzKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2Vy dFRydWUocGFzc2luZ19ydW4oWyctLWdjLWJldHdlZW4tdGVzdHMnXSkpCisKKyAgICBkZWYgdGVz dF9jb21wbGV4X3RleHQoc2VsZik6CisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShwYXNzaW5nX3J1 bihbJy0tY29tcGxleC10ZXh0J10pKQorCisgICAgZGVmIHRlc3RfdGhyZWFkZWQoc2VsZik6Cisg ICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShwYXNzaW5nX3J1bihbJy0tdGhyZWFkZWQnXSkpCisKICAg ICBkZWYgdGVzdF9ydW5fY2h1bmsoc2VsZik6CiAgICAgICAgICMgVGVzdCB0aGF0IHdlIGFjdHVh bGx5IHNlbGVjdCB0aGUgcmlnaHQgY2h1bmsKICAgICAgICAgYWxsX3Rlc3RzX3J1biA9IGdldF90 ZXN0c19ydW4oZmxhdHRlbl9iYXRjaGVzPVRydWUpCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQkocmV2aXNpb24gODQ5OTAp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQko d29ya2luZyBjb3B5KQpAQCAtMSw2ICsxLDcgQEAKICMhL3Vzci9iaW4vZW52IHB5dGhvbgogIyBD b3B5cmlnaHQgKEMpIDIwMTAgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMgQ29w eXJpZ2h0IChDKSAyMDEwIEdhYm9yIFJhcGNzYW55aSA8cmdhYm9yQGluZi51LXN6ZWdlZC5odT4s IFVuaXZlcnNpdHkgb2YgU3plZ2VkCisjIENvcHlyaWdodCAoQykgMjAxMSBBcHBsZSBJbmMuIEFs bCByaWdodHMgcmVzZXJ2ZWQuCiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNl IGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFyZSBw ZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCkBAIC0z NzUsNiArMzc2LDEzIEBAIGNsYXNzIFdlYktpdERyaXZlcihiYXNlLkRyaXZlcik6CiAgICAgICAg IGNtZC5hcHBlbmQoc2VsZi5fcG9ydC5fcGF0aF90b19kcml2ZXIoKSkKICAgICAgICAgaWYgc2Vs Zi5fcG9ydC5nZXRfb3B0aW9uKCdwaXhlbF90ZXN0cycpOgogICAgICAgICAgICAgY21kLmFwcGVu ZCgnLS1waXhlbC10ZXN0cycpCisgICAgICAgIGlmIHNlbGYuX3BvcnQuZ2V0X29wdGlvbignZ2Nf YmV0d2Vlbl90ZXN0cycpOgorICAgICAgICAgICAgY21kLmFwcGVuZCgnLS1nYy1iZXR3ZWVuLXRl c3RzJykKKyAgICAgICAgaWYgc2VsZi5fcG9ydC5nZXRfb3B0aW9uKCdjb21wbGV4X3RleHQnKToK KyAgICAgICAgICAgIGNtZC5hcHBlbmQoJy0tY29tcGxleC10ZXh0JykKKyAgICAgICAgaWYgc2Vs Zi5fcG9ydC5nZXRfb3B0aW9uKCd0aHJlYWRlZCcpOgorICAgICAgICAgICAgY21kLmFwcGVuZCgn LS10aHJlYWRlZCcpCisKICAgICAgICAgY21kLmV4dGVuZChzZWxmLl9wb3J0LmdldF9vcHRpb24o J2FkZGl0aW9uYWxfZHJ0X2ZsYWcnLCBbXSkpCiAgICAgICAgIGNtZC5hcHBlbmQoJy0nKQogICAg ICAgICByZXR1cm4gY21kCg==