<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>59562</bug_id>
          
          <creation_ts>2011-04-26 16:59:59 -0700</creation_ts>
          <short_desc>new-run-webkit-tests should disable/enable spindump on mac</short_desc>
          <delta_ts>2012-07-13 17:10:35 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.6</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>NRWT</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>64491</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Stephanie Lewis">slewis</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>dpranke</cc>
    
    <cc>slewis</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>393106</commentid>
    <comment_count>0</comment_count>
    <who name="Stephanie Lewis">slewis</who>
    <bug_when>2011-04-26 16:59:59 -0700</bug_when>
    <thetext>new-run-webkit-tests should disable/enable spindump on mac.  It can hog the available memory and cpu

to disable:
sudo launchctl unload -w /System/Library/LaunchDaemons/com.apple.spindump.plist
sudo launchctl unload -w /System/Library/LaunchDaemons/com.apple.spindump_symbolicator.plist 
sudo launchctl load -w /System/Library/LaunchDaemons/com.apple.spindump_starter.plist 

to enable:
sudo launchctl load -w /System/Library/LaunchDaemons/com.apple.spindump.plist
sudo launchctl load -w /System/Library/LaunchDaemons/com.apple.spindump_symbolicator.plist 
sudo launchctl load -w /System/Library/LaunchDaemons/com.apple.spindump_starter.plist</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>651942</commentid>
    <comment_count>1</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-06-18 18:08:37 -0700</bug_when>
    <thetext>hm. Sorry for not looking at this before now ... 

This is a problematic idea for me, since sudo would prompt for passwords and hence presumably cause problems on the bots, unless the commands were specially treated in sudoers.

Unless there&apos;s another way to solve this, the best I can come up with is to add a --disable-spindump flag that would do this only on request, but I&apos;m not sure if that&apos;s really better than just doing this yourself in a wrapper script around new-run-webkit-tests.

WDYT?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652880</commentid>
    <comment_count>2</comment_count>
    <who name="Stephanie Lewis">slewis</who>
    <bug_when>2012-06-19 15:23:43 -0700</bug_when>
    <thetext>For the bots it would probably just be easier for each bot to disable spindump permanently (there&apos;s a good chance we already do this on the mac bots).  

I was thinking more of people running the tests on their machines.  Spindump, when it gets going, can dramatically reduce performance particularly when symbolicating custom builds.  I haven&apos; t tested it recently so I should get some numbers on cpu usage on a recent build.

I don&apos;t like the idea of a wrapper, it seems like it would add an extra layer of complexity for a small benefit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652895</commentid>
    <comment_count>3</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-06-19 15:45:40 -0700</bug_when>
    <thetext>maybe we should add a separate script for enabling/disabling spindump so people can run it when they want?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>669606</commentid>
    <comment_count>4</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-07-13 17:10:35 -0700</bug_when>
    <thetext>I&apos;m going to close this as WONTFIX, since I don&apos;t see a good way of doing this without prompting for passwords, and I don&apos;t think that&apos;s a good idea. Let me know if you disagree.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>