59482 2011-04-26 12:08:37 -0700 Unused but set variable warning in MacroAssemberX86_64 2011-05-04 01:22:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 59568 1 xan.lopez xan.lopez abarth commit-queue dbates eric menard webkit.review.bot xan.lopez oldest_to_newest 392626 0 xan.lopez 2011-04-26 12:08:37 -0700 ../../Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h: In member function ‘JSC::AbstractMacroAssembler<JSC::X86Assembler>::Call JSC::MacroAssemblerX86_64::call()’: ../../Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:118:22: warning: variable ‘label’ set but not used [-Wunused-but-set-variable] ../../Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h: In member function ‘JSC::AbstractMacroAssembler<JSC::X86Assembler>::Call JSC::MacroAssemblerX86_64::tailRecursiveCall()’: ../../Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:126:22: warning: variable ‘label’ set but not used [-Wunused-but-set-variable] ../../Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h: In member function ‘JSC::AbstractMacroAssembler<JSC::X86Assembler>::Call JSC::MacroAssemblerX86_64::makeTailRecursiveCall(JSC::AbstractMacroAssembler<JSC::X86Assembler>::Jump)’: ../../Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:135:22: warning: variable ‘label’ set but not used [-Wunused-but-set-variable] CXX Source/JavaScriptCore/runtime/libJavaScriptCore_la-JSLock.lo CXX Source/JavaScriptCore/runtime/libJavaScriptCore_la-JSNotAnObject.lo ../../Source/JavaScriptCore/runtime/JSLock.cpp: In static member function ‘static void JSC::JSLock::lock(JSC::JSLockBehavior)’: ../../Source/JavaScriptCore/runtime/JSLock.cpp:91:13: warning: variable ‘result’ set but not used [-Wunused-but-set-variable] ../../Source/JavaScriptCore/runtime/JSLock.cpp: In static member function ‘static void JSC::JSLock::unlock(JSC::JSLockBehavior)’: ../../Source/JavaScriptCore/runtime/JSLock.cpp:111:13: warning: variable ‘result’ set but not used [-Wunused-but-set-variable] Trivial patch coming. 392628 1 91143 xan.lopez 2011-04-26 12:10:50 -0700 Created attachment 91143 Patch 392984 2 91143 dbates 2011-04-26 16:22:18 -0700 Comment on attachment 91143 Patch I wish there was a better way we could do this. This looks sane to me. 393019 3 91143 xan.lopez 2011-04-26 16:32:10 -0700 Comment on attachment 91143 Patch Landed as r84977. 393021 4 xan.lopez 2011-04-26 16:32:21 -0700 Closing. 393171 5 webkit.review.bot 2011-04-26 17:23:41 -0700 http://trac.webkit.org/changeset/84977 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: accessibility/anchor-linked-anonymous-block-crash.html accessibility/aria-activedescendant-crash.html accessibility/aria-checkbox-checked.html accessibility/aria-checkbox-text.html accessibility/aria-combobox.html accessibility/aria-controls-with-tabs.html accessibility/aria-describedby-on-input.html accessibility/aria-disabled.html accessibility/aria-help.html accessibility/aria-hidden-update.html accessibility/aria-hidden-with-elements.html accessibility/aria-hidden.html accessibility/aria-label.html accessibility/aria-labelledby-on-input.html accessibility/aria-labelledby-overrides-label.html accessibility/aria-labelledby-stay-within.html accessibility/aria-link-supports-press.html accessibility/aria-list-and-listitem.html accessibility/aria-option-role.html accessibility/aria-presentational-role.html 393262 6 dbates 2011-04-26 18:48:35 -0700 This patch was rolled out in <http://trac.webkit.org/changeset/85000> (bug #59568). 393361 7 91234 xan.lopez 2011-04-26 22:43:00 -0700 Created attachment 91234 Patch 393362 8 xan.lopez 2011-04-26 22:46:12 -0700 OK, that was obviously broken. Unfortunately we even need an even slightly uglier patch here... I wonder if there's a way of flagging a variable as unused, we could do that for release builds here. Maybe just (void)var;, like ASSERT_UNUSED, but without using the macro because we need it in NDEBUG. 396057 9 91234 eric 2011-05-01 14:51:05 -0700 Comment on attachment 91234 Patch We have an UNUSED() macro for this, no? 397223 10 92095 menard 2011-05-03 11:36:58 -0700 Created attachment 92095 Patch 397227 11 92095 eric 2011-05-03 11:39:04 -0700 Comment on attachment 92095 Patch OK. 397706 12 92095 commit-queue 2011-05-03 23:09:00 -0700 Comment on attachment 92095 Patch Clearing flags on attachment: 92095 Committed r85718: <http://trac.webkit.org/changeset/85718> 397707 13 commit-queue 2011-05-03 23:09:07 -0700 All reviewed patches have been landed. Closing bug. 397738 14 commit-queue 2011-05-04 01:22:18 -0700 The commit-queue encountered the following flaky tests while processing attachment 92095: http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 33357 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 91143 2011-04-26 12:10:50 -0700 2011-04-26 16:32:10 -0700 Patch bug-59482-20110426121049.patch text/plain 2422 xan.lopez U3VidmVyc2lvbiBSZXZpc2lvbjogODQ5MzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGIz NTQyYjFlNmQ2NzlkNTIzMThlZGU0NjczNzVhNjdjNzUzNTVkNTguLjJjNzEzNjQwZjNkMWYzYTA4 MDJjNjlkM2UwYjJmYjYzMzA3OTExNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMiw2 ICsyLDE5IEBACiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAKKyAgICAg ICAgVW51c2VkIGJ1dCBzZXQgdmFyaWFibGUgd2FybmluZyBpbiBNYWNyb0Fzc2VtYmVsWDg2XzY0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTQ4Mgor CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2XzY0Lmg6CisgICAgICAgIChK U0M6Ok1hY3JvQXNzZW1ibGVyWDg2XzY0OjpjYWxsKTogZG8gbm90IGRlY2xhcmUgdGhlIGxhYmVs CisgICAgICAgIHZhcmlhYmxlIGlmIHdlIGFyZSBub3QgZ29pbmcgdG8gdXNlIGl0LgorICAgICAg ICAoSlNDOjpNYWNyb0Fzc2VtYmxlclg4Nl82NDo6dGFpbFJlY3Vyc2l2ZUNhbGwpOiBkaXR0by4K KyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJYODZfNjQ6Om1ha2VUYWlsUmVjdXJzaXZlQ2Fs bCk6IGRpdHRvLgorCisyMDExLTA0LTI2ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBMb3NzIG9m IHByZWNpc3Npb24gZXJyb3JzIHRocm91Z2hvdXQgdGhlIGNvZGViYXNlIHNwb3R0ZWQgYnkgR0ND IDQuNgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk0 NzcKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlclg4Nl82NC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlclg4Nl82NC5oCmluZGV4IDkwNzEwMzAyY2Q5Yzk2ZWRmZjg0MzI5NDk2ZDI0NGRhYzhj OTFiNmIuLjU4MjJhYTVkNzBjYzFlZTMyNDcxZDU2MDk4MzhkZGRjOWFmZTI1YTEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZfNjQu aAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2 XzY0LmgKQEAgLTExNSw3ICsxMTUsOSBAQCBwdWJsaWM6CiAKICAgICBDYWxsIGNhbGwoKQogICAg IHsKKyNpZm5kZWYgTkRFQlVHCiAgICAgICAgIERhdGFMYWJlbFB0ciBsYWJlbCA9IG1vdmVXaXRo UGF0Y2goVHJ1c3RlZEltbVB0cigwKSwgc2NyYXRjaFJlZ2lzdGVyKTsKKyNlbmRpZgogICAgICAg ICBDYWxsIHJlc3VsdCA9IENhbGwobV9hc3NlbWJsZXIuY2FsbChzY3JhdGNoUmVnaXN0ZXIpLCBD YWxsOjpMaW5rYWJsZSk7CiAgICAgICAgIEFTU0VSVChkaWZmZXJlbmNlQmV0d2VlbihsYWJlbCwg cmVzdWx0KSA9PSBSRVBUQUNIX09GRlNFVF9DQUxMX1IxMSk7CiAgICAgICAgIHJldHVybiByZXN1 bHQ7CkBAIC0xMjMsNyArMTI1LDkgQEAgcHVibGljOgogCiAgICAgQ2FsbCB0YWlsUmVjdXJzaXZl Q2FsbCgpCiAgICAgeworI2lmbmRlZiBOREVCVUcKICAgICAgICAgRGF0YUxhYmVsUHRyIGxhYmVs ID0gbW92ZVdpdGhQYXRjaChUcnVzdGVkSW1tUHRyKDApLCBzY3JhdGNoUmVnaXN0ZXIpOworI2Vu ZGlmCiAgICAgICAgIEp1bXAgbmV3SnVtcCA9IEp1bXAobV9hc3NlbWJsZXIuam1wX3Ioc2NyYXRj aFJlZ2lzdGVyKSk7CiAgICAgICAgIEFTU0VSVChkaWZmZXJlbmNlQmV0d2VlbihsYWJlbCwgbmV3 SnVtcCkgPT0gUkVQVEFDSF9PRkZTRVRfQ0FMTF9SMTEpOwogICAgICAgICByZXR1cm4gQ2FsbDo6 ZnJvbVRhaWxKdW1wKG5ld0p1bXApOwpAQCAtMTMyLDcgKzEzNiw5IEBAIHB1YmxpYzoKICAgICBD YWxsIG1ha2VUYWlsUmVjdXJzaXZlQ2FsbChKdW1wIG9sZEp1bXApCiAgICAgewogICAgICAgICBv bGRKdW1wLmxpbmsodGhpcyk7CisjaWZuZGVmIE5ERUJVRwogICAgICAgICBEYXRhTGFiZWxQdHIg bGFiZWwgPSBtb3ZlV2l0aFBhdGNoKFRydXN0ZWRJbW1QdHIoMCksIHNjcmF0Y2hSZWdpc3Rlcik7 CisjZW5kaWYKICAgICAgICAgSnVtcCBuZXdKdW1wID0gSnVtcChtX2Fzc2VtYmxlci5qbXBfcihz Y3JhdGNoUmVnaXN0ZXIpKTsKICAgICAgICAgQVNTRVJUKGRpZmZlcmVuY2VCZXR3ZWVuKGxhYmVs LCBuZXdKdW1wKSA9PSBSRVBUQUNIX09GRlNFVF9DQUxMX1IxMSk7CiAgICAgICAgIHJldHVybiBD YWxsOjpmcm9tVGFpbEp1bXAobmV3SnVtcCk7Cg== 91234 2011-04-26 22:43:00 -0700 2011-05-03 11:36:52 -0700 Patch bug-59482-20110426224246.patch text/plain 2615 xan.lopez U3VidmVyc2lvbiBSZXZpc2lvbjogODUwMTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDlh Mjk3NDdhZDgxMTJjNTYyM2U0NWM2Y2I2OGQ3OWM4NWZkYzA1OWMuLjk0ZDYwYTA2ZTAzNGE0NTg4 MmQ0OWYxN2JiN2ZmNWY4YTIwMjNlYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDExLTA0LTI2ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbnVzZWQgYnV0 IHNldCB2YXJpYWJsZSB3YXJuaW5nIGluIE1hY3JvQXNzZW1iZWxYODZfNjQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5NDgyCisKKyAgICAgICAgKiBh c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZfNjQuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3Nl bWJsZXJYODZfNjQ6OmNhbGwpOiBkbyBub3QgZGVjbGFyZSB0aGUgbGFiZWwKKyAgICAgICAgdmFy aWFibGUgaWYgd2UgYXJlIG5vdCBnb2luZyB0byB1c2UgaXQuCisgICAgICAgIChKU0M6Ok1hY3Jv QXNzZW1ibGVyWDg2XzY0Ojp0YWlsUmVjdXJzaXZlQ2FsbCk6IGRpdHRvLgorICAgICAgICAoSlND OjpNYWNyb0Fzc2VtYmxlclg4Nl82NDo6bWFrZVRhaWxSZWN1cnNpdmVDYWxsKTogZGl0dG8uCisK IDIwMTEtMDQtMjYgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI4NDk3Ny4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZfNjQuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZfNjQuaAppbmRl eCA5MDcxMDMwMmNkOWM5NmVkZmY4NDMyOTQ5NmQyNDRkYWM4YzkxYjZiLi5iMjJhNzlkMWVlNWJl MThhMzNmZmZkYzk4NThlMzI2YjI3NThiMzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2XzY0LmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4Nl82NC5oCkBAIC0xMTUsNyArMTE1 LDEwIEBAIHB1YmxpYzoKIAogICAgIENhbGwgY2FsbCgpCiAgICAgewotICAgICAgICBEYXRhTGFi ZWxQdHIgbGFiZWwgPSBtb3ZlV2l0aFBhdGNoKFRydXN0ZWRJbW1QdHIoMCksIHNjcmF0Y2hSZWdp c3Rlcik7CisjaWZuZGVmIE5ERUJVRworICAgICAgICBEYXRhTGFiZWxQdHIgbGFiZWwgPQorI2Vu ZGlmCisgICAgICAgIG1vdmVXaXRoUGF0Y2goVHJ1c3RlZEltbVB0cigwKSwgc2NyYXRjaFJlZ2lz dGVyKTsKICAgICAgICAgQ2FsbCByZXN1bHQgPSBDYWxsKG1fYXNzZW1ibGVyLmNhbGwoc2NyYXRj aFJlZ2lzdGVyKSwgQ2FsbDo6TGlua2FibGUpOwogICAgICAgICBBU1NFUlQoZGlmZmVyZW5jZUJl dHdlZW4obGFiZWwsIHJlc3VsdCkgPT0gUkVQVEFDSF9PRkZTRVRfQ0FMTF9SMTEpOwogICAgICAg ICByZXR1cm4gcmVzdWx0OwpAQCAtMTIzLDcgKzEyNiwxMCBAQCBwdWJsaWM6CiAKICAgICBDYWxs IHRhaWxSZWN1cnNpdmVDYWxsKCkKICAgICB7Ci0gICAgICAgIERhdGFMYWJlbFB0ciBsYWJlbCA9 IG1vdmVXaXRoUGF0Y2goVHJ1c3RlZEltbVB0cigwKSwgc2NyYXRjaFJlZ2lzdGVyKTsKKyNpZm5k ZWYgTkRFQlVHCisgICAgICAgIERhdGFMYWJlbFB0ciBsYWJlbCA9CisjZW5kaWYKKyAgICAgICAg bW92ZVdpdGhQYXRjaChUcnVzdGVkSW1tUHRyKDApLCBzY3JhdGNoUmVnaXN0ZXIpOwogICAgICAg ICBKdW1wIG5ld0p1bXAgPSBKdW1wKG1fYXNzZW1ibGVyLmptcF9yKHNjcmF0Y2hSZWdpc3Rlcikp OwogICAgICAgICBBU1NFUlQoZGlmZmVyZW5jZUJldHdlZW4obGFiZWwsIG5ld0p1bXApID09IFJF UFRBQ0hfT0ZGU0VUX0NBTExfUjExKTsKICAgICAgICAgcmV0dXJuIENhbGw6OmZyb21UYWlsSnVt cChuZXdKdW1wKTsKQEAgLTEzMiw3ICsxMzgsMTAgQEAgcHVibGljOgogICAgIENhbGwgbWFrZVRh aWxSZWN1cnNpdmVDYWxsKEp1bXAgb2xkSnVtcCkKICAgICB7CiAgICAgICAgIG9sZEp1bXAubGlu ayh0aGlzKTsKLSAgICAgICAgRGF0YUxhYmVsUHRyIGxhYmVsID0gbW92ZVdpdGhQYXRjaChUcnVz dGVkSW1tUHRyKDApLCBzY3JhdGNoUmVnaXN0ZXIpOworI2lmbmRlZiBOREVCVUcKKyAgICAgICAg RGF0YUxhYmVsUHRyIGxhYmVsID0KKyNlbmRpZgorICAgICAgICBtb3ZlV2l0aFBhdGNoKFRydXN0 ZWRJbW1QdHIoMCksIHNjcmF0Y2hSZWdpc3Rlcik7CiAgICAgICAgIEp1bXAgbmV3SnVtcCA9IEp1 bXAobV9hc3NlbWJsZXIuam1wX3Ioc2NyYXRjaFJlZ2lzdGVyKSk7CiAgICAgICAgIEFTU0VSVChk aWZmZXJlbmNlQmV0d2VlbihsYWJlbCwgbmV3SnVtcCkgPT0gUkVQVEFDSF9PRkZTRVRfQ0FMTF9S MTEpOwogICAgICAgICByZXR1cm4gQ2FsbDo6ZnJvbVRhaWxKdW1wKG5ld0p1bXApOwo= 92095 2011-05-03 11:36:58 -0700 2011-05-03 23:09:00 -0700 Patch bug-59482-20110503153700.patch text/plain 2255 menard SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODU2MjYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDUtMDMgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW51c2Vk IGJ1dCBzZXQgdmFyaWFibGUgd2FybmluZyBpbiBNYWNyb0Fzc2VtYmVyWDg2XzY0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTQ4MgorCisgICAgICAg ICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2XzY0Lmg6CisgICAgICAgIChKU0M6Ok1hY3Jv QXNzZW1ibGVyWDg2XzY0OjpjYWxsKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJYODZf NjQ6OnRhaWxSZWN1cnNpdmVDYWxsKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJYODZf NjQ6Om1ha2VUYWlsUmVjdXJzaXZlQ2FsbCk6CisKIDIwMTEtMDUtMDMgIFhhbiBMb3BleiAgPHhs b3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4K SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZf NjQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyWDg2XzY0LmgJKHJldmlzaW9uIDg1NjIyKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4Nl82NC5oCSh3b3JraW5nIGNvcHkpCkBAIC0x MTcsNyArMTE3LDcgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgRGF0YUxhYmVsUHRyIGxhYmVs ID0gbW92ZVdpdGhQYXRjaChUcnVzdGVkSW1tUHRyKDApLCBzY3JhdGNoUmVnaXN0ZXIpOwogICAg ICAgICBDYWxsIHJlc3VsdCA9IENhbGwobV9hc3NlbWJsZXIuY2FsbChzY3JhdGNoUmVnaXN0ZXIp LCBDYWxsOjpMaW5rYWJsZSk7Ci0gICAgICAgIEFTU0VSVChkaWZmZXJlbmNlQmV0d2VlbihsYWJl bCwgcmVzdWx0KSA9PSBSRVBUQUNIX09GRlNFVF9DQUxMX1IxMSk7CisgICAgICAgIEFTU0VSVF9V TlVTRUQobGFiZWwsIGRpZmZlcmVuY2VCZXR3ZWVuKGxhYmVsLCByZXN1bHQpID09IFJFUFRBQ0hf T0ZGU0VUX0NBTExfUjExKTsKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9CiAKQEAgLTEy NSw3ICsxMjUsNyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICBEYXRhTGFiZWxQdHIgbGFiZWwg PSBtb3ZlV2l0aFBhdGNoKFRydXN0ZWRJbW1QdHIoMCksIHNjcmF0Y2hSZWdpc3Rlcik7CiAgICAg ICAgIEp1bXAgbmV3SnVtcCA9IEp1bXAobV9hc3NlbWJsZXIuam1wX3Ioc2NyYXRjaFJlZ2lzdGVy KSk7Ci0gICAgICAgIEFTU0VSVChkaWZmZXJlbmNlQmV0d2VlbihsYWJlbCwgbmV3SnVtcCkgPT0g UkVQVEFDSF9PRkZTRVRfQ0FMTF9SMTEpOworICAgICAgICBBU1NFUlRfVU5VU0VEKGxhYmVsLCBk aWZmZXJlbmNlQmV0d2VlbihsYWJlbCwgbmV3SnVtcCkgPT0gUkVQVEFDSF9PRkZTRVRfQ0FMTF9S MTEpOwogICAgICAgICByZXR1cm4gQ2FsbDo6ZnJvbVRhaWxKdW1wKG5ld0p1bXApOwogICAgIH0K IApAQCAtMTM0LDcgKzEzNCw3IEBAIHB1YmxpYzoKICAgICAgICAgb2xkSnVtcC5saW5rKHRoaXMp OwogICAgICAgICBEYXRhTGFiZWxQdHIgbGFiZWwgPSBtb3ZlV2l0aFBhdGNoKFRydXN0ZWRJbW1Q dHIoMCksIHNjcmF0Y2hSZWdpc3Rlcik7CiAgICAgICAgIEp1bXAgbmV3SnVtcCA9IEp1bXAobV9h c3NlbWJsZXIuam1wX3Ioc2NyYXRjaFJlZ2lzdGVyKSk7Ci0gICAgICAgIEFTU0VSVChkaWZmZXJl bmNlQmV0d2VlbihsYWJlbCwgbmV3SnVtcCkgPT0gUkVQVEFDSF9PRkZTRVRfQ0FMTF9SMTEpOwor ICAgICAgICBBU1NFUlRfVU5VU0VEKGxhYmVsLCBkaWZmZXJlbmNlQmV0d2VlbihsYWJlbCwgbmV3 SnVtcCkgPT0gUkVQVEFDSF9PRkZTRVRfQ0FMTF9SMTEpOwogICAgICAgICByZXR1cm4gQ2FsbDo6 ZnJvbVRhaWxKdW1wKG5ld0p1bXApOwogICAgIH0KIAo=