59480 2011-04-26 12:05:04 -0700 InlineBox.h shouldn't include RenderBR.h 2011-04-26 14:22:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mihaip mihaip commit-queue eric thakis oldest_to_newest 392621 0 mihaip 2011-04-26 12:05:04 -0700 InlineBox.h shouldn't include RenderBR.h 392623 1 91141 mihaip 2011-04-26 12:06:41 -0700 Created attachment 91141 Patch 392645 2 thakis 2011-04-26 13:05:15 -0700 Cool! You could add something like "this reduces the size of InlineBox.h by XXX kB" to the ChangeLog entry. You get the XXX from eric's script attached to bug 59348. 392683 3 mihaip 2011-04-26 14:06:50 -0700 Before: Source/WebCore/rendering/InlineBox.h: 0.917 247 226.499000 (from bug 59348) After: Source/WebCore/rendering/InlineBox.h: 0.906 247 223.782000 So it's only 11K in the .h file, and 3MB across all the includes? 392686 4 thakis 2011-04-26 14:11:43 -0700 Looks like it. Probably because InlineBox.h and RenderBR.h include similar files. :-/ 392709 5 91141 commit-queue 2011-04-26 14:22:07 -0700 Comment on attachment 91141 Patch Clearing flags on attachment: 91141 Committed r84956: <http://trac.webkit.org/changeset/84956> 392710 6 commit-queue 2011-04-26 14:22:12 -0700 All reviewed patches have been landed. Closing bug. 91141 2011-04-26 12:06:41 -0700 2011-04-26 14:22:07 -0700 Patch bug-59480-20110426120639.patch text/plain 2175 mihaip U3VidmVyc2lvbiBSZXZpc2lvbjogODQ5MTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NDMwNmFjZWVkNzlmNjQw MWFkZTFkNWM5Yzc1NzFlYTc0MWUxMjc0Li42ZWZiNjk0N2JjMTE4NDYwYWZhYzA3N2M5NTZjZjY4 MmExNTg1YTUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMjYgIE1paGFp IFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5saW5lQm94Lmggc2hvdWxkbid0IGluY2x1ZGUg UmVuZGVyQlIuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTk0ODAKKworICAgICAgICBQZXIgYnVnIDU5MzQ4IFJlbmRlckJSLmggaXMgYSAidG9wIGhl YWRlciIgYnkgaW5jbHVkZSAqIHNpemUsIGJlY2F1c2UKKyAgICAgICAgSW5saW5lQm94LmggaW5j bHVkZXMgaXQuIFRoZXJlJ3Mgbm8gcmVhc29uIHdoeSBpdCBoYXMgdG8uCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvSW5saW5lQm94Lmg6CisgICAgICAgICogcmVuZGVyaW5nL0lubGluZVRleHRCb3gu Y3BwOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5oOgorCiAyMDExLTA0LTI2ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh biBCZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5l Qm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmgKaW5kZXggODk4OWE3 Nzk3ODc0ZGYzZmYwODRhNmZhNWE1MmE4MzcwMjZiMmYyMC4uZTk2YTEyNmEwY2YyZTY4ZDc4OWU2 Nzg4MDM4OTZiY2I2MGQxYmFjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L0lubGluZUJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guaApA QCAtMjEsNyArMjEsNiBAQAogI2lmbmRlZiBJbmxpbmVCb3hfaAogI2RlZmluZSBJbmxpbmVCb3hf aAogCi0jaW5jbHVkZSAiUmVuZGVyQlIuaCIKICNpbmNsdWRlICJSZW5kZXJCb3hNb2RlbE9iamVj dC5oIgogI2luY2x1ZGUgIlRleHREaXJlY3Rpb24uaCIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL0lubGluZVRleHRCb3guY3BwCmluZGV4IGZjMzlhOWZhOWI3OGY2MjZiNDI4OTZkOTZiOTRi N2E2ZjhjNWEwMmUuLjQ1NzMzZjk1NmZlMGQ5MmE0ZjBiMTUyNzg1YzdkNGJmOGI0YzA0MmUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHAKQEAgLTM1LDYgKzM1 LDcgQEAKICNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVkZSAiUGFpbnRJbmZvLmgiCiAjaW5jbHVk ZSAiUmVuZGVyQXJlbmEuaCIKKyNpbmNsdWRlICJSZW5kZXJCUi5oIgogI2luY2x1ZGUgIlJlbmRl ckJsb2NrLmgiCiAjaW5jbHVkZSAiUmVuZGVyQ29tYmluZVRleHQuaCIKICNpbmNsdWRlICJSZW5k ZXJSdWJ5UnVuLmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QmxvY2suaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCmluZGV4IDc1 ZDkzZTk5ZGI3ZDA1MmE4ZTQ1M2FiZWFlOTllYzhkMTE1YTU3ZWQuLjcxNzY5NTgwODM2ZTkwNzIy N2UzY2M3MDk1Mzg3OWJmZWUxZDE1ZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9jay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC bG9jay5oCkBAIC0zOSw2ICszOSw3IEBAIGNsYXNzIExheW91dFN0YXRlTWFpbnRhaW5lcjsKIGNs YXNzIExhenlMaW5lQnJlYWtJdGVyYXRvcjsKIGNsYXNzIExpbmVXaWR0aDsKIGNsYXNzIFJlbmRl cklubGluZTsKK2NsYXNzIFJlbmRlclRleHQ7CiAKIHN0cnVjdCBCaWRpUnVuOwogc3RydWN0IFBh aW50SW5mbzsK