59475 2011-04-26 11:38:43 -0700 AnimationBase asserts if a test tries to pause during the delay phase 2011-07-18 09:16:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser webkit-unassigned cmarrin dino joybro201 simon.fraser webkit.review.bot oldest_to_newest 392596 0 91132 simon.fraser 2011-04-26 11:38:43 -0700 Created attachment 91132 Test I hit an assert at WebCore::AnimationBase::freezeAtTime(double) + 158 (AnimationBase.cpp:1381) with the test that will be attached. 392616 1 simon.fraser 2011-04-26 12:00:52 -0700 m_startTime is still 0 if the transition is in the delay phase. 393654 2 cmarrin 2011-04-27 10:56:38 -0700 Looking at the code, this only happens when using the pause API from DRT (or from embedding apps). The play-state property doesn't go through this code path, so there's no way to generate this error with content. 393660 3 simon.fraser 2011-04-27 11:05:41 -0700 Right, the bug was failed about DRT. This bug prevents me from converting some time-consuming delay-related tests to use the pause API. 435683 4 100494 joybro201 2011-07-12 08:59:57 -0700 Created attachment 100494 Patch 435710 5 100494 dino 2011-07-12 10:10:22 -0700 Comment on attachment 100494 Patch This looks good to me. You might want to add an animation test for completeness. I can't wait until this API is improved. 436457 6 joybro201 2011-07-13 08:41:57 -0700 (In reply to comment #5) > (From update of attachment 100494 [details]) > This looks good to me. You might want to add an animation test for completeness. > > I can't wait until this API is improved. Thanks, Dean. I found a problem in following your advice(making an animation test). I'm afraid this patch does not work in an animation case. When an animation is in its delay phase, it should not affect its intrinsic style[1], but this patch is returning the start value of the animation. This is not a regression of this patch, as it is reproducible now. I'd like to fix this problem in another bug because this bug's title is so far away from the above animation bug, if you agree. [1] http://www.w3.org/TR/css3-animations/#animation-behavior- 438513 7 100494 webkit.review.bot 2011-07-18 09:16:30 -0700 Comment on attachment 100494 Patch Clearing flags on attachment: 100494 Committed r91187: <http://trac.webkit.org/changeset/91187> 438514 8 webkit.review.bot 2011-07-18 09:16:35 -0700 All reviewed patches have been landed. Closing bug. 91132 2011-04-26 11:38:43 -0700 2011-04-26 11:38:43 -0700 Test transition-shorthand-delay.html text/html 1063 simon.fraser PCFET0NUWVBFIGh0bWw+Cgo8aHRtbD4KPGhlYWQ+CiAgPHN0eWxlPgogICAgYm9keSB7CiAgICAg IG1hcmdpbjogMDsKICAgIH0KICAgIAogICAgZGl2IHsKICAgICAgcG9zaXRpb246IHJlbGF0aXZl OwogICAgICBsZWZ0OiAxMDBweDsKICAgICAgaGVpZ2h0OiA1MHB4OwogICAgICB3aWR0aDogNTBw eDsKICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CiAgICAgIC13ZWJraXQtdHJhbnNpdGlv bjogbGVmdCA0cyBsaW5lYXIgMXM7CiAgICB9CiAgICAKICAgIC5tb3ZlZCB7CiAgICAgIGxlZnQ6 IDIwMHB4OwogICAgfQogICA8L3N0eWxlPgogICA8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3RyYW5z aXRpb24tdGVzdC1oZWxwZXJzLmpzIj48L3NjcmlwdD4KICAgPHNjcmlwdD4KICAgICBjb25zdCBl eHBlY3RlZFZhbHVlcyA9IFsKICAgICAgIC8vIFt0aW1lLCBlbGVtZW50LWlkLCBwcm9wZXJ0eSwg ZXhwZWN0ZWQtdmFsdWUsIHRvbGVyYW5jZV0KICAgICAgIFswLjUsICJ0YXJnZXQiLCAibGVmdCIs IDEyNSwgNF0sCiAgICAgXTsKCiAgICAgZnVuY3Rpb24gc2V0dXBUZXN0KCkKICAgICB7CiAgICAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0IikuY2xhc3NOYW1lID0gIm1vdmVkIjsK ICAgICB9CgogICAgIHJ1blRyYW5zaXRpb25UZXN0KGV4cGVjdGVkVmFsdWVzLCBzZXR1cFRlc3Qs IHVzZVBhdXNlQVBJKTsKICAgPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHk+CiAgPGgxPlRlc3QgZm9y IHRyYW5zaXRpb24gc2hvcnRoYW5kPC9oMT4KCiAgPHA+VGhpcyB0ZXN0IHdvcmtzIG9ubHkgaW4g RHVtcFJlbmRlclRyZWUuIEl0IHVzZXMgYW4gQVBJIGV4cG9zZWQKICAgIG9ubHkgdGhlcmUgdG8g anVtcCB0byBhIHBhcnRpY3VsYXIgdGltZSBpbiBhIHJ1bm5pbmcgdHJhbnNpdGlvbi4KICAgIFRl c3RzIGJ1ZyA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjEyNDciPjIxMjQ3PC9hPgogIDwvcD4KCiAgPGRpdiBpZD0idGFyZ2V0Ij48L2Rpdj4KICA8ZGl2 IGlkPSJyZXN1bHQiPjwvZGl2PgoKPC9ib2R5Pgo8L2h0bWw+Cg== 100494 2011-07-12 08:59:57 -0700 2011-07-18 09:16:30 -0700 Patch bug-59475-20110713005955.patch text/plain 4748 joybro201 U3VidmVyc2lvbiBSZXZpc2lvbjogOTA4MTEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyMDE1YjlkMzY3NzRmODQzMjMwZWVl OTM4ZDExNDczOWQ4MzU5N2Q3Li41MmYzNWZmNjAzMmQyZWViMDc2YTQwMjdiMzNlODU3MzFjNDdh YzVjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMTIgIFlvdW5nIEhhbiBMZWUgIDxq b3licm9AY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgQW5pbWF0aW9uQmFzZSBhc3NlcnRzIGlm IGEgdGVzdCB0cmllcyB0byBwYXVzZSBkdXJpbmcgdGhlIGRlbGF5IHBoYXNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTQ3NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIG5vIG1vcmUgYXNz ZXJ0aW9uIGZhaWx1cmUgYWZ0ZXIgcjkwNzY1LCBidXQgdGhlIHRlc3RjYXNlIHN0aWxsIGZhaWxz IGR1ZSB0bworICAgICAgICB0aGUgbWlzY2FsY3VsYXRpb24gb2YgdGhlIHBhdXNlVGltZS4gVGhp cyBwYXRjaCBwYXVzZXMgdGhlIGFuaW1hdGlvbiBhdCBpdHMgc3RhcnRUaW1lCisgICAgICAgIGlm IGEgdGVzdCB0cmllcyB0byBwYXVzZSBpdCBkdXJpbmcgdGhlIGRlbGF5IHBoYXNlLgorCisgICAg ICAgICogdHJhbnNpdGlvbnMvdHJhbnNpdGlvbi1pbi1kZWxheS1waGFzZS1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIHRyYW5zaXRpb25zL3RyYW5zaXRpb24taW4tZGVsYXktcGhhc2Uu aHRtbDogQWRkZWQuCisKIDIwMTEtMDctMTIgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3Jn PgogCiAgICAgICAgIFtRdF0gTlJXVCBzaG91bGQgcGljayB1cCB0aGUgcmlnaHQgaHR0cGQgY29u ZmlnIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24t aW4tZGVsYXktcGhhc2UtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMvdHJh bnNpdGlvbi1pbi1kZWxheS1waGFzZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjMzZDFjNWQx YjUzMTM1NWY4YzM5MzE0MjIyODIzMjMzZmU2MTlkZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24taW4tZGVsYXktcGhhc2UtZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsNiBAQAorVGVzdCBmb3IgdHJhbnNpdGlvbiBpbiBkZWxheSBwaGFzZQorCitU aGlzIHRlc3Qgd29ya3Mgb25seSBpbiBEdW1wUmVuZGVyVHJlZS4gSXQgdXNlcyBhbiBBUEkgZXhw b3NlZCBvbmx5IHRoZXJlIHRvIGp1bXAgdG8gYSBwYXJ0aWN1bGFyIHRpbWUgaW4gYSBydW5uaW5n IHRyYW5zaXRpb24uIFRlc3RzIGJ1ZyA1OTQ3NQorCitQQVNTIC0gImxlZnQiIHByb3BlcnR5IGZv ciAidGFyZ2V0IiBlbGVtZW50IGF0IDAuNXMgc2F3IHNvbWV0aGluZyBjbG9zZSB0bzogMTAwCisK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24taW4tZGVsYXkt cGhhc2UuaHRtbCBiL0xheW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24taW4tZGVsYXkt cGhhc2UuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kYTNkM2I3MzBhNmNjNDE4MTJmYzlmZWM0NWMzMjExNWI5 N2Y5NWU4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMvdHJhbnNp dGlvbi1pbi1kZWxheS1waGFzZS5odG1sCkBAIC0wLDAgKzEsNDQgQEAKKzxodG1sPgorPGhlYWQ+ CisgIDxzdHlsZT4KKyAgICBkaXYgeworICAgICAgcG9zaXRpb246IHJlbGF0aXZlOworICAgICAg bGVmdDogMTAwcHg7CisgICAgICBoZWlnaHQ6IDUwcHg7CisgICAgICB3aWR0aDogNTBweDsKKyAg ICAgIGJhY2tncm91bmQtY29sb3I6IGdyZWVuOworICAgICAgLXdlYmtpdC10cmFuc2l0aW9uOiBs ZWZ0IDRzIGxpbmVhciAxczsKKyAgICB9CisgICAgCisgICAgLm1vdmVkIHsKKyAgICAgIGxlZnQ6 IDIwMHB4OworICAgIH0KKyAgIDwvc3R5bGU+CisgICA8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3Ry YW5zaXRpb24tdGVzdC1oZWxwZXJzLmpzIj48L3NjcmlwdD4KKyAgIDxzY3JpcHQ+CisgICAgIGNv bnN0IGV4cGVjdGVkVmFsdWVzID0gWworICAgICAgIC8vIFt0aW1lLCBlbGVtZW50LWlkLCBwcm9w ZXJ0eSwgZXhwZWN0ZWQtdmFsdWUsIHRvbGVyYW5jZV0KKyAgICAgICBbMC41LCAidGFyZ2V0Iiwg ImxlZnQiLCAxMDAsIDRdLAorICAgICBdOworCisgICAgIGZ1bmN0aW9uIHNldHVwVGVzdCgpCisg ICAgIHsKKyAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0IikuY2xhc3NOYW1l ID0gIm1vdmVkIjsKKyAgICAgfQorCisgICAgIHJ1blRyYW5zaXRpb25UZXN0KGV4cGVjdGVkVmFs dWVzLCBzZXR1cFRlc3QsIHVzZVBhdXNlQVBJKTsKKyAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJv ZHk+CisgIDxoMT5UZXN0IGZvciB0cmFuc2l0aW9uIGluIGRlbGF5IHBoYXNlPC9oMT4KKworICA8 cD5UaGlzIHRlc3Qgd29ya3Mgb25seSBpbiBEdW1wUmVuZGVyVHJlZS4gSXQgdXNlcyBhbiBBUEkg ZXhwb3NlZAorICAgIG9ubHkgdGhlcmUgdG8ganVtcCB0byBhIHBhcnRpY3VsYXIgdGltZSBpbiBh IHJ1bm5pbmcgdHJhbnNpdGlvbi4KKyAgICBUZXN0cyBidWcgPGEgaHJlZj0iaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5NDc1Ij41OTQ3NTwvYT4KKyAgPC9wPgorCisg IDxkaXYgaWQ9InRhcmdldCI+PC9kaXY+CisgIDxkaXYgaWQ9InJlc3VsdCI+PC9kaXY+CisKKzwv Ym9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZjI2NjQzN2Q0MDFkNTBkYmI2NWNmMzIzMmNm ZTA4YzFiNDUyNTVmLi42NDUzZDIxY2VmMWNhYWE2NzExYWJjZmM0ZjViMmRhM2ZiN2E1NjZlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDctMTIgIFlvdW5nIEhhbiBMZWUgIDxq b3licm9AY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgQW5pbWF0aW9uQmFzZSBhc3NlcnRzIGlm IGEgdGVzdCB0cmllcyB0byBwYXVzZSBkdXJpbmcgdGhlIGRlbGF5IHBoYXNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTQ3NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIG5vIG1vcmUgYXNz ZXJ0aW9uIGZhaWx1cmUgYWZ0ZXIgcjkwNzY1LCBidXQgdGhlIHRlc3RjYXNlIHN0aWxsIGZhaWxz IGR1ZSB0bworICAgICAgICB0aGUgbWlzY2FsY3VsYXRpb24gb2YgdGhlIHBhdXNlVGltZS4gVGhp cyBwYXRjaCBwYXVzZXMgdGhlIGFuaW1hdGlvbiBhdCBpdHMgc3RhcnRUaW1lCisgICAgICAgIGlm IGEgdGVzdCB0cmllcyB0byBwYXVzZSBpdCBkdXJpbmcgdGhlIGRlbGF5IHBoYXNlLgorCisgICAg ICAgIFRlc3Q6IHRyYW5zaXRpb25zL3RyYW5zaXRpb24taW4tZGVsYXktcGhhc2UuaHRtbAorCisg ICAgICAgICogcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFzZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpBbmltYXRpb25CYXNlOjpmcmVlemVBdFRpbWUpOgorCiAyMDExLTA3LTEyICBPbGl2ZXIg VmFyZ2EgIDxWYXJnYS5PbGl2ZXJAc3R1ZC51LXN6ZWdlZC5odT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBOaWtvbGFzIFppbW1lcm1hbm4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0 aW9uL0FuaW1hdGlvbkJhc2UuY3BwCmluZGV4IDNiNzMwMmIzZjNiZTUyNGEzY2I1OTVjZDEzMWY1 ZTMxM2Y3MWMzY2YuLjhjNDIxMjBmNGZiOWU0NTBiY2Q1ZTNmYTNiYWFiY2I1NDMyYTI0YWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkJhc2UuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkJhc2UuY3BwCkBA IC0xNDQ5LDcgKzE0NDksMTAgQEAgdm9pZCBBbmltYXRpb25CYXNlOjpmcmVlemVBdFRpbWUoZG91 YmxlIHQpCiAgICAgfQogCiAgICAgQVNTRVJUKG1fc3RhcnRUaW1lKTsgICAgICAgIC8vIGlmIG1f c3RhcnRUaW1lIGlzIHplcm8sIHdlIGhhdmVuJ3Qgc3RhcnRlZCB5ZXQsIHNvIHdlJ2xsIGdldCBh IGJhZCBwYXVzZSB0aW1lLgotICAgIG1fcGF1c2VUaW1lID0gbV9zdGFydFRpbWUgKyB0IC0gbV9h bmltYXRpb24tPmRlbGF5KCk7CisgICAgaWYgKHQgPD0gbV9hbmltYXRpb24tPmRlbGF5KCkpCisg ICAgICAgIG1fcGF1c2VUaW1lID0gbV9zdGFydFRpbWU7CisgICAgZWxzZQorICAgICAgICBtX3Bh dXNlVGltZSA9IG1fc3RhcnRUaW1lICsgdCAtIG1fYW5pbWF0aW9uLT5kZWxheSgpOwogCiAjaWYg VVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIGlmIChtX29iamVjdCAmJiBtX29iamVj dC0+aGFzTGF5ZXIoKSkgewo=