59470 2011-04-26 11:03:38 -0700 Prohibit the use of OwnPtr<T*> 2011-06-20 09:41:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED WONTFIX P2 Normal --- 59469 59489 59559 1 enne enne abarth buildbot dglazkov enne webkit.review.bot oldest_to_newest 392570 0 enne 2011-04-26 11:03:38 -0700 Prohibit the use of OwnPtr<T*> 392573 1 91129 enne 2011-04-26 11:04:47 -0700 Created attachment 91129 Patch 392574 2 enne 2011-04-26 11:09:51 -0700 There may be some better way to implement this, but I think it would be an excellent idea to prevent somebody accidentally using OwnPtr<T*> when they intended OwnPtr<T>. I can't think of any usage for the former. (Also, I'm a little unsure of who to CC on this bug, so please add others.) 392586 3 webkit.review.bot 2011-04-26 11:26:49 -0700 Attachment 91129 did not build on chromium: Build output: http://queues.webkit.org/results/8509701 392625 4 buildbot 2011-04-26 12:07:53 -0700 Attachment 91129 did not build on win: Build output: http://queues.webkit.org/results/8508728 392629 5 webkit.review.bot 2011-04-26 12:11:43 -0700 Attachment 91129 did not build on mac: Build output: http://queues.webkit.org/results/8505948 392630 6 91144 enne 2011-04-26 12:13:51 -0700 Created attachment 91144 Patch 392631 7 enne 2011-04-26 12:14:30 -0700 Let's try this again now that the blocking bugfix has landed. 392642 8 webkit.review.bot 2011-04-26 12:57:47 -0700 Attachment 91144 did not build on chromium: Build output: http://queues.webkit.org/results/8509721 392657 9 91144 enne 2011-04-26 13:23:57 -0700 Comment on attachment 91144 Patch Oops. Need to touch up DRT as well. 392668 10 webkit.review.bot 2011-04-26 13:54:35 -0700 Attachment 91129 did not build on chromium: Build output: http://queues.webkit.org/results/8510701 392677 11 buildbot 2011-04-26 14:01:35 -0700 Attachment 91144 did not build on win: Build output: http://queues.webkit.org/results/8509734 392832 12 webkit.review.bot 2011-04-26 15:34:52 -0700 Attachment 91144 did not build on mac: Build output: http://queues.webkit.org/results/8508780 392988 13 91177 enne 2011-04-26 16:23:33 -0700 Created attachment 91177 Patch 392991 14 enne 2011-04-26 16:23:59 -0700 Third time's a charm for fixing all the build errors. 393104 15 91177 ggaren 2011-04-26 16:59:51 -0700 Comment on attachment 91177 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91177&action=review r=me > Source/JavaScriptCore/wtf/OwnPtr.h:179 > + template<typename T> class OwnPtr<T*> { > + // Prevent usage as a real OwnPtr by not defining any functions. > + }; > +#endif I believe you can do even better here by just using a declaration with no definition. 393122 16 enne 2011-04-26 17:03:50 -0700 (In reply to comment #15) > (From update of attachment 91177 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91177&action=review > > r=me Thanks for all the reviews today. :) > > Source/JavaScriptCore/wtf/OwnPtr.h:179 > > + template<typename T> class OwnPtr<T*> { > > + // Prevent usage as a real OwnPtr by not defining any functions. > > + }; > > +#endif > > I believe you can do even better here by just using a declaration with no definition. That would be cleaner. I'll do that before landing. 393132 17 buildbot 2011-04-26 17:05:00 -0700 Attachment 91177 did not build on win: Build output: http://queues.webkit.org/results/8507775 393174 18 enne 2011-04-26 17:25:08 -0700 (In reply to comment #16) > (In reply to comment #15) > > > Source/JavaScriptCore/wtf/OwnPtr.h:179 > > > + template<typename T> class OwnPtr<T*> { > > > + // Prevent usage as a real OwnPtr by not defining any functions. > > > + }; > > > +#endif > > > > I believe you can do even better here by just using a declaration with no definition. > > That would be cleaner. I'll do that before landing. After some study, I think an empty class rather than an incomplete declaration is better. If the class is incomplete, then it's harder to #ifdef out this error because every class that is-a or has-a class with an OwnPtr<T*> needs the ALLOW_RAW_POINTER_IN_OWNPTR define. Hopefully that should go away soon, but in the short term MediaPlayer.h is used in a number of places. Also, the error message points to OwnPtr.h in the former case where somebody might see the comment, but just says the slightly more obscure "incomplete declaration" in the latter. 393221 19 webkit.review.bot 2011-04-26 18:22:01 -0700 Attachment 91144 did not build on chromium: Build output: http://queues.webkit.org/results/8510781 393666 20 enne 2011-04-27 11:11:10 -0700 Oh, yuck. It looks like the Windows port is set up to handle OwnPtr<HBITMAP> (which is a void*), but has a deleteOwnPtr(HBITMAP) function which will properly clean up its resources. So, I can't disallow all OwnPtr<T*>, just all except any except the 10 or so port-specific pointer types listed in OwnPtrCommon.h. I'll have to take another look at this patch to account for that while still disallowing the general case. 423191 21 91177 darin 2011-06-18 12:46:21 -0700 Comment on attachment 91177 Patch Clearing review flag because we need to rework this for Windows’ sake. Best possibility would probably be to change Windows to use to something other than OwnPtr. It’s not safe to have it using OwnPtr with void*! 423712 22 enne 2011-06-20 09:41:40 -0700 (In reply to comment #21) > (From update of attachment 91177 [details]) > Clearing review flag because we need to rework this for Windows’ sake. Best possibility would probably be to change Windows to use to something other than OwnPtr. It’s not safe to have it using OwnPtr with void*! Ack. I thought I had closed this bug. It turns out that I was just mistaken. All the Windows-specific versions of OwnPtr like OwnPtr<HBITMAP> have their own specialized delete function which gets called. And thanks to template magic, for the general case of T, it turns out that OwnPtr<T*> is identical to OwnPtr<T> in terms of what gets stored in the OwnPtr and which delete function gets called. 91129 2011-04-26 11:04:47 -0700 2011-04-26 12:13:48 -0700 Patch bug-59470-20110426110446.patch text/plain 2706 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODQ5MTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDhh Nzk1NGMzNGZkM2FiMmU3OTc4YzlhYTQ0ZmQ3NmRhYWZiZGY4NDguLjI4ZGU2ZWNiYjJkZTY5ZjM0 ZWVkMGVmNWM1MmZlYzc1YzYyYjJkYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDExLTA0LTI2ICBBZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJvaGli aXQgdGhlIHVzZSBvZiBPd25QdHI8VCo+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01OTQ3MAorCisgICAgICAgICogd3RmL093blB0ci5oOgorCiAyMDEx LTA0LTI2ICBHYWJvciBMb2tpICA8bG9raUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IENzYWJhIE9zenRyb2dvbsOhYy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvT3duUHRyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL093blB0ci5oCmluZGV4 IGZiNTk0MzIxYjVhMDU0Mzg3MGY4NjgyZWI4YmQ1MzFjYjUwODM2M2IuLmI5YzQ3YTVlYWM0ZWIw NTNjMDVlZDRlMzEwZjcwZTNiYmI2ODIzNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvT3duUHRyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Pd25QdHIu aApAQCAtMTcwLDYgKzE3MCwxNCBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgcmV0dXJuIHAu Z2V0KCk7CiAgICAgfQogCisjaWZuZGVmIEFMTE9XX1JBV19QT0lOVEVSX0lOX09XTlBUUgorICAg IC8vIFBhcnRpYWwgdGVtcGxhdGUgc3BlY2lhbGl6YXRpb24gdG8gcHJvaGliaXQgcmF3IHBvaW50 ZXJzIGJlaW5nIHN0b3JlZAorICAgIC8vIGluIGFuIE93blB0ci4gVXNlIE93bkFycmF5UHRyIGZv ciBhcnJheXMuCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gY2xhc3MgT3duUHRyPFQqPiB7Cisg ICAgICAgIC8vIFByZXZlbnQgdXNhZ2UgYXMgYSByZWFsIE93blB0ciBieSBub3QgZGVmaW5pbmcg YW55IGZ1bmN0aW9ucy4KKyAgICB9OworI2VuZGlmCisKIH0gLy8gbmFtZXNwYWNlIFdURgogCiB1 c2luZyBXVEY6Ok93blB0cjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNzRjYzk4ZTM4OWJlNWUxODM5NTY0Yzhk MjhlNWFkNjdjNTMwZjUzLi4wNjM5ZTg0Yzg3OGExOGViNzFlNDliMWY3YTM5MmE1MzFhN2IwNmEw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMjYgIEFkcmllbm5lIFdhbGtl ciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQcm9oaWJpdCB0aGUgdXNlIG9mIE93blB0cjxUKj4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5NDcwCisKKyAgICAgICAgQWxs b3cgdGhpcyB0ZW1wb3JhcmlseSBpbiBNZWRpYVBsYXllciBiZWNhdXNlIGl0IG5lZWRzIHRvIGJl IGZpeGVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuaDoKKwog MjAxMS0wNC0yNiAgR2Fib3IgTG9raSAgPGxva2lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvTWVkaWFQbGF5ZXIuaAppbmRleCAzNDgxYjBlMWQ2MzhiZDI3YWE4ZTE4ZDVjYzA2 OGNlNjIxNTBhMmVhLi41NDQyOGVhMzA5ZTlkYTFlNTdmYjc5N2FjNjE3ODE1YjBjN2JlNTBkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmgKQEAg LTI4LDYgKzI4LDkgQEAKIAogI2lmIEVOQUJMRShWSURFTykKIAorLy8gRklYTUU6IFJlbW92ZSB0 aGlzIGFmdGVyIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTQ2Ngor I2RlZmluZSBBTExPV19SQVdfUE9JTlRFUl9JTl9PV05QVFIKKwogI2lmIEVOQUJMRShQTFVHSU5f UFJPWFlfRk9SX1ZJREVPKQogI2luY2x1ZGUgIk1lZGlhUGxheWVyUHJveHkuaCIKICNlbmRpZgpA QCAtMzQzLDYgKzM0Niw5IEBAIHR5cGVkZWYgdm9pZCAoKk1lZGlhRW5naW5lUmVnaXN0cmFyKShD cmVhdGVNZWRpYUVuZ2luZVBsYXllciwgTWVkaWFFbmdpbmVTdXBwb3J0CiAKIH0KIAorLy8gRklY TUU6IFJlbW92ZSB0aGlzIGFmdGVyIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01OTQ2NgorI3VuZGVmIEFMTE9XX1JBV19QT0lOVEVSX0lOX09XTlBUUgorCiAjZW5kaWYg Ly8gRU5BQkxFKFZJREVPKQogCiAjZW5kaWYK 91144 2011-04-26 12:13:51 -0700 2011-04-26 16:23:30 -0700 Patch bug-59470-20110426121350.patch text/plain 2623 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODQ5NDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGE1 ZDA0MzhlN2JlMWU2YjFkOTg4MjlkNTY2NDYyNzlmNDE2MGExZDEuLjk4ZWE1ODBkYmI0ODVlNTQz MTM4ODdjNzc2MWM3ZWJhMTY4YmI3ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDExLTA0LTI2ICBBZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJvaGli aXQgdGhlIHVzZSBvZiBPd25QdHI8VCo+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01OTQ3MAorCisgICAgICAgICogd3RmL093blB0ci5oOgorCiAyMDEx LTA0LTI1ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL093blB0ci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Pd25QdHIuaAppbmRleCBm YjU5NDMyMWI1YTA1NDM4NzBmODY4MmViOGJkNTMxY2I1MDgzNjNiLi5iOWM0N2E1ZWFjNGViMDUz YzA1ZWQ0ZTMxMGY3MGUzYmJiNjgyMzQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd3RmL093blB0ci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvT3duUHRyLmgK QEAgLTE3MCw2ICsxNzAsMTQgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIHJldHVybiBwLmdl dCgpOwogICAgIH0KIAorI2lmbmRlZiBBTExPV19SQVdfUE9JTlRFUl9JTl9PV05QVFIKKyAgICAv LyBQYXJ0aWFsIHRlbXBsYXRlIHNwZWNpYWxpemF0aW9uIHRvIHByb2hpYml0IHJhdyBwb2ludGVy cyBiZWluZyBzdG9yZWQKKyAgICAvLyBpbiBhbiBPd25QdHIuIFVzZSBPd25BcnJheVB0ciBmb3Ig YXJyYXlzLgorICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGNsYXNzIE93blB0cjxUKj4geworICAg ICAgICAvLyBQcmV2ZW50IHVzYWdlIGFzIGEgcmVhbCBPd25QdHIgYnkgbm90IGRlZmluaW5nIGFu eSBmdW5jdGlvbnMuCisgICAgfTsKKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFjZSBXVEYKIAogdXNp bmcgV1RGOjpPd25QdHI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjVlYjU2MjdhODU3YmU4MmNjOWY4OTY1NTQ5 YWQwZDdiNTg3OGM0NC4uNWEwNDRiZDA3MjU1YmY5ZmQyMzRiY2EwOGIyMTg1OWU0YmJjMTgzOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDExLTA0LTI2ICBBZHJpZW5uZSBXYWxrZXIg IDxlbm5lQGdvb2dsZS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUHJvaGliaXQgdGhlIHVzZSBvZiBPd25QdHI8VCo+CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTQ3MAorCisgICAgICAgIEFsbG93 IHRoaXMgdGVtcG9yYXJpbHkgaW4gTWVkaWFQbGF5ZXIgYmVjYXVzZSBpdCBuZWVkcyB0byBiZSBm aXhlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmg6CisKKzIw MTEtMDQtMjYgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKwogICAgICAgICBS ZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KIAogICAgICAgICBVc2UgT3duQXJyYXlQdHI8VD4g aW5zdGVhZCBvZiBPd25QdHI8VCo+IGluIFNjb3BlVHJhY2VyCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuaAppbmRleCAzNDgxYjBlMWQ2MzhiZDI3YWE4 ZTE4ZDVjYzA2OGNlNjIxNTBhMmVhLi43YmI4MGYxMzZhYzIzZDNmZDg0MmFjMDAyOWI0MTRkYmVm NGY4Njc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRp YVBsYXllci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxh eWVyLmgKQEAgLTI4LDYgKzI4LDEzIEBACiAKICNpZiBFTkFCTEUoVklERU8pCiAKKy8vIEZJWE1F OiBSZW1vdmUgdGhpcyBhZnRlciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTk0NjYKKyNpZm5kZWYgQUxMT1dfUkFXX1BPSU5URVJfSU5fT1dOUFRSCisjZGVmaW5lIEFM TE9XX1JBV19QT0lOVEVSX0lOX09XTlBUUgorI2luY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KKyN1bmRl ZiBBTExPV19SQVdfUE9JTlRFUl9JTl9PV05QVFIKKyNlbmRpZgorCiAjaWYgRU5BQkxFKFBMVUdJ Tl9QUk9YWV9GT1JfVklERU8pCiAjaW5jbHVkZSAiTWVkaWFQbGF5ZXJQcm94eS5oIgogI2VuZGlm Cg== 91177 2011-04-26 16:23:33 -0700 2011-06-18 12:46:21 -0700 Patch bug-59470-20110426162332.patch text/plain 2623 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODQ5NDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGE1 ZDA0MzhlN2JlMWU2YjFkOTg4MjlkNTY2NDYyNzlmNDE2MGExZDEuLjk4ZWE1ODBkYmI0ODVlNTQz MTM4ODdjNzc2MWM3ZWJhMTY4YmI3ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDExLTA0LTI2ICBBZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJvaGli aXQgdGhlIHVzZSBvZiBPd25QdHI8VCo+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01OTQ3MAorCisgICAgICAgICogd3RmL093blB0ci5oOgorCiAyMDEx LTA0LTI1ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL093blB0ci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9Pd25QdHIuaAppbmRleCBm YjU5NDMyMWI1YTA1NDM4NzBmODY4MmViOGJkNTMxY2I1MDgzNjNiLi5iOWM0N2E1ZWFjNGViMDUz YzA1ZWQ0ZTMxMGY3MGUzYmJiNjgyMzQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd3RmL093blB0ci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvT3duUHRyLmgK QEAgLTE3MCw2ICsxNzAsMTQgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIHJldHVybiBwLmdl dCgpOwogICAgIH0KIAorI2lmbmRlZiBBTExPV19SQVdfUE9JTlRFUl9JTl9PV05QVFIKKyAgICAv LyBQYXJ0aWFsIHRlbXBsYXRlIHNwZWNpYWxpemF0aW9uIHRvIHByb2hpYml0IHJhdyBwb2ludGVy cyBiZWluZyBzdG9yZWQKKyAgICAvLyBpbiBhbiBPd25QdHIuIFVzZSBPd25BcnJheVB0ciBmb3Ig YXJyYXlzLgorICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGNsYXNzIE93blB0cjxUKj4geworICAg ICAgICAvLyBQcmV2ZW50IHVzYWdlIGFzIGEgcmVhbCBPd25QdHIgYnkgbm90IGRlZmluaW5nIGFu eSBmdW5jdGlvbnMuCisgICAgfTsKKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFjZSBXVEYKIAogdXNp bmcgV1RGOjpPd25QdHI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjVlYjU2MjdhODU3YmU4MmNjOWY4OTY1NTQ5 YWQwZDdiNTg3OGM0NC4uNWEwNDRiZDA3MjU1YmY5ZmQyMzRiY2EwOGIyMTg1OWU0YmJjMTgzOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDExLTA0LTI2ICBBZHJpZW5uZSBXYWxrZXIg IDxlbm5lQGdvb2dsZS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUHJvaGliaXQgdGhlIHVzZSBvZiBPd25QdHI8VCo+CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTQ3MAorCisgICAgICAgIEFsbG93 IHRoaXMgdGVtcG9yYXJpbHkgaW4gTWVkaWFQbGF5ZXIgYmVjYXVzZSBpdCBuZWVkcyB0byBiZSBm aXhlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmg6CisKKzIw MTEtMDQtMjYgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKwogICAgICAgICBS ZXZpZXdlZCBieSBHZW9mZnJleSBHYXJlbi4KIAogICAgICAgICBVc2UgT3duQXJyYXlQdHI8VD4g aW5zdGVhZCBvZiBPd25QdHI8VCo+IGluIFNjb3BlVHJhY2VyCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuaAppbmRleCAzNDgxYjBlMWQ2MzhiZDI3YWE4 ZTE4ZDVjYzA2OGNlNjIxNTBhMmVhLi43YmI4MGYxMzZhYzIzZDNmZDg0MmFjMDAyOWI0MTRkYmVm NGY4Njc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRp YVBsYXllci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxh eWVyLmgKQEAgLTI4LDYgKzI4LDEzIEBACiAKICNpZiBFTkFCTEUoVklERU8pCiAKKy8vIEZJWE1F OiBSZW1vdmUgdGhpcyBhZnRlciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTk0NjYKKyNpZm5kZWYgQUxMT1dfUkFXX1BPSU5URVJfSU5fT1dOUFRSCisjZGVmaW5lIEFM TE9XX1JBV19QT0lOVEVSX0lOX09XTlBUUgorI2luY2x1ZGUgPHd0Zi9Pd25QdHIuaD4KKyN1bmRl ZiBBTExPV19SQVdfUE9JTlRFUl9JTl9PV05QVFIKKyNlbmRpZgorCiAjaWYgRU5BQkxFKFBMVUdJ Tl9QUk9YWV9GT1JfVklERU8pCiAjaW5jbHVkZSAiTWVkaWFQbGF5ZXJQcm94eS5oIgogI2VuZGlm Cg==