59455 2011-04-26 07:44:35 -0700 Web Inspector: implement incremental CSS editing in the structure view. 2011-04-27 01:34:41 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 392450 0 pfeldman 2011-04-26 07:44:35 -0700 Patch to follow. 392452 1 91105 pfeldman 2011-04-26 07:46:20 -0700 Created attachment 91105 Patch 392457 2 91105 apavlov 2011-04-26 07:49:44 -0700 Comment on attachment 91105 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91105&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1699 > + if (this._handleUpOrDownKeyPressed(event)) A good idea is to align this with _applyFreeFlowStyleTextEdit (just remove the model modification code from _handleUpOrDownKeyPressed and call _apply...() unconditionally). 392516 3 91105 pfeldman 2011-04-26 09:38:48 -0700 Comment on attachment 91105 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91105&action=review >> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1699 >> + if (this._handleUpOrDownKeyPressed(event)) > > A good idea is to align this with _applyFreeFlowStyleTextEdit (just remove the model modification code from _handleUpOrDownKeyPressed and call _apply...() unconditionally). I think increments should be processed synchronously, with no delay 393438 4 91105 pfeldman 2011-04-27 01:34:32 -0700 Comment on attachment 91105 Patch Clearing flags on attachment: 91105 Committed r85034: <http://trac.webkit.org/changeset/85034> 393439 5 pfeldman 2011-04-27 01:34:41 -0700 All reviewed patches have been landed. Closing bug. 91105 2011-04-26 07:46:20 -0700 2011-04-27 01:34:32 -0700 Patch bug-59455-20110426184618.patch text/plain 3345 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogODQ5MTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2ZDFmMGNmODdlZTMyYzI2 ZTk4YTFiOTIzYzdmOWZhZTg4MjFhZjNhLi4yNjUxN2IzZGFlYWVkYzVhZWRjMDYwNGE0ZjM0ZWM0 OWYzNWQ5MDlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTEtMDQtMjYgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGltcGxlbWVudCBpbmNyZW1l bnRhbCBDU1MgZWRpdGluZyBpbiB0aGUgc3RydWN0dXJlIHZpZXcuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTQ1NQorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlKToKKworMjAxMS0wNC0yNiAgUGF2 ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGdvb2dsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkg WXVyeSBTZW1pa2hhdHNreS4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBjbG9zZSBidXR0b24g aXMgb2ZmIGluIGRvY2tlZCBtb2RlIG9uIGEgbWFjLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKaW5kZXggZjA5ZGEy NDVjZjNhYjAxYjY2MjQzODg4NzZmNDVmNTFiNjJmNDkzNi4uODg4OGQyY2FjNWQ4OTgzNWE1NGVk YzFlYTU4MmI5NWM1NDMwOWViOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCkBAIC0xNjk2LDE4ICsxNjk2LDM4 IEBAIFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlID0gewog ICAgIHsKICAgICAgICAgaWYgKGV2ZW50LmhhbmRsZWQpCiAgICAgICAgICAgICByZXR1cm47Cisg ICAgICAgIGlmICh0aGlzLl9oYW5kbGVVcE9yRG93bktleVByZXNzZWQoZXZlbnQpKQorICAgICAg ICAgICAgcmV0dXJuOworCisgICAgICAgIHRoaXMuX2FwcGx5RnJlZUZsb3dTdHlsZVRleHRFZGl0 KCk7CisgICAgfSwKKworICAgIF9hcHBseUZyZWVGbG93U3R5bGVUZXh0RWRpdDogZnVuY3Rpb24o KQorICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX2FwcGx5RnJlZUZsb3dTdHlsZVRleHRFZGl0VGlt ZXIpCisgICAgICAgICAgICBjbGVhclRpbWVvdXQodGhpcy5fYXBwbHlGcmVlRmxvd1N0eWxlVGV4 dEVkaXRUaW1lcik7CisKKyAgICAgICAgZnVuY3Rpb24gYXBwbHkoKQorICAgICAgICB7CisgICAg ICAgICAgICB0aGlzLmFwcGx5U3R5bGVUZXh0KHRoaXMubmFtZUVsZW1lbnQudGV4dENvbnRlbnQg KyAiOiAiICsgdGhpcy52YWx1ZUVsZW1lbnQudGV4dENvbnRlbnQpOworICAgICAgICB9CisgICAg ICAgIHRoaXMuX2FwcGx5RnJlZUZsb3dTdHlsZVRleHRFZGl0VGltZXIgPSBzZXRUaW1lb3V0KGFw cGx5LmJpbmQodGhpcyksIDEwMCk7CisgICAgfSwKKworICAgIF9oYW5kbGVVcE9yRG93bktleVBy ZXNzZWQ6IGZ1bmN0aW9uKGV2ZW50KQorICAgIHsKICAgICAgICAgdmFyIGFycm93S2V5UHJlc3Nl ZCA9IChldmVudC5rZXlJZGVudGlmaWVyID09PSAiVXAiIHx8IGV2ZW50LmtleUlkZW50aWZpZXIg PT09ICJEb3duIik7CiAgICAgICAgIHZhciBwYWdlS2V5UHJlc3NlZCA9IChldmVudC5rZXlJZGVu dGlmaWVyID09PSAiUGFnZVVwIiB8fCBldmVudC5rZXlJZGVudGlmaWVyID09PSAiUGFnZURvd24i KTsKICAgICAgICAgaWYgKCFhcnJvd0tleVByZXNzZWQgJiYgIXBhZ2VLZXlQcmVzc2VkKQotICAg ICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgICAgIHZh ciBzZWxlY3Rpb24gPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CiAgICAgICAgIGlmICghc2VsZWN0 aW9uLnJhbmdlQ291bnQpCi0gICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CiAKICAgICAgICAgdmFyIHNlbGVjdGlvblJhbmdlID0gc2VsZWN0aW9uLmdldFJhbmdl QXQoMCk7CiAgICAgICAgIGlmIChzZWxlY3Rpb25SYW5nZS5jb21tb25BbmNlc3RvckNvbnRhaW5l ciAhPT0gdGhpcy52YWx1ZUVsZW1lbnQgJiYgIXNlbGVjdGlvblJhbmdlLmNvbW1vbkFuY2VzdG9y Q29udGFpbmVyLmlzRGVzY2VuZGFudCh0aGlzLnZhbHVlRWxlbWVudCkpCi0gICAgICAgICAgICBy ZXR1cm47CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAgICAgdmFyIHdvcmRSYW5n ZSA9IHNlbGVjdGlvblJhbmdlLnN0YXJ0Q29udGFpbmVyLnJhbmdlT2ZXb3JkKHNlbGVjdGlvblJh bmdlLnN0YXJ0T2Zmc2V0LCBXZWJJbnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUuU3R5bGVWYWx1 ZURlbGltaXRlcnMsIHRoaXMudmFsdWVFbGVtZW50KTsKICAgICAgICAgdmFyIHdvcmRTdHJpbmcg PSB3b3JkUmFuZ2UudG9TdHJpbmcoKTsKQEAgLTE3NTgsMTAgKzE3NzgsMTQgQEAgV2ViSW5zcGVj dG9yLlN0eWxlUHJvcGVydHlUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAv LyBTeW50aGVzaXplIHByb3BlcnR5IHRleHQgZGlzcmVnYXJkaW5nIGFueSBjb21tZW50cywgY3Vz dG9tIHdoaXRlc3BhY2UgZXRjLgogICAgICAgICAgICAgdGhpcy5hcHBseVN0eWxlVGV4dCh0aGlz Lm5hbWVFbGVtZW50LnRleHRDb250ZW50ICsgIjogIiArIHRoaXMudmFsdWVFbGVtZW50LnRleHRD b250ZW50KTsKICAgICAgICAgfQorICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LAogCiAgICAg ZWRpdGluZ0VuZGVkOiBmdW5jdGlvbihjb250ZXh0KQogICAgIHsKKyAgICAgICAgaWYgKHRoaXMu X2FwcGx5RnJlZUZsb3dTdHlsZVRleHRFZGl0VGltZXIpCisgICAgICAgICAgICBjbGVhclRpbWVv dXQodGhpcy5fYXBwbHlGcmVlRmxvd1N0eWxlVGV4dEVkaXRUaW1lcik7CisKICAgICAgICAgdGhp cy5oYXNDaGlsZHJlbiA9IGNvbnRleHQuaGFzQ2hpbGRyZW47CiAgICAgICAgIGlmIChjb250ZXh0 LmV4cGFuZGVkKQogICAgICAgICAgICAgdGhpcy5leHBhbmQoKTsK