59429 2011-04-26 00:13:07 -0700 Fix last strict OwnPtr violation under svg/... 2011-04-26 04:12:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 adamk adamk abarth eric levin webkit.review.bot oldest_to_newest 392318 0 adamk 2011-04-26 00:13:07 -0700 Fix last strict OwnPtr violation under svg/... 392319 1 91075 adamk 2011-04-26 00:13:37 -0700 Created attachment 91075 Patch 392327 2 91075 abarth 2011-04-26 00:24:56 -0700 Comment on attachment 91075 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91075&action=review > Source/WebCore/svg/SVGDocumentExtensions.cpp:243 > - OwnPtr<SVGPendingElements> set(m_pendingResources.get(id)); > + OwnPtr<SVGPendingElements> set(adoptPtr(m_pendingResources.get(id))); We prefer the assignment form of the constructor: OwnPtr<SVGPendingElements> set = adoptPtr(m_pendingResources.get(id)); 392331 3 abarth 2011-04-26 00:27:59 -0700 I can land this for you. 392332 4 abarth 2011-04-26 00:30:22 -0700 Committed r84891: <http://trac.webkit.org/changeset/84891> 392387 5 webkit.review.bot 2011-04-26 04:12:24 -0700 http://trac.webkit.org/changeset/84891 might have broken SnowLeopard Intel Release (WebKit2 Tests) 91075 2011-04-26 00:13:37 -0700 2011-04-26 00:24:56 -0700 Patch bug-59429-20110426001334.patch text/plain 1479 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogODQ4ODYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5Nzg2MTEyYmRmMzEwM2Ux MTY1YzFmZThkZjM2OWNlYzNjMTkwM2RhLi41ZTVmNTIwYjMyMGY0MjE0NGY5ZmY3MmU0ZGMyODg2 YjRlMzVlMmQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDQtMjYgIEFkYW0g S2xlaW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRml4IGxhc3Qgc3RyaWN0IE93blB0ciB2aW9sYXRpb24gdW5k ZXIgc3ZnLy4uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTk0MjkKKworICAgICAgICAqIHN2Zy9TVkdEb2N1bWVudEV4dGVuc2lvbnMuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U1ZHRG9jdW1lbnRFeHRlbnNpb25zOjpyZW1vdmVQZW5kaW5nUmVzb3Vy Y2UpOgorCiAyMDExLTA0LTI1ICBMZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9zdmcvU1ZHRG9jdW1lbnRFeHRlbnNpb25zLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2 Zy9TVkdEb2N1bWVudEV4dGVuc2lvbnMuY3BwCmluZGV4IDEzMzc3NjMzM2EyZDYxNzgwMWUyYjI0 NmQwMTU1MjFlYWQwMmI0NjAuLjgyMmU5ODI5YWYxZTk2YmQzNmMxN2E5YTEzMjI3NjMyNDNlNjQx MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdEb2N1bWVudEV4dGVuc2lvbnMu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdEb2N1bWVudEV4dGVuc2lvbnMuY3BwCkBA IC0yMSw5ICsyMSw2IEBACiAKICNpbmNsdWRlICJjb25maWcuaCIKIAotLy8gRklYTUU6IFJlbW92 ZSB0aGlzIGRlZmluZSEKLSNkZWZpbmUgTE9PU0VfT1dOX1BUUgotCiAjaWYgRU5BQkxFKFNWRykK ICNpbmNsdWRlICJTVkdEb2N1bWVudEV4dGVuc2lvbnMuaCIKIApAQCAtMjQzLDcgKzI0MCw3IEBA IFBhc3NPd25QdHI8SGFzaFNldDxSZWZQdHI8U1ZHU3R5bGVkRWxlbWVudD4gPiA+IFNWR0RvY3Vt ZW50RXh0ZW5zaW9uczo6cmVtb3ZlUGVuCiB7CiAgICAgQVNTRVJUKG1fcGVuZGluZ1Jlc291cmNl cy5jb250YWlucyhpZCkpOwogCi0gICAgT3duUHRyPFNWR1BlbmRpbmdFbGVtZW50cz4gc2V0KG1f cGVuZGluZ1Jlc291cmNlcy5nZXQoaWQpKTsKKyAgICBPd25QdHI8U1ZHUGVuZGluZ0VsZW1lbnRz PiBzZXQoYWRvcHRQdHIobV9wZW5kaW5nUmVzb3VyY2VzLmdldChpZCkpKTsKICAgICBtX3BlbmRp bmdSZXNvdXJjZXMucmVtb3ZlKGlkKTsKICAgICByZXR1cm4gc2V0LnJlbGVhc2UoKTsKIH0K