59424 2011-04-25 23:21:19 -0700 WebKit1 should build cleanly with strict OwnPtrs 2011-04-25 23:25:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth levin oldest_to_newest 392290 0 abarth 2011-04-25 23:21:19 -0700 WebKit1 should build cleanly with strict OwnPtrs 392291 1 91067 abarth 2011-04-25 23:21:33 -0700 Created attachment 91067 Patch 392294 2 91067 levin 2011-04-25 23:23:11 -0700 Comment on attachment 91067 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91067&action=review one minor nit. > Source/WebKit/mac/WebView/WebDeviceOrientationProviderMock.mm:28 > +#import <wtf/PassOwnPtr.h> Should this be after the import that follows it? 392297 3 abarth 2011-04-25 23:25:02 -0700 Committed r84883: <http://trac.webkit.org/changeset/84883> 91067 2011-04-25 23:21:33 -0700 2011-04-25 23:23:11 -0700 Patch bug-59424-20110425232132.patch text/plain 5623 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0ODgwKQorKysgU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDQtMjUg IEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQxIHNob3VsZCBidWlsZCBjbGVhbmx5IHdp dGggc3RyaWN0IE93blB0cnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU5NDI0CisKKyAgICAgICAgKiBIaXN0b3J5L1dlYkhpc3RvcnlJdGVtLm1tOgor ICAgICAgICAoLVtXZWJIaXN0b3J5SXRlbSBpbml0RnJvbURpY3Rpb25hcnlSZXByZXNlbnRhdGlv bjpdKToKKyAgICAgICAgKiBQbHVnaW5zL1dlYk5ldHNjYXBlUGx1Z2luRXZlbnRIYW5kbGVyLmg6 CisgICAgICAgICogUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdpbkV2ZW50SGFuZGxlci5tbToKKyAg ICAgICAgKFdlYk5ldHNjYXBlUGx1Z2luRXZlbnRIYW5kbGVyOjpjcmVhdGUpOgorICAgICAgICAq IFBsdWdpbnMvV2ViTmV0c2NhcGVQbHVnaW5WaWV3Lm1tOgorICAgICAgICAoLVtXZWJOZXRzY2Fw ZVBsdWdpblZpZXcgY3JlYXRlUGx1Z2luXSk6CisgICAgICAgICogV2ViVmlldy9XZWJEZXZpY2VP cmllbnRhdGlvblByb3ZpZGVyTW9jay5tbToKKyAgICAgICAgKiBXZWJWaWV3L1dlYlRleHRJdGVy YXRvci5tbToKKyAgICAgICAgKC1bV2ViVGV4dEl0ZXJhdG9yIGluaXRXaXRoUmFuZ2U6XSk6CisK IDIwMTEtMDQtMjUgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpJbmRleDogU291cmNlL1dlYktpdC9tYWMvSGlzdG9y eS9XZWJIaXN0b3J5SXRlbS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9IaXN0 b3J5L1dlYkhpc3RvcnlJdGVtLm1tCShyZXZpc2lvbiA4NDg4MCkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0hpc3RvcnkvV2ViSGlzdG9yeUl0ZW0ubW0JKHdvcmtpbmcgY29weSkKQEAgLTM3OCw3ICsz NzgsNyBAQCAtIChpZClpbml0RnJvbURpY3Rpb25hcnlSZXByZXNlbnRhdGlvbjooCiAKICAgICBp ZiAoTlNBcnJheSAqcmVkaXJlY3RVUkxzID0gW2RpY3QgX3dlYmtpdF9hcnJheUZvcktleTpyZWRp cmVjdFVSTHNLZXldKSB7CiAgICAgICAgIE5TVUludGVnZXIgc2l6ZSA9IFtyZWRpcmVjdFVSTHMg Y291bnRdOwotICAgICAgICBPd25QdHI8VmVjdG9yPFN0cmluZz4gPiByZWRpcmVjdFVSTHNWZWN0 b3IobmV3IFZlY3RvcjxTdHJpbmc+KHNpemUpKTsKKyAgICAgICAgT3duUHRyPFZlY3RvcjxTdHJp bmc+ID4gcmVkaXJlY3RVUkxzVmVjdG9yID0gYWRvcHRQdHIobmV3IFZlY3RvcjxTdHJpbmc+KHNp emUpKTsKICAgICAgICAgZm9yIChOU1VJbnRlZ2VyIGkgPSAwOyBpIDwgc2l6ZTsgKytpKQogICAg ICAgICAgICAgKCpyZWRpcmVjdFVSTHNWZWN0b3IpW2ldID0gU3RyaW5nKFtyZWRpcmVjdFVSTHMg X3dlYmtpdF9zdHJpbmdBdEluZGV4OmldKTsKICAgICAgICAgY29yZShfcHJpdmF0ZSktPnNldFJl ZGlyZWN0VVJMcyhyZWRpcmVjdFVSTHNWZWN0b3IucmVsZWFzZSgpKTsKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvbWFjL1BsdWdpbnMvV2ViTmV0c2NhcGVQbHVnaW5FdmVudEhhbmRsZXIuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9QbHVnaW5zL1dlYk5ldHNjYXBlUGx1Z2luRXZlbnRI YW5kbGVyLmgJKHJldmlzaW9uIDg0ODgwKQorKysgU291cmNlL1dlYktpdC9tYWMvUGx1Z2lucy9X ZWJOZXRzY2FwZVBsdWdpbkV2ZW50SGFuZGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNyw3ICsz Nyw3IEBAIHN0cnVjdCBDR1JlY3Q7CiAKIGNsYXNzIFdlYk5ldHNjYXBlUGx1Z2luRXZlbnRIYW5k bGVyIHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgV2ViTmV0c2NhcGVQbHVnaW5FdmVudEhhbmRsZXIq IGNyZWF0ZShXZWJOZXRzY2FwZVBsdWdpblZpZXcqKTsKKyAgICBzdGF0aWMgUGFzc093blB0cjxX ZWJOZXRzY2FwZVBsdWdpbkV2ZW50SGFuZGxlcj4gY3JlYXRlKFdlYk5ldHNjYXBlUGx1Z2luVmll dyopOwogICAgIHZpcnR1YWwgfldlYk5ldHNjYXBlUGx1Z2luRXZlbnRIYW5kbGVyKCkgeyB9CiAg ICAgCiAgICAgdmlydHVhbCB2b2lkIGRyYXdSZWN0KENHQ29udGV4dFJlZiwgY29uc3QgTlNSZWN0 JikgPSAwOwpJbmRleDogU291cmNlL1dlYktpdC9tYWMvUGx1Z2lucy9XZWJOZXRzY2FwZVBsdWdp bkV2ZW50SGFuZGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9QbHVnaW5z L1dlYk5ldHNjYXBlUGx1Z2luRXZlbnRIYW5kbGVyLm1tCShyZXZpc2lvbiA4NDg4MCkKKysrIFNv dXJjZS9XZWJLaXQvbWFjL1BsdWdpbnMvV2ViTmV0c2NhcGVQbHVnaW5FdmVudEhhbmRsZXIubW0J KHdvcmtpbmcgY29weSkKQEAgLTI4LDIyICsyOCwyMyBAQAogI2ltcG9ydCAiV2ViTmV0c2NhcGVQ bHVnaW5FdmVudEhhbmRsZXIuaCIKIAogI2ltcG9ydCA8d3RmL0Fzc2VydGlvbnMuaD4KKyNpbXBv cnQgPHd0Zi9QYXNzT3duUHRyLmg+CiAjaW1wb3J0ICJXZWJOZXRzY2FwZVBsdWdpblZpZXcuaCIK ICNpbXBvcnQgIldlYk5ldHNjYXBlUGx1Z2luRXZlbnRIYW5kbGVyQ2FyYm9uLmgiCiAjaW1wb3J0 ICJXZWJOZXRzY2FwZVBsdWdpbkV2ZW50SGFuZGxlckNvY29hLmgiCiAKLVdlYk5ldHNjYXBlUGx1 Z2luRXZlbnRIYW5kbGVyKiBXZWJOZXRzY2FwZVBsdWdpbkV2ZW50SGFuZGxlcjo6Y3JlYXRlKFdl Yk5ldHNjYXBlUGx1Z2luVmlldyogcGx1Z2luVmlldykKK1Bhc3NPd25QdHI8V2ViTmV0c2NhcGVQ bHVnaW5FdmVudEhhbmRsZXI+IFdlYk5ldHNjYXBlUGx1Z2luRXZlbnRIYW5kbGVyOjpjcmVhdGUo V2ViTmV0c2NhcGVQbHVnaW5WaWV3KiBwbHVnaW5WaWV3KQogewogICAgIHN3aXRjaCAoW3BsdWdp blZpZXcgZXZlbnRNb2RlbF0pIHsKICNpZm5kZWYgTlBfTk9fQ0FSQk9OCiAgICAgICAgIGNhc2Ug TlBFdmVudE1vZGVsQ2FyYm9uOgotICAgICAgICAgICAgcmV0dXJuIG5ldyBXZWJOZXRzY2FwZVBs dWdpbkV2ZW50SGFuZGxlckNhcmJvbihwbHVnaW5WaWV3KTsKKyAgICAgICAgICAgIHJldHVybiBh ZG9wdFB0cihuZXcgV2ViTmV0c2NhcGVQbHVnaW5FdmVudEhhbmRsZXJDYXJib24ocGx1Z2luVmll dykpOwogI2VuZGlmIC8vIE5QX05PX0NBUkJPTgogICAgICAgICBjYXNlIE5QRXZlbnRNb2RlbENv Y29hOgotICAgICAgICAgICAgcmV0dXJuIG5ldyBXZWJOZXRzY2FwZVBsdWdpbkV2ZW50SGFuZGxl ckNvY29hKHBsdWdpblZpZXcpOworICAgICAgICAgICAgcmV0dXJuIGFkb3B0UHRyKG5ldyBXZWJO ZXRzY2FwZVBsdWdpbkV2ZW50SGFuZGxlckNvY29hKHBsdWdpblZpZXcpKTsKICAgICAgICAgZGVm YXVsdDoKICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgICAgICAgICAgcmV0 dXJuIDA7CisgICAgICAgICAgICByZXR1cm4gUGFzc093blB0cjxXZWJOZXRzY2FwZVBsdWdpbkV2 ZW50SGFuZGxlcj4oKTsKICAgICB9CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1BsdWdp bnMvV2ViTmV0c2NhcGVQbHVnaW5WaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv bWFjL1BsdWdpbnMvV2ViTmV0c2NhcGVQbHVnaW5WaWV3Lm1tCShyZXZpc2lvbiA4NDg4MCkKKysr IFNvdXJjZS9XZWJLaXQvbWFjL1BsdWdpbnMvV2ViTmV0c2NhcGVQbHVnaW5WaWV3Lm1tCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMTI5LDggKzExMjksOCBAQCAtIChCT09MKWNyZWF0ZVBsdWdpbgogI2Vu ZGlmCiAgICAgCiAgICAgLy8gQ3JlYXRlIHRoZSBldmVudCBoYW5kbGVyCi0gICAgX2V2ZW50SGFu ZGxlci5zZXQoV2ViTmV0c2NhcGVQbHVnaW5FdmVudEhhbmRsZXI6OmNyZWF0ZShzZWxmKSk7Ci0g ICAgICAgIAorICAgIF9ldmVudEhhbmRsZXIgPSBXZWJOZXRzY2FwZVBsdWdpbkV2ZW50SGFuZGxl cjo6Y3JlYXRlKHNlbGYpOworCiAgICAgcmV0dXJuIFlFUzsKIH0KIApJbmRleDogU291cmNlL1dl YktpdC9tYWMvV2ViVmlldy9XZWJEZXZpY2VPcmllbnRhdGlvblByb3ZpZGVyTW9jay5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkRldmljZU9yaWVudGF0aW9u UHJvdmlkZXJNb2NrLm1tCShyZXZpc2lvbiA4NDg4MCkKKysrIFNvdXJjZS9XZWJLaXQvbWFjL1dl YlZpZXcvV2ViRGV2aWNlT3JpZW50YXRpb25Qcm92aWRlck1vY2subW0JKHdvcmtpbmcgY29weSkK QEAgLTI1LDYgKzI1LDcgQEAKIAogI2ltcG9ydCAiV2ViRGV2aWNlT3JpZW50YXRpb25Qcm92aWRl ck1vY2tJbnRlcm5hbC5oIgogCisjaW1wb3J0IDx3dGYvUGFzc093blB0ci5oPgogI2ltcG9ydCAi V2ViRGV2aWNlT3JpZW50YXRpb25JbnRlcm5hbC5oIgogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29y ZTsKQEAgLTM2LDcgKzM3LDcgQEAgLSAoaWQpaW5pdAogICAgIHNlbGYgPSBbc3VwZXIgaW5pdF07 CiAgICAgaWYgKCFzZWxmKQogICAgICAgICByZXR1cm4gbmlsOwotICAgIG1fY29yZS5zZXQobmV3 IERldmljZU9yaWVudGF0aW9uQ2xpZW50TW9jaygpKTsKKyAgICBtX2NvcmUgPSBhZG9wdFB0cihu ZXcgRGV2aWNlT3JpZW50YXRpb25DbGllbnRNb2NrKCkpOwogICAgIHJldHVybiBzZWxmOwogfQog CkluZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlRleHRJdGVyYXRvci5tbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlRleHRJdGVyYXRvci5tbQko cmV2aXNpb24gODQ4ODApCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlRleHRJdGVy YXRvci5tbQkod29ya2luZyBjb3B5KQpAQCAtNzEsNyArNzEsNyBAQCAtIChpZClpbml0V2l0aFJh bmdlOihET01SYW5nZSAqKXJhbmdlCiAgICAgICAgIHJldHVybiBzZWxmOwogICAgIAogICAgIF9w cml2YXRlID0gW1tXZWJUZXh0SXRlcmF0b3JQcml2YXRlIGFsbG9jXSBpbml0XTsKLSAgICBfcHJp dmF0ZS0+X3RleHRJdGVyYXRvci5zZXQobmV3IFRleHRJdGVyYXRvcihjb3JlKHJhbmdlKSkpOwor ICAgIF9wcml2YXRlLT5fdGV4dEl0ZXJhdG9yID0gYWRvcHRQdHIobmV3IFRleHRJdGVyYXRvcihj b3JlKHJhbmdlKSkpOwogICAgIHJldHVybiBzZWxmOwogfQogCg==