59416 2011-04-25 21:39:19 -0700 Fix timestamp comparison in check-for-weak-vtables-and-externals 2011-04-26 07:47:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mihaip mihaip aroben commit-queue darin eric oldest_to_newest 392241 0 mihaip 2011-04-25 21:39:19 -0700 Fix timestamp comparison in check-for-weak-vtables-and-externals 392245 1 91052 mihaip 2011-04-25 21:40:11 -0700 Created attachment 91052 Patch 392246 2 mihaip 2011-04-25 21:41:55 -0700 Seems to shave a couple of seconds off a no-op build on my 12 core Mac Pro (currently at 21 seconds). 392269 3 91052 eric 2011-04-25 22:46:10 -0700 Comment on attachment 91052 Patch Yay! What about the exit-time-destructors you were mentioning today? 392276 4 mihaip 2011-04-25 22:57:49 -0700 (In reply to comment #3) > (From update of attachment 91052 [details]) > Yay! What about the exit-time-destructors you were mentioning today? I think I got that mixed up with this script; it seems to behave as expected. 392326 5 91052 commit-queue 2011-04-26 00:23:58 -0700 Comment on attachment 91052 Patch Rejecting attachment 91052 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 1 Last 500 characters of output: return self.open(self.click(*args, **kwds)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://queues.webkit.org/results/8510508 392453 6 91052 commit-queue 2011-04-26 07:47:26 -0700 Comment on attachment 91052 Patch Clearing flags on attachment: 91052 Committed r84912: <http://trac.webkit.org/changeset/84912> 392454 7 commit-queue 2011-04-26 07:47:31 -0700 All reviewed patches have been landed. Closing bug. 91052 2011-04-25 21:40:11 -0700 2011-04-26 07:47:26 -0700 Patch bug-59416-20110425214010.patch text/plain 1543 mihaip U3VidmVyc2lvbiBSZXZpc2lvbjogODQ4NjQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3M2FlZDZjZmUyYjkwNmY0NzEzNTE0MWYzYTQ4ZTk3MjNk YWIxYmRlLi5mZjEyNmEyMzY1MTY3OGU2ZWI5YTE2ZTllYjVhYTJlMjUwOTZjOTQxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDQtMjUgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRpbWVz dGFtcCBjb21wYXJpc29uIGluIGNoZWNrLWZvci13ZWFrLXZ0YWJsZXMtYW5kLWV4dGVybmFscwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTk0MTYKKyAg ICAgICAgCisgICAgICAgIFdlIHNob3VsZCBvbmx5IHJlLXJ1biB0aGUgY2hlY2stZm9yLXdlYWst dnRhYmxlcy1hbmQtZXh0ZXJuYWxzIHNjcmlwdAorICAgICAgICBpZiB0aGUgZXhlY3V0YWJsZSBp cyBtb3JlIHJlY2VudCB0aGFuIHRoZSBsYXN0IHJ1bi4KKworICAgICAgICAqIFNjcmlwdHMvY2hl Y2stZm9yLXdlYWstdnRhYmxlcy1hbmQtZXh0ZXJuYWxzOgorCiAyMDExLTA0LTI1ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4K ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9yLXdlYWstdnRhYmxlcy1hbmQtZXh0 ZXJuYWxzIGIvVG9vbHMvU2NyaXB0cy9jaGVjay1mb3Itd2Vhay12dGFibGVzLWFuZC1leHRlcm5h bHMKaW5kZXggYTNkYzM2NDE3ODI2NDIxYmNjOGQ5YzYxN2IwZGZmMzhlNTlmMTNlYi4uZGZiZjg5 ZmVmZjQ1NTQ4YmEwZmNlZWE0YmRhZjhiZjE5ZTQ2MTRkYyAxMDA3NTUKLS0tIGEvVG9vbHMvU2Ny aXB0cy9jaGVjay1mb3Itd2Vhay12dGFibGVzLWFuZC1leHRlcm5hbHMKKysrIGIvVG9vbHMvU2Ny aXB0cy9jaGVjay1mb3Itd2Vhay12dGFibGVzLWFuZC1leHRlcm5hbHMKQEAgLTU2LDcgKzU2LDcg QEAgbXkgJGV4ZWN1dGFibGVQYXRoQWdlID0gLU0gJGV4ZWN1dGFibGVQYXRoOwogCiBteSAkc2F3 RXJyb3IgPSAwOwogCi1pZiAoIWRlZmluZWQgJGV4ZWN1dGFibGVQYXRoQWdlIHx8ICFkZWZpbmVk ICRidWlsZFRpbWVzdGFtcEFnZSB8fCAkZXhlY3V0YWJsZVBhdGhBZ2UgPiAkYnVpbGRUaW1lc3Rh bXBBZ2UpIHsKK2lmICghZGVmaW5lZCAkZXhlY3V0YWJsZVBhdGhBZ2UgfHwgIWRlZmluZWQgJGJ1 aWxkVGltZXN0YW1wQWdlIHx8ICRleGVjdXRhYmxlUGF0aEFnZSA8ICRidWlsZFRpbWVzdGFtcEFn ZSkgewogICAgIGlmICghb3BlbiBOTSwgIihubSAtbSAnJGV4ZWN1dGFibGVQYXRoJyB8IGMrK2Zp bHQgfCBzZWQgJ3MvXi9TVERPVVQ6LycpIDI+JjEgfCIpIHsKICAgICAgICAgcHJpbnQgIkVSUk9S OiBDb3VsZCBub3Qgb3BlbiAkZXhlY3V0YWJsZVBhdGhcbiI7CiAgICAgICAgICRzYXdFcnJvciA9 IDE7Cg==