59401 2011-04-25 16:50:19 -0700 JavaScriptCore should play nice strict OwnPtrs 2011-04-25 21:39:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth oldest_to_newest 392115 0 abarth 2011-04-25 16:50:19 -0700 JavaScriptCore should play nice strict OwnPtrs 392116 1 91019 abarth 2011-04-25 16:51:20 -0700 Created attachment 91019 Patch 392125 2 abarth 2011-04-25 16:54:49 -0700 Committed r84846: <http://trac.webkit.org/changeset/84846> 392244 3 91019 eric 2011-04-25 21:39:45 -0700 Comment on attachment 91019 Patch Cleared review? from attachment 91019 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 91019 2011-04-25 16:51:20 -0700 2011-04-25 21:39:45 -0700 Patch bug-59401-20110425165118.patch text/plain 4457 abarth SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODQ4NDMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTEtMDQtMjUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKYXZhU2NyaXB0Q29yZSBzaG91 bGQgcGxheSBuaWNlIHN0cmljdCBPd25QdHJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01OTQwMQorCisgICAgICAgICogZGZnL0RGR0J5dGVDb2RlUGFy c2VyLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpCeXRlQ29kZVBhcnNlcjo6cGFyc2UpOgorICAg ICAgICAqIGhlYXAvSGVhcC5jcHA6CisgICAgICAgIChKU0M6OlR5cGVDb3VudGVyOjpUeXBlQ291 bnRlcik6CisgICAgICAgICogaml0L0pJVFN0dWJzLmNwcDoKKyAgICAgICAgKEpTQzo6SklUVGh1 bmtzOjpKSVRUaHVua3MpOgorICAgICAgICAqIHBhcnNlci9KU1BhcnNlci5jcHA6CisgICAgICAg IChKU0M6OkpTUGFyc2VyOjpTY29wZTo6U2NvcGUpOgorICAgICAgICAqIHlhcnIvWWFyckpJVC5j cHA6CisgICAgICAgIChKU0M6OllhcnI6OllhcnJHZW5lcmF0b3I6OkdlbmVyYXRpb25TdGF0ZTo6 YWRkUGFyZW50aGVzZXNUYWlsKToKKwogMjAxMS0wNC0yNSAgTWFyayBSb3dlICA8bXJvd2VAYXBw bGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCShyZXZpc2lvbiA4NDgzNikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMTA1LDggKzExMDUsOSBAQCBib29sIEJ5dGVDb2RlUGFyc2VyOjpwYXJzZSgpCiAK ICAgICAgICAgLy8gTG9vcCB1bnRpbCB3ZSByZWFjaCB0aGUgY3VycmVudCBsaW1pdCAoaS5lLiBu ZXh0IGp1bXAgdGFyZ2V0KS4KICAgICAgICAgZG8gewotICAgICAgICAgICAgbV9jdXJyZW50Qmxv Y2sgPSBuZXcgQmFzaWNCbG9jayhtX2N1cnJlbnRJbmRleCwgbV9ncmFwaC5zaXplKCksIG1fbnVt QXJndW1lbnRzLCBtX251bUxvY2Fscyk7Ci0gICAgICAgICAgICBtX2dyYXBoLm1fYmxvY2tzLmFw cGVuZChtX2N1cnJlbnRCbG9jayk7CisgICAgICAgICAgICBPd25QdHI8QmFzaWNCbG9jaz4gYmxv Y2sgPSBhZG9wdFB0cihuZXcgQmFzaWNCbG9jayhtX2N1cnJlbnRJbmRleCwgbV9ncmFwaC5zaXpl KCksIG1fbnVtQXJndW1lbnRzLCBtX251bUxvY2FscykpOworICAgICAgICAgICAgbV9jdXJyZW50 QmxvY2sgPSBibG9jay5nZXQoKTsKKyAgICAgICAgICAgIG1fZ3JhcGgubV9ibG9ja3MuYXBwZW5k KGJsb2NrLnJlbGVhc2UoKSk7CiAKICAgICAgICAgICAgIGlmICghcGFyc2VCbG9jayhsaW1pdCkp CiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2hlYXAvSGVhcC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGVhcC5jcHAJKHJldmlzaW9uIDg0ODM2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGVhcC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxNiw3ICszMTYsNyBAQCBwcml2YXRlOgog fTsKIAogaW5saW5lIFR5cGVDb3VudGVyOjpUeXBlQ291bnRlcigpCi0gICAgOiBtX3R5cGVDb3Vu dFNldChuZXcgVHlwZUNvdW50U2V0KQorICAgIDogbV90eXBlQ291bnRTZXQoYWRvcHRQdHIobmV3 IFR5cGVDb3VudFNldCkpCiB7CiB9CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv SklUU3R1YnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU U3R1YnMuY3BwCShyZXZpc2lvbiA4NDgzNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv SklUU3R1YnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NTIsNyArNzUyLDcgQEAgX19hc20gdm9p ZCBjdGlPcFRocm93Tm90Q2F1Z2h0KCkKICNlbmRpZgogCiBKSVRUaHVua3M6OkpJVFRodW5rcyhK U0dsb2JhbERhdGEqIGdsb2JhbERhdGEpCi0gICAgOiBtX2hvc3RGdW5jdGlvblN0dWJNYXAobmV3 IEhvc3RGdW5jdGlvblN0dWJNYXApCisgICAgOiBtX2hvc3RGdW5jdGlvblN0dWJNYXAoYWRvcHRQ dHIobmV3IEhvc3RGdW5jdGlvblN0dWJNYXApKQogewogICAgIGlmICghZ2xvYmFsRGF0YS0+ZXhl Y3V0YWJsZUFsbG9jYXRvci5pc1ZhbGlkKCkpCiAgICAgICAgIHJldHVybjsKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvSlNQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvSlNQYXJzZXIuY3BwCShyZXZpc2lvbiA4NDgzNikKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvSlNQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yOTEsNyArMjkxLDYgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICwgbV9pc1ZhbGlkU3Ry aWN0TW9kZSh0cnVlKQogICAgICAgICAgICAgLCBtX2xvb3BEZXB0aCgwKQogICAgICAgICAgICAg LCBtX3N3aXRjaERlcHRoKDApCi0gICAgICAgICAgICAsIG1fbGFiZWxzKDApCiAgICAgICAgIHsK ICAgICAgICAgfQogCkBAIC0zMDcsNyArMzA2LDYgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICwg bV9pc1ZhbGlkU3RyaWN0TW9kZShyaHMubV9pc1ZhbGlkU3RyaWN0TW9kZSkKICAgICAgICAgICAg ICwgbV9sb29wRGVwdGgocmhzLm1fbG9vcERlcHRoKQogICAgICAgICAgICAgLCBtX3N3aXRjaERl cHRoKHJocy5tX3N3aXRjaERlcHRoKQotICAgICAgICAgICAgLCBtX2xhYmVscygwKQogICAgICAg ICB7CiAgICAgICAgICAgICBpZiAocmhzLm1fbGFiZWxzKSB7CiAgICAgICAgICAgICAgICAgbV9s YWJlbHMgPSBhZG9wdFB0cihuZXcgTGFiZWxTdGFjayk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUveWFyci9ZYXJySklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUveWFyci9ZYXJySklULmNwcAkocmV2aXNpb24gODQ4MzYpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUveWFyci9ZYXJySklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDE3LDExICs0MTcsMTMg QEAgY2xhc3MgWWFyckdlbmVyYXRvciA6IHByaXZhdGUgTWFjcm9Bc3NlbQogCiAgICAgICAgIFBh cmVudGhlc2VzVGFpbCogYWRkUGFyZW50aGVzZXNUYWlsKFBhdHRlcm5UZXJtJiB0ZXJtLCBKdW1w TGlzdCoganVtcExpc3RUb1ByaW9yUGFyZW4pCiAgICAgICAgIHsKLSAgICAgICAgICAgIFBhcmVu dGhlc2VzVGFpbCogcGFyZW50aGVzZXNUYWlsID0gbmV3IFBhcmVudGhlc2VzVGFpbCh0ZXJtLCBt X3BhcmVuTmVzdGluZ0xldmVsLCBqdW1wTGlzdFRvUHJpb3JQYXJlbik7Ci0gICAgICAgICAgICBt X3BhcmVuVGFpbHMuYXBwZW5kKHBhcmVudGhlc2VzVGFpbCk7Ci0gICAgICAgICAgICBtX3BhcmVu VGFpbHNGb3JJdGVyYXRpb24uYXBwZW5kKHBhcmVudGhlc2VzVGFpbCk7CisgICAgICAgICAgICBP d25QdHI8UGFyZW50aGVzZXNUYWlsPiB0YWlsID0gYWRvcHRQdHIobmV3IFBhcmVudGhlc2VzVGFp bCh0ZXJtLCBtX3BhcmVuTmVzdGluZ0xldmVsLCBqdW1wTGlzdFRvUHJpb3JQYXJlbikpOworICAg ICAgICAgICAgUGFyZW50aGVzZXNUYWlsKiByYXdUYWlsID0gdGFpbC5nZXQoKTsKIAotICAgICAg ICAgICAgcmV0dXJuIHBhcmVudGhlc2VzVGFpbDsKKyAgICAgICAgICAgIG1fcGFyZW5UYWlscy5h cHBlbmQodGFpbC5yZWxlYXNlKCkpOworICAgICAgICAgICAgbV9wYXJlblRhaWxzRm9ySXRlcmF0 aW9uLmFwcGVuZChyYXdUYWlsKTsKKworICAgICAgICAgICAgcmV0dXJuIHJhd1RhaWw7CiAgICAg ICAgIH0KIAogICAgICAgICB2b2lkIGVtaXRQYXJlbnRoZXNlc1RhaWwoWWFyckdlbmVyYXRvciog Z2VuZXJhdG9yKQo=