5939 2005-12-04 23:27:08 -0800 final comma in javascript object prevents parsing 2006-01-11 09:19:00 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 RESOLVED FIXED http://ruphus.com/stash/comma-problem.html P2 Normal --- 1 pathall darin oldest_to_newest 25543 0 pathall 2005-12-04 23:27:08 -0800 In firefox the final comma in the object "pt" doesn't prevent the script from being parsed, but in Safari it does. 27701 1 5469 ricciadams 2006-01-03 22:30:05 -0800 Created attachment 5469 Patch and test case 27742 2 5469 darin 2006-01-04 13:03:29 -0800 Comment on attachment 5469 Patch and test case Does adding this rule create any conflicts in the grammar? If not, then we're fine. If so, we should look for a way of fixing things so that there are no conflicts. The way to find out is to build and look for output from bison when compiling the grammar file. 27770 3 ricciadams 2006-01-04 23:43:53 -0800 Darin, I do not see any conflicts when bisoning JavaScriptCore/kjs/grammar.y with my patch. However, my grep did turn up conflicts in the CSS parser, which I documented here: http:// bugzilla.opendarwin.org/show_bug.cgi?id=6380 27845 4 5469 mjs 2006-01-06 01:49:05 -0800 Comment on attachment 5469 Patch and test case r=me 5469 2006-01-03 22:30:05 -0800 2006-01-06 01:49:05 -0800 Patch and test case 5939.txt text/plain 2273 ricciadams SW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9ncmFtbWFyLnkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9yb290L0phdmFTY3JpcHRDb3JlL2tqcy9ncmFtbWFyLnksdgpyZXRyaWV2aW5nIHJldmlz aW9uIDEuMzIKZGlmZiAtcCAtdSAtcjEuMzIgSmF2YVNjcmlwdENvcmUva2pzL2dyYW1tYXIueQot LS0gSmF2YVNjcmlwdENvcmUva2pzL2dyYW1tYXIueQkxMyBEZWMgMjAwNSAyMToyNDo1MSAtMDAw MAkxLjMyCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvZ3JhbW1hci55CTQgSmFuIDIwMDYgMDY6MzE6 MzMgLTAwMDAKQEAgLTIyNiw2ICsyMjYsNyBAQCBQcmltYXJ5RXhwcjoKICAgICBQcmltYXJ5RXhw ck5vQnJhY2UKICAgfCAneycgJ30nICAgICAgICAgICAgICAgICAgICAgICAgICAgICB7ICQkID0g bmV3IE9iamVjdExpdGVyYWxOb2RlKCk7IH0KICAgfCAneycgUHJvcGVydHlMaXN0ICd9JyAgICAg ICAgICAgICAgICB7ICQkID0gbmV3IE9iamVjdExpdGVyYWxOb2RlKCQyKTsgfQorICB8ICd7JyBQ cm9wZXJ0eUxpc3QgJywnICd9JyAgICAgICAgICAgIHsgJCQgPSBuZXcgT2JqZWN0TGl0ZXJhbE5v ZGUoJDIpOyB9CiA7CiAKIFByaW1hcnlFeHByTm9CcmFjZToKSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvanMvb2JqZWN0LWV4dHJhLWNvbW1hLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CmRpZmYgLU5w dSBMYXlvdXRUZXN0cy9mYXN0L2pzL29iamVjdC1leHRyYS1jb21tYS1leHBlY3RlZC50eHQKLS0t IExheW91dFRlc3RzL2Zhc3QvanMvb2JqZWN0LWV4dHJhLWNvbW1hLWV4cGVjdGVkLnR4dAkxIEph biAxOTcwIDAwOjAwOjAwIC0wMDAwCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL29iamVjdC1leHRy YS1jb21tYS1leHBlY3RlZC50eHQJNCBKYW4gMjAwNiAwNjoxODoyNiAtMDAwMApAQCAtMCwwICsx LDMgQEAKK1RoaXMgdGVzdHMgZm9yIHJlZ3Jlc3Npb25zIHRvIGh0dHA6Ly9idWd6aWxsYS5vcGVu ZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkzOS4gSWYgdGhpcyB0ZXN0IGlzIHN1Y2Nlc3Nm dWwsICJZRVMiIHNob3VsZCBiZSBkaXNwbGF5ZWQgYmVsb3cuCitZRVMKKwpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9qcy9vYmplY3QtZXh0cmEtY29tbWEuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CmRpZmYgLU5w dSBMYXlvdXRUZXN0cy9mYXN0L2pzL29iamVjdC1leHRyYS1jb21tYS5odG1sCi0tLSBMYXlvdXRU ZXN0cy9mYXN0L2pzL29iamVjdC1leHRyYS1jb21tYS5odG1sCTEgSmFuIDE5NzAgMDA6MDA6MDAg LTAwMDAKKysrIExheW91dFRlc3RzL2Zhc3QvanMvb2JqZWN0LWV4dHJhLWNvbW1hLmh0bWwJNCBK YW4gMjAwNiAwNjoxNjoyNiAtMDAwMApAQCAtMCwwICsxLDI3IEBACis8aHRtbD4KKzxoZWFkPgor ICAgIDxzY3JpcHQ+CisgICAgZnVuY3Rpb24gZGVidWcocykgeworICAgICAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgnY29uc29sZScpLmlubmVySFRNTCArPSBzICsgJzxicj4nOworICAgIH0K KyAgICAKKyAgICBmdW5jdGlvbiB0ZXN0KCkgeworICAgICAgICBmb3IgKGogaW4gaW5kZXgpIHsK KyAgICAgICAgICAgIHRlc3RQcm9wZXJ0eShpbmRleFtqXSk7CisgICAgICAgIH0KKyAgICB9Cisg ICAgZnVuY3Rpb24gcnVuVGVzdHMoKSB7CisgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCkK KyAgICAgICAgdmFyIGZvbyA9IHsgImJhciIgOiAiWUVTIiwgfQorICAgICAgICBkZWJ1Zyhmb29b ImJhciJdKQorICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9uTG9hZD0icnVu VGVzdHMoKSI+CitUaGlzIHRlc3RzIGZvciByZWdyZXNzaW9ucyB0byA8YSBocmVmPSJodHRwOi8v YnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTU5MzkiPmh0dHA6Ly9idWd6 aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkzOTwvYT4uCitJZiB0aGlzIHRl c3QgaXMgc3VjY2Vzc2Z1bCwgJnF1b3Q7WUVTJnF1b3Q7IHNob3VsZCBiZSBkaXNwbGF5ZWQgYmVs b3cuCis8L2JvZHk+Cis8cHJlIGlkPSJjb25zb2xlIj4KKzwvcHJlPgorPC9odG1sPgo=