59382 2011-04-25 16:15:31 -0700 WebCore/css/CSS* files should play nice with strict OwnPtrs 2011-04-25 16:41:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 enne enne abarth enne eric webkit.review.bot oldest_to_newest 392022 0 enne 2011-04-25 16:15:31 -0700 WebCore/css/CSS* files should play nice with strict OwnPtrs 392028 1 90988 enne 2011-04-25 16:16:31 -0700 Created attachment 90988 Patch 392041 2 90988 levin 2011-04-25 16:20:04 -0700 Comment on attachment 90988 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90988&action=review two nits to fix. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Fix this :) > Source/WebCore/css/CSSFontFaceSource.cpp:167 > fontDescription.textOrientation(), fontDescription.widthVariant(), fontDescription.renderingMode()), true, false)); This should be indented further. 392082 3 enne 2011-04-25 16:37:01 -0700 Committed r84836: <http://trac.webkit.org/changeset/84836> 392093 4 webkit.review.bot 2011-04-25 16:41:44 -0700 http://trac.webkit.org/changeset/84836 might have broken Chromium Linux Release 90988 2011-04-25 16:16:31 -0700 2011-04-25 16:20:04 -0700 Patch bug-59382-20110425161630.patch text/plain 4756 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODQ4MTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZDJlODkxMDE4NzMyMDY2 MTIxMDMwMDIzNGU2OTNmMTkxZjViNmI2Li5lMjI1YjAzYWZlODAwYjk0YWViMzIxYmNjMmI2YTkw OGE3NGI0NDRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMjUgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWJDb3JlL2Nzcy9DU1MqIGZpbGVzIHNob3VsZCBwbGF5 IG5pY2Ugd2l0aCBzdHJpY3QgT3duUHRycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTkzODIKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkK KworICAgICAgICAqIGNzcy9DU1NGb250RmFjZVNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDU1NGb250RmFjZVNvdXJjZTo6Z2V0Rm9udERhdGEpOgorICAgICAgICAqIGNzcy9DU1NQYXJz ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjphZGRQcm9wZXJ0eSk6CisgICAg ICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlVmFsdWUpOgorCiAyMDExLTA0LTI1ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQXR0ZW1wdCB0byBmaXggdGhl IGNvbXBpbGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9udEZhY2VTb3Vy Y2UuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRGYWNlU291cmNlLmNwcAppbmRleCBl ZWI5MGE0M2M2NGY4OGM4ZGM2OWUzNDUwZjE5Yjc2YzRlNTZiMGEwLi5iMGY3MzY1ZDYzZWI5Mjky YzA5MjNlOTBmM2Q1NmVmOWUyNWU5YTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTRm9udEZhY2VTb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250RmFj ZVNvdXJjZS5jcHAKQEAgLTE1NCw3ICsxNTQsNyBAQCBTaW1wbGVGb250RGF0YSogQ1NTRm9udEZh Y2VTb3VyY2U6OmdldEZvbnREYXRhKGNvbnN0IEZvbnREZXNjcmlwdGlvbiYgZm9udERlc2NyaQog ICAgICAgICAgICAgICAgICAgICAgICAgbV9zdmdGb250RmFjZUVsZW1lbnQgPSBmb250RmFjZUVs ZW1lbnQ7CiAgICAgICAgICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgICAgICAgICBmb250 RGF0YS5zZXQobmV3IFNpbXBsZUZvbnREYXRhKGFkb3B0UHRyKG5ldyBTVkdGb250RGF0YShmb250 RmFjZUVsZW1lbnQpKSwgZm9udERlc2NyaXB0aW9uLmNvbXB1dGVkUGl4ZWxTaXplKCksIHN5bnRo ZXRpY0JvbGQsIHN5bnRoZXRpY0l0YWxpYykpOworICAgICAgICAgICAgICAgICAgICBmb250RGF0 YSA9IGFkb3B0UHRyKG5ldyBTaW1wbGVGb250RGF0YShhZG9wdFB0cihuZXcgU1ZHRm9udERhdGEo Zm9udEZhY2VFbGVtZW50KSksIGZvbnREZXNjcmlwdGlvbi5jb21wdXRlZFBpeGVsU2l6ZSgpLCBz eW50aGV0aWNCb2xkLCBzeW50aGV0aWNJdGFsaWMpKTsKICAgICAgICAgICAgICAgICB9CiAgICAg ICAgICAgICB9IGVsc2UKICNlbmRpZgpAQCAtMTYzLDE0ICsxNjMsMTQgQEAgU2ltcGxlRm9udERh dGEqIENTU0ZvbnRGYWNlU291cmNlOjpnZXRGb250RGF0YShjb25zdCBGb250RGVzY3JpcHRpb24m IGZvbnREZXNjcmkKICAgICAgICAgICAgICAgICBpZiAoIW1fZm9udC0+ZW5zdXJlQ3VzdG9tRm9u dERhdGEoKSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICAgICAgICAgICAg ICBmb250RGF0YS5zZXQobmV3IFNpbXBsZUZvbnREYXRhKG1fZm9udC0+cGxhdGZvcm1EYXRhRnJv bUN1c3RvbURhdGEoZm9udERlc2NyaXB0aW9uLmNvbXB1dGVkUGl4ZWxTaXplKCksIHN5bnRoZXRp Y0JvbGQsIHN5bnRoZXRpY0l0YWxpYywgZm9udERlc2NyaXB0aW9uLm9yaWVudGF0aW9uKCksCisg ICAgICAgICAgICAgICAgZm9udERhdGEgPSBhZG9wdFB0cihuZXcgU2ltcGxlRm9udERhdGEobV9m b250LT5wbGF0Zm9ybURhdGFGcm9tQ3VzdG9tRGF0YShmb250RGVzY3JpcHRpb24uY29tcHV0ZWRQ aXhlbFNpemUoKSwgc3ludGhldGljQm9sZCwgc3ludGhldGljSXRhbGljLCBmb250RGVzY3JpcHRp b24ub3JpZW50YXRpb24oKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZm9udERlc2NyaXB0 aW9uLnRleHRPcmllbnRhdGlvbigpLCBmb250RGVzY3JpcHRpb24ud2lkdGhWYXJpYW50KCksIGZv bnREZXNjcmlwdGlvbi5yZW5kZXJpbmdNb2RlKCkpLCB0cnVlLCBmYWxzZSkpOwogICAgICAgICAg ICAgfQogICAgICAgICB9IGVsc2UgewogI2lmIEVOQUJMRShTVkdfRk9OVFMpCiAgICAgICAgICAg ICAvLyBJbi1Eb2N1bWVudCBTVkcgRm9udHMKICAgICAgICAgICAgIGlmIChtX3N2Z0ZvbnRGYWNl RWxlbWVudCkKLSAgICAgICAgICAgICAgICBmb250RGF0YS5zZXQobmV3IFNpbXBsZUZvbnREYXRh KGFkb3B0UHRyKG5ldyBTVkdGb250RGF0YShtX3N2Z0ZvbnRGYWNlRWxlbWVudC5nZXQoKSkpLCBm b250RGVzY3JpcHRpb24uY29tcHV0ZWRQaXhlbFNpemUoKSwgc3ludGhldGljQm9sZCwgc3ludGhl dGljSXRhbGljKSk7CisgICAgICAgICAgICAgICAgZm9udERhdGEgPSBhZG9wdFB0cihuZXcgU2lt cGxlRm9udERhdGEoYWRvcHRQdHIobmV3IFNWR0ZvbnREYXRhKG1fc3ZnRm9udEZhY2VFbGVtZW50 LmdldCgpKSksIGZvbnREZXNjcmlwdGlvbi5jb21wdXRlZFBpeGVsU2l6ZSgpLCBzeW50aGV0aWNC b2xkLCBzeW50aGV0aWNJdGFsaWMpKTsKICNlbmRpZgogICAgICAgICB9CiAgICAgfSBlbHNlIHsK QEAgLTE4Miw3ICsxODIsNyBAQCBTaW1wbGVGb250RGF0YSogQ1NTRm9udEZhY2VTb3VyY2U6Omdl dEZvbnREYXRhKGNvbnN0IEZvbnREZXNjcmlwdGlvbiYgZm9udERlc2NyaQogICAgICAgICBpZiAo IXRlbXBEYXRhKQogICAgICAgICAgICAgdGVtcERhdGEgPSBmb250Q2FjaGUoKS0+Z2V0TGFzdFJl c29ydEZhbGxiYWNrRm9udChmb250RGVzY3JpcHRpb24pOwogCi0gICAgICAgIGZvbnREYXRhLnNl dChuZXcgU2ltcGxlRm9udERhdGEodGVtcERhdGEtPnBsYXRmb3JtRGF0YSgpLCB0cnVlLCB0cnVl KSk7CisgICAgICAgIGZvbnREYXRhID0gYWRvcHRQdHIobmV3IFNpbXBsZUZvbnREYXRhKHRlbXBE YXRhLT5wbGF0Zm9ybURhdGEoKSwgdHJ1ZSwgdHJ1ZSkpOwogICAgIH0KIAogICAgIFNpbXBsZUZv bnREYXRhKiBmb250RGF0YVJhd1B0ciA9IGZvbnREYXRhLmxlYWtQdHIoKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5jcHAKaW5kZXggMWQ4YjZiMGRjMThmMzhlMjk1MjU0MzU0N2I3MTdiNzI2YjQ5OWQy NC4uYWU2YjYxYjYwYzE5OGNhMDRjOTQxYWRhYjdhOWE1NWQyMmQyMzNiNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1BhcnNlci5jcHAKQEAgLTU4MSw3ICs1ODEsNyBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VN ZWRpYVF1ZXJ5KE1lZGlhTGlzdCogcXVlcmllcywgY29uc3QgU3RyaW5nJiBzdHJpbmcpCiAKIHZv aWQgQ1NTUGFyc2VyOjphZGRQcm9wZXJ0eShpbnQgcHJvcElkLCBQYXNzUmVmUHRyPENTU1ZhbHVl PiB2YWx1ZSwgYm9vbCBpbXBvcnRhbnQpCiB7Ci0gICAgT3duUHRyPENTU1Byb3BlcnR5PiBwcm9w KG5ldyBDU1NQcm9wZXJ0eShwcm9wSWQsIHZhbHVlLCBpbXBvcnRhbnQsIG1fY3VycmVudFNob3J0 aGFuZCwgbV9pbXBsaWNpdFNob3J0aGFuZCkpOworICAgIE93blB0cjxDU1NQcm9wZXJ0eT4gcHJv cChhZG9wdFB0cihuZXcgQ1NTUHJvcGVydHkocHJvcElkLCB2YWx1ZSwgaW1wb3J0YW50LCBtX2N1 cnJlbnRTaG9ydGhhbmQsIG1faW1wbGljaXRTaG9ydGhhbmQpKSk7CiAgICAgaWYgKG1fbnVtUGFy c2VkUHJvcGVydGllcyA+PSBtX21heFBhcnNlZFByb3BlcnRpZXMpIHsKICAgICAgICAgbV9tYXhQ YXJzZWRQcm9wZXJ0aWVzICs9IDMyOwogICAgICAgICBpZiAobV9tYXhQYXJzZWRQcm9wZXJ0aWVz ID4gVUlOVF9NQVggLyBzaXplb2YoQ1NTUHJvcGVydHkqKSkKQEAgLTExMjksNyArMTEyOSw3IEBA IGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVZhbHVlKGludCBwcm9wSWQsIGJvb2wgaW1wb3J0YW50KQog ICAgICAgICAgICAgICAgIHByb3BJZCA9PSBDU1NQcm9wZXJ0eUJhY2tncm91bmRSZXBlYXQgfHwK ICAgICAgICAgICAgICAgICBwcm9wSWQgPT0gQ1NTUHJvcGVydHlXZWJraXRNYXNrUG9zaXRpb24g fHwKICAgICAgICAgICAgICAgICBwcm9wSWQgPT0gQ1NTUHJvcGVydHlXZWJraXRNYXNrUmVwZWF0 KSB7Ci0gICAgICAgICAgICAgICAgc2hvcnRoYW5kU2NvcGUuc2V0KG5ldyBTaG9ydGhhbmRTY29w ZSh0aGlzLCBwcm9wSWQpKTsKKyAgICAgICAgICAgICAgICBzaG9ydGhhbmRTY29wZSA9IGFkb3B0 UHRyKG5ldyBTaG9ydGhhbmRTY29wZSh0aGlzLCBwcm9wSWQpKTsKICAgICAgICAgICAgIH0KICAg ICAgICAgICAgIGFkZFByb3BlcnR5KHByb3BJZDEsIHZhbDEucmVsZWFzZSgpLCBpbXBvcnRhbnQp OwogICAgICAgICAgICAgaWYgKHZhbDIpCg==