59378 2011-04-25 16:10:45 -0700 WebKit2: Should be able to inspect Web Inspector in Debug Builds 2011-04-25 16:43:22 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein aroben timothy oldest_to_newest 392011 0 bweinstein 2011-04-25 16:10:45 -0700 WebKit2: Should be able to inspect Web Inspector in Debug Builds 392015 1 90984 bweinstein 2011-04-25 16:12:24 -0700 Created attachment 90984 [PATCH] Fix 392060 2 90984 aroben 2011-04-25 16:28:10 -0700 Comment on attachment 90984 [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=90984&action=review > Source/WebKit2/UIProcess/WebInspectorProxy.cpp:62 > WebPageGroup* WebInspectorProxy::inspectorPageGroup() > { > - static WebPageGroup* pageGroup = WebPageGroup::create("__WebInspectorPageGroup__", false, false).leakRef(); > + static WebPageGroup* pageGroup; > + if (pageGroup) > + return pageGroup; > + > + pageGroup = WebPageGroup::create("__WebInspectorPageGroup__", false, false).leakRef(); > + > +#ifndef NDEBUG > + // Allow developers to inspect the Web Inspector in debug builds. > + pageGroup->preferences()->setDeveloperExtrasEnabled(true); > +#endif > + > return pageGroup; > } I think it would be clearer to add a separate createInspectorPageGroup() helper function that had all the creation code. Then this function could stay simple. 392079 3 91011 bweinstein 2011-04-25 16:36:23 -0700 Created attachment 91011 [PATCH] Fix v2 392086 4 91011 aroben 2011-04-25 16:37:46 -0700 Comment on attachment 91011 [PATCH] Fix v2 View in context: https://bugs.webkit.org/attachment.cgi?id=91011&action=review > Source/WebKit2/ChangeLog:9 > + (WebKit::WebInspectorProxy::createInspectorPageGroup): Creates an inspector page group and enables The "WebInspectorProxy::" part of this line is incorrect. > Source/WebKit2/UIProcess/WebInspectorProxy.cpp:50 > +static WebPageGroup* createInspectorPageGroup() > +{ > + WebPageGroup* pageGroup = WebPageGroup::create("__WebInspectorPageGroup__", false, false).leakRef(); You should make this function return a PassRefPtr and put the leakRef at the call site. 392095 5 bweinstein 2011-04-25 16:43:22 -0700 Landed in r84841. 90984 2011-04-25 16:12:24 -0700 2011-04-25 16:36:23 -0700 [PATCH] Fix dev_extras_inspector.patch text/plain 1763 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0ODI0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMjUgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdDI6IFNob3VsZCBiZSBhYmxlIHRvIGluc3Bl Y3QgV2ViIEluc3BlY3RvciBpbiBEZWJ1ZyBCdWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5Mzc4CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2Vi SW5zcGVjdG9yUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6 aW5zcGVjdG9yUGFnZUdyb3VwKTogRW5hYmxlIGRldmVsb3BlciBleHRyYXMgb24gdGhlIGluc3Bl Y3RvcgorICAgICAgICAgICAgcGFnZSBncm91cCBpZiB3ZSBhcmUgYSBkZWJ1ZyBidWlsZC4KKwog MjAxMS0wNC0yNSAgQnJpYW4gV2VpbnN0ZWluICA8YndlaW5zdGVpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpJbmRleDogU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwCShyZXZpc2lvbiA4NDc4NSkKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJXZWJJbnNwZWN0b3JNZXNzYWdlcy5o IgogI2luY2x1ZGUgIldlYlBhZ2VQcm94eS5oIgogI2luY2x1ZGUgIldlYlBhZ2VDcmVhdGlvblBh cmFtZXRlcnMuaCIKKyNpbmNsdWRlICJXZWJQcmVmZXJlbmNlcy5oIgogI2luY2x1ZGUgIldlYlBy b2Nlc3NQcm94eS5oIgogI2luY2x1ZGUgIldlYlBhZ2VHcm91cC5oIgogCkBAIC00Niw3ICs0Nywx NyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIAogV2ViUGFnZUdyb3VwKiBXZWJJbnNwZWN0b3JQcm94 eTo6aW5zcGVjdG9yUGFnZUdyb3VwKCkKIHsKLSAgICBzdGF0aWMgV2ViUGFnZUdyb3VwKiBwYWdl R3JvdXAgPSBXZWJQYWdlR3JvdXA6OmNyZWF0ZSgiX19XZWJJbnNwZWN0b3JQYWdlR3JvdXBfXyIs IGZhbHNlLCBmYWxzZSkubGVha1JlZigpOworICAgIHN0YXRpYyBXZWJQYWdlR3JvdXAqIHBhZ2VH cm91cDsKKyAgICBpZiAocGFnZUdyb3VwKQorICAgICAgICByZXR1cm4gcGFnZUdyb3VwOworCisg ICAgcGFnZUdyb3VwID0gV2ViUGFnZUdyb3VwOjpjcmVhdGUoIl9fV2ViSW5zcGVjdG9yUGFnZUdy b3VwX18iLCBmYWxzZSwgZmFsc2UpLmxlYWtSZWYoKTsKKworI2lmbmRlZiBOREVCVUcKKyAgICAv LyBBbGxvdyBkZXZlbG9wZXJzIHRvIGluc3BlY3QgdGhlIFdlYiBJbnNwZWN0b3IgaW4gZGVidWcg YnVpbGRzLgorICAgIHBhZ2VHcm91cC0+cHJlZmVyZW5jZXMoKS0+c2V0RGV2ZWxvcGVyRXh0cmFz RW5hYmxlZCh0cnVlKTsKKyNlbmRpZgorCiAgICAgcmV0dXJuIHBhZ2VHcm91cDsKIH0KIAo= 91011 2011-04-25 16:36:23 -0700 2011-04-25 16:37:46 -0700 [PATCH] Fix v2 dev_extras_inspector.patch text/plain 1963 bweinstein SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0ODI0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQtMjUgIEJyaWFuIFdl aW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktpdDI6IFNob3VsZCBiZSBhYmxlIHRvIGluc3Bl Y3QgV2ViIEluc3BlY3RvciBpbiBEZWJ1ZyBCdWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5Mzc4CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2Vi SW5zcGVjdG9yUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6 Y3JlYXRlSW5zcGVjdG9yUGFnZUdyb3VwKTogQ3JlYXRlcyBhbiBpbnNwZWN0b3IgcGFnZSBncm91 cCBhbmQgZW5hYmxlcworICAgICAgICAgICAgZGV2ZWxvcGVyIGV4dHJhcyBpbiBhIGRlYnVnIGJ1 aWxkLgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6aW5zcGVjdG9yUGFnZUdy b3VwKTogQ2FsbHMgY3JlYXRlSW5zcGVjdG9yUGFnZUdyb3VwLgorCiAyMDExLTA0LTI1ICBCcmlh biBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBUaW1vdGh5IEhhdGNoZXIuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5z cGVjdG9yUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJJbnNwZWN0b3JQcm94eS5jcHAJKHJldmlzaW9uIDg0Nzg1KQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzEsNiAr MzEsNyBAQAogI2luY2x1ZGUgIldlYkluc3BlY3Rvck1lc3NhZ2VzLmgiCiAjaW5jbHVkZSAiV2Vi UGFnZVByb3h5LmgiCiAjaW5jbHVkZSAiV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycy5oIgorI2lu Y2x1ZGUgIldlYlByZWZlcmVuY2VzLmgiCiAjaW5jbHVkZSAiV2ViUHJvY2Vzc1Byb3h5LmgiCiAj aW5jbHVkZSAiV2ViUGFnZUdyb3VwLmgiCiAKQEAgLTQ0LDkgKzQ1LDIxIEBAIHVzaW5nIG5hbWVz cGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAorc3RhdGljIFdlYlBhZ2VHcm91 cCogY3JlYXRlSW5zcGVjdG9yUGFnZUdyb3VwKCkKK3sKKyAgICBXZWJQYWdlR3JvdXAqIHBhZ2VH cm91cCA9IFdlYlBhZ2VHcm91cDo6Y3JlYXRlKCJfX1dlYkluc3BlY3RvclBhZ2VHcm91cF9fIiwg ZmFsc2UsIGZhbHNlKS5sZWFrUmVmKCk7CisKKyNpZm5kZWYgTkRFQlVHCisgICAgLy8gQWxsb3cg ZGV2ZWxvcGVycyB0byBpbnNwZWN0IHRoZSBXZWIgSW5zcGVjdG9yIGluIGRlYnVnIGJ1aWxkcy4K KyAgICBwYWdlR3JvdXAtPnByZWZlcmVuY2VzKCktPnNldERldmVsb3BlckV4dHJhc0VuYWJsZWQo dHJ1ZSk7CisjZW5kaWYKKworICAgIHJldHVybiBwYWdlR3JvdXA7Cit9CisKIFdlYlBhZ2VHcm91 cCogV2ViSW5zcGVjdG9yUHJveHk6Omluc3BlY3RvclBhZ2VHcm91cCgpCiB7Ci0gICAgc3RhdGlj IFdlYlBhZ2VHcm91cCogcGFnZUdyb3VwID0gV2ViUGFnZUdyb3VwOjpjcmVhdGUoIl9fV2ViSW5z cGVjdG9yUGFnZUdyb3VwX18iLCBmYWxzZSwgZmFsc2UpLmxlYWtSZWYoKTsKKyAgICBzdGF0aWMg V2ViUGFnZUdyb3VwKiBwYWdlR3JvdXAgPSBjcmVhdGVJbnNwZWN0b3JQYWdlR3JvdXAoKTsKICAg ICByZXR1cm4gcGFnZUdyb3VwOwogfQogCg==