59375 2011-04-25 16:07:44 -0700 Fix strict OwnPtrs in ContextMenuController.cpp 2011-04-26 00:32:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 levin levin oldest_to_newest 391996 0 levin 2011-04-25 16:07:44 -0700 Fix strict OwnPtrs in ContextMenuController.cpp 391998 1 90980 levin 2011-04-25 16:08:36 -0700 Created attachment 90980 Patch 392009 2 90980 abarth 2011-04-25 16:10:05 -0700 Comment on attachment 90980 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90980&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) OOPS! > Source/WebCore/page/ContextMenuController.cpp:126 > - return 0; > + return adoptPtr<ContextMenu>(0); PassOwnPtr<ContextMenu>() 392017 3 90985 levin 2011-04-25 16:13:37 -0700 Created attachment 90985 Patch 392018 4 90985 kbr 2011-04-25 16:15:11 -0700 Comment on attachment 90985 Patch Looks good to me. 392334 5 levin 2011-04-26 00:32:30 -0700 Committed as http://trac.webkit.org/changeset/84829 90980 2011-04-25 16:08:36 -0700 2011-04-25 16:13:33 -0700 Patch bug-59375-20110425160835.patch text/plain 2347 levin U3VidmVyc2lvbiBSZXZpc2lvbjogODQ4MjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmOGU1YzQ2ZjgyN2RiZGQ0 ZDdiNjFhNTFkMjk3MGM5YTc3ZWI3NDk1Li40NTQyOGNjNGJlZjZiNTdiODE3ZmQxMmYyMzE2MWMz MTEyYjU4MGE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDQtMjUgIERhdmlk IExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBzdHJpY3QgT3duUHRycyBpbiBDb250ZXh0TWVudUNv bnRyb2xsZXIuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01OTM3NQorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICog cGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGV4 dE1lbnVDb250cm9sbGVyOjpjcmVhdGVDb250ZXh0TWVudSk6CisgICAgICAgIChXZWJDb3JlOjpz ZXBhcmF0b3JJdGVtKToKKwogMjAxMS0wNC0yNSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBw bGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeDogVGhpcyB0aW1lIGZvciBzdXJlIQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwCmluZGV4IGEwZTY0Yjgw ZDI3Yjk5ODQ4YjBiODU0YmY3NDhmZDUwNDUxNjI1N2MuLmZmYTVjNmJhMzUzMGE3YmRmYmIyYWU1 ODRmOTExYzdmOWI4YTYzYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ29udGV4 dE1lbnVDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRleHRNZW51 Q29udHJvbGxlci5jcHAKQEAgLTEyMyw3ICsxMjMsNyBAQCB2b2lkIENvbnRleHRNZW51Q29udHJv bGxlcjo6c2hvd0NvbnRleHRNZW51KEV2ZW50KiBldmVudCwgUGFzc1JlZlB0cjxDb250ZXh0TWVu dQogUGFzc093blB0cjxDb250ZXh0TWVudT4gQ29udGV4dE1lbnVDb250cm9sbGVyOjpjcmVhdGVD b250ZXh0TWVudShFdmVudCogZXZlbnQpCiB7CiAgICAgaWYgKCFldmVudC0+aXNNb3VzZUV2ZW50 KCkpCi0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4gYWRvcHRQdHI8Q29udGV4dE1l bnU+KDApOwogCiAgICAgTW91c2VFdmVudCogbW91c2VFdmVudCA9IHN0YXRpY19jYXN0PE1vdXNl RXZlbnQqPihldmVudCk7CiAgICAgSGl0VGVzdFJlc3VsdCByZXN1bHQobW91c2VFdmVudC0+YWJz b2x1dGVMb2NhdGlvbigpKTsKQEAgLTEzMiwxMSArMTMyLDExIEBAIFBhc3NPd25QdHI8Q29udGV4 dE1lbnU+IENvbnRleHRNZW51Q29udHJvbGxlcjo6Y3JlYXRlQ29udGV4dE1lbnUoRXZlbnQqIGV2 ZW50KQogICAgICAgICByZXN1bHQgPSBmcmFtZS0+ZXZlbnRIYW5kbGVyKCktPmhpdFRlc3RSZXN1 bHRBdFBvaW50KG1vdXNlRXZlbnQtPmFic29sdXRlTG9jYXRpb24oKSwgZmFsc2UpOwogCiAgICAg aWYgKCFyZXN1bHQuaW5uZXJOb25TaGFyZWROb2RlKCkpCi0gICAgICAgIHJldHVybiAwOworICAg ICAgICByZXR1cm4gYWRvcHRQdHI8Q29udGV4dE1lbnU+KDApOwogCiAgICAgbV9oaXRUZXN0UmVz dWx0ID0gcmVzdWx0OwogCi0gICAgcmV0dXJuIG5ldyBDb250ZXh0TWVudTsKKyAgICByZXR1cm4g YWRvcHRQdHIobmV3IENvbnRleHRNZW51KTsKIH0KIAogdm9pZCBDb250ZXh0TWVudUNvbnRyb2xs ZXI6OnNob3dDb250ZXh0TWVudShFdmVudCogZXZlbnQpCkBAIC00MzMsNyArNDMzLDcgQEAgdm9p ZCBDb250ZXh0TWVudUNvbnRyb2xsZXI6OmFwcGVuZEl0ZW0oQ29udGV4dE1lbnVJdGVtJiBtZW51 SXRlbSwgQ29udGV4dE1lbnUqIHAKIAogc3RhdGljIFBhc3NPd25QdHI8Q29udGV4dE1lbnVJdGVt PiBzZXBhcmF0b3JJdGVtKCkKIHsKLSAgICByZXR1cm4gbmV3IENvbnRleHRNZW51SXRlbShTZXBh cmF0b3JUeXBlLCBDb250ZXh0TWVudUl0ZW1UYWdOb0FjdGlvbiwgU3RyaW5nKCkpOworICAgIHJl dHVybiBhZG9wdFB0cihuZXcgQ29udGV4dE1lbnVJdGVtKFNlcGFyYXRvclR5cGUsIENvbnRleHRN ZW51SXRlbVRhZ05vQWN0aW9uLCBTdHJpbmcoKSkpOwogfQogCiB2b2lkIENvbnRleHRNZW51Q29u dHJvbGxlcjo6Y3JlYXRlQW5kQXBwZW5kRm9udFN1Yk1lbnUoQ29udGV4dE1lbnVJdGVtJiBmb250 TWVudUl0ZW0pCg== 90985 2011-04-25 16:13:37 -0700 2011-04-25 16:15:11 -0700 Patch bug-59375-20110425161335.patch text/plain 2316 levin U3VidmVyc2lvbiBSZXZpc2lvbjogODQ4MjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmOGU1YzQ2ZjgyN2RiZGQ0 ZDdiNjFhNTFkMjk3MGM5YTc3ZWI3NDk1Li5hZGZmNWVjYjgxMDJjOWQ5YmQ5NmQyNDMxMDFiNzJj NGY5MzUxODI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQtMjUgIERhdmlk IExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBzdHJpY3QgT3duUHRycyBpbiBDb250ZXh0TWVudUNv bnRyb2xsZXIuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01OTM3NQorCisgICAgICAgICogcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q29udGV4dE1lbnVDb250cm9sbGVyOjpjcmVhdGVDb250ZXh0TWVu dSk6CisgICAgICAgIChXZWJDb3JlOjpzZXBhcmF0b3JJdGVtKToKKwogMjAxMS0wNC0yNSAgR2Vv ZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeDogVGhp cyB0aW1lIGZvciBzdXJlIQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9Db250ZXh0 TWVudUNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRy b2xsZXIuY3BwCmluZGV4IGEwZTY0YjgwZDI3Yjk5ODQ4YjBiODU0YmY3NDhmZDUwNDUxNjI1N2Mu LjRiZmJkZDUxOGQzNWQ1YmYyYmNiNjRjMzYzYmEzZDc1M2RjY2I4MjQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvQ29udGV4dE1lbnVDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0NvbnRleHRNZW51Q29udHJvbGxlci5jcHAKQEAgLTEyMyw3ICsxMjMsNyBA QCB2b2lkIENvbnRleHRNZW51Q29udHJvbGxlcjo6c2hvd0NvbnRleHRNZW51KEV2ZW50KiBldmVu dCwgUGFzc1JlZlB0cjxDb250ZXh0TWVudQogUGFzc093blB0cjxDb250ZXh0TWVudT4gQ29udGV4 dE1lbnVDb250cm9sbGVyOjpjcmVhdGVDb250ZXh0TWVudShFdmVudCogZXZlbnQpCiB7CiAgICAg aWYgKCFldmVudC0+aXNNb3VzZUV2ZW50KCkpCi0gICAgICAgIHJldHVybiAwOworICAgICAgICBy ZXR1cm4gUGFzc093blB0cjxDb250ZXh0TWVudT4oKTsKIAogICAgIE1vdXNlRXZlbnQqIG1vdXNl RXZlbnQgPSBzdGF0aWNfY2FzdDxNb3VzZUV2ZW50Kj4oZXZlbnQpOwogICAgIEhpdFRlc3RSZXN1 bHQgcmVzdWx0KG1vdXNlRXZlbnQtPmFic29sdXRlTG9jYXRpb24oKSk7CkBAIC0xMzIsMTEgKzEz MiwxMSBAQCBQYXNzT3duUHRyPENvbnRleHRNZW51PiBDb250ZXh0TWVudUNvbnRyb2xsZXI6OmNy ZWF0ZUNvbnRleHRNZW51KEV2ZW50KiBldmVudCkKICAgICAgICAgcmVzdWx0ID0gZnJhbWUtPmV2 ZW50SGFuZGxlcigpLT5oaXRUZXN0UmVzdWx0QXRQb2ludChtb3VzZUV2ZW50LT5hYnNvbHV0ZUxv Y2F0aW9uKCksIGZhbHNlKTsKIAogICAgIGlmICghcmVzdWx0LmlubmVyTm9uU2hhcmVkTm9kZSgp KQotICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIFBhc3NPd25QdHI8Q29udGV4dE1l bnU+KCk7CiAKICAgICBtX2hpdFRlc3RSZXN1bHQgPSByZXN1bHQ7CiAKLSAgICByZXR1cm4gbmV3 IENvbnRleHRNZW51OworICAgIHJldHVybiBhZG9wdFB0cihuZXcgQ29udGV4dE1lbnUpOwogfQog CiB2b2lkIENvbnRleHRNZW51Q29udHJvbGxlcjo6c2hvd0NvbnRleHRNZW51KEV2ZW50KiBldmVu dCkKQEAgLTQzMyw3ICs0MzMsNyBAQCB2b2lkIENvbnRleHRNZW51Q29udHJvbGxlcjo6YXBwZW5k SXRlbShDb250ZXh0TWVudUl0ZW0mIG1lbnVJdGVtLCBDb250ZXh0TWVudSogcAogCiBzdGF0aWMg UGFzc093blB0cjxDb250ZXh0TWVudUl0ZW0+IHNlcGFyYXRvckl0ZW0oKQogewotICAgIHJldHVy biBuZXcgQ29udGV4dE1lbnVJdGVtKFNlcGFyYXRvclR5cGUsIENvbnRleHRNZW51SXRlbVRhZ05v QWN0aW9uLCBTdHJpbmcoKSk7CisgICAgcmV0dXJuIGFkb3B0UHRyKG5ldyBDb250ZXh0TWVudUl0 ZW0oU2VwYXJhdG9yVHlwZSwgQ29udGV4dE1lbnVJdGVtVGFnTm9BY3Rpb24sIFN0cmluZygpKSk7 CiB9CiAKIHZvaWQgQ29udGV4dE1lbnVDb250cm9sbGVyOjpjcmVhdGVBbmRBcHBlbmRGb250U3Vi TWVudShDb250ZXh0TWVudUl0ZW0mIGZvbnRNZW51SXRlbSkK