59345 2011-04-25 14:28:07 -0700 [Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762 2011-06-01 12:32:26 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 38654 1 ossy cmarcelo ademar cmarcelo commit-queue kenneth ossy rafael.lobo oldest_to_newest 391894 0 ossy 2011-04-25 14:28:07 -0700 original bug: Handling of URLs like http:/example.com/ is incorrect https://bugs.webkit.org/show_bug.cgi?id=59300 http://trac.webkit.org/changeset/84762 fail: ------ FAIL! : tst_QWebFrame::setUrlToInvalid() Compared values are not the same Actual (frame->url()): http://here/ Expected (invalidUrl): http:/here Loc: [/home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(3460)] ----- 405651 1 ossy 2011-05-18 05:04:08 -0700 updated error message with r86748: FAIL! : tst_QWebFrame::setUrlToInvalid() Compared values are not the same Actual (frame->url()): http://here/ Expected (invalidUrl): http:/here Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(3462)] 406395 2 94069 ossy 2011-05-19 07:53:21 -0700 Created attachment 94069 mark failing test cases as expected fail This is a month old regression, so it is time to mark the failing test cases as expected fail to make buildbot happier. We can easily catch regressions if all tests passes on the bot. 407034 3 commit-queue 2011-05-20 06:30:18 -0700 The commit-queue encountered the following flaky tests while processing attachment 94069: inspector/debugger/source-frame.html bug 57399 (author: podivilov@chromium.org) The commit-queue is continuing to process your patch. 407036 4 94069 commit-queue 2011-05-20 06:32:17 -0700 Comment on attachment 94069 mark failing test cases as expected fail Clearing flags on attachment: 94069 Committed r86946: <http://trac.webkit.org/changeset/86946> 407037 5 commit-queue 2011-05-20 06:32:22 -0700 All reviewed patches have been landed. Closing bug. 407041 6 ossy 2011-05-20 06:34:33 -0700 Reopen to fix the bug. 407062 7 commit-queue 2011-05-20 06:54:01 -0700 The commit-queue encountered the following flaky tests while processing attachment 94069: animations/suspend-resume-animation.html bug 48161 (authors: cmarrin@apple.com and simon.fraser@apple.com) The commit-queue is continuing to process your patch. 412025 8 95300 cmarcelo 2011-05-29 14:23:30 -0700 Created attachment 95300 Patch 412027 9 95300 kenneth 2011-05-29 14:27:53 -0700 Comment on attachment 95300 Patch ok 412028 10 95300 kenneth 2011-05-29 14:28:36 -0700 Comment on attachment 95300 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95300&action=review > Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:3462 > + const QUrl validUrl("http://example.com/"); Shouldnt this be with one / then? or 412242 11 cmarcelo 2011-05-30 08:44:55 -0700 (In reply to comment #10) > (From update of attachment 95300 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95300&action=review > > > Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:3462 > > + const QUrl validUrl("http://example.com/"); > > Shouldnt this be with one / then? or No, this one is the valid URL that QWebFrame will end up with when you feed with the invalid one. So all url() and family will have the valid one now. 413361 12 kenneth 2011-06-01 07:14:35 -0700 (In reply to comment #11) > (In reply to comment #10) > > (From update of attachment 95300 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=95300&action=review > > > > > Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:3462 > > > + const QUrl validUrl("http://example.com/"); > > > > Shouldnt this be with one / then? or > > No, this one is the valid URL that QWebFrame will end up with when you feed with the invalid one. So all url() and family will have the valid one now. ok fine :-) pls commit 413456 13 95300 commit-queue 2011-06-01 09:58:50 -0700 Comment on attachment 95300 Patch Clearing flags on attachment: 95300 Committed r87818: <http://trac.webkit.org/changeset/87818> 413457 14 commit-queue 2011-06-01 09:58:56 -0700 All reviewed patches have been landed. Closing bug. 413471 15 commit-queue 2011-06-01 10:27:11 -0700 The commit-queue encountered the following flaky tests while processing attachment 95300: http/tests/websocket/tests/frame-length-longer-than-buffer.html bug 61837 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 413579 16 ademar 2011-06-01 12:32:26 -0700 Revision r86946 cherry-picked into qtwebkit-2.2 with commit 8234285 <http://gitorious.org/webkit/qtwebkit/commit/8234285> Revision r87818 cherry-picked into qtwebkit-2.2 with commit 0c7056f <http://gitorious.org/webkit/qtwebkit/commit/0c7056f> 94069 2011-05-19 07:53:21 -0700 2011-05-20 06:34:44 -0700 mark failing test cases as expected fail 1.patch text/plain 1470 ossy ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggMzNkOTM0YS4uYmNhZWE3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMS0wNS0xOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtR dF1GaXggdHN0X1FXZWJGcmFtZTo6c2V0VXJsVG9JbnZhbGlkKCkgYXV0b3Rlc3QgYWZ0ZXIgcjg0 NzYyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTM0 NQorCisgICAgICAgICogdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwOgorICAgICAg ICAodHN0X1FXZWJGcmFtZTo6c2V0VXJsVG9JbnZhbGlkKTogTWFyayBmYWlsaW5nIHRlc3QgY2Fz ZXMgYXMgZXhwZWN0ZWQgZmFpbHMuCisKIDIwMTEtMDUtMTkgIFpzb2x0IEZlaMOpciAgPGg0OTAy NjdAc3R1ZC51LXN6ZWdlZC5odT4KIAogICAgICAgICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9n b27DoWMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJmcmFtZS90c3Rf cXdlYmZyYW1lLmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2Vi ZnJhbWUuY3BwCmluZGV4IGE5ODIxMTkuLmNhZGM5ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvcXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwCkBAIC0zNDU5LDggKzM0NTks MTEgQEAgdm9pZCB0c3RfUVdlYkZyYW1lOjpzZXRVcmxUb0ludmFsaWQoKQogICAgIFFWRVJJRlko aW52YWxpZFVybCAhPSBRVXJsKCkpOwogCiAgICAgZnJhbWUtPnNldFVybChpbnZhbGlkVXJsKTsK KyAgICBRRVhQRUNUX0ZBSUwoIiIsICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTkzNDUiLCBDb250aW51ZSk7CiAgICAgUUNPTVBBUkUoZnJhbWUtPnVybCgpLCBpbnZh bGlkVXJsKTsKKyAgICBRRVhQRUNUX0ZBSUwoIiIsICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTkzNDUiLCBDb250aW51ZSk7CiAgICAgUUNPTVBBUkUoZnJhbWUtPnJl cXVlc3RlZFVybCgpLCBpbnZhbGlkVXJsKTsKKyAgICBRRVhQRUNUX0ZBSUwoIiIsICJodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkzNDUiLCBDb250aW51ZSk7CiAgICAg UUNPTVBBUkUoZnJhbWUtPmJhc2VVcmwoKSwgaW52YWxpZFVybCk7CiAKICAgICAvLyBRVXJscyBl cXVpdmFsZW50IHRvIFFVcmwoKSB3aWxsIGJlIHRyZWF0ZWQgYXMgc3VjaC4K 95300 2011-05-29 14:23:30 -0700 2011-06-01 09:58:50 -0700 Patch 0001-Qt-Fix-tst_QWebFrame-setUrlToInvalid-autotest-after-.patch text/plain 3733 cmarcelo RnJvbSA3YmEzZGFiZjM5MDgxYTRkZTZlMjZhOWExNWI0ODYxYzkyZmIzMjExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gPGNhaW8u b2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KRGF0ZTogU3VuLCAyOSBNYXkgMjAxMSAxODoyMDozMSAt MDMwMApTdWJqZWN0OiBbUEFUQ0hdIFtRdF1GaXggdHN0X1FXZWJGcmFtZTo6c2V0VXJsVG9JbnZh bGlkKCkgYXV0b3Rlc3QgYWZ0ZXIKIHI4NDc2MiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTkzNDUKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKS1VSTCBhbmQg UVVybCBkaXNhZ3JlZSB3aGV0aGVyIGNlcnRhaW4gVVJMcyBhcmUgdmFsaWQgb3Igbm90LiBUaGUg cmVncmVzc2lvbiBoZXJlCndhcyBjYXVzZWQgYnkgdGhlIGZhY3QgdGhhdCBub3cgS1VSTCBhY2Nl cHRzICJodHRwOi9leGFtcGxlLmNvbSIgKG5vdGUgb25seSBvbmUKc2xhc2gpIGFuZCBvdXIgdGVz dCBjYXNlIHVzZWQgYSBzdHJhbmdlIGVkZ2UgY2FzZSB0aGF0J3MgdHJhbnNmb3JtZWQgaW50byBh CiJvbmUtc2xhc2giIFVSTCB0aGF0IG5vdyBLVVJMIGNhbiBoYW5kbGUuCgpRdFdlYktpdCBhcHBy b2FjaCBpbiB0aGlzIGNhc2UgaXMgdG8gZG8gYSBiZXN0IGVmZm9ydCBhbmQgYWNjZXB0IHRoZSBR VXJsIGlmIEtVUkwKY2FuIHVuZGVyc3RhbmQgaXQuIFNvIEkndmUgdXBkYXRlZCB0aGUgdGVzdCB0 byB1c2UgYSBtb3JlIG1lYW5pbmdmdWwgZXhhbXBsZSBhbmQKc2hvdyB0aGF0IGFuIGludmFsaWQg VVJMIGdldHMgY29udmVydGVkIHRvIGEgdmFsaWQgVVJMIGlmIHBvc3NpYmxlLgoKKiB0ZXN0cy9x d2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHA6Cih0c3RfUVdlYkZyYW1lOjpzZXRVcmxUb0ludmFs aWQpOgotLS0KIFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgIHwgICAxOSArKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3 ZWJmcmFtZS90c3RfcXdlYmZyYW1lLmNwcCB8ICAgMTMgKysrKysrLS0tLS0tLQogMiBmaWxlcyBj aGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5k ZXggMzQwYzIzZi4uMmNjNDE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAx MS0wNS0yOSAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBv cGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF1GaXggdHN0X1FXZWJGcmFtZTo6c2V0VXJsVG9JbnZhbGlkKCkgYXV0b3Rlc3Qg YWZ0ZXIgcjg0NzYyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01OTM0NQorCisgICAgICAgIEtVUkwgYW5kIFFVcmwgZGlzYWdyZWUgd2hldGhlciBjZXJ0 YWluIFVSTHMgYXJlIHZhbGlkIG9yIG5vdC4gVGhlIHJlZ3Jlc3Npb24gaGVyZQorICAgICAgICB3 YXMgY2F1c2VkIGJ5IHRoZSBmYWN0IHRoYXQgbm93IEtVUkwgYWNjZXB0cyAiaHR0cDovZXhhbXBs ZS5jb20iIChub3RlIG9ubHkgb25lCisgICAgICAgIHNsYXNoKSBhbmQgb3VyIHRlc3QgY2FzZSB1 c2VkIGEgc3RyYW5nZSBlZGdlIGNhc2UgdGhhdCdzIHRyYW5zZm9ybWVkIGludG8gYQorICAgICAg ICAib25lLXNsYXNoIiBVUkwgdGhhdCBub3cgS1VSTCBjYW4gaGFuZGxlLgorCisgICAgICAgIFF0 V2ViS2l0IGFwcHJvYWNoIGluIHRoaXMgY2FzZSBpcyB0byBkbyBhIGJlc3QgZWZmb3J0IGFuZCBh Y2NlcHQgdGhlIFFVcmwgaWYgS1VSTAorICAgICAgICBjYW4gdW5kZXJzdGFuZCBpdC4gU28gSSd2 ZSB1cGRhdGVkIHRoZSB0ZXN0IHRvIHVzZSBhIG1vcmUgbWVhbmluZ2Z1bCBleGFtcGxlIGFuZAor ICAgICAgICBzaG93IHRoYXQgYW4gaW52YWxpZCBVUkwgZ2V0cyBjb252ZXJ0ZWQgdG8gYSB2YWxp ZCBVUkwgaWYgcG9zc2libGUuCisKKyAgICAgICAgKiB0ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJm cmFtZS5jcHA6CisgICAgICAgICh0c3RfUVdlYkZyYW1lOjpzZXRVcmxUb0ludmFsaWQpOgorCiAy MDExLTA1LTI4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv cXQvdGVzdHMvcXdlYmZyYW1lL3RzdF9xd2ViZnJhbWUuY3BwIGIvU291cmNlL1dlYktpdC9xdC90 ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFtZS5jcHAKaW5kZXggY2FkYzlkNi4uMzc4NjAzMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFt ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2ViZnJhbWUvdHN0X3F3ZWJmcmFt ZS5jcHAKQEAgLTM0NTMsMTggKzM0NTMsMTcgQEAgdm9pZCB0c3RfUVdlYkZyYW1lOjpzZXRVcmxU b0ludmFsaWQoKQogICAgIFFXZWJQYWdlIHBhZ2U7CiAgICAgUVdlYkZyYW1lKiBmcmFtZSA9IHBh Z2UubWFpbkZyYW1lKCk7CiAKLSAgICBjb25zdCBRVXJsIGludmFsaWRVcmwoImh0dHA6Ly9zdHJh bmdlO2hvc3RuYW1lL2hlcmUiKTsKKyAgICBjb25zdCBRVXJsIGludmFsaWRVcmwoImh0dHA6L2V4 YW1wbGUuY29tIik7CiAgICAgUVZFUklGWSghaW52YWxpZFVybC5pc0VtcHR5KCkpOwogICAgIFFW RVJJRlkoIWludmFsaWRVcmwuaXNWYWxpZCgpKTsKICAgICBRVkVSSUZZKGludmFsaWRVcmwgIT0g UVVybCgpKTsKIAorICAgIC8vIFFXZWJGcmFtZSB3aWxsIGRvIGl0cyBiZXN0IHRvIGFjY2VwdCB0 aGUgVVJMLCBwb3NzaWJsZSBjb252ZXJ0aW5nIGl0IHRvIGEgdmFsaWQgZXF1aXZhbGVudCBVUkwu CisgICAgY29uc3QgUVVybCB2YWxpZFVybCgiaHR0cDovL2V4YW1wbGUuY29tLyIpOwogICAgIGZy YW1lLT5zZXRVcmwoaW52YWxpZFVybCk7Ci0gICAgUUVYUEVDVF9GQUlMKCIiLCAiaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5MzQ1IiwgQ29udGludWUpOwotICAgIFFD T01QQVJFKGZyYW1lLT51cmwoKSwgaW52YWxpZFVybCk7Ci0gICAgUUVYUEVDVF9GQUlMKCIiLCAi aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5MzQ1IiwgQ29udGludWUp OwotICAgIFFDT01QQVJFKGZyYW1lLT5yZXF1ZXN0ZWRVcmwoKSwgaW52YWxpZFVybCk7Ci0gICAg UUVYUEVDVF9GQUlMKCIiLCAiaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU5MzQ1IiwgQ29udGludWUpOwotICAgIFFDT01QQVJFKGZyYW1lLT5iYXNlVXJsKCksIGludmFs aWRVcmwpOworICAgIFFDT01QQVJFKGZyYW1lLT51cmwoKSwgdmFsaWRVcmwpOworICAgIFFDT01Q QVJFKGZyYW1lLT5yZXF1ZXN0ZWRVcmwoKSwgdmFsaWRVcmwpOworICAgIFFDT01QQVJFKGZyYW1l LT5iYXNlVXJsKCksIHZhbGlkVXJsKTsKIAogICAgIC8vIFFVcmxzIGVxdWl2YWxlbnQgdG8gUVVy bCgpIHdpbGwgYmUgdHJlYXRlZCBhcyBzdWNoLgogICAgIGNvbnN0IFFVcmwgYWJvdXRCbGFuaygi YWJvdXQ6YmxhbmsiKTsKLS0gCjEuNy41LjIKCg==