59339 2011-04-25 13:39:23 -0700 WebCore build on Windows should include windows.h in its precompiled header to speed builds 2011-04-25 13:51:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sfalken sfalken webkit.review.bot oldest_to_newest 391861 0 sfalken 2011-04-25 13:39:23 -0700 WebCore build on Windows should include windows.h in its precompiled header to speed builds 391866 1 90938 sfalken 2011-04-25 13:45:55 -0700 Created attachment 90938 Patch 391868 2 webkit.review.bot 2011-04-25 13:47:36 -0700 Attachment 90938 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/WebCorePrefix.h:135: "windows.h" already included at Source/WebCore/WebCorePrefix.h:120 [build/include] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 391870 3 sfalken 2011-04-25 13:51:38 -0700 Committed r84797: <http://trac.webkit.org/changeset/84797> 90938 2011-04-25 13:45:55 -0700 2011-04-25 13:48:43 -0700 Patch bug-59339-20110425134545.patch text/plain 1409 sfalken SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0Nzk2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDQtMjUgIFN0ZXZlIEZh bGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWJDb3JlIGJ1aWxkIG9uIFdpbmRvd3Mgc2hvdWxkIGlu Y2x1ZGUgd2luZG93cy5oIGluIGl0cyBwcmVjb21waWxlZCBoZWFkZXIgdG8gc3BlZWQgYnVpbGRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTMzOQor CisgICAgICAgIHdpbmRvd3MuaCBpcyBpbmNsdWRlZCBieSBzZXZlcmFsIG9mIHRoZSB1bmRlcmx5 aW5nIHd0ZiBoZWFkZXJzLCBpbmNsdWRpbmcgQXRvbWljcy5oIGFuZAorICAgICAgICBUaHJlYWRp bmdQcmltaXRpdmVzLmggYW55d2F5LCBzbyBpbmNsdWRlIGl0IGluIHRoZSBXZWJDb3JlUHJlZml4 LmggdG8gc3BlZWQgdXAgY29tcGlsYXRpb24uCisgICAgICAgIAorICAgICAgICBPbiBteSA4IGNv cmUgTWFjIFBybywgdGhpcyByZWR1Y2VzIGEgY2xlYW4gcmVidWlsZCBvZiBkZWJ1ZyBXZWJDb3Jl IGZyb20gOCBtaW51dGVzIHRvIDcgbWludXRlcworICAgICAgICAoYSAxMiUgc3BlZWR1cCkuCisK KyAgICAgICAgKiBXZWJDb3JlUHJlZml4Lmg6IEluY2x1ZGUgd2luZG93cy5oCisKIDIwMTEtMDQt MjUgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFhhbiBMb3Blei4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmVQcmVmaXgu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlUHJlZml4LmgJKHJldmlzaW9u IDg0Nzc3KQorKysgU291cmNlL1dlYkNvcmUvV2ViQ29yZVByZWZpeC5oCSh3b3JraW5nIGNvcHkp CkBAIC0xMzIsNiArMTMyLDcgQEAKIC8qIFdpbmRvd3MgZG9lc24ndCBpbmNsdWRlIENGTmV0d29y ay5oIHZpYSBDb3JlU2VydmljZXMuaCwgc28gd2UgZG8KICAgIGl0IGV4cGxpY2l0bHkgaGVyZSB0 byBtYWtlIFdpbmRvd3MgbW9yZSBjb25zaXN0ZW50IHdpdGggTWFjLiAqLwogI2luY2x1ZGUgPENG TmV0d29yay9DRk5ldHdvcmsuaD4KKyNpbmNsdWRlIDx3aW5kb3dzLmg+CiAjZWxzZQogI2luY2x1 ZGUgPENvcmVTZXJ2aWNlcy9Db3JlU2VydmljZXMuaD4KICNlbmRpZgo=