59328 2011-04-25 09:50:23 -0700 Crash beneath WKURLIsEqual() when reloading in MiniBrowser 2011-09-10 10:51:25 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 1 mitz webkit-unassigned andersca kling sam webkit.review.bot oldest_to_newest 391796 0 mitz 2011-04-25 09:50:23 -0700 Steps to reproduce: Run MiniBrowser After the WebKit Open Source Project webpage loads, click the Reload button several times Result: Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit2 0x0000000100022658 WTF::RefPtr<WTF::StringImpl>::get() const + 12 (RefPtr.h:60) 1 com.apple.WebKit2 0x000000010005d999 WTF::String::impl() const + 21 (WTFString.h:126) 2 com.apple.WebKit2 0x000000010005fbb4 WTF::operator==(WTF::String const&, WTF::String const&) + 38 (WTFString.h:365) 3 com.apple.WebKit2 0x0000000100156429 WKURLIsEqual + 65 (WKURL.cpp:50) 4 com.yourcompany.MiniBrowser 0x0000000100003f7d -[BrowserWindowController updateProvisionalURLForFrame:] + 81 (BrowserWindowController.m:684) 5 com.apple.WebKit2 0x000000010008b6fc WebKit::WebLoaderClient::didFailLoadWithErrorForFrame(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, WebCore::ResourceError const&, WebKit::APIObject*) + 142 (WebLoaderClient.cpp:91) 6 com.apple.WebKit2 0x00000001000a8421 WebKit::WebPageProxy::didFailLoadForFrame(unsigned long long, WebCore::ResourceError const&, CoreIPC::ArgumentDecoder*) + 273 (WebPageProxy.cpp:1612) 7 com.apple.WebKit2 0x000000010016b2f0 void CoreIPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(unsigned long long, WebCore::ResourceError const&, CoreIPC::ArgumentDecoder*), unsigned long long, WebCore::ResourceError>(CoreIPC::Arguments2<unsigned long long, WebCore::ResourceError> const&, CoreIPC::ArgumentDecoder*, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(unsigned long long, WebCore::ResourceError const&, CoreIPC::ArgumentDecoder*)) + 114 (HandleMessage.h:204) 8 com.apple.WebKit2 0x0000000100172fd3 void CoreIPC::handleMessageVariadic<Messages::WebPageProxy::DidFailLoadForFrame, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(unsigned long long, WebCore::ResourceError const&, CoreIPC::ArgumentDecoder*)>(CoreIPC::ArgumentDecoder*, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(unsigned long long, WebCore::ResourceError const&, CoreIPC::ArgumentDecoder*)) + 83 (HandleMessage.h:286) 9 com.apple.WebKit2 0x0000000100169bcb WebKit::WebPageProxy::didReceiveWebPageProxyMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) + 2777 (WebPageProxyMessageReceiver.cpp:180) 10 com.apple.WebKit2 0x00000001000a96ef WebKit::WebPageProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) + 251 (WebPageProxy.cpp:1352) 11 com.apple.WebKit2 0x00000001000ec99b WebKit::WebProcessProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::ArgumentDecoder*) + 327 (WebProcessProxy.cpp:261) 12 com.apple.WebKit2 0x0000000100016aee CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::ArgumentDecoder>&) + 292 (Connection.cpp:646) 13 com.apple.WebKit2 0x0000000100016c39 CoreIPC::Connection::dispatchMessages() + 105 (Connection.cpp:667) 14 com.apple.WebKit2 0x00000001000190fd MemberFunctionWorkItem0<CoreIPC::Connection>::execute() + 109 (WorkItem.h:76) 15 com.apple.WebKit2 0x0000000100052e25 RunLoop::performWork() + 119 (RunLoop.cpp:61) 16 com.apple.WebKit2 0x0000000100053f41 RunLoop::performWork(void*) + 93 (RunLoopMac.mm:38) 17 com.apple.CoreFoundation 0x00007fff8593e401 __CFRunLoopDoSources0 + 1361 18 com.apple.CoreFoundation 0x00007fff8593c5f9 __CFRunLoopRun + 873 19 com.apple.CoreFoundation 0x00007fff8593bdbf CFRunLoopRunSpecific + 575 20 com.apple.HIToolbox 0x00007fff861f07ee RunCurrentEventLoopInMode + 333 21 com.apple.HIToolbox 0x00007fff861f05f3 ReceiveNextEventCommon + 310 22 com.apple.HIToolbox 0x00007fff861f04ac BlockUntilNextEventMatchingListInMode + 59 23 com.apple.AppKit 0x00007fff8718be64 _DPSNextEvent + 718 24 com.apple.AppKit 0x00007fff8718b7a9 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 155 25 com.apple.AppKit 0x00007fff8715148b -[NSApplication run] + 395 26 com.apple.AppKit 0x00007fff8714a1a8 NSApplicationMain + 364 27 com.yourcompany.MiniBrowser 0x0000000100001c84 start + 52 465296 1 106976 kling 2011-09-10 07:33:54 -0700 Created attachment 106976 Proposed patch Add missing null check for the WKURLRef returned by WKFrameCopyProvisionalURL(). 465300 2 106976 webkit.review.bot 2011-09-10 10:51:21 -0700 Comment on attachment 106976 Proposed patch Clearing flags on attachment: 106976 Committed r94909: <http://trac.webkit.org/changeset/94909> 465301 3 webkit.review.bot 2011-09-10 10:51:25 -0700 All reviewed patches have been landed. Closing bug. 106976 2011-09-10 07:33:54 -0700 2011-09-10 10:51:21 -0700 Proposed patch bug-59328.diff text/plain 1151 kling ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMWMy YjlmLi44OGIzM2EyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMTAgIEFuZHJlYXMgS2xpbmcgIDxrbGlu Z0B3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIGJlbmVhdGggV0tVUkxJc0VxdWFsKCkgd2hl biByZWxvYWRpbmcgaW4gTWluaUJyb3dzZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01OTMyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvbWFjL0Jyb3dzZXJXaW5kb3dDb250cm9s bGVyLm06CisgICAgICAgICgtW0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyIHVwZGF0ZVByb3Zpc2lv bmFsVVJMRm9yRnJhbWU6XSk6IEFkZCBtaXNzaW5nIG51bGwgY2hlY2suCisKIDIwMTEtMDktMDkg IFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHI5NDg1MS4KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93 c2VyL21hYy9Ccm93c2VyV2luZG93Q29udHJvbGxlci5tIGIvVG9vbHMvTWluaUJyb3dzZXIvbWFj L0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyLm0KaW5kZXggNTA2ZDQzNy4uZjdlNjE1MSAxMDA2NDQK LS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvbWFjL0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyLm0KKysr IGIvVG9vbHMvTWluaUJyb3dzZXIvbWFjL0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyLm0KQEAgLTY4 NCw2ICs2ODQsMTAgQEAgLSAodm9pZCl1cGRhdGVQcm92aXNpb25hbFVSTEZvckZyYW1lOihXS0Zy YW1lUmVmKWZyYW1lCiAgICAgICAgIGVtcHR5VVJMID0gV0tVUkxDcmVhdGVXaXRoVVRGOENTdHJp bmcoIiIpOwogCiAgICAgV0tVUkxSZWYgdXJsID0gV0tGcmFtZUNvcHlQcm92aXNpb25hbFVSTChm cmFtZSk7CisKKyAgICBpZiAoIXVybCkKKyAgICAgICAgcmV0dXJuOworCiAgICAgaWYgKFdLVVJM SXNFcXVhbCh1cmwsIGVtcHR5VVJMKSkgewogICAgICAgICBXS1JlbGVhc2UodXJsKTsKICAgICAg ICAgcmV0dXJuOwo=