59322 2011-04-25 07:59:26 -0700 Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM 2011-04-25 09:33:48 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 391759 0 apavlov 2011-04-25 07:59:26 -0700 A UTF-8 BOM is not handled properly by the CSSParser (and it should never get through to it). Upstreaming http://code.google.com/p/chromium/issues/detail?id=78703 391763 1 90917 apavlov 2011-04-25 08:27:59 -0700 Created attachment 90917 [PATCH] Suggested fix 391764 2 90917 yurys 2011-04-25 08:34:08 -0700 Comment on attachment 90917 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=90917&action=review > LayoutTests/inspector/styles/parse-utf8-bom.html:15 > + InspectorTest.dumpSelectedElementStyles(true, false, true); Can we be sure that the styles content is already loaded at this point? 391766 3 apavlov 2011-04-25 08:41:00 -0700 (In reply to comment #2) > (From update of attachment 90917 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90917&action=review > > > LayoutTests/inspector/styles/parse-utf8-bom.html:15 > > + InspectorTest.dumpSelectedElementStyles(true, false, true); > > Can we be sure that the styles content is already loaded at this point? Yes, all external stylesheets will have been loaded by the time window.onload fires. 391771 4 apavlov 2011-04-25 08:54:42 -0700 Committed r84777: <http://trac.webkit.org/changeset/84777> 391782 5 90917 pfeldman 2011-04-25 09:33:48 -0700 Comment on attachment 90917 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=90917&action=review > Source/WebCore/inspector/InspectorStyleSheet.cpp:1061 > + success = resourceStyleSheetText(&rawText); You should instead fetch CachedResource, cast it to the Stylesheet and get decoded data. 90917 2011-04-25 08:27:59 -0700 2011-04-25 09:33:47 -0700 [PATCH] Suggested fix fixutf8.patch text/plain 5390 apavlov Y29tbWl0IGRhZDBlYmQ1ODRhMWVhYTg5Mzk4ZDk5ZWEwYWEyZWJlMjBmMDlkZjIKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBNb24gQXByIDI1 IDE0OjIwOjA4IDIwMTEgKzA0MDAKCiAgICBGaXgKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjFhNDkyNy4uZmRiMGY1YyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTA0LTI1ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBh dmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIGlzIHBhcnNlZCBpbXByb3Blcmx5IHdoZW4g c2F2ZWQgaW4gVVRGLTggd2l0aCBhIEJPTQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTkzMjIKKworICAgICAgICAqIGluc3BlY3Rvci9zdHlsZXMvcGFy c2UtdXRmOC1ib20tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBpbnNwZWN0b3Ivc3R5 bGVzL3BhcnNlLXV0ZjgtYm9tLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci9zdHls ZXMvcmVzb3VyY2VzL3BhcnNlLXV0ZjgtYm9tLW1haW4uY3NzOiBBZGRlZC4KKyAgICAgICAgKGgx KToKKyAgICAgICAgKGgyKToKKyAgICAgICAgKiBpbnNwZWN0b3Ivc3R5bGVzL3Jlc291cmNlcy9w YXJzZS11dGY4LWJvbS1yZXNldC5jc3M6IEFkZGVkLgorCiAyMDExLTA0LTI1ICBNYWNpZWogU3Rh Y2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ2FtZXJvbiBa d2FyaWNoLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9wYXJzZS11 dGY4LWJvbS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3BhcnNl LXV0ZjgtYm9tLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAw Li4zNjEyZTVjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxl cy9wYXJzZS11dGY4LWJvbS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyMSBAQAorVGVzdHMgdGhh dCBzb3VyY2UgZGF0YSBhcmUgZXh0cmFjdGVkIGNvcnJlY3RseSBmcm9tIGV4dGVybmFsIHN0eWxl c2hlZXRzIGluIFVURi04IHdpdGggQk9NLiBCdWcgNTkzMjIuCisKK0knbSByZWQuCisKK1tleHBh bmRlZF0gZWxlbWVudC5zdHlsZSB7ICgpCisKKz09PT09PT09IE1hdGNoZWQgQ1NTIFJ1bGVzID09 PT09PT09CitbZXhwYW5kZWRdIGgxIHsgKHBhcnNlLXV0ZjgtYm9tLW1haW4uY3NzOjMpCitjb2xv cjogcmVkOworCitbZXhwYW5kZWRdIGgxIHsgKHVzZXIgYWdlbnQgc3R5bGVzaGVldCkKK2Rpc3Bs YXk6IGJsb2NrOworZm9udC1zaXplOiAyZW07Cistd2Via2l0LW1hcmdpbi1iZWZvcmU6IDAuNjdl bTsKKy13ZWJraXQtbWFyZ2luLWFmdGVyOiAwLjY3ZW07Cistd2Via2l0LW1hcmdpbi1zdGFydDog MHB4OworLXdlYmtpdC1tYXJnaW4tZW5kOiAwcHg7Citmb250LXdlaWdodDogYm9sZDsKKworCisK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMvcGFyc2UtdXRmOC1ib20u aHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMvcGFyc2UtdXRmOC1ib20uaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi44YjU4YzdkCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9wYXJzZS11dGY4LWJvbS5odG1sCkBA IC0wLDAgKzEsMzIgQEAKKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIHR5 cGU9InRleHQvY3NzIiBocmVmPSJyZXNvdXJjZXMvcGFyc2UtdXRmOC1ib20tbWFpbi5jc3MiPgor Cis8c2NyaXB0IHNyYz0iLi4vLi4vaHR0cC90ZXN0cy9pbnNwZWN0b3IvaW5zcGVjdG9yLXRlc3Qu anMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2Vs ZW1lbnRzLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKworZnVuY3Rpb24gdGVzdCgpCit7 CisgICAgSW5zcGVjdG9yVGVzdC5zZWxlY3ROb2RlV2l0aElkKCJpbnNwZWN0ZWQiLCBzdGVwMSk7 CisKKyAgICBmdW5jdGlvbiBzdGVwMSgpCisgICAgeworICAgICAgICBJbnNwZWN0b3JUZXN0LmR1 bXBTZWxlY3RlZEVsZW1lbnRTdHlsZXModHJ1ZSwgZmFsc2UsIHRydWUpOworICAgICAgICBJbnNw ZWN0b3JUZXN0LmNvbXBsZXRlVGVzdCgpOworICAgIH0KK30KKworPC9zY3JpcHQ+Cis8L2hlYWQ+ CisKKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKzxwPgorVGVzdHMgdGhhdCBzb3VyY2UgZGF0 YSBhcmUgZXh0cmFjdGVkIGNvcnJlY3RseSBmcm9tIGV4dGVybmFsIHN0eWxlc2hlZXRzIGluIFVU Ri04IHdpdGggQk9NLiA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTkzMjIiPkJ1ZyA1OTMyMjwvYT4uCis8L3A+Cis8aDEgaWQ9Imluc3BlY3RlZCI+CitJ J20gcmVkLgorPC9oMT4KKworPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL3N0eWxlcy9yZXNvdXJjZXMvcGFyc2UtdXRmOC1ib20tbWFpbi5jc3MgYi9M YXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3Jlc291cmNlcy9wYXJzZS11dGY4LWJvbS1tYWlu LmNzcwpuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi44YjE5NDg1Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9yZXNvdXJjZXMvcGFyc2Ut dXRmOC1ib20tbWFpbi5jc3MKQEAgLTAsMCArMSw5IEBACivvu79AaW1wb3J0ICcuL3BhcnNlLXV0 ZjgtYm9tLXJlc2V0LmNzcyc7CisKK2gxIHsKKyAgICBjb2xvcjogcmVkOworfQorCitoMiB7Cisg ICAgY29sb3I6IGJsdWU7Cit9ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9yZXNvdXJjZXMvcGFyc2UtdXRmOC1ib20t cmVzZXQuY3NzIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9yZXNvdXJjZXMvcGFyc2Ut dXRmOC1ib20tcmVzZXQuY3NzCm5ldyBmaWxlIG1vZGUgMTAwNzU1CmluZGV4IDAwMDAwMDAuLjVm MjgyNzAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3Jl c291cmNlcy9wYXJzZS11dGY4LWJvbS1yZXNldC5jc3MKQEAgLTAsMCArMSBAQAor77u/ClwgTm8g bmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGRmYjZlNzQuLjczMTU1NDYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wNC0yNSAgQWxleGFuZGVyIFBhdmxvdiAg PGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENTUyBpcyBwYXJzZWQgaW1wcm9wZXJseSB3 aGVuIHNhdmVkIGluIFVURi04IHdpdGggYSBCT00KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU5MzIyCisKKyAgICAgICAgVXNlIFRleHRSZXNvdXJjZURl Y29kZXIgdG8gZGV0ZXJtaW5lIGV4dGVybmFsIHN0eWxlc2hlZXQgY2hhcnNldHMgY29ycmVjdGx5 LgorCisgICAgICAgIFRlc3Q6IGluc3BlY3Rvci9zdHlsZXMvcGFyc2UtdXRmOC1ib20uaHRtbAor CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SW5zcGVjdG9yU3R5bGVTaGVldDo6b3JpZ2luYWxTdHlsZVNoZWV0VGV4dCk6CisK IDIwMTEtMDQtMjUgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvclN0eWxlU2hlZXQuY3BwCmluZGV4IDJlZGI4YTEuLjY4ZjllYTcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHAKQEAgLTQ1 LDYgKzQ1LDcgQEAKICNpbmNsdWRlICJJbnNwZWN0b3JWYWx1ZXMuaCIKICNpbmNsdWRlICJOb2Rl LmgiCiAjaW5jbHVkZSAiU3R5bGVTaGVldExpc3QuaCIKKyNpbmNsdWRlICJUZXh0UmVzb3VyY2VE ZWNvZGVyLmgiCiAjaW5jbHVkZSAiV2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZS5oIgogCiAjaW5jbHVk ZSA8d3RmL093blB0ci5oPgpAQCAtMTA1NCwxMiArMTA1NSwxNyBAQCB2b2lkIEluc3BlY3RvclN0 eWxlU2hlZXQ6OnJldmFsaWRhdGVTdHlsZShDU1NTdHlsZURlY2xhcmF0aW9uKiBwYWdlU3R5bGUp CiAKIGJvb2wgSW5zcGVjdG9yU3R5bGVTaGVldDo6b3JpZ2luYWxTdHlsZVNoZWV0VGV4dChTdHJp bmcqIHJlc3VsdCkgY29uc3QKIHsKLSAgICBTdHJpbmcgdGV4dDsKLSAgICBib29sIHN1Y2Nlc3Mg PSBpbmxpbmVTdHlsZVNoZWV0VGV4dCgmdGV4dCk7CisgICAgU3RyaW5nIHJhd1RleHQ7CisgICAg Ym9vbCBzdWNjZXNzID0gaW5saW5lU3R5bGVTaGVldFRleHQoJnJhd1RleHQpOwogICAgIGlmICgh c3VjY2VzcykKLSAgICAgICAgc3VjY2VzcyA9IHJlc291cmNlU3R5bGVTaGVldFRleHQoJnRleHQp OwotICAgIGlmIChzdWNjZXNzKQotICAgICAgICAqcmVzdWx0ID0gdGV4dDsKKyAgICAgICAgc3Vj Y2VzcyA9IHJlc291cmNlU3R5bGVTaGVldFRleHQoJnJhd1RleHQpOworICAgIGlmIChzdWNjZXNz KSB7CisgICAgICAgIENTdHJpbmcgY1N0cmluZyA9IHJhd1RleHQudXRmOCgpOworICAgICAgICBS ZWZQdHI8VGV4dFJlc291cmNlRGVjb2Rlcj4gZGVjb2RlciA9IFRleHRSZXNvdXJjZURlY29kZXI6 OmNyZWF0ZSgidGV4dC9jc3MiKTsKKyAgICAgICAgU3RyaW5nIHNoZWV0VGV4dCA9IGRlY29kZXIt PmRlY29kZShjU3RyaW5nLmRhdGEoKSwgY1N0cmluZy5sZW5ndGgoKSk7CisgICAgICAgIHNoZWV0 VGV4dCArPSBkZWNvZGVyLT5mbHVzaCgpOworICAgICAgICAqcmVzdWx0ID0gc2hlZXRUZXh0Owor ICAgIH0KICAgICByZXR1cm4gc3VjY2VzczsKIH0KIAo=