<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>59310</bug_id>
          
          <creation_ts>2011-04-24 21:24:43 -0700</creation_ts>
          <short_desc>Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects</short_desc>
          <delta_ts>2011-04-26 17:56:46 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Weinig">sam</reporter>
          <assigned_to name="Sam Weinig">sam</assigned_to>
          <cc>abarth</cc>
    
    <cc>buildbot</cc>
    
    <cc>eric</cc>
    
    <cc>webkit-ews</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>391670</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2011-04-24 21:24:43 -0700</bug_when>
    <thetext>Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>391672</commentid>
    <comment_count>1</comment_count>
      <attachid>90898</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2011-04-24 21:27:14 -0700</bug_when>
    <thetext>Created attachment 90898
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>391673</commentid>
    <comment_count>2</comment_count>
      <attachid>90898</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2011-04-24 21:29:27 -0700</bug_when>
    <thetext>Comment on attachment 90898
Patch

r=ke</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>391674</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-24 21:30:15 -0700</bug_when>
    <thetext>Attachment 90898 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1

Source/WebCore/bindings/js/JSDOMWrapper.h:56:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>391677</commentid>
    <comment_count>4</comment_count>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2011-04-24 21:42:30 -0700</bug_when>
    <thetext>Attachment 90898 did not build on qt:
Build output: http://queues.webkit.org/results/8510141</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>391681</commentid>
    <comment_count>5</comment_count>
    <who name="Build Bot">buildbot</who>
    <bug_when>2011-04-24 22:19:42 -0700</bug_when>
    <thetext>Attachment 90898 did not build on win:
Build output: http://queues.webkit.org/results/8509151</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>391699</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-24 23:37:11 -0700</bug_when>
    <thetext>Attachment 90898 did not build on mac:
Build output: http://queues.webkit.org/results/8504607</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>391719</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-25 01:29:19 -0700</bug_when>
    <thetext>Attachment 90898 did not build on mac:
Build output: http://queues.webkit.org/results/8509179</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>392656</commentid>
    <comment_count>8</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2011-04-26 13:23:11 -0700</bug_when>
    <thetext>Landed in r84945.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>392697</commentid>
    <comment_count>9</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2011-04-26 14:19:18 -0700</bug_when>
    <thetext>Didn&apos;t take.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>392699</commentid>
    <comment_count>10</comment_count>
      <attachid>91159</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2011-04-26 14:21:00 -0700</bug_when>
    <thetext>Created attachment 91159
Updated patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>392714</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-26 14:25:20 -0700</bug_when>
    <thetext>Attachment 91159 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1

Source/WebCore/bindings/js/JSDOMWrapper.h:56:  Should only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>392717</commentid>
    <comment_count>12</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-04-26 14:31:30 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/84945 might have broken WinCairo Debug (Build)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>392983</commentid>
    <comment_count>13</comment_count>
      <attachid>91159</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-04-26 16:21:55 -0700</bug_when>
    <thetext>Comment on attachment 91159
Updated patch

OMG YOU ARE MY HERO.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>393194</commentid>
    <comment_count>14</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2011-04-26 17:56:46 -0700</bug_when>
    <thetext>Relanded in r84992.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>90898</attachid>
            <date>2011-04-24 21:27:14 -0700</date>
            <delta_ts>2011-04-26 14:21:00 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-59310-20110424212713.patch</filename>
            <type>text/plain</type>
            <size>6066</size>
            <attacher name="Sam Weinig">sam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NzY0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDQtMjQgIFNhbSBXZWlu
aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBSZW1vdmUgSlNET01XcmFwcGVyV2l0aEdsb2JhbFBvaW50ZXIgbm93IHRo
YXQgYWxsIEpTRE9NV3JhcHBlcnMgaGF2ZSBnbG9iYWwgb2JqZWN0cworICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkzMTAKKworICAgICAgICAqIGJpbmRp
bmdzL2pzL0pTRE9NQmluZGluZy5oOgorICAgICAgICAoV2ViQ29yZTo6RE9NQ29uc3RydWN0b3JP
YmplY3Q6OkRPTUNvbnN0cnVjdG9yT2JqZWN0KToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RP
TVdyYXBwZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRE9NV3JhcHBlcjo6Z2xvYmFsT2JqZWN0
KToKKyAgICAgICAgKFdlYkNvcmU6OkpTRE9NV3JhcHBlcjo6c2NyaXB0RXhlY3V0aW9uQ29udGV4
dCk6CisgICAgICAgIChXZWJDb3JlOjpKU0RPTVdyYXBwZXI6OmNyZWF0ZVN0cnVjdHVyZSk6Cisg
ICAgICAgIChXZWJDb3JlOjpKU0RPTVdyYXBwZXI6OkpTRE9NV3JhcHBlcik6CisgICAgICAgIE1l
cmdlIEpTRE9NV3JhcHBlcldpdGhHbG9iYWxQb2ludGVyIHdpdGggSlNET01XcmFwcGVyLgorCisg
ICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIE1h
a2UgSlNET01XcmFwcGVyIHRoZSBiYXNlIGNsYXNzLgorCiAyMDExLTA0LTI0ICBHZW9mZnJleSBH
YXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5p
Zy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5oCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5oCShyZXZp
c2lvbiA4NDc2NCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5o
CSh3b3JraW5nIGNvcHkpCkBAIC01MiwzOSArNTIsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK
ICAgICB0eXBlZGVmIGludCBFeGNlcHRpb25Db2RlOwogCi0gICAgLy8gRklYTUU6IFRoaXMgY2xh
c3Mgc2hvdWxkIGNvbGxhcHNlIGludG8gSlNET01XcmFwcGVyIG9uY2UgYWxsIEpTRE9NV3JhcHBl
cnMgYXJlCi0gICAgLy8gdXBkYXRlZCB0byBzdG9yZSBhIGdsb2JhbE9iamVjdCBwb2ludGVyLgot
ICAgIGNsYXNzIEpTRE9NV3JhcHBlcldpdGhHbG9iYWxQb2ludGVyIDogcHVibGljIEpTRE9NV3Jh
cHBlciB7Ci0gICAgcHVibGljOgotICAgICAgICBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2Jq
ZWN0KCkgY29uc3QKLSAgICAgICAgewotICAgICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PEpT
RE9NR2xvYmFsT2JqZWN0Kj4oSlNET01XcmFwcGVyOjpnbG9iYWxPYmplY3QoKSk7Ci0gICAgICAg
IH0KLQotICAgICAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBzY3JpcHRFeGVjdXRpb25Db250
ZXh0KCkgY29uc3QKLSAgICAgICAgewotICAgICAgICAgICAgLy8gRklYTUU6IFNob3VsZCBuZXZl
ciBiZSAwLCBidXQgY2FuIGJlIGR1ZSB0byBidWcgMjc2NDAuCi0gICAgICAgICAgICByZXR1cm4g
Z2xvYmFsT2JqZWN0KCktPnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKTsKLSAgICAgICAgfQotCi0g
ICAgICAgIHN0YXRpYyBKU0M6OlN0cnVjdHVyZSogY3JlYXRlU3RydWN0dXJlKEpTQzo6SlNHbG9i
YWxEYXRhJiBnbG9iYWxEYXRhLCBKU0M6OkpTVmFsdWUgcHJvdG90eXBlKQotICAgICAgICB7Ci0g
ICAgICAgICAgICByZXR1cm4gSlNDOjpTdHJ1Y3R1cmU6OmNyZWF0ZShnbG9iYWxEYXRhLCBwcm90
b3R5cGUsIEpTQzo6VHlwZUluZm8oSlNDOjpPYmplY3RUeXBlLCBTdHJ1Y3R1cmVGbGFncyksIEFu
b255bW91c1Nsb3RDb3VudCwgJnNfaW5mbyk7Ci0gICAgICAgIH0KLQotICAgIHByb3RlY3RlZDoK
LSAgICAgICAgSlNET01XcmFwcGVyV2l0aEdsb2JhbFBvaW50ZXIoSlNDOjpTdHJ1Y3R1cmUqIHN0
cnVjdHVyZSwgSlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCkKLSAgICAgICAgICAgIDog
SlNET01XcmFwcGVyKGdsb2JhbE9iamVjdCwgc3RydWN0dXJlKQotICAgICAgICB7Ci0gICAgICAg
ICAgICAvLyBGSVhNRTogVGhpcyBBU1NFUlQgaXMgdmFsaWQsIGJ1dCBmaXJlcyBpbiBmYXN0L2Rv
bS9nYy02Lmh0bWwgd2hlbiB0cnlpbmcgdG8gY3JlYXRlCi0gICAgICAgICAgICAvLyBuZXcgSmF2
YVNjcmlwdCBvYmplY3RzIG9uIGRldGFjaGVkIHdpbmRvd3MgZHVlIHRvIERPTVdpbmRvdzo6ZG9j
dW1lbnQoKQotICAgICAgICAgICAgLy8gbmVlZGluZyB0byByZWFjaCB0aHJvdWdoIHRoZSBmcmFt
ZSB0byBnZXQgdG8gdGhlIERvY3VtZW50Ki4gIFNlZSBidWcgMjc2NDAuCi0gICAgICAgICAgICAv
LyBBU1NFUlQoZ2xvYmFsT2JqZWN0LT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpOwotICAgICAg
ICB9Ci0gICAgfTsKLQogICAgIC8vIEJhc2UgY2xhc3MgZm9yIGFsbCBjb25zdHJ1Y3RvciBvYmpl
Y3RzIGluIHRoZSBKU0MgYmluZGluZ3MuCi0gICAgY2xhc3MgRE9NQ29uc3RydWN0b3JPYmplY3Qg
OiBwdWJsaWMgSlNET01XcmFwcGVyV2l0aEdsb2JhbFBvaW50ZXIgeworICAgIGNsYXNzIERPTUNv
bnN0cnVjdG9yT2JqZWN0IDogcHVibGljIEpTRE9NV3JhcHBlciB7CiAgICAgcHVibGljOgogICAg
ICAgICBzdGF0aWMgSlNDOjpTdHJ1Y3R1cmUqIGNyZWF0ZVN0cnVjdHVyZShKU0M6OkpTR2xvYmFs
RGF0YSYgZ2xvYmFsRGF0YSwgSlNDOjpKU1ZhbHVlIHByb3RvdHlwZSkKICAgICAgICAgewpAQCAt
OTIsOSArNjEsOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIH0KIAogICAgIHByb3Rl
Y3RlZDoKLSAgICAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIFN0cnVjdHVyZUZsYWdzID0gSlND
OjpJbXBsZW1lbnRzSGFzSW5zdGFuY2UgfCBKU0M6Ok92ZXJyaWRlc1Zpc2l0Q2hpbGRyZW4gfCBK
U0RPTVdyYXBwZXJXaXRoR2xvYmFsUG9pbnRlcjo6U3RydWN0dXJlRmxhZ3M7CisgICAgICAgIHN0
YXRpYyBjb25zdCB1bnNpZ25lZCBTdHJ1Y3R1cmVGbGFncyA9IEpTQzo6SW1wbGVtZW50c0hhc0lu
c3RhbmNlIHwgSlNDOjpPdmVycmlkZXNWaXNpdENoaWxkcmVuIHwgSlNET01XcmFwcGVyOjpTdHJ1
Y3R1cmVGbGFnczsKICAgICAgICAgRE9NQ29uc3RydWN0b3JPYmplY3QoSlNDOjpTdHJ1Y3R1cmUq
IHN0cnVjdHVyZSwgSlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCkKLSAgICAgICAgICAg
IDogSlNET01XcmFwcGVyV2l0aEdsb2JhbFBvaW50ZXIoc3RydWN0dXJlLCBnbG9iYWxPYmplY3Qp
CisgICAgICAgICAgICA6IEpTRE9NV3JhcHBlcihzdHJ1Y3R1cmUsIGdsb2JhbE9iamVjdCkKICAg
ICAgICAgewogICAgICAgICB9CiAgICAgfTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz
L2pzL0pTRE9NV3JhcHBlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz
L2pzL0pTRE9NV3JhcHBlci5oCShyZXZpc2lvbiA4NDc2NCkKKysrIFNvdXJjZS9XZWJDb3JlL2Jp
bmRpbmdzL2pzL0pTRE9NV3JhcHBlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMiwxNSArMjIsMzkg
QEAKICNpZm5kZWYgSlNET01XcmFwcGVyX2gKICNkZWZpbmUgSlNET01XcmFwcGVyX2gKIAorI2lu
Y2x1ZGUgIkpTRE9NR2xvYmFsT2JqZWN0LmgiCiAjaW5jbHVkZSA8cnVudGltZS9KU09iamVjdFdp
dGhHbG9iYWxPYmplY3QuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjbGFzcyBTY3JpcHRF
eGVjdXRpb25Db250ZXh0OworCiBjbGFzcyBKU0RPTVdyYXBwZXIgOiBwdWJsaWMgSlNDOjpKU09i
amVjdFdpdGhHbG9iYWxPYmplY3QgeworcHVibGljOgorICAgIEpTRE9NR2xvYmFsT2JqZWN0KiBn
bG9iYWxPYmplY3QoKSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PEpT
RE9NR2xvYmFsT2JqZWN0Kj4oSlNET01XcmFwcGVyOjpnbG9iYWxPYmplY3QoKSk7CisgICAgfQor
CisgICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpIGNv
bnN0CisgICAgeworICAgICAgICAvLyBGSVhNRTogU2hvdWxkIG5ldmVyIGJlIDAsIGJ1dCBjYW4g
YmUgZHVlIHRvIGJ1ZyAyNzY0MC4KKyAgICAgICAgcmV0dXJuIGdsb2JhbE9iamVjdCgpLT5zY3Jp
cHRFeGVjdXRpb25Db250ZXh0KCk7CisgICAgfQorCisgICAgc3RhdGljIEpTQzo6U3RydWN0dXJl
KiBjcmVhdGVTdHJ1Y3R1cmUoSlNDOjpKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEsIEpTQzo6SlNW
YWx1ZSBwcm90b3R5cGUpCisgICAgeworICAgICAgICByZXR1cm4gSlNDOjpTdHJ1Y3R1cmU6OmNy
ZWF0ZShnbG9iYWxEYXRhLCBwcm90b3R5cGUsIEpTQzo6VHlwZUluZm8oSlNDOjpPYmplY3RUeXBl
LCBTdHJ1Y3R1cmVGbGFncyksIEFub255bW91c1Nsb3RDb3VudCwgJnNfaW5mbyk7CisgICAgfQor
CiBwcm90ZWN0ZWQ6Ci0gICAgZXhwbGljaXQgSlNET01XcmFwcGVyKEpTQzo6SlNHbG9iYWxPYmpl
Y3QqIGdsb2JhbE9iamVjdCwgSlNDOjpTdHJ1Y3R1cmUqIHN0cnVjdHVyZSkgCisgICAgZXhwbGlj
aXQgSlNET01XcmFwcGVyKEpTQzo6U3RydWN0dXJlKiBzdHJ1Y3R1cmUsIEpTQzo6SlNHbG9iYWxP
YmplY3QqIGdsb2JhbE9iamVjdCkgCiAgICAgICAgIDogSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0
KGdsb2JhbE9iamVjdCwgc3RydWN0dXJlKQogICAgIHsKKyAgICAgICAgLy8gRklYTUU6IFRoaXMg
QVNTRVJUIGlzIHZhbGlkLCBidXQgZmlyZXMgaW4gZmFzdC9kb20vZ2MtNi5odG1sIHdoZW4gdHJ5
aW5nIHRvIGNyZWF0ZQorICAgICAgICAvLyBuZXcgSmF2YVNjcmlwdCBvYmplY3RzIG9uIGRldGFj
aGVkIHdpbmRvd3MgZHVlIHRvIERPTVdpbmRvdzo6ZG9jdW1lbnQoKQorICAgICAgICAvLyBuZWVk
aW5nIHRvIHJlYWNoIHRocm91Z2ggdGhlIGZyYW1lIHRvIGdldCB0byB0aGUgRG9jdW1lbnQqLiAg
U2VlIGJ1ZyAyNzY0MC4KKyAgICAgICAgLy8gQVNTRVJUKGdsb2JhbE9iamVjdC0+c2NyaXB0RXhl
Y3V0aW9uQ29udGV4dCgpKTsKICAgICB9CiAKICNpZm5kZWYgTkRFQlVHCkluZGV4OiBTb3VyY2Uv
V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQkocmV2
aXNpb24gODQ3NjQpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l
cmF0b3JKUy5wbQkod29ya2luZyBjb3B5KQpAQCAtMjAwLDcgKzIwMCw3IEBAIHN1YiBHZXRQYXJl
bnRDbGFzc05hbWUKICAgICBteSAkZGF0YU5vZGUgPSBzaGlmdDsKIAogICAgIHJldHVybiAkZGF0
YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJMZWdhY3lQYXJlbnQifSBpZiAkZGF0YU5vZGUt
PmV4dGVuZGVkQXR0cmlidXRlcy0+eyJMZWdhY3lQYXJlbnQifTsKLSAgICByZXR1cm4gIkpTRE9N
V3JhcHBlcldpdGhHbG9iYWxQb2ludGVyIiBpZiAoQHskZGF0YU5vZGUtPnBhcmVudHN9IGVxIDAp
OworICAgIHJldHVybiAiSlNET01XcmFwcGVyIiBpZiAoQHskZGF0YU5vZGUtPnBhcmVudHN9IGVx
IDApOwogICAgIHJldHVybiAiSlMiIC4gJGNvZGVHZW5lcmF0b3ItPlN0cmlwTW9kdWxlKCRkYXRh
Tm9kZS0+cGFyZW50cygwKSk7CiB9CiAK
</data>
<flag name="review"
          id="83665"
          type_id="1"
          status="+"
          setter="mjs"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>91159</attachid>
            <date>2011-04-26 14:21:00 -0700</date>
            <delta_ts>2011-04-26 16:21:55 -0700</delta_ts>
            <desc>Updated patch</desc>
            <filename>patch.diff</filename>
            <type>text/plain</type>
            <size>6051</size>
            <attacher name="Sam Weinig">sam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0OTU0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDQtMjYgIFNhbSBXZWlu
aWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBUcnkgYWdhaW46CisgICAgICAgICAgICBSZW1vdmUgSlNET01XcmFwcGVy
V2l0aEdsb2JhbFBvaW50ZXIgbm93IHRoYXQgYWxsIEpTRE9NV3JhcHBlcnMgaGF2ZSBnbG9iYWwg
b2JqZWN0cworICAgICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTU5MzEwCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaDoKKyAgICAg
ICAgKFdlYkNvcmU6OkRPTUNvbnN0cnVjdG9yT2JqZWN0OjpET01Db25zdHJ1Y3Rvck9iamVjdCk6
CisgICAgICAgICogYmluZGluZ3MvanMvSlNET01XcmFwcGVyLmg6CisgICAgICAgIChXZWJDb3Jl
OjpKU0RPTVdyYXBwZXI6Omdsb2JhbE9iamVjdCk6CisgICAgICAgIChXZWJDb3JlOjpKU0RPTVdy
YXBwZXI6OnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQpOgorICAgICAgICAoV2ViQ29yZTo6SlNET01X
cmFwcGVyOjpjcmVhdGVTdHJ1Y3R1cmUpOgorICAgICAgICAoV2ViQ29yZTo6SlNET01XcmFwcGVy
OjpKU0RPTVdyYXBwZXIpOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv
ckpTLnBtOgorCiAyMDExLTA0LTI2ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAg
ICAgICAgTm9wZSwgcm9sbCBvdXQgcjg0OTUwIGFuZCByODQ5NTIuIFdvcmtpbmcgb24gYSBsYXB0
b3AgaXMgY2xlYXJseSBub3Qgc29tZXRoaW5nCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n
cy9qcy9KU0RPTUJpbmRpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n
cy9qcy9KU0RPTUJpbmRpbmcuaAkocmV2aXNpb24gODQ5NTQpCisrKyBTb3VyY2UvV2ViQ29yZS9i
aW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaAkod29ya2luZyBjb3B5KQpAQCAtNTIsMzkgKzUyLDgg
QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgdHlwZWRlZiBpbnQgRXhjZXB0aW9uQ29kZTsK
IAotICAgIC8vIEZJWE1FOiBUaGlzIGNsYXNzIHNob3VsZCBjb2xsYXBzZSBpbnRvIEpTRE9NV3Jh
cHBlciBvbmNlIGFsbCBKU0RPTVdyYXBwZXJzIGFyZQotICAgIC8vIHVwZGF0ZWQgdG8gc3RvcmUg
YSBnbG9iYWxPYmplY3QgcG9pbnRlci4KLSAgICBjbGFzcyBKU0RPTVdyYXBwZXJXaXRoR2xvYmFs
UG9pbnRlciA6IHB1YmxpYyBKU0RPTVdyYXBwZXIgewotICAgIHB1YmxpYzoKLSAgICAgICAgSlNE
T01HbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCgpIGNvbnN0Ci0gICAgICAgIHsKLSAgICAgICAg
ICAgIHJldHVybiBzdGF0aWNfY2FzdDxKU0RPTUdsb2JhbE9iamVjdCo+KEpTRE9NV3JhcHBlcjo6
Z2xvYmFsT2JqZWN0KCkpOwotICAgICAgICB9Ci0KLSAgICAgICAgU2NyaXB0RXhlY3V0aW9uQ29u
dGV4dCogc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpIGNvbnN0Ci0gICAgICAgIHsKLSAgICAgICAg
ICAgIC8vIEZJWE1FOiBTaG91bGQgbmV2ZXIgYmUgMCwgYnV0IGNhbiBiZSBkdWUgdG8gYnVnIDI3
NjQwLgotICAgICAgICAgICAgcmV0dXJuIGdsb2JhbE9iamVjdCgpLT5zY3JpcHRFeGVjdXRpb25D
b250ZXh0KCk7Ci0gICAgICAgIH0KLQotICAgICAgICBzdGF0aWMgSlNDOjpTdHJ1Y3R1cmUqIGNy
ZWF0ZVN0cnVjdHVyZShKU0M6OkpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSwgSlNDOjpKU1ZhbHVl
IHByb3RvdHlwZSkKLSAgICAgICAgewotICAgICAgICAgICAgcmV0dXJuIEpTQzo6U3RydWN0dXJl
OjpjcmVhdGUoZ2xvYmFsRGF0YSwgcHJvdG90eXBlLCBKU0M6OlR5cGVJbmZvKEpTQzo6T2JqZWN0
VHlwZSwgU3RydWN0dXJlRmxhZ3MpLCBBbm9ueW1vdXNTbG90Q291bnQsICZzX2luZm8pOwotICAg
ICAgICB9Ci0KLSAgICBwcm90ZWN0ZWQ6Ci0gICAgICAgIEpTRE9NV3JhcHBlcldpdGhHbG9iYWxQ
b2ludGVyKEpTQzo6U3RydWN0dXJlKiBzdHJ1Y3R1cmUsIEpTRE9NR2xvYmFsT2JqZWN0KiBnbG9i
YWxPYmplY3QpCi0gICAgICAgICAgICA6IEpTRE9NV3JhcHBlcihnbG9iYWxPYmplY3QsIHN0cnVj
dHVyZSkKLSAgICAgICAgewotICAgICAgICAgICAgLy8gRklYTUU6IFRoaXMgQVNTRVJUIGlzIHZh
bGlkLCBidXQgZmlyZXMgaW4gZmFzdC9kb20vZ2MtNi5odG1sIHdoZW4gdHJ5aW5nIHRvIGNyZWF0
ZQotICAgICAgICAgICAgLy8gbmV3IEphdmFTY3JpcHQgb2JqZWN0cyBvbiBkZXRhY2hlZCB3aW5k
b3dzIGR1ZSB0byBET01XaW5kb3c6OmRvY3VtZW50KCkKLSAgICAgICAgICAgIC8vIG5lZWRpbmcg
dG8gcmVhY2ggdGhyb3VnaCB0aGUgZnJhbWUgdG8gZ2V0IHRvIHRoZSBEb2N1bWVudCouICBTZWUg
YnVnIDI3NjQwLgotICAgICAgICAgICAgLy8gQVNTRVJUKGdsb2JhbE9iamVjdC0+c2NyaXB0RXhl
Y3V0aW9uQ29udGV4dCgpKTsKLSAgICAgICAgfQotICAgIH07Ci0KICAgICAvLyBCYXNlIGNsYXNz
IGZvciBhbGwgY29uc3RydWN0b3Igb2JqZWN0cyBpbiB0aGUgSlNDIGJpbmRpbmdzLgotICAgIGNs
YXNzIERPTUNvbnN0cnVjdG9yT2JqZWN0IDogcHVibGljIEpTRE9NV3JhcHBlcldpdGhHbG9iYWxQ
b2ludGVyIHsKKyAgICBjbGFzcyBET01Db25zdHJ1Y3Rvck9iamVjdCA6IHB1YmxpYyBKU0RPTVdy
YXBwZXIgewogICAgIHB1YmxpYzoKICAgICAgICAgc3RhdGljIEpTQzo6U3RydWN0dXJlKiBjcmVh
dGVTdHJ1Y3R1cmUoSlNDOjpKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEsIEpTQzo6SlNWYWx1ZSBw
cm90b3R5cGUpCiAgICAgICAgIHsKQEAgLTkyLDkgKzYxLDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUg
ewogICAgICAgICB9CiAKICAgICBwcm90ZWN0ZWQ6Ci0gICAgICAgIHN0YXRpYyBjb25zdCB1bnNp
Z25lZCBTdHJ1Y3R1cmVGbGFncyA9IEpTQzo6SW1wbGVtZW50c0hhc0luc3RhbmNlIHwgSlNDOjpP
dmVycmlkZXNWaXNpdENoaWxkcmVuIHwgSlNET01XcmFwcGVyV2l0aEdsb2JhbFBvaW50ZXI6OlN0
cnVjdHVyZUZsYWdzOworICAgICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgU3RydWN0dXJlRmxh
Z3MgPSBKU0M6OkltcGxlbWVudHNIYXNJbnN0YW5jZSB8IEpTQzo6T3ZlcnJpZGVzVmlzaXRDaGls
ZHJlbiB8IEpTRE9NV3JhcHBlcjo6U3RydWN0dXJlRmxhZ3M7CiAgICAgICAgIERPTUNvbnN0cnVj
dG9yT2JqZWN0KEpTQzo6U3RydWN0dXJlKiBzdHJ1Y3R1cmUsIEpTRE9NR2xvYmFsT2JqZWN0KiBn
bG9iYWxPYmplY3QpCi0gICAgICAgICAgICA6IEpTRE9NV3JhcHBlcldpdGhHbG9iYWxQb2ludGVy
KHN0cnVjdHVyZSwgZ2xvYmFsT2JqZWN0KQorICAgICAgICAgICAgOiBKU0RPTVdyYXBwZXIoc3Ry
dWN0dXJlLCBnbG9iYWxPYmplY3QpCiAgICAgICAgIHsKICAgICAgICAgfQogICAgIH07CkluZGV4
OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdyYXBwZXIuaAo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdyYXBwZXIuaAkocmV2aXNpb24gODQ5
NTQpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdyYXBwZXIuaAkod29ya2lu
ZyBjb3B5KQpAQCAtMjIsMTUgKzIyLDM5IEBACiAjaWZuZGVmIEpTRE9NV3JhcHBlcl9oCiAjZGVm
aW5lIEpTRE9NV3JhcHBlcl9oCiAKKyNpbmNsdWRlICJKU0RPTUdsb2JhbE9iamVjdC5oIgogI2lu
Y2x1ZGUgPHJ1bnRpbWUvSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0Lmg+CiAKIG5hbWVzcGFjZSBX
ZWJDb3JlIHsKIAorY2xhc3MgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDsKKwogY2xhc3MgSlNET01X
cmFwcGVyIDogcHVibGljIEpTQzo6SlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0IHsKK3B1YmxpYzoK
KyAgICBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0KCkgY29uc3QKKyAgICB7CisgICAg
ICAgIHJldHVybiBzdGF0aWNfY2FzdDxKU0RPTUdsb2JhbE9iamVjdCo+KEpTQzo6SlNPYmplY3RX
aXRoR2xvYmFsT2JqZWN0OjpnbG9iYWxPYmplY3QoKSk7CisgICAgfQorCisgICAgU2NyaXB0RXhl
Y3V0aW9uQ29udGV4dCogc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpIGNvbnN0CisgICAgeworICAg
ICAgICAvLyBGSVhNRTogU2hvdWxkIG5ldmVyIGJlIDAsIGJ1dCBjYW4gYmUgZHVlIHRvIGJ1ZyAy
NzY0MC4KKyAgICAgICAgcmV0dXJuIGdsb2JhbE9iamVjdCgpLT5zY3JpcHRFeGVjdXRpb25Db250
ZXh0KCk7CisgICAgfQorCisgICAgc3RhdGljIEpTQzo6U3RydWN0dXJlKiBjcmVhdGVTdHJ1Y3R1
cmUoSlNDOjpKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEsIEpTQzo6SlNWYWx1ZSBwcm90b3R5cGUp
CisgICAgeworICAgICAgICByZXR1cm4gSlNDOjpTdHJ1Y3R1cmU6OmNyZWF0ZShnbG9iYWxEYXRh
LCBwcm90b3R5cGUsIEpTQzo6VHlwZUluZm8oSlNDOjpPYmplY3RUeXBlLCBTdHJ1Y3R1cmVGbGFn
cyksIEFub255bW91c1Nsb3RDb3VudCwgJnNfaW5mbyk7CisgICAgfQorCiBwcm90ZWN0ZWQ6Ci0g
ICAgZXhwbGljaXQgSlNET01XcmFwcGVyKEpTQzo6SlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVj
dCwgSlNDOjpTdHJ1Y3R1cmUqIHN0cnVjdHVyZSkgCisgICAgZXhwbGljaXQgSlNET01XcmFwcGVy
KEpTQzo6U3RydWN0dXJlKiBzdHJ1Y3R1cmUsIEpTQzo6SlNHbG9iYWxPYmplY3QqIGdsb2JhbE9i
amVjdCkgCiAgICAgICAgIDogSlNPYmplY3RXaXRoR2xvYmFsT2JqZWN0KGdsb2JhbE9iamVjdCwg
c3RydWN0dXJlKQogICAgIHsKKyAgICAgICAgLy8gRklYTUU6IFRoaXMgQVNTRVJUIGlzIHZhbGlk
LCBidXQgZmlyZXMgaW4gZmFzdC9kb20vZ2MtNi5odG1sIHdoZW4gdHJ5aW5nIHRvIGNyZWF0ZQor
ICAgICAgICAvLyBuZXcgSmF2YVNjcmlwdCBvYmplY3RzIG9uIGRldGFjaGVkIHdpbmRvd3MgZHVl
IHRvIERPTVdpbmRvdzo6ZG9jdW1lbnQoKQorICAgICAgICAvLyBuZWVkaW5nIHRvIHJlYWNoIHRo
cm91Z2ggdGhlIGZyYW1lIHRvIGdldCB0byB0aGUgRG9jdW1lbnQqLiAgU2VlIGJ1ZyAyNzY0MC4K
KyAgICAgICAgLy8gQVNTRVJUKGdsb2JhbE9iamVjdC0+c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgp
KTsKICAgICB9CiAKICNpZm5kZWYgTkRFQlVHCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n
cy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y
ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQkocmV2aXNpb24gODQ5NTQpCisr
KyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQkod29y
a2luZyBjb3B5KQpAQCAtMjAwLDcgKzIwMCw3IEBAIHN1YiBHZXRQYXJlbnRDbGFzc05hbWUKICAg
ICBteSAkZGF0YU5vZGUgPSBzaGlmdDsKIAogICAgIHJldHVybiAkZGF0YU5vZGUtPmV4dGVuZGVk
QXR0cmlidXRlcy0+eyJMZWdhY3lQYXJlbnQifSBpZiAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmli
dXRlcy0+eyJMZWdhY3lQYXJlbnQifTsKLSAgICByZXR1cm4gIkpTRE9NV3JhcHBlcldpdGhHbG9i
YWxQb2ludGVyIiBpZiAoQHskZGF0YU5vZGUtPnBhcmVudHN9IGVxIDApOworICAgIHJldHVybiAi
SlNET01XcmFwcGVyIiBpZiAoQHskZGF0YU5vZGUtPnBhcmVudHN9IGVxIDApOwogICAgIHJldHVy
biAiSlMiIC4gJGNvZGVHZW5lcmF0b3ItPlN0cmlwTW9kdWxlKCRkYXRhTm9kZS0+cGFyZW50cygw
KSk7CiB9CiAK
</data>
<flag name="review"
          id="83942"
          type_id="1"
          status="+"
          setter="eric"
    />
    <flag name="commit-queue"
          id="83971"
          type_id="3"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>