59299 2011-04-24 03:07:12 -0700 Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com 2011-04-24 11:31:45 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 391584 0 mitz 2011-04-24 03:07:12 -0700 Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com 391585 1 90881 mitz 2011-04-24 03:09:16 -0700 Created attachment 90881 Add null checks 391586 2 90881 mitz 2011-04-24 03:10:48 -0700 Comment on attachment 90881 Add null checks This requires a manual test because the borderless window used by WebKitTestRunner doesn’t have a grow box, and having one is essential for the crashing code path to be taken. 391587 3 90881 mjs 2011-04-24 03:32:17 -0700 Comment on attachment 90881 Add null checks r=me 391613 4 mitz 2011-04-24 11:31:45 -0700 Fixed in r84757. <http://trac.webkit.org/changeset/84757> 90881 2011-04-24 03:09:16 -0700 2011-04-24 03:32:17 -0700 Add null checks bug-59299-20110424030915.patch text/plain 4035 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NzU2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQtMjQgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNYW51YWwgdGVzdCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzkzMjk3NDE+ IFJlcHJvZHVjaWJsZSBjcmFzaCBpbiBXZWJDaHJvbWVDbGllbnQ6OmludmFsaWRhdGVDb250ZW50 c0FuZFdpbmRvdygpIG9uIHNpbW9uc2NhdC5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU5Mjk5CisKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvYmFj ay1mcm9tLWRvY3VtZW50LXdpdGgtc2Nyb2xsYmFyLmh0bWw6IEFkZGVkLgorCiAyMDExLTA0LTI0 ICBSaWsgQ2FiYW5pZXIgIDxjYWJhbmllckBhZG9iZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgU2ltb24gRnJhc2VyLgpJbmRleDogU291cmNlL1dlYkNvcmUvbWFudWFsLXRlc3RzL2JhY2st ZnJvbS1kb2N1bWVudC13aXRoLXNjcm9sbGJhci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL21hbnVhbC10ZXN0cy9iYWNrLWZyb20tZG9jdW1lbnQtd2l0aC1zY3JvbGxiYXIuaHRt bAkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9XZWJDb3JlL21hbnVhbC10ZXN0cy9iYWNrLWZyb20t ZG9jdW1lbnQtd2l0aC1zY3JvbGxiYXIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0MiBA QAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIG5hdmlnYXRlKCkKK3sKKyAg ICBpZiAobG9jYXRpb24uaGFzaCA9PSAiIikgeworICAgICAgICBpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKSB7CisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNU ZXh0KCk7CisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7 CisgICAgICAgIH0KKworICAgICAgICBoaXN0b3J5LnB1c2hTdGF0ZSh7IH0sICIiLCB3aW5kb3cu bG9jYXRpb24gKyAiIzEiKTsKKyAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAg ICAgICAgIHdpbmRvdy5sb2NhdGlvbi5ocmVmID0gJ2RhdGE6dGV4dC9odG1sLCBcCisgICAgICAg ICAgICAgICAgPGh0bWwgc3R5bGU9ImhlaWdodDogMjAwJSI+IFwKKyAgICAgICAgICAgICAgICA8 Ym9keSBvbnVubG9hZD0iIj4gXAorICAgICAgICAgICAgICAgIDxzY3JpcHQ+IFwKKyAgICAgICAg ICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5vZmZzZXRXaWR0aDsgXAorICAgICAgICAgICAgICAg ICAgICBzZXRUaW1lb3V0KCJ3aW5kb3cuaGlzdG9yeS5iYWNrKCk7IiwgMCk7IFwKKyAgICAgICAg ICAgICAgICA8JyArICcvc2NyaXB0PiBcCisgICAgICAgICAgICAgICAgPC9ib2R5PiBcCisgICAg ICAgICAgICAgICAgPC9odG1sPiBcCisgICAgICAgICAgICAnOworICAgICAgICB9LCAwKTsKKyAg ICAgICAgcmV0dXJuOworICAgIH0KKworICAgIHNldFRpbWVvdXQoZnVuY3Rpb24gKCkgeyAKKyAg ICAgICAgdmFyIHJlc3VsdCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKTsKKyAg ICAgICAgcmVzdWx0LmlubmVySFRNTCA9ICJTdWNjZXNzIGlmIHRoZSB3ZWIgcHJvY2VzcyBkaWQg bm90IGNyYXNoLiIKKyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICB9LCAwKTsK K30KKworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbnBhZ2VzaG93PSJuYXZpZ2F0ZSgpOyI+ CisgICAgPGRpdiBpZD0icmVzdWx0Ij5UZXN0IGRpZCBub3QgY29tcGxldGU8L2Rpdj4KKzwvYm9k eT4KKzwvaHRtTD4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg0NzU2KQorKysgU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDQt MjQgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTMyOTc0MT4gUmVw cm9kdWNpYmxlIGNyYXNoIGluIFdlYkNocm9tZUNsaWVudDo6aW52YWxpZGF0ZUNvbnRlbnRzQW5k V2luZG93KCkgb24gc2ltb25zY2F0LmNvbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTkyOTkKKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1 cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ2hyb21lQ2xp ZW50OjppbnZhbGlkYXRlQ29udGVudHNBbmRXaW5kb3cpOiBOdWxsLWNoZWNrIHRoZSBkb2N1bWVu dC4KKyAgICAgICAgKFdlYktpdDo6V2ViQ2hyb21lQ2xpZW50OjppbnZhbGlkYXRlQ29udGVudHNG b3JTbG93U2Nyb2xsKTogRGl0dG8uCisKIDIwMTEtMDQtMjMgIFNoZXJpZmYgQm90ICA8d2Via2l0 LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHI4NDc0MC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQv V2ViQ2hyb21lQ2xpZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHAJKHJldmlzaW9uIDg0NzQ5KQor KysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGll bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTYsMTUgKzM1NiwyMSBAQCB2b2lkIFdlYkNocm9t ZUNsaWVudDo6aW52YWxpZGF0ZVdpbmRvdyhjCiAKIHZvaWQgV2ViQ2hyb21lQ2xpZW50OjppbnZh bGlkYXRlQ29udGVudHNBbmRXaW5kb3coY29uc3QgSW50UmVjdCYgcmVjdCwgYm9vbCkKIHsKLSAg ICBpZiAobV9wYWdlLT5jb3JlUGFnZSgpLT5tYWluRnJhbWUoKS0+ZG9jdW1lbnQoKS0+cHJpbnRp bmcoKSkKLSAgICAgICAgcmV0dXJuOworICAgIGlmIChEb2N1bWVudCogZG9jdW1lbnQgPSBtX3Bh Z2UtPmNvcmVQYWdlKCktPm1haW5GcmFtZSgpLT5kb2N1bWVudCgpKSB7CisgICAgICAgIGlmIChk b2N1bWVudC0+cHJpbnRpbmcoKSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBt X3BhZ2UtPmRyYXdpbmdBcmVhKCktPnNldE5lZWRzRGlzcGxheShyZWN0KTsKIH0KIAogdm9pZCBX ZWJDaHJvbWVDbGllbnQ6OmludmFsaWRhdGVDb250ZW50c0ZvclNsb3dTY3JvbGwoY29uc3QgSW50 UmVjdCYgcmVjdCwgYm9vbCkKIHsKLSAgICBpZiAobV9wYWdlLT5jb3JlUGFnZSgpLT5tYWluRnJh bWUoKS0+ZG9jdW1lbnQoKS0+cHJpbnRpbmcoKSkKLSAgICAgICAgcmV0dXJuOworICAgIGlmIChE b2N1bWVudCogZG9jdW1lbnQgPSBtX3BhZ2UtPmNvcmVQYWdlKCktPm1haW5GcmFtZSgpLT5kb2N1 bWVudCgpKSB7CisgICAgICAgIGlmIChkb2N1bWVudC0+cHJpbnRpbmcoKSkKKyAgICAgICAgICAg IHJldHVybjsKKyAgICB9CisKICAgICBtX3BhZ2UtPnBhZ2VEaWRTY3JvbGwoKTsKICAgICBtX3Bh Z2UtPmRyYXdpbmdBcmVhKCktPnNldE5lZWRzRGlzcGxheShyZWN0KTsKIH0K