59283 2011-04-23 14:04:52 -0700 wrong exception raised in Lighttpd start method 2011-05-01 18:27:26 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 a.renevier webkit-unassigned commit-queue eric oldest_to_newest 391481 0 a.renevier 2011-04-23 14:04:52 -0700 Hi, when try to run the tests with lighttd server, for some reason server could not start. Then I get following exception: NameError: global name 'google' is not defined Actually, in start method of Lighttpd class, > raise google.httpd_utils.HttpdNotStarted('Failed to start httpd.') raises a name error because google is not defined. This does not change much, as an exception is raised anyway. But may be it's better to raise a relevant exception. 391482 1 90857 a.renevier 2011-04-23 14:11:23 -0700 Created attachment 90857 patch v1 391483 2 90858 a.renevier 2011-04-23 14:16:04 -0700 Created attachment 90858 patch v1 As HttpdNotStarted is not used anywhere else, it's also possible to remove it totally, and raise a simple Exception as in pache_http_server.py 392987 3 90858 ojan 2011-04-26 16:23:32 -0700 Comment on attachment 90858 patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=90858&action=review > Tools/ChangeLog:7 > + Would be nice to put a bit more detail here that google.httpd_utils.HttpdNotStarted does not exist. 393419 4 91247 a.renevier 2011-04-27 00:41:55 -0700 Created attachment 91247 patch v1.1 396157 5 91247 commit-queue 2011-05-01 18:03:25 -0700 Comment on attachment 91247 patch v1.1 Clearing flags on attachment: 91247 Committed r85447: <http://trac.webkit.org/changeset/85447> 396158 6 commit-queue 2011-05-01 18:03:30 -0700 All reviewed patches have been landed. Closing bug. 396172 7 eric 2011-05-01 18:27:26 -0700 Committed r85449: <http://trac.webkit.org/changeset/85449> 90857 2011-04-23 14:11:23 -0700 2011-04-23 14:16:01 -0700 patch v1 bug-59283-20110423231121.patch text/plain 1359 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogODQxMDMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZjYzYmE4MTg4OGRlNTY1YTYxNjQxZjE5YzEzMTIwNTBh M2VkNTgwLi5mOGNhNjkwMGMwZTBhMjBjMzc4MTA4NDJlNTEyOGViNTQ4MWE5MzcxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTUg QEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICB3cm9u ZyBleGNlcHRpb24gcmFpc2VkIGluIExpZ2h0dHBkIHN0YXJ0IG1ldGhvZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkyODMKKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvaHR0cF9zZXJ2ZXIucHk6CisKKzIwMTEt MDQtMjMgIEFybm8gUmVuZXZpZXIgIDxhcm5vQHJlbmV2aWVyLm5ldD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBtYWtlIHJ1bi1ndGstdGVzdHMgZXhl Y3V0YWJsZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTkyNzgKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9odHRwX3NlcnZlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvaHR0cF9zZXJ2ZXIucHkKaW5kZXggNWJhNzY3ZmFlODVhYTg3NTU0ODQ3MzIzM2JjNjAy MDVhYmE4ZWE5OC4uZTZjYmRkM2VjNDNiMGQ2MDY4OTk1N2ZkZjY0ODY4MzhhMDY0NGY1NSAxMDA3 NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX3Nl cnZlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0 dHBfc2VydmVyLnB5CkBAIC0yMjMsNyArMjIzLDcgQEAgY2xhc3MgTGlnaHR0cGQoaHR0cF9zZXJ2 ZXJfYmFzZS5IdHRwU2VydmVyQmFzZSk6CiAKICAgICAgICAgIyBPdXIgcHJvY2VzcyB0ZXJtaW5h dGVkIGFscmVhZHkKICAgICAgICAgaWYgbm90IHNlcnZlcl9zdGFydGVkIG9yIHNlbGYuX3Byb2Nl c3MucmV0dXJuY29kZSAhPSBOb25lOgotICAgICAgICAgICAgcmFpc2UgZ29vZ2xlLmh0dHBkX3V0 aWxzLkh0dHBkTm90U3RhcnRlZCgnRmFpbGVkIHRvIHN0YXJ0IGh0dHBkLicpCisgICAgICAgICAg ICByYWlzZSBIdHRwZE5vdFN0YXJ0ZWQoJ0ZhaWxlZCB0byBzdGFydCBodHRwZC4nKQogCiAgICAg ICAgIF9sb2cuZGVidWcoIlNlcnZlciBzdWNjZXNzZnVsbHkgc3RhcnRlZCIpCiAK 90858 2011-04-23 14:16:04 -0700 2011-04-27 00:41:55 -0700 patch v1 bug-59283-20110423231602.patch text/plain 1644 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogODQxMDMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZjYzYmE4MTg4OGRlNTY1YTYxNjQxZjE5YzEzMTIwNTBh M2VkNTgwLi5mOGNhNjkwMGMwZTBhMjBjMzc4MTA4NDJlNTEyOGViNTQ4MWE5MzcxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTUg QEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICB3cm9u ZyBleGNlcHRpb24gcmFpc2VkIGluIExpZ2h0dHBkIHN0YXJ0IG1ldGhvZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTkyODMKKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvaHR0cF9zZXJ2ZXIucHk6CisKKzIwMTEt MDQtMjMgIEFybm8gUmVuZXZpZXIgIDxhcm5vQHJlbmV2aWVyLm5ldD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBtYWtlIHJ1bi1ndGstdGVzdHMgZXhl Y3V0YWJsZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTkyNzgKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9odHRwX3NlcnZlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvaHR0cF9zZXJ2ZXIucHkKaW5kZXggNWJhNzY3ZmFlODVhYTg3NTU0ODQ3MzIzM2JjNjAy MDVhYmE4ZWE5OC4uZTUyNWVlMGU0OTEyZmUwOTUzOGY3Y2RmZGYzYTFiNjM0ODEyNDMyZCAxMDA3 NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX3Nl cnZlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0 dHBfc2VydmVyLnB5CkBAIC00OCwxMCArNDgsNiBAQCBpbXBvcnQgaHR0cF9zZXJ2ZXJfYmFzZQog X2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKCJ3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydC5odHRw X3NlcnZlciIpCiAKIAotY2xhc3MgSHR0cGROb3RTdGFydGVkKEV4Y2VwdGlvbik6Ci0gICAgcGFz cwotCi0KIGNsYXNzIExpZ2h0dHBkKGh0dHBfc2VydmVyX2Jhc2UuSHR0cFNlcnZlckJhc2UpOgog CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIHBvcnRfb2JqLCBvdXRwdXRfZGlyLCBiYWNrZ3JvdW5k PUZhbHNlLCBwb3J0PU5vbmUsCkBAIC0yMjMsNyArMjE5LDcgQEAgY2xhc3MgTGlnaHR0cGQoaHR0 cF9zZXJ2ZXJfYmFzZS5IdHRwU2VydmVyQmFzZSk6CiAKICAgICAgICAgIyBPdXIgcHJvY2VzcyB0 ZXJtaW5hdGVkIGFscmVhZHkKICAgICAgICAgaWYgbm90IHNlcnZlcl9zdGFydGVkIG9yIHNlbGYu X3Byb2Nlc3MucmV0dXJuY29kZSAhPSBOb25lOgotICAgICAgICAgICAgcmFpc2UgZ29vZ2xlLmh0 dHBkX3V0aWxzLkh0dHBkTm90U3RhcnRlZCgnRmFpbGVkIHRvIHN0YXJ0IGh0dHBkLicpCisgICAg ICAgICAgICByYWlzZSBFeGNlcHRpb24oJ0ZhaWxlZCB0byBzdGFydCBodHRwZC4nKQogCiAgICAg ICAgIF9sb2cuZGVidWcoIlNlcnZlciBzdWNjZXNzZnVsbHkgc3RhcnRlZCIpCiAK 91247 2011-04-27 00:41:55 -0700 2011-05-01 18:03:25 -0700 patch v1.1 0001-wrong-exception-raised-in-Lighttpd-start-method-5928.patch text/plain 2024 a.renevier RnJvbSAyMzg4M2Q2MDVkYzg0MDU3Y2Q0NWNhZDg3ZjVhOWNmMThmODhkZDFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBcm5vIFJlbmV2aWVyIDxhcm5vQHJlbmV2aWVyLm5ldD4KRGF0 ZTogU2F0LCAyMyBBcHIgMjAxMSAyMzoxMjo1MCArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMS8yXSB3 cm9uZyBleGNlcHRpb24gcmFpc2VkIGluIExpZ2h0dHBkIHN0YXJ0IG1ldGhvZCAoIzU5MjgzKQoK LS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTIgKysrKysrKysrKysrCiAuLi4vd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvaHR0cF9z ZXJ2ZXIucHkgICAgICB8ICAgIDYgKy0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlv bnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v bHMvQ2hhbmdlTG9nCmluZGV4IDU5ZjVmOGMuLjNjYTg0M2UgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTIsNiArMiwxOCBAQAogCiAgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIHdyb25nIGV4Y2VwdGlvbiBy YWlzZWQgaW4gTGlnaHR0cGQgc3RhcnQgbWV0aG9kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTI4MworCisgICAgICAgIHJhaXNlIHN0YW5kYXJkIEV4 Y2VwdGlvbiBpbnN0ZWFkIG9mIG5vbiBleGlzdGVudAorICAgICAgICBnb29nbGUuaHR0cGRfdXRp bHMuSHR0cGROb3RTdGFydGVkCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2h0dHBfc2VydmVyLnB5OgorCisyMDExLTA0LTIzICBBcm5vIFJlbmV2aWVyICA8 YXJub0ByZW5ldmllci5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKICAgICAgICAgbWFrZSBydW4tZ3RrLXRlc3RzIGV4ZWN1dGFibGUKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5Mjc4CiAKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvaHR0cF9zZXJ2ZXIucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2h0dHBfc2VydmVyLnB5Cmlu ZGV4IDViYTc2N2YuLmU1MjVlZTAgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvaHR0cF9zZXJ2ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9odHRwX3NlcnZlci5weQpAQCAtNDgsMTAgKzQ4LDYgQEAg aW1wb3J0IGh0dHBfc2VydmVyX2Jhc2UKIF9sb2cgPSBsb2dnaW5nLmdldExvZ2dlcigid2Via2l0 cHkubGF5b3V0X3Rlc3RzLnBvcnQuaHR0cF9zZXJ2ZXIiKQogCiAKLWNsYXNzIEh0dHBkTm90U3Rh cnRlZChFeGNlcHRpb24pOgotICAgIHBhc3MKLQotCiBjbGFzcyBMaWdodHRwZChodHRwX3NlcnZl cl9iYXNlLkh0dHBTZXJ2ZXJCYXNlKToKIAogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwb3J0X29i aiwgb3V0cHV0X2RpciwgYmFja2dyb3VuZD1GYWxzZSwgcG9ydD1Ob25lLApAQCAtMjIzLDcgKzIx OSw3IEBAIGNsYXNzIExpZ2h0dHBkKGh0dHBfc2VydmVyX2Jhc2UuSHR0cFNlcnZlckJhc2UpOgog CiAgICAgICAgICMgT3VyIHByb2Nlc3MgdGVybWluYXRlZCBhbHJlYWR5CiAgICAgICAgIGlmIG5v dCBzZXJ2ZXJfc3RhcnRlZCBvciBzZWxmLl9wcm9jZXNzLnJldHVybmNvZGUgIT0gTm9uZToKLSAg ICAgICAgICAgIHJhaXNlIGdvb2dsZS5odHRwZF91dGlscy5IdHRwZE5vdFN0YXJ0ZWQoJ0ZhaWxl ZCB0byBzdGFydCBodHRwZC4nKQorICAgICAgICAgICAgcmFpc2UgRXhjZXB0aW9uKCdGYWlsZWQg dG8gc3RhcnQgaHR0cGQuJykKIAogICAgICAgICBfbG9nLmRlYnVnKCJTZXJ2ZXIgc3VjY2Vzc2Z1 bGx5IHN0YXJ0ZWQiKQogCi0tIAoxLjcuNC40Cgo=