59253 2011-04-22 16:23:35 -0700 CommitQueue should remember the expected failures from patch to patch 2011-04-22 16:35:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth eric oldest_to_newest 391212 0 abarth 2011-04-22 16:23:35 -0700 CommitQueue should remember the expected failures from patch to patch 391214 1 90799 abarth 2011-04-22 16:24:49 -0700 Created attachment 90799 Patch 391216 2 90799 eric 2011-04-22 16:27:18 -0700 Comment on attachment 90799 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90799&action=review Otherwise looks fine. > Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py:69 > - self._expected_failures = ExpectedFailures() > + self._expected_failures = delegate.expected_failures() Looks like we should jus tpass them into the constructor instead. 391221 3 abarth 2011-04-22 16:35:49 -0700 Committed r84704: <http://trac.webkit.org/changeset/84704> 90799 2011-04-22 16:24:49 -0700 2011-04-22 16:27:18 -0700 Patch bug-59253-20110422162448.patch text/plain 5016 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg0NzAxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMDQtMjIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb21taXRRdWV1 ZSBzaG91bGQgcmVtZW1iZXIgdGhlIGV4cGVjdGVkIGZhaWx1cmVzIGZyb20gcGF0Y2ggdG8gcGF0 Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5MjUz CisKKyAgICAgICAgUHJldmlvdXNseSwgd2Ugc3RvcmVkIHRoZSBzZXQgb2YgZXhwZWN0ZWQgZmFp bHVyZXMgb24gdGhlIHRhc2sgb2JqZWN0LAorICAgICAgICB3aGljaCBtZWFudCB0aGUgY29tbWl0 LXF1ZXVlIGZvcmdvdCBhYm91dCB0aGVtIGFmdGVyIGVhY2ggcGF0Y2guICBUaGlzCisgICAgICAg IHBhdGNoIG1vdmVzIHRoZW0gdG8gdGhlIENvbW1pdFF1ZXVlIG9iamVjdCBzbyB0aGV5IHdpbGwg aGF2ZSBhIGxvbmdlcgorICAgICAgICBsaWZldGltZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvdG9vbC9ib3QvY29tbWl0cXVldWV0YXNrX3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvcGF0Y2hhbmFseXNpc3Rhc2sucHk6CisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weToKKwogMjAxMS0wNC0yMiAg RGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg Q3NhYmEgT3N6dHJvZ29uw6FjLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Jv dC9jb21taXRxdWV1ZXRhc2tfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRhc2tfdW5pdHRlc3QucHkJKHJldmlzaW9u IDg0NjU4KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9jb21taXRxdWV1ZXRh c2tfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTM4LDYgKzM4LDcgQEAgZnJvbSB3ZWJr aXRweS5sYXlvdXRfdGVzdHMubGF5b3V0X3BhY2thZwogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVz dHMubGF5b3V0X3BhY2thZ2UgaW1wb3J0IHRlc3RfZmFpbHVyZXMKIGZyb20gd2Via2l0cHkudGhp cmRwYXJ0eS5tb2NrIGltcG9ydCBNb2NrCiBmcm9tIHdlYmtpdHB5LnRvb2wuYm90LmNvbW1pdHF1 ZXVldGFzayBpbXBvcnQgKgorZnJvbSB3ZWJraXRweS50b29sLmJvdC5leHBlY3RlZGZhaWx1cmVz IGltcG9ydCBFeHBlY3RlZEZhaWx1cmVzCiBmcm9tIHdlYmtpdHB5LnRvb2wubW9ja3Rvb2wgaW1w b3J0IE1vY2tUb29sCiAKIApAQCAtNjQsNiArNjUsOSBAQCBjbGFzcyBNb2NrQ29tbWl0UXVldWUo Q29tbWl0UXVldWVUYXNrRGVsCiAgICAgZGVmIHJlZmV0Y2hfcGF0Y2goc2VsZiwgcGF0Y2gpOgog ICAgICAgICByZXR1cm4gcGF0Y2gKIAorICAgIGRlZiBleHBlY3RlZF9mYWlsdXJlcyhzZWxmKToK KyAgICAgICAgcmV0dXJuIEV4cGVjdGVkRmFpbHVyZXMoKQorCiAgICAgZGVmIGxheW91dF90ZXN0 X3Jlc3VsdHMoc2VsZik6CiAgICAgICAgIHJldHVybiBOb25lCiAKQEAgLTM3Niw2ICszODAsOSBA QCBjb21tYW5kX2ZhaWxlZDogZmFpbHVyZV9tZXNzYWdlPSdVbmFibGUgCiAgICAgICAgICAgICBk ZWYgcmVmZXRjaF9wYXRjaChzZWxmLCBwYXRjaCk6CiAgICAgICAgICAgICAgICAgcmV0dXJuIHBh dGNoCiAKKyAgICAgICAgICAgIGRlZiBleHBlY3RlZF9mYWlsdXJlcyhzZWxmKToKKyAgICAgICAg ICAgICAgICByZXR1cm4gRXhwZWN0ZWRGYWlsdXJlcygpCisKICAgICAgICAgdGFzayA9IENvbW1p dFF1ZXVlVGFzayhNb2NrRGVsZWdhdGUoKSwgcGF0Y2gpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWxzKHRhc2sudmFsaWRhdGUoKSwgaXNfdmFsaWQpCiAKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9ib3QvcGF0Y2hhbmFseXNpc3Rhc2sucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9wYXRjaGFuYWx5c2lzdGFzay5weQkocmV2aXNpb24g ODQ2NTgpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3BhdGNoYW5hbHlzaXN0 YXNrLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yOCw3ICsyOCw2IEBACiAKIGZyb20gd2Via2l0cHku Y29tbW9uLnN5c3RlbS5leGVjdXRpdmUgaW1wb3J0IFNjcmlwdEVycm9yCiBmcm9tIHdlYmtpdHB5 LmNvbW1vbi5uZXQubGF5b3V0dGVzdHJlc3VsdHMgaW1wb3J0IExheW91dFRlc3RSZXN1bHRzCi1m cm9tIHdlYmtpdHB5LnRvb2wuYm90LmV4cGVjdGVkZmFpbHVyZXMgaW1wb3J0IEV4cGVjdGVkRmFp bHVyZXMKIAogCiBjbGFzcyBQYXRjaEFuYWx5c2lzVGFza0RlbGVnYXRlKG9iamVjdCk6CkBAIC00 Nyw2ICs0Niw5IEBAIGNsYXNzIFBhdGNoQW5hbHlzaXNUYXNrRGVsZWdhdGUob2JqZWN0KToKICAg ICBkZWYgcmVmZXRjaF9wYXRjaChzZWxmLCBwYXRjaCk6CiAgICAgICAgIHJhaXNlIE5vdEltcGxl bWVudGVkRXJyb3IoInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQiKQogCisgICAgZGVmIGV4cGVj dGVkX2ZhaWx1cmVzKHNlbGYpOgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCJz dWJjbGFzc2VzIG11c3QgaW1wbGVtZW50IikKKwogICAgIGRlZiBsYXlvdXRfdGVzdF9yZXN1bHRz KHNlbGYpOgogICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCJzdWJjbGFzc2VzIG11 c3QgaW1wbGVtZW50IikKIApAQCAtNjQsNyArNjYsNyBAQCBjbGFzcyBQYXRjaEFuYWx5c2lzVGFz ayhvYmplY3QpOgogICAgICAgICBzZWxmLl9wYXRjaCA9IHBhdGNoCiAgICAgICAgIHNlbGYuX3Nj cmlwdF9lcnJvciA9IE5vbmUKICAgICAgICAgc2VsZi5fcmVzdWx0c19hcmNoaXZlX2Zyb21fcGF0 Y2hfdGVzdF9ydW4gPSBOb25lCi0gICAgICAgIHNlbGYuX2V4cGVjdGVkX2ZhaWx1cmVzID0gRXhw ZWN0ZWRGYWlsdXJlcygpCisgICAgICAgIHNlbGYuX2V4cGVjdGVkX2ZhaWx1cmVzID0gZGVsZWdh dGUuZXhwZWN0ZWRfZmFpbHVyZXMoKQogCiAgICAgZGVmIF9ydW5fY29tbWFuZChzZWxmLCBjb21t YW5kLCBzdWNjZXNzX21lc3NhZ2UsIGZhaWx1cmVfbWVzc2FnZSk6CiAgICAgICAgIHRyeToKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQko cmV2aXNpb24gODQ2ODkpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMv cXVldWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00NSw2ICs0NSw3IEBAIGZyb20gd2Via2l0cHku Y29tbW9uLnN5c3RlbS5kZXByZWNhdGVkX2wKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5l eGVjdXRpdmUgaW1wb3J0IFNjcmlwdEVycm9yCiBmcm9tIHdlYmtpdHB5LnRvb2wuYm90LmJvdGlu Zm8gaW1wb3J0IEJvdEluZm8KIGZyb20gd2Via2l0cHkudG9vbC5ib3QuY29tbWl0cXVldWV0YXNr IGltcG9ydCBDb21taXRRdWV1ZVRhc2ssIENvbW1pdFF1ZXVlVGFza0RlbGVnYXRlCitmcm9tIHdl YmtpdHB5LnRvb2wuYm90LmV4cGVjdGVkZmFpbHVyZXMgaW1wb3J0IEV4cGVjdGVkRmFpbHVyZXMK IGZyb20gd2Via2l0cHkudG9vbC5ib3QuZmVlZGVycyBpbXBvcnQgQ29tbWl0UXVldWVGZWVkZXIs IEVXU0ZlZWRlcgogZnJvbSB3ZWJraXRweS50b29sLmJvdC5sYXlvdXR0ZXN0cmVzdWx0c3JlYWRl ciBpbXBvcnQgTGF5b3V0VGVzdFJlc3VsdHNSZWFkZXIKIGZyb20gd2Via2l0cHkudG9vbC5ib3Qu cXVldWVlbmdpbmUgaW1wb3J0IFF1ZXVlRW5naW5lLCBRdWV1ZUVuZ2luZURlbGVnYXRlCkBAIC0y NTAsNiArMjUxLDcgQEAgY2xhc3MgQ29tbWl0UXVldWUoQWJzdHJhY3RQYXRjaFF1ZXVlLCBTdAog ICAgIGRlZiBiZWdpbl93b3JrX3F1ZXVlKHNlbGYpOgogICAgICAgICBBYnN0cmFjdFBhdGNoUXVl dWUuYmVnaW5fd29ya19xdWV1ZShzZWxmKQogICAgICAgICBzZWxmLmNvbW1pdHRlcl92YWxpZGF0 b3IgPSBDb21taXR0ZXJWYWxpZGF0b3Ioc2VsZi5fdG9vbC5idWdzKQorICAgICAgICBzZWxmLl9l eHBlY3RlZF9mYWlsdXJlcyA9IEV4cGVjdGVkRmFpbHVyZXMoKQogICAgICAgICBzZWxmLl9sYXlv dXRfdGVzdF9yZXN1bHRzX3JlYWRlciA9IExheW91dFRlc3RSZXN1bHRzUmVhZGVyKHNlbGYuX3Rv b2wsIHNlbGYuX2xvZ19kaXJlY3RvcnkoKSkKIAogICAgIGRlZiBuZXh0X3dvcmtfaXRlbShzZWxm KToKQEAgLTMxMSw2ICszMTMsOSBAQCBjbGFzcyBDb21taXRRdWV1ZShBYnN0cmFjdFBhdGNoUXVl dWUsIFN0CiAgICAgICAgIGZhaWx1cmVfbG9nID0gc2VsZi5fbG9nX2Zyb21fc2NyaXB0X2Vycm9y X2Zvcl91cGxvYWQoc2NyaXB0X2Vycm9yKQogICAgICAgICByZXR1cm4gc2VsZi5fdXBkYXRlX3N0 YXR1cyhtZXNzYWdlLCBwYXRjaD1wYXRjaCwgcmVzdWx0c19maWxlPWZhaWx1cmVfbG9nKQogCisg ICAgZGVmIGV4cGVjdGVkX2ZhaWx1cmVzKHNlbGYpOgorICAgICAgICByZXR1cm4gc2VsZi5fZXhw ZWN0ZWRfZmFpbHVyZXMKKwogICAgIGRlZiBsYXlvdXRfdGVzdF9yZXN1bHRzKHNlbGYpOgogICAg ICAgICByZXR1cm4gc2VsZi5fbGF5b3V0X3Rlc3RfcmVzdWx0c19yZWFkZXIucmVzdWx0cygpCiAK