59252 2011-04-22 16:13:55 -0700 Use native NullPtr when using GCC 4.6.0 and C++0x 2011-05-02 14:16:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned lucas.de.marchi pnormand webkit-ews webkit.review.bot xan.lopez oldest_to_newest 391197 0 xan.lopez 2011-04-22 16:13:55 -0700 GCC 4.6.0 supports nullptr when -std=c++0x is used. Detect that in NullPtr.h and don't re-define stuff. This gets rid of a huge warning per compiled file. 391199 1 90794 xan.lopez 2011-04-22 16:15:39 -0700 Created attachment 90794 nullptr.diff 391201 2 90796 xan.lopez 2011-04-22 16:16:53 -0700 Created attachment 90796 nullptr.diff Fix nit. 391203 3 webkit.review.bot 2011-04-22 16:17:43 -0700 Attachment 90794 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/NullPtr.h:38: Missing space after , [whitespace/comma] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 391241 4 webkit-ews 2011-04-22 16:55:16 -0700 Attachment 90796 did not build on qt: Build output: http://queues.webkit.org/results/8495608 391260 5 90812 xan.lopez 2011-04-22 17:19:58 -0700 Created attachment 90812 nullptr.diff Try to fix Qt build. 391403 6 90812 ap 2011-04-22 21:50:09 -0700 Comment on attachment 90812 nullptr.diff View in context: https://bugs.webkit.org/attachment.cgi?id=90812&action=review > Source/JavaScriptCore/ChangeLog:13 > + use native nullptr. Two extra spaces here. 396381 7 pnormand 2011-05-02 07:32:45 -0700 Ping Xan, can you land this? :) 396654 8 90812 xan.lopez 2011-05-02 14:16:12 -0700 Comment on attachment 90812 nullptr.diff Landed in r85521. The build is still totally broken with C++0x though, so don't get your hopes too high. 396655 9 xan.lopez 2011-05-02 14:16:22 -0700 Closing. 90794 2011-04-22 16:15:39 -0700 2011-04-22 16:16:53 -0700 nullptr.diff nullptr.diff text/plain 1854 xan.lopez RnJvbSAxZGJkODdiMTIyZWJjYTkzN2I4ZjIzNDRjOTY0MzQ5Yjc3YzgzNWJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBG cmksIDIyIEFwciAyMDExIDE2OjE0OjUyIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMS0wNC0y MiAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBVc2UgbmF0aXZlIE51bGxQdHIgd2hlbiB1c2luZyBHQ0Mg NC42LjAgYW5kIEMrKzB4CiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU5MjUyCgogICAgICAgIEdDQyA0LjYuMCBoYXMgbnVsbHB0ciBzdXBwb3J0LCB1c2Ug aXQgd2hlbiBwb3NzaWJsZS4KCiAgICAgICAgKiB3dGYvTnVsbFB0ci5oOgotLS0KIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgIHwgICAxMSArKysrKysrKysrKwogU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi9OdWxsUHRyLmggfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEy IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5k ZXggNTdhNThhMi4uMDI5NmRjNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIs MTcgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBV c2UgbmF0aXZlIE51bGxQdHIgd2hlbiB1c2luZyBHQ0MgNC42LjAgYW5kIEMrKzB4CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTI1MgorCisgICAgICAg IEdDQyA0LjYuMCBoYXMgbnVsbHB0ciBzdXBwb3J0LCB1c2UgaXQgd2hlbiBwb3NzaWJsZS4KKwor ICAgICAgICAqIHd0Zi9OdWxsUHRyLmg6CisKKzIwMTEtMDQtMjIgIFhhbiBMb3BleiAgPHhsb3Bl ekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAg ICAgICAgIENvbGxpZGluZyBpc2luZi9pc25hbiBiZXR3ZWVuIEM5OSBhbmQgQysrMHggd2l0aCBH Q0MgNC42LjAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU5MjQ5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTnVsbFB0ci5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9OdWxsUHRyLmgKaW5kZXggMDhlY2U1Ni4uMWM3 OTYzMiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9OdWxsUHRyLmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9OdWxsUHRyLmgKQEAgLTM1LDcgKzM1LDcgQEAg U09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1B R0UuCiAgICAgI2RlZmluZSBfX2hhc19mZWF0dXJlKGZlYXR1cmUpIDAKICNlbmRpZgogCi0jaWYg X19oYXNfZmVhdHVyZShjeHhfbnVsbHB0cikgfHwgKGRlZmluZWQoX01TQ19WRVIpICYmIF9NU0Nf VkVSID49IDE2MDApCisjaWYgX19oYXNfZmVhdHVyZShjeHhfbnVsbHB0cikgfHwgKEdDQ19WRVJT SU9OX0FUX0xFQVNUKDQsNiwwKSAmJiBkZWZpbmVkKF9fR1hYX0VYUEVSSU1FTlRBTF9DWFgwWF9f KSkgfHwgKGRlZmluZWQoX01TQ19WRVIpICYmIF9NU0NfVkVSID49IDE2MDApCiAKICNkZWZpbmUg SEFWRV9OVUxMUFRSIDEKIAotLSAKMS43LjQuNAoK 90796 2011-04-22 16:16:53 -0700 2011-04-22 17:19:58 -0700 nullptr.diff nullptr.diff text/plain 1856 xan.lopez RnJvbSA5YzIwMGU5ODFhYTY0ZmFmOTVkZTMzNDE0NWE2YTI5NjBmYzA4ZDIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBG cmksIDIyIEFwciAyMDExIDE2OjE0OjUyIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMS0wNC0y MiAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBVc2UgbmF0aXZlIE51bGxQdHIgd2hlbiB1c2luZyBHQ0Mg NC42LjAgYW5kIEMrKzB4CiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU5MjUyCgogICAgICAgIEdDQyA0LjYuMCBoYXMgbnVsbHB0ciBzdXBwb3J0LCB1c2Ug aXQgd2hlbiBwb3NzaWJsZS4KCiAgICAgICAgKiB3dGYvTnVsbFB0ci5oOgotLS0KIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgIHwgICAxMSArKysrKysrKysrKwogU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi9OdWxsUHRyLmggfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEy IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5k ZXggNTdhNThhMi4uMDI5NmRjNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIs MTcgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBV c2UgbmF0aXZlIE51bGxQdHIgd2hlbiB1c2luZyBHQ0MgNC42LjAgYW5kIEMrKzB4CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTI1MgorCisgICAgICAg IEdDQyA0LjYuMCBoYXMgbnVsbHB0ciBzdXBwb3J0LCB1c2UgaXQgd2hlbiBwb3NzaWJsZS4KKwor ICAgICAgICAqIHd0Zi9OdWxsUHRyLmg6CisKKzIwMTEtMDQtMjIgIFhhbiBMb3BleiAgPHhsb3Bl ekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAg ICAgICAgIENvbGxpZGluZyBpc2luZi9pc25hbiBiZXR3ZWVuIEM5OSBhbmQgQysrMHggd2l0aCBH Q0MgNC42LjAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU5MjQ5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTnVsbFB0ci5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9OdWxsUHRyLmgKaW5kZXggMDhlY2U1Ni4uYzBl N2JkMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9OdWxsUHRyLmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9OdWxsUHRyLmgKQEAgLTM1LDcgKzM1LDcgQEAg U09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1B R0UuCiAgICAgI2RlZmluZSBfX2hhc19mZWF0dXJlKGZlYXR1cmUpIDAKICNlbmRpZgogCi0jaWYg X19oYXNfZmVhdHVyZShjeHhfbnVsbHB0cikgfHwgKGRlZmluZWQoX01TQ19WRVIpICYmIF9NU0Nf VkVSID49IDE2MDApCisjaWYgX19oYXNfZmVhdHVyZShjeHhfbnVsbHB0cikgfHwgKEdDQ19WRVJT SU9OX0FUX0xFQVNUKDQsIDYsIDApICYmIGRlZmluZWQoX19HWFhfRVhQRVJJTUVOVEFMX0NYWDBY X18pKSB8fCAoZGVmaW5lZChfTVNDX1ZFUikgJiYgX01TQ19WRVIgPj0gMTYwMCkKIAogI2RlZmlu ZSBIQVZFX05VTExQVFIgMQogCi0tIAoxLjcuNC40Cgo= 90812 2011-04-22 17:19:58 -0700 2011-05-02 14:16:12 -0700 nullptr.diff nullptr.diff text/plain 2766 xan.lopez RnJvbSBmYTBmNzYxN2VlMDY1MWQ4OGRjZmJlZDc1YWYxMTZjYWI4ODBiYjJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBG cmksIDIyIEFwciAyMDExIDE2OjE0OjUyIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMS0wNC0y MiAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBVc2UgbmF0aXZlIE51bGxQdHIgd2hlbiB1c2luZyBHQ0Mg NC42LjAgYW5kIEMrKzB4CiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU5MjUyCgogICAgICAgIEdDQyA0LjYuMCBoYXMgbnVsbHB0ciBzdXBwb3J0LCB1c2Ug aXQgd2hlbiBwb3NzaWJsZS4KCiAgICAgICAgKiB3dGYvTnVsbFB0ci5jcHA6IGluY2x1ZGUgY29u ZmlnLmggdG8gcHVsbCBpbiBQbGF0Zm9ybS5oIGJlZm9yZQogICAgICAgIE51bGxQdHIuaCwgc2lu Y2Ugd2UgbmVlZCB0aGUgR0NDX1ZFUlNJT05fQVRfTEVBU1QgZGVmaW5pdGlvbi4KICAgICAgICAq IHd0Zi9OdWxsUHRyLmg6IGNoZWNrIGZvciBHQ0MgPj0gNC42LjAgYW5kIEMrKzB4IGluIG9yZGVy IHRvCiAgICAgICAgICB1c2UgbmF0aXZlIG51bGxwdHIuCi0tLQogU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZyAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS93dGYvTnVsbFB0ci5jcHAgfCAgICAzICstLQogU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9OdWxsUHRyLmggICB8ICAgIDIgKy0KIDMgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4MmNlMzQ4 Li5mMzJlZTYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMCBAQAogCiAg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFVzZSBuYXRpdmUg TnVsbFB0ciB3aGVuIHVzaW5nIEdDQyA0LjYuMCBhbmQgQysrMHgKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU5MjUyCisKKyAgICAgICAgR0NDIDQuNi4w IGhhcyBudWxscHRyIHN1cHBvcnQsIHVzZSBpdCB3aGVuIHBvc3NpYmxlLgorCisgICAgICAgICog d3RmL051bGxQdHIuY3BwOiBpbmNsdWRlIGNvbmZpZy5oIHRvIHB1bGwgaW4gUGxhdGZvcm0uaCBi ZWZvcmUKKyAgICAgICAgTnVsbFB0ci5oLCBzaW5jZSB3ZSBuZWVkIHRoZSBHQ0NfVkVSU0lPTl9B VF9MRUFTVCBkZWZpbml0aW9uLgorICAgICAgICAqIHd0Zi9OdWxsUHRyLmg6IGNoZWNrIGZvciBH Q0MgPj0gNC42LjAgYW5kIEMrKzB4IGluIG9yZGVyIHRvCisgICAgICAgICAgdXNlIG5hdGl2ZSBu dWxscHRyLgorCisyMDExLTA0LTIyICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBDb2xsaWRpbmcg aXNpbmYvaXNuYW4gYmV0d2VlbiBDOTkgYW5kIEMrKzB4IHdpdGggR0NDIDQuNi4wCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTI0OQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL051bGxQdHIuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9OdWxsUHRyLmNwcAppbmRleCBjNDIyOGUzLi4yMjRmMWYxIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL051bGxQdHIuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvTnVsbFB0ci5jcHAKQEAgLTI0LDEwICsyNCw5IEBAIFNPRlRXQVJF LCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCiAq LwogCisjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiTnVsbFB0ci5oIgogCi0jaW5jbHVk ZSAiUGxhdGZvcm0uaCIKLQogI2lmICFIQVZFKE5VTExQVFIpCiAKIHN0ZDo6bnVsbHB0cl90IG51 bGxwdHI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL051bGxQdHIuaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTnVsbFB0ci5oCmluZGV4IDA4ZWNlNTYuLmMwZTdi ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTnVsbFB0ci5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvTnVsbFB0ci5oCkBAIC0zNSw3ICszNSw3IEBAIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgogICAgICNkZWZpbmUgX19oYXNfZmVhdHVyZShmZWF0dXJlKSAwCiAjZW5kaWYKIAotI2lmIF9f aGFzX2ZlYXR1cmUoY3h4X251bGxwdHIpIHx8IChkZWZpbmVkKF9NU0NfVkVSKSAmJiBfTVNDX1ZF UiA+PSAxNjAwKQorI2lmIF9faGFzX2ZlYXR1cmUoY3h4X251bGxwdHIpIHx8IChHQ0NfVkVSU0lP Tl9BVF9MRUFTVCg0LCA2LCAwKSAmJiBkZWZpbmVkKF9fR1hYX0VYUEVSSU1FTlRBTF9DWFgwWF9f KSkgfHwgKGRlZmluZWQoX01TQ19WRVIpICYmIF9NU0NfVkVSID49IDE2MDApCiAKICNkZWZpbmUg SEFWRV9OVUxMUFRSIDEKIAotLSAKMS43LjQuNAoK