59250 2011-04-22 15:47:20 -0700 Add missing default constructors for HashMap iterator specializations. 2011-04-27 18:31:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vitalyr webkit-unassigned abarth levin oldest_to_newest 391168 0 vitalyr 2011-04-22 15:47:20 -0700 Add missing default constructors for HashMap iterator specializations. 391171 1 90787 vitalyr 2011-04-22 15:49:28 -0700 Created attachment 90787 patch 391195 2 90787 abarth 2011-04-22 16:12:40 -0700 Comment on attachment 90787 patch View in context: https://bugs.webkit.org/attachment.cgi?id=90787&action=review > Source/JavaScriptCore/wtf/HashTable.h:129 > - addIterator(0, this); > + addIterator(static_cast<const HashTableType*>(0), this); Why is this needed? More explanation in the ChangeLog would be helpful. 391211 3 90798 vitalyr 2011-04-22 16:20:12 -0700 Created attachment 90798 patch Added the explanation to ChangeLog. 391288 4 vitalyr 2011-04-22 17:59:55 -0700 M Source/JavaScriptCore/ChangeLog M Source/JavaScriptCore/wtf/HashIterators.h M Source/JavaScriptCore/wtf/HashTable.h Committed r84718 391407 5 ap 2011-04-22 21:54:18 -0700 + HashTableConstIteratorAdapter() {} WebKit style is to have a space between such braces. Please file a bug against the style checker. 394068 6 levin 2011-04-27 18:31:14 -0700 (In reply to comment #5) > + HashTableConstIteratorAdapter() {} > > WebKit style is to have a space between such braces. Please file a bug against the style checker. We really don't have this in the style guide but we commonly flag it. We probably should add it to the style guide. Anyway, this was an easy change to do on my plane flight: https://bugs.webkit.org/show_bug.cgi?id=59665 90787 2011-04-22 15:49:28 -0700 2011-04-22 16:20:12 -0700 patch iter_fix.patch text/plain 2244 vitalyr ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ1NGMxYTUuLjI5OTgzZjAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTA0LTIyICBWaXRhbHkgUmVwZXNo a28gIDx2aXRhbHlyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgbWlzc2luZyBkZWZhdWx0IGNvbnN0cnVjdG9ycyBmb3Ig SGFzaE1hcCBpdGVyYXRvciBzcGVjaWFsaXphdGlvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTI1MAorCisgICAgICAgICogd3RmL0hhc2hJdGVy YXRvcnMuaDoKKyAgICAgICAgKiB3dGYvSGFzaFRhYmxlLmg6CisgICAgICAgIChXVEY6Okhhc2hU YWJsZUNvbnN0SXRlcmF0b3I6Okhhc2hUYWJsZUNvbnN0SXRlcmF0b3IpOgorCiAyMDExLTA0LTIx ICBWaXRhbHkgUmVwZXNoa28gIDx2aXRhbHlyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0 Zi9IYXNoSXRlcmF0b3JzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0hhc2hJdGVyYXRv cnMuaAppbmRleCA2ODJjODNiLi42YWZhMmZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL0hhc2hJdGVyYXRvcnMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3Rm L0hhc2hJdGVyYXRvcnMuaApAQCAtNDAsNiArNDAsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAg ICAgdHlwZWRlZiBIYXNoVGFibGVDb25zdEtleXNJdGVyYXRvcjxIYXNoVGFibGVUeXBlLCBLZXlU eXBlLCBNYXBwZWRUeXBlPiBLZXlzOwogICAgICAgICB0eXBlZGVmIEhhc2hUYWJsZUNvbnN0VmFs dWVzSXRlcmF0b3I8SGFzaFRhYmxlVHlwZSwgS2V5VHlwZSwgTWFwcGVkVHlwZT4gVmFsdWVzOwog CisgICAgICAgIEhhc2hUYWJsZUNvbnN0SXRlcmF0b3JBZGFwdGVyKCkge30KICAgICAgICAgSGFz aFRhYmxlQ29uc3RJdGVyYXRvckFkYXB0ZXIoY29uc3QgdHlwZW5hbWUgSGFzaFRhYmxlVHlwZTo6 Y29uc3RfaXRlcmF0b3ImIGltcGwpIDogbV9pbXBsKGltcGwpIHt9CiAKICAgICAgICAgY29uc3Qg VmFsdWVUeXBlKiBnZXQoKSBjb25zdCB7IHJldHVybiAoY29uc3QgVmFsdWVUeXBlKiltX2ltcGwu Z2V0KCk7IH0KQEAgLTYyLDYgKzYzLDcgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIHR5cGVk ZWYgSGFzaFRhYmxlS2V5c0l0ZXJhdG9yPEhhc2hUYWJsZVR5cGUsIEtleVR5cGUsIE1hcHBlZFR5 cGU+IEtleXM7CiAgICAgICAgIHR5cGVkZWYgSGFzaFRhYmxlVmFsdWVzSXRlcmF0b3I8SGFzaFRh YmxlVHlwZSwgS2V5VHlwZSwgTWFwcGVkVHlwZT4gVmFsdWVzOwogCisgICAgICAgIEhhc2hUYWJs ZUl0ZXJhdG9yQWRhcHRlcigpIHt9CiAgICAgICAgIEhhc2hUYWJsZUl0ZXJhdG9yQWRhcHRlcihj b25zdCB0eXBlbmFtZSBIYXNoVGFibGVUeXBlOjppdGVyYXRvciYgaW1wbCkgOiBtX2ltcGwoaW1w bCkge30KIAogICAgICAgICBWYWx1ZVR5cGUqIGdldCgpIGNvbnN0IHsgcmV0dXJuIChWYWx1ZVR5 cGUqKW1faW1wbC5nZXQoKTsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0 Zi9IYXNoVGFibGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvSGFzaFRhYmxlLmgKaW5k ZXggNWFjYTI1ZC4uNzllOGIzZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0 Zi9IYXNoVGFibGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0hhc2hUYWJsZS5o CkBAIC0xMjYsNyArMTI2LDcgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgcHVibGljOgogICAgICAg ICBIYXNoVGFibGVDb25zdEl0ZXJhdG9yKCkKICAgICAgICAgewotICAgICAgICAgICAgYWRkSXRl cmF0b3IoMCwgdGhpcyk7CisgICAgICAgICAgICBhZGRJdGVyYXRvcihzdGF0aWNfY2FzdDxjb25z dCBIYXNoVGFibGVUeXBlKj4oMCksIHRoaXMpOwogICAgICAgICB9CiAKICAgICAgICAgLy8gZGVm YXVsdCBjb3B5LCBhc3NpZ25tZW50IGFuZCBkZXN0cnVjdG9yIGFyZSBPSyBpZiBDSEVDS19IQVNI VEFCTEVfSVRFUkFUT1JTIGlzIDAK 90798 2011-04-22 16:20:12 -0700 2011-04-22 17:01:50 -0700 patch iter_fix.patch text/plain 2309 vitalyr ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ1NGMxYTUuLmVkMmFiNTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA0LTIyICBWaXRhbHkgUmVwZXNo a28gIDx2aXRhbHlyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgbWlzc2luZyBkZWZhdWx0IGNvbnN0cnVjdG9ycyBmb3Ig SGFzaE1hcCBpdGVyYXRvciBzcGVjaWFsaXphdGlvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTI1MAorCisgICAgICAgICogd3RmL0hhc2hJdGVy YXRvcnMuaDoKKyAgICAgICAgKiB3dGYvSGFzaFRhYmxlLmg6CisgICAgICAgIChXVEY6Okhhc2hU YWJsZUNvbnN0SXRlcmF0b3I6Okhhc2hUYWJsZUNvbnN0SXRlcmF0b3IpOiBBZGRlZCBjYXN0Cisg ICAgICAgIHRvIGhlbHAgY29tcGlsZXIgZmluZCB0aGUgZnVuY3Rpb24gdGVtcGxhdGUuCisKIDIw MTEtMDQtMjEgIFZpdGFseSBSZXBlc2hrbyAgPHZpdGFseXJAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL0hhc2hJdGVyYXRvcnMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvSGFz aEl0ZXJhdG9ycy5oCmluZGV4IDY4MmM4M2IuLjZhZmEyZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvSGFzaEl0ZXJhdG9ycy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvSGFzaEl0ZXJhdG9ycy5oCkBAIC00MCw2ICs0MCw3IEBAIG5hbWVzcGFjZSBXVEYg ewogICAgICAgICB0eXBlZGVmIEhhc2hUYWJsZUNvbnN0S2V5c0l0ZXJhdG9yPEhhc2hUYWJsZVR5 cGUsIEtleVR5cGUsIE1hcHBlZFR5cGU+IEtleXM7CiAgICAgICAgIHR5cGVkZWYgSGFzaFRhYmxl Q29uc3RWYWx1ZXNJdGVyYXRvcjxIYXNoVGFibGVUeXBlLCBLZXlUeXBlLCBNYXBwZWRUeXBlPiBW YWx1ZXM7CiAKKyAgICAgICAgSGFzaFRhYmxlQ29uc3RJdGVyYXRvckFkYXB0ZXIoKSB7fQogICAg ICAgICBIYXNoVGFibGVDb25zdEl0ZXJhdG9yQWRhcHRlcihjb25zdCB0eXBlbmFtZSBIYXNoVGFi bGVUeXBlOjpjb25zdF9pdGVyYXRvciYgaW1wbCkgOiBtX2ltcGwoaW1wbCkge30KIAogICAgICAg ICBjb25zdCBWYWx1ZVR5cGUqIGdldCgpIGNvbnN0IHsgcmV0dXJuIChjb25zdCBWYWx1ZVR5cGUq KW1faW1wbC5nZXQoKTsgfQpAQCAtNjIsNiArNjMsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAg ICAgdHlwZWRlZiBIYXNoVGFibGVLZXlzSXRlcmF0b3I8SGFzaFRhYmxlVHlwZSwgS2V5VHlwZSwg TWFwcGVkVHlwZT4gS2V5czsKICAgICAgICAgdHlwZWRlZiBIYXNoVGFibGVWYWx1ZXNJdGVyYXRv cjxIYXNoVGFibGVUeXBlLCBLZXlUeXBlLCBNYXBwZWRUeXBlPiBWYWx1ZXM7CiAKKyAgICAgICAg SGFzaFRhYmxlSXRlcmF0b3JBZGFwdGVyKCkge30KICAgICAgICAgSGFzaFRhYmxlSXRlcmF0b3JB ZGFwdGVyKGNvbnN0IHR5cGVuYW1lIEhhc2hUYWJsZVR5cGU6Oml0ZXJhdG9yJiBpbXBsKSA6IG1f aW1wbChpbXBsKSB7fQogCiAgICAgICAgIFZhbHVlVHlwZSogZ2V0KCkgY29uc3QgeyByZXR1cm4g KFZhbHVlVHlwZSopbV9pbXBsLmdldCgpOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL0hhc2hUYWJsZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9IYXNoVGFi bGUuaAppbmRleCA1YWNhMjVkLi43OWU4YjNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL0hhc2hUYWJsZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvSGFz aFRhYmxlLmgKQEAgLTEyNiw3ICsxMjYsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICBwdWJsaWM6 CiAgICAgICAgIEhhc2hUYWJsZUNvbnN0SXRlcmF0b3IoKQogICAgICAgICB7Ci0gICAgICAgICAg ICBhZGRJdGVyYXRvcigwLCB0aGlzKTsKKyAgICAgICAgICAgIGFkZEl0ZXJhdG9yKHN0YXRpY19j YXN0PGNvbnN0IEhhc2hUYWJsZVR5cGUqPigwKSwgdGhpcyk7CiAgICAgICAgIH0KIAogICAgICAg ICAvLyBkZWZhdWx0IGNvcHksIGFzc2lnbm1lbnQgYW5kIGRlc3RydWN0b3IgYXJlIE9LIGlmIENI RUNLX0hBU0hUQUJMRV9JVEVSQVRPUlMgaXMgMAo=