59235 2011-04-22 14:38:47 -0700 [Chromium] createWindow() does not pass url to createView() in the case of a FrameLoadRequest 2013-04-11 13:41:48 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 0 anthony.taranto webkit-unassigned abarth emerick eric fishd japhet magreenblatt schenney oldest_to_newest 391078 0 anthony.taranto 2011-04-22 14:38:47 -0700 The url is available if createWindow is called as a result of a NavigationRequest, but not for all cases of FrameLoadRequest. This patch always passes url to createView() in all cases. This is required to fix this Chromium Embedded Framework issue: http://code.google.com/p/chromiumembedded/issues/detail?id=5 Previous mailing list discussion: http://groups.google.com/group/chromium-dev/browse_thread/thread/6597b4b28e564a95 391086 1 90765 anthony.taranto 2011-04-22 14:43:54 -0700 Created attachment 90765 fix 392994 2 eric 2011-04-26 16:24:44 -0700 This is chromium API, right? That means you need fishd sign-off. 393009 3 90765 fishd 2011-04-26 16:29:54 -0700 Comment on attachment 90765 fix View in context: https://bugs.webkit.org/attachment.cgi?id=90765&action=review > Source/WebKit/chromium/public/WebViewClient.h:90 > + const WebURL& url, what does this "url" refer to, and under what conditions does it differ from request.url()? it is very confusing for this method to be passed two "urls"... which one is meaningful to the implementer of the createView method? perhaps we should make sure that request.url() is always meaningful? 393010 4 fishd 2011-04-26 16:30:10 -0700 R- because there is no explanation for why these URLs are different. 402177 5 magreenblatt 2011-05-11 12:44:54 -0700 Darin, the problem is that r.resourceRequest() is null in ChromeClientImpl::createWindow() when clicking a link with target="_blank". It might be best to create a request object in ChromeClientImpl::createWindow() with just the URL component from NavigationAction and pass that as the request argument to WebViewClient::createView(). 874116 6 schenney 2013-04-11 13:41:48 -0700 Assuming fixed or no longer relevant as this is an old issue. Reopen in crbug if that's not true. 90765 2011-04-22 14:43:54 -0700 2011-04-26 16:29:54 -0700 fix webkit-59235.patch text/plain 2571 anthony.taranto SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4NDY4NSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDQtMjIgIEFudGhvbnkgVGFyYW50byAgPGFudGhvbnkudGFyYW50b0BnbWFpbC5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0No cm9taXVtXSBjcmVhdGVXaW5kb3coKSBkb2VzIG5vdCBwYXNzIHVybCB0byBjcmVhdGVWaWV3KCkg aW4gdGhlIGNhc2Ugb2YgYSBGcmFtZUxvYWRSZXF1ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01OTIzNQorCisgICAgICAgICogcHVibGljL1dlYlZp ZXdDbGllbnQuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0NsaWVudDo6Y3JlYXRlVmlldyk6 CisgICAgICAgICogc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpD aHJvbWVDbGllbnRJbXBsOjpjcmVhdGVXaW5kb3cpOgorCiAyMDExLTA0LTIyICBNaWtoYWlsIE5h Z2Fub3YgIDxtbmFnYW5vdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2 ZWwgRmVsZG1hbi4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdD bGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJW aWV3Q2xpZW50LmgJKHJldmlzaW9uIDgzOTk0KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViVmlld0NsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC04Nyw2ICs4Nyw3IEBAIHB1 YmxpYzoKICAgICAvLyBUaGUgcmVxdWVzdCBwYXJhbWV0ZXIgaXMgb25seSBmb3IgdGhlIGNsaWVu dCB0byBjaGVjayBpZiB0aGUgcmVxdWVzdAogICAgIC8vIGNvdWxkIGJlIGZ1bGZpbGxlZC4gIFRo ZSBjbGllbnQgc2hvdWxkIG5vdCBsb2FkIHRoZSByZXF1ZXN0LgogICAgIHZpcnR1YWwgV2ViVmll dyogY3JlYXRlVmlldyhXZWJGcmFtZSogY3JlYXRvciwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgY29uc3QgV2ViVVJMJiB1cmwsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGNvbnN0IFdlYlVSTFJlcXVlc3QmIHJlcXVlc3QsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGNvbnN0IFdlYldpbmRvd0ZlYXR1cmVzJiBmZWF0dXJlcywKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2ViU3RyaW5nJiBuYW1lKSB7CkluZGV4OiBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAkocmV2aXNp b24gODM5OTQpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBs LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjU5LDcgKzI1OSw3IEBAIHZvaWQgQ2hyb21lQ2xpZW50 SW1wbDo6Zm9jdXNlZEZyYW1lQ2hhbmcKIH0KIAogUGFnZSogQ2hyb21lQ2xpZW50SW1wbDo6Y3Jl YXRlV2luZG93KAotICAgIEZyYW1lKiBmcmFtZSwgY29uc3QgRnJhbWVMb2FkUmVxdWVzdCYgciwg Y29uc3QgV2luZG93RmVhdHVyZXMmIGZlYXR1cmVzLCBjb25zdCBOYXZpZ2F0aW9uQWN0aW9uJikK KyAgICBGcmFtZSogZnJhbWUsIGNvbnN0IEZyYW1lTG9hZFJlcXVlc3QmIHIsIGNvbnN0IFdpbmRv d0ZlYXR1cmVzJiBmZWF0dXJlcywgY29uc3QgTmF2aWdhdGlvbkFjdGlvbiYgYWN0aW9uKQogewog ICAgIGlmICghbV93ZWJWaWV3LT5jbGllbnQoKSkKICAgICAgICAgcmV0dXJuIDA7CkBAIC0yNjgs NyArMjY4LDcgQEAgUGFnZSogQ2hyb21lQ2xpZW50SW1wbDo6Y3JlYXRlV2luZG93KAogICAgIGlm ICghci5yZXNvdXJjZVJlcXVlc3QoKS5pc0VtcHR5KCkpCiAgICAgICAgIHJlcXVlc3QuYmluZChy LnJlc291cmNlUmVxdWVzdCgpKTsKICAgICBXZWJWaWV3SW1wbCogbmV3VmlldyA9IHN0YXRpY19j YXN0PFdlYlZpZXdJbXBsKj4oCi0gICAgICAgIG1fd2ViVmlldy0+Y2xpZW50KCktPmNyZWF0ZVZp ZXcoV2ViRnJhbWVJbXBsOjpmcm9tRnJhbWUoZnJhbWUpLCByZXF1ZXN0LCBmZWF0dXJlcywgci5m cmFtZU5hbWUoKSkpOworICAgICAgICBtX3dlYlZpZXctPmNsaWVudCgpLT5jcmVhdGVWaWV3KFdl YkZyYW1lSW1wbDo6ZnJvbUZyYW1lKGZyYW1lKSwgYWN0aW9uLnVybCgpLCByZXF1ZXN0LCBmZWF0 dXJlcywgci5mcmFtZU5hbWUoKSkpOwogICAgIGlmICghbmV3VmlldykKICAgICAgICAgcmV0dXJu IDA7CiAK